coreboot-gerrit June 2017

coreboot-gerrit@coreboot.org

1 participants
2269 discussions

Change in coreboot[master]: libpayload/libc: Add second version of hexdump
by Lee Leahy (Code Review) 30 Jun '17

30 Jun '17

Lee Leahy has uploaded this change for review. ( https://review.coreboot.org/20441 Change subject: libpayload/libc: Add second version of hexdump ...................................................................... libpayload/libc: Add second version of hexdump Add hexdump_gpl.c which is selected with CONFIG_GPL. Simplify the conditional logic. Don't continue displaying data after the end of the specified buffer. Use the version from coreboot to display only the data requested. This version also compresses the all ones display. TEST=Build and run on Galileo Gen2 Change-Id: I0e2f943346cd4f421987075cc37d1ac6d3e980ef Signed-off-by: Lee Leahy <Leroy.P.Leahy(a)intel.com> --- M payloads/libpayload/libc/Makefile.inc A payloads/libpayload/libc/hexdump_gpl.c 2 files changed, 80 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/20441/1 diff --git a/payloads/libpayload/libc/Makefile.inc b/payloads/libpayload/libc/Makefile.inc index edef62c..39f4584 100644 --- a/payloads/libpayload/libc/Makefile.inc +++ b/payloads/libpayload/libc/Makefile.inc @@ -28,18 +28,24 @@ ## SUCH DAMAGE. ## -libc-$(CONFIG_LP_LIBC) += malloc.c printf.c console.c string.c -libc-$(CONFIG_LP_LIBC) += memory.c ctype.c ipchecksum.c lib.c libgcc.c -libc-$(CONFIG_LP_LIBC) += rand.c time.c exec.c -libc-$(CONFIG_LP_LIBC) += readline.c getopt_long.c sysinfo.c -libc-$(CONFIG_LP_LIBC) += args.c -libc-$(CONFIG_LP_LIBC) += strlcpy.c -libc-$(CONFIG_LP_LIBC) += qsort.c -libc-$(CONFIG_LP_LIBC) += hexdump.c -libc-$(CONFIG_LP_LIBC) += die.c -libc-$(CONFIG_LP_LIBC) += coreboot.c -libc-$(CONFIG_LP_LIBC) += fmap.c +ifeq ($(CONFIG_LP_LIBC),y) -ifeq ($(CONFIG_LP_ARCH_MIPS),y) -libc-$(CONFIG_LP_LIBC) += 64bit_div.c +libc-y += malloc.c printf.c console.c string.c +libc-y += memory.c ctype.c ipchecksum.c lib.c libgcc.c +libc-y += rand.c time.c exec.c +libc-y += readline.c getopt_long.c sysinfo.c +libc-y += args.c +libc-y += strlcpy.c +libc-y += qsort.c +ifeq ($(CONFIG_GPL),y) +libc-y += hexdump_gpl.c +else +libc-y += hexdump.c +endif +libc-y += die.c +libc-y += coreboot.c +libc-y += fmap.c + +libc-$(CONFIG_LP_ARCH_MIPS) += 64bit_div.c + endif diff --git a/payloads/libpayload/libc/hexdump_gpl.c b/payloads/libpayload/libc/hexdump_gpl.c new file mode 100644 index 0000000..9f99a79 --- /dev/null +++ b/payloads/libpayload/libc/hexdump_gpl.c @@ -0,0 +1,61 @@ +/* + * Copyright 2013 Google Inc. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but without any warranty; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <libpayload.h> + +void hexdump(const void *memory, size_t length) +{ + int i; + uint8_t *line; + int all_zero = 0; + int all_one = 0; + size_t num_bytes; + + for (i = 0; i < length; i += 16) { + int j; + num_bytes = MIN(length - i, 16); + line = ((uint8_t *)memory) + i; + + all_zero++; + all_one++; + for (j = 0; j < num_bytes; j++) { + if (line[j] != 0) { + all_zero = 0; + break; + } + } + + for (j = 0; j < num_bytes; j++) { + if (line[j] != 0xff) { + all_one = 0; + break; + } + } + + if ((all_zero < 2) && (all_one < 2)) { + printf("%p:", memory + i); + for (j = 0; j < num_bytes; j++) + printf(" %02x", line[j]); + for (; j < 16; j++) + printf(" "); + printf(" "); + for (j = 0; j < num_bytes; j++) + printf("%c", + isprint(line[j]) ? line[j] : '.'); + printf("\n"); + } else if ((all_zero == 2) || (all_one == 2)) { + printf("...\n"); + } + } +} -- To view, visit https://review.coreboot.org/20441 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0e2f943346cd4f421987075cc37d1ac6d3e980ef Gerrit-Change-Number: 20441 Gerrit-PatchSet: 1 Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/quark: Add I2C debugging
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20422 ) Change subject: soc/intel/quark: Add I2C debugging ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56493/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12078/ : SUCCESS -- To view, visit https://review.coreboot.org/20422 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia17be8b4213b13fd6c6a367d081414d0f21fbb0f Gerrit-Change-Number: 20422 Gerrit-PatchSet: 2 Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 16:43:47 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/eve: Fix interrupt config for audio devices
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20433 ) Change subject: mb/google/eve: Fix interrupt config for audio devices ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56492/ : SUCCESS -- To view, visit https://review.coreboot.org/20433 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40a8ee667de653e4e70770cd96b6417442c1b0ec Gerrit-Change-Number: 20433 Gerrit-PatchSet: 4 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 15:06:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/eve: Implement EC device events for S3 wake
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20428 ) Change subject: mb/google/eve: Implement EC device events for S3 wake ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56491/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12077/ : SUCCESS -- To view, visit https://review.coreboot.org/20428 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d6a9c5bfd4cea85e13446ffaa6fe3dab0db96a2 Gerrit-Change-Number: 20428 Gerrit-PatchSet: 3 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 15:05:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/google/chromeec: Sync header with Chromium EC codebase
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20425 ) Change subject: ec/google/chromeec: Sync header with Chromium EC codebase ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56490/ : SUCCESS -- To view, visit https://review.coreboot.org/20425 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56c9f891262d8984b6a9a69d96752c2dd6bb2371 Gerrit-Change-Number: 20425 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 15:03:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/google/chromeec: Add support for EC device events
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20426 ) Change subject: ec/google/chromeec: Add support for EC device events ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56489/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12076/ : SUCCESS -- To view, visit https://review.coreboot.org/20426 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5126c6d6ffb6b0ef6e8db8dcd5aec62db925a371 Gerrit-Change-Number: 20426 Gerrit-PatchSet: 3 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 15:01:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: elog: Update for EC Device Events
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20427 ) Change subject: elog: Update for EC Device Events ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56488/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12075/ : SUCCESS -- To view, visit https://review.coreboot.org/20427 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f3aeedb87c2aad29a0a67b5c50c29a6961fb45f Gerrit-Change-Number: 20427 Gerrit-PatchSet: 3 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 15:01:38 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/fsp_sandybridge/gma: Set ASLS on S3 resume
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20286 ) Change subject: nb/intel/fsp_sandybridge/gma: Set ASLS on S3 resume ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56487/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12074/ : SUCCESS -- To view, visit https://review.coreboot.org/20286 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I772d680774890c32ca6dc9b1e2143b3ab3bf6513 Gerrit-Change-Number: 20286 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 14:20:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/haswell/gma: Set ASLS on S3 resume
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20285 ) Change subject: nb/intel/haswell/gma: Set ASLS on S3 resume ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56486/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12073/ : SUCCESS -- To view, visit https://review.coreboot.org/20285 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1944fcca91ee1a0ad8df5c8b6f402e907de5e78f Gerrit-Change-Number: 20285 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 14:19:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drv/intel/gma/opregion: Add method to restore ASLS
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20436 ) Change subject: drv/intel/gma/opregion: Add method to restore ASLS ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56484/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12071/ : SUCCESS -- To view, visit https://review.coreboot.org/20436 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I254683081cbaf3a5938794dcba140ac9ee07f48a Gerrit-Change-Number: 20436 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 14:17:46 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2017