coreboot-gerrit June 2017

coreboot-gerrit@coreboot.org

1 participants
2269 discussions

Change in coreboot[master]: mb/intel/d410pt: Add mainboard
by Arthur Heymans (Code Review) 02 Jun '17

02 Jun '17

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/20000 to look at the new patch set (#2). Change subject: mb/intel/d410pt: Add mainboard ...................................................................... mb/intel/d410pt: Add mainboard This board is almost identical to D510MO, the only differences are some differences in populated connections, CPU with less L2 cache and a 10/100 Realtek NIC. The vendor uses the very same binary for both D510M0 and D410PT. Change-Id: I220515365b69e785ef249c4e3a9af5f7fddf02f9 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/intel/d510mo/Kconfig.name 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/20000/2 -- To view, visit https://review.coreboot.org/20000 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I220515365b69e785ef249c4e3a9af5f7fddf02f9 Gerrit-Change-Number: 20000 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: cbfstool/lz4/lib/lz4frame.c: Don't fallthrough on case dstag...
by Patrick Georgi (Code Review) 02 Jun '17

02 Jun '17

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/19998 ) Change subject: cbfstool/lz4/lib/lz4frame.c: Don't fallthrough on case dstage_getHeader ...................................................................... Patch Set 3: Code-Review-1 https://github.com/lz4/lz4/blob/dev/lib/lz4frame.c#L1099 indicates that the fall through might be deliberate. maybe we should just update the library? -- To view, visit https://review.coreboot.org/19998 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2dcc0895cd5ea149425c1ae01fc1af70e3657e7 Gerrit-Change-Number: 19998 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Jun 2017 05:55:38 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/d410pt: Add mainboard
by Patrick Georgi (Code Review) 02 Jun '17

02 Jun '17

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/20000 ) Change subject: mb/intel/d410pt: Add mainboard ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/20000/1/src/mainboard/intel/d510mo/Kconfig.… File src/mainboard/intel/d510mo/Kconfig.name: https://review.coreboot.org/#/c/20000/1/src/mainboard/intel/d510mo/Kconfig.… PS1, Line 2: "D510MO > I suppose just changing this into D510MO / D410PT would also work. Do we wa I'd go with just changing this string. -- To view, visit https://review.coreboot.org/20000 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I220515365b69e785ef249c4e3a9af5f7fddf02f9 Gerrit-Change-Number: 20000 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Jun 2017 05:43:54 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: arch/*: Update Kconfig symbol usage
by Philippe Mathieu-Daudé (Code Review) 02 Jun '17

02 Jun '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/20005 ) Change subject: arch/*: Update Kconfig symbol usage ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/20005 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a84414d2d1631e35ac91efb67a0d4c1f673bf85 Gerrit-Change-Number: 20005 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Jun 2017 05:20:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/arm/armv7: Correct checkpatch errors
by Philippe Mathieu-Daudé (Code Review) 02 Jun '17

02 Jun '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19996 ) Change subject: arch/arm/armv7: Correct checkpatch errors ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/19996/2/src/arch/arm/armv7/mmu.c File src/arch/arm/armv7/mmu.c: https://review.coreboot.org/#/c/19996/2/src/arch/arm/armv7/mmu.c@288 PS2, Line 288: remove 1 tab? -- To view, visit https://review.coreboot.org/19996 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69d50030b07b1919555feca44967472922176a81 Gerrit-Change-Number: 19996 Gerrit-PatchSet: 2 Gerrit-Owner: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Jun 2017 05:17:38 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: cbfstool/lz4/lib/lz4frame.c: Don't fallthrough on case dstag...
by Philippe Mathieu-Daudé (Code Review) 02 Jun '17

02 Jun '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19998 ) Change subject: cbfstool/lz4/lib/lz4frame.c: Don't fallthrough on case dstage_getHeader ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/19998 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2dcc0895cd5ea149425c1ae01fc1af70e3657e7 Gerrit-Change-Number: 19998 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Jun 2017 05:15:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/eve: [Don't merge] Sample code to enable ACPI debug
by build bot (Jenkins) (Code Review) 02 Jun '17

02 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20010 ) Change subject: mainboard/eve: [Don't merge] Sample code to enable ACPI debug ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10476/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54774/ : SUCCESS -- To view, visit https://review.coreboot.org/20010 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfc366114cbbb4c1354d71ed8c7074c2750f6bde Gerrit-Change-Number: 20010 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Jun 2017 05:01:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/common/acpi: Fix ACPI debug log issue with LPSS UART
by build bot (Jenkins) (Code Review) 02 Jun '17

02 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20009 ) Change subject: intel/common/acpi: Fix ACPI debug log issue with LPSS UART ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10477/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54773/ : SUCCESS -- To view, visit https://review.coreboot.org/20009 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b6af789c0ffc79f7fee4652b4aa6a125b182296 Gerrit-Change-Number: 20009 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Fri, 02 Jun 2017 04:59:44 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/eve: [Don't merge] Sample code to enable ACPI debug
by Subrata Banik (Code Review) 02 Jun '17

02 Jun '17

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/20010 Change subject: mainboard/eve: [Don't merge] Sample code to enable ACPI debug ...................................................................... mainboard/eve: [Don't merge] Sample code to enable ACPI debug Change-Id: Icfc366114cbbb4c1354d71ed8c7074c2750f6bde Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/mainboard/google/eve/Kconfig M src/soc/intel/skylake/acpi/platform.asl 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/20010/1 diff --git a/src/mainboard/google/eve/Kconfig b/src/mainboard/google/eve/Kconfig index 16bcbd5..b54bf10 100644 --- a/src/mainboard/google/eve/Kconfig +++ b/src/mainboard/google/eve/Kconfig @@ -19,6 +19,7 @@ select MAINBOARD_USES_FSP2_0 select SOC_INTEL_KABYLAKE select TPM2 + select ACPI_CONSOLE config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES diff --git a/src/soc/intel/skylake/acpi/platform.asl b/src/soc/intel/skylake/acpi/platform.asl index 39debe1..a1a9357 100644 --- a/src/soc/intel/skylake/acpi/platform.asl +++ b/src/soc/intel/skylake/acpi/platform.asl @@ -17,6 +17,7 @@ /* Enable ACPI _SWS methods */ #include <soc/intel/common/acpi/acpi_wake_source.asl> +#include <soc/intel/common/acpi/acpi_debug.asl> /* The APM port can be used for generating software SMIs */ -- To view, visit https://review.coreboot.org/20010 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icfc366114cbbb4c1354d71ed8c7074c2750f6bde Gerrit-Change-Number: 20010 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: intel/common/acpi: Fix ACPI debug log issue with LPSS UART
by Subrata Banik (Code Review) 02 Jun '17

02 Jun '17

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/20009 Change subject: intel/common/acpi: Fix ACPI debug log issue with LPSS UART ...................................................................... intel/common/acpi: Fix ACPI debug log issue with LPSS UART This patch fixes ACPI debug print issue reported internally while using APRT asl method. Potentially some juke characters gets added into final print buffer. TEST=Built and boo eve to ensure to be able to get ASL console log without any corruption. Change-Id: I0b6af789c0ffc79f7fee4652b4aa6a125b182296 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/common/acpi/acpi_debug.asl 1 file changed, 14 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/20009/1 diff --git a/src/soc/intel/common/acpi/acpi_debug.asl b/src/soc/intel/common/acpi/acpi_debug.asl index 5b686f2..76805fe 100644 --- a/src/soc/intel/common/acpi/acpi_debug.asl +++ b/src/soc/intel/common/acpi/acpi_debug.asl @@ -41,7 +41,8 @@ Name(ADBG, Buffer(256) {0}) If (LEqual(ObjectType(Arg0), 1)) { /* Integer */ - ToHexString(Arg0, ADBG) + ToHexString(Arg0, Local0) + Store(Local0, ADBG) } ElseIf (LEqual(ObjectType(Arg0), 2)) { /* String */ Store(Arg0, ADBG) } ElseIf (LEqual(ObjectType(Arg0), 3)) { /* Buffer */ @@ -60,12 +61,18 @@ OperationRegion (UBAR, SystemMemory, UART_DEBUG_BASE_ADDRESS, 24) Field (UBAR, AnyAcc, NoLock, Preserve) { - TDR, 32, /* Transmit Data Register BAR + 0x000 */ - IER, 32, /* Interrupt Enable Register BAR + 0x004 */ - IIR, 32, /* Interrupt Identification Register BAR + 0x008 */ - LCR, 32, /* Line Control Register BAR + 0x00C */ - MCR, 32, /* Modem Control Register BAR + 0x010 */ - LSR, 32 /* Line Status Register BAR + 0x014 */ + TDR, 8, /* Transmit Data Register BAR + 0x000 */ + , 24, + IER, 8, /* Interrupt Enable Register BAR + 0x004 */ + , 24, + IIR, 8, /* Interrupt Identification Register BAR + 0x008 */ + , 24, + LCR, 8, /* Line Control Register BAR + 0x00C */ + , 24, + MCR, 8, /* Modem Control Register BAR + 0x010 */ + , 24, + LSR, 8, /* Line Status Register BAR + 0x014 */ + , 24 } #else OperationRegion (UBAR, SystemIO, LURT (CONFIG_UART_FOR_CONSOLE), 6) -- To view, visit https://review.coreboot.org/20009 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0b6af789c0ffc79f7fee4652b4aa6a125b182296 Gerrit-Change-Number: 20009 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2017