coreboot-gerrit June 2017

coreboot-gerrit@coreboot.org

1 participants
2269 discussions

Change in coreboot[master]: util/cbfstool: Update lz4 to 1.7.5
by Patrick Georgi (Code Review) 02 Jun '17

02 Jun '17

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/20011 ) Change subject: util/cbfstool: Update lz4 to 1.7.5 ...................................................................... Patch Set 4: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/20011/4/util/cbfstool/Makefile.inc File util/cbfstool/Makefile.inc: https://review.coreboot.org/#/c/20011/4/util/cbfstool/Makefile.inc@172 PS4, Line 172: gcc > seems bad... could be prettier, eg. for systems without gcc. hm... -- To view, visit https://review.coreboot.org/20011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id17f5183392decc15a41f654e398968120832bcc Gerrit-Change-Number: 20011 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Jun 2017 07:56:43 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: util/cbfstool: Update lz4 to 1.7.5
by Arthur Heymans (Code Review) 02 Jun '17

02 Jun '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/20011 ) Change subject: util/cbfstool: Update lz4 to 1.7.5 ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/20011/4/util/cbfstool/Makefile.inc File util/cbfstool/Makefile.inc: https://review.coreboot.org/#/c/20011/4/util/cbfstool/Makefile.inc@172 PS4, Line 172: gcc seems bad... but using $(HOSTCC) is not that much better since it should also check if it is actually gcc -- To view, visit https://review.coreboot.org/20011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id17f5183392decc15a41f654e398968120832bcc Gerrit-Change-Number: 20011 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Jun 2017 07:51:17 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: util/cbfstool: Update lz4 to 1.7.5
by build bot (Jenkins) (Code Review) 02 Jun '17

02 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20011 ) Change subject: util/cbfstool: Update lz4 to 1.7.5 ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10488/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54785/ : SUCCESS -- To view, visit https://review.coreboot.org/20011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id17f5183392decc15a41f654e398968120832bcc Gerrit-Change-Number: 20011 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Jun 2017 07:50:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/cbfstool: Update lz4 to 1.7.5
by Arthur Heymans (Code Review) 02 Jun '17

02 Jun '17

Hello build bot (Jenkins), Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/20011 to look at the new patch set (#4). Change subject: util/cbfstool: Update lz4 to 1.7.5 ...................................................................... util/cbfstool: Update lz4 to 1.7.5 This fixes building with GCC7 This does the following: * update lz4 to 1.7.5 and change deprecated constants in compress.c * add -Wimplicit-fallthrough=3 to TOOLCFLAGS if toolchain is gcc7 * Change Pass through in Fall through in lz4frame.c since this is what GCC looks for * Fix trailing whitespace in lz4hc.c Change-Id: Id17f5183392decc15a41f654e398968120832bcc Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/cbfstool/Makefile.inc M util/cbfstool/compress.c M util/cbfstool/lz4/lib/LICENSE M util/cbfstool/lz4/lib/Makefile M util/cbfstool/lz4/lib/README.md M util/cbfstool/lz4/lib/liblz4.pc.in M util/cbfstool/lz4/lib/lz4.c M util/cbfstool/lz4/lib/lz4.h M util/cbfstool/lz4/lib/lz4frame.c M util/cbfstool/lz4/lib/lz4frame.h M util/cbfstool/lz4/lib/lz4frame_static.h M util/cbfstool/lz4/lib/lz4hc.c M util/cbfstool/lz4/lib/lz4hc.h A util/cbfstool/lz4/lib/lz4opt.h M util/cbfstool/lz4/lib/xxhash.c M util/cbfstool/lz4/lib/xxhash.h 16 files changed, 2,686 insertions(+), 2,205 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/20011/4 -- To view, visit https://review.coreboot.org/20011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id17f5183392decc15a41f654e398968120832bcc Gerrit-Change-Number: 20011 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/cbfstool: Update lz4 to 1.7.5
by build bot (Jenkins) (Code Review) 02 Jun '17

02 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20011 ) Change subject: util/cbfstool: Update lz4 to 1.7.5 ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/54784/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/10487/ : SUCCESS -- To view, visit https://review.coreboot.org/20011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id17f5183392decc15a41f654e398968120832bcc Gerrit-Change-Number: 20011 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Jun 2017 07:34:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/cbfstool: Update lz4 to 1.7.5
by Arthur Heymans (Code Review) 02 Jun '17

02 Jun '17

Hello build bot (Jenkins), Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/20011 to look at the new patch set (#3). Change subject: util/cbfstool: Update lz4 to 1.7.5 ...................................................................... util/cbfstool: Update lz4 to 1.7.5 This fixes building with GCC7 This does the following: * update lz4 to 1.7.5 and change deprecated constants in compress.c * add -Wimplicit-fallthrough=3 to TOOLCFLAGS * Change Pass through in Fall through in lz4frame.c since this is what GCC looks for * Fix trailing whitespace in lz4hc.c Change-Id: Id17f5183392decc15a41f654e398968120832bcc Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/cbfstool/Makefile.inc M util/cbfstool/compress.c M util/cbfstool/lz4/lib/LICENSE M util/cbfstool/lz4/lib/Makefile M util/cbfstool/lz4/lib/README.md M util/cbfstool/lz4/lib/liblz4.pc.in M util/cbfstool/lz4/lib/lz4.c M util/cbfstool/lz4/lib/lz4.h M util/cbfstool/lz4/lib/lz4frame.c M util/cbfstool/lz4/lib/lz4frame.h M util/cbfstool/lz4/lib/lz4frame_static.h M util/cbfstool/lz4/lib/lz4hc.c M util/cbfstool/lz4/lib/lz4hc.h A util/cbfstool/lz4/lib/lz4opt.h M util/cbfstool/lz4/lib/xxhash.c M util/cbfstool/lz4/lib/xxhash.h 16 files changed, 2,683 insertions(+), 2,206 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/20011/3 -- To view, visit https://review.coreboot.org/20011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id17f5183392decc15a41f654e398968120832bcc Gerrit-Change-Number: 20011 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/apollolake: Bring in delta for GLK SOC
by build bot (Jenkins) (Code Review) 02 Jun '17

02 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19603 ) Change subject: soc/intel/apollolake: Bring in delta for GLK SOC ...................................................................... Patch Set 64: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/54781/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/10484/ : SUCCESS -- To view, visit https://review.coreboot.org/19603 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3 Gerrit-Change-Number: 19603 Gerrit-PatchSet: 64 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com> Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Jun 2017 07:32:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/cbfstool: Update lz4 to 1.7.5
by build bot (Jenkins) (Code Review) 02 Jun '17

02 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20011 ) Change subject: util/cbfstool: Update lz4 to 1.7.5 ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/54783/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/10486/ : SUCCESS -- To view, visit https://review.coreboot.org/20011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id17f5183392decc15a41f654e398968120832bcc Gerrit-Change-Number: 20011 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Jun 2017 07:27:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/cbfstool: Update lz4 to 1.7.5
by Arthur Heymans (Code Review) 02 Jun '17

02 Jun '17

Hello build bot (Jenkins), Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/20011 to look at the new patch set (#2). Change subject: util/cbfstool: Update lz4 to 1.7.5 ...................................................................... util/cbfstool: Update lz4 to 1.7.5 This fixes building with GCC7 This does the following: * update lz4 to 1.7.5 and change deprecated constants in compress.c * add -Wimplicit-fallthrough=3 to TOOLCFLAGS * Change Pass through in Fall through in lz4frame.c since this is what GCC looks for * Fix trailing whitespace in lz4hc.c Change-Id: Id17f5183392decc15a41f654e398968120832bcc Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/cbfstool/Makefile.inc M util/cbfstool/compress.c M util/cbfstool/lz4/lib/LICENSE M util/cbfstool/lz4/lib/Makefile M util/cbfstool/lz4/lib/README.md M util/cbfstool/lz4/lib/liblz4.pc.in M util/cbfstool/lz4/lib/lz4.c M util/cbfstool/lz4/lib/lz4.h M util/cbfstool/lz4/lib/lz4frame.c M util/cbfstool/lz4/lib/lz4frame.h M util/cbfstool/lz4/lib/lz4frame_static.h M util/cbfstool/lz4/lib/lz4hc.c M util/cbfstool/lz4/lib/lz4hc.h A util/cbfstool/lz4/lib/lz4opt.h M util/cbfstool/lz4/lib/xxhash.c M util/cbfstool/lz4/lib/xxhash.h 16 files changed, 2,683 insertions(+), 2,205 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/20011/2 -- To view, visit https://review.coreboot.org/20011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id17f5183392decc15a41f654e398968120832bcc Gerrit-Change-Number: 20011 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/cbfstool: Update lz4 to 1.7.5
by build bot (Jenkins) (Code Review) 02 Jun '17

02 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20011 ) Change subject: util/cbfstool: Update lz4 to 1.7.5 ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/54782/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/10485/ : SUCCESS -- To view, visit https://review.coreboot.org/20011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id17f5183392decc15a41f654e398968120832bcc Gerrit-Change-Number: 20011 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Jun 2017 07:23:27 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2017