coreboot-gerrit June 2017

coreboot-gerrit@coreboot.org

1 participants
2269 discussions

Change in coreboot[master]: arch/*: Update Kconfig symbol usage
by build bot (Jenkins) (Code Review) 07 Jun '17

07 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20005 ) Change subject: arch/*: Update Kconfig symbol usage ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/55121/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/10801/ : SUCCESS -- To view, visit https://review.coreboot.org/20005 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a84414d2d1631e35ac91efb67a0d4c1f673bf85 Gerrit-Change-Number: 20005 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Jun 2017 19:53:29 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/*: Update Kconfig symbol usage
by build bot (Jenkins) (Code Review) 07 Jun '17

07 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20005 ) Change subject: arch/*: Update Kconfig symbol usage ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/55120/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/10800/ : SUCCESS -- To view, visit https://review.coreboot.org/20005 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a84414d2d1631e35ac91efb67a0d4c1f673bf85 Gerrit-Change-Number: 20005 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Jun 2017 19:47:14 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util: Add sgxtool
by build bot (Jenkins) (Code Review) 07 Jun '17

07 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20041 ) Change subject: util: Add sgxtool ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10799/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/55119/ : SUCCESS -- To view, visit https://review.coreboot.org/20041 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id57576584a949c5a97683d78450af6623dc63581 Gerrit-Change-Number: 20041 Gerrit-PatchSet: 3 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Jun 2017 19:23:30 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/cpu/amd/atrr/amd_mtrr.c Fix checkpatch errors + warnings
by build bot (Jenkins) (Code Review) 07 Jun '17

07 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20097 ) Change subject: src/cpu/amd/atrr/amd_mtrr.c Fix checkpatch errors + warnings ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10798/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/55118/ : SUCCESS -- To view, visit https://review.coreboot.org/20097 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31b1932a2c1e401e56751e0c790bcc6287fb550d Gerrit-Change-Number: 20097 Gerrit-PatchSet: 1 Gerrit-Owner: Evelyn Huang <evhuang(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Jun 2017 19:16:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/foxconn/g41s-k: add new mainboard
by build bot (Jenkins) (Code Review) 07 Jun '17

07 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20027 ) Change subject: mb/foxconn/g41s-k: add new mainboard ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10796/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/55116/ : SUCCESS -- To view, visit https://review.coreboot.org/20027 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc4c8935b1a11e55f4bf6cfa484a8a8d09b1adda Gerrit-Change-Number: 20027 Gerrit-PatchSet: 3 Gerrit-Owner: Samuel Holland <samuel(a)sholland.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Samuel Holland <samuel(a)sholland.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Jun 2017 19:15:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: device/pnp: remove struct io_info
by build bot (Jenkins) (Code Review) 07 Jun '17

07 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20078 ) Change subject: device/pnp: remove struct io_info ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10795/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/55115/ : SUCCESS -- To view, visit https://review.coreboot.org/20078 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e7853844605cd2a6d568caf05488e1218fb53f9 Gerrit-Change-Number: 20078 Gerrit-PatchSet: 4 Gerrit-Owner: Samuel Holland <samuel(a)sholland.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Jun 2017 19:10:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: device/pnp: simplify pnp_get_ioresource
by Samuel Holland (Code Review) 07 Jun '17

07 Jun '17

Samuel Holland has posted comments on this change. ( https://review.coreboot.org/20095 ) Change subject: device/pnp: simplify pnp_get_ioresource ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/20095/1/src/device/pnp_device.c File src/device/pnp_device.c: https://review.coreboot.org/#/c/20095/1/src/device/pnp_device.c@a241 PS1, Line 241: This is the original bug -- for single I/O ports, step == 0, so step - 1 is 0xffffffff -- To view, visit https://review.coreboot.org/20095 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia99b785dcd9cf56fb236ad7ade54656851f88a5e Gerrit-Change-Number: 20095 Gerrit-PatchSet: 1 Gerrit-Owner: Samuel Holland <samuel(a)sholland.org> Gerrit-Reviewer: Samuel Holland <samuel(a)sholland.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Jun 2017 19:10:35 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: device/pnp: simplify pnp_get_ioresource
by build bot (Jenkins) (Code Review) 07 Jun '17

07 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20095 ) Change subject: device/pnp: simplify pnp_get_ioresource ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10794/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/55114/ : SUCCESS -- To view, visit https://review.coreboot.org/20095 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia99b785dcd9cf56fb236ad7ade54656851f88a5e Gerrit-Change-Number: 20095 Gerrit-PatchSet: 1 Gerrit-Owner: Samuel Holland <samuel(a)sholland.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Jun 2017 19:09:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/cpu/amd/pi/00630F01 Fix checkpatch warnings and errors
by build bot (Jenkins) (Code Review) 07 Jun '17

07 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20096 ) Change subject: src/cpu/amd/pi/00630F01 Fix checkpatch warnings and errors ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10797/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/55117/ : SUCCESS -- To view, visit https://review.coreboot.org/20096 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66f1a8640ec5c9d8a1dd039088598f40e8d30f95 Gerrit-Change-Number: 20096 Gerrit-PatchSet: 1 Gerrit-Owner: Evelyn Huang <evhuang(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Jun 2017 19:09:23 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/cpu/amd/atrr/amd_mtrr.c Fix checkpatch errors + warnings
by Evelyn Huang (Code Review) 07 Jun '17

07 Jun '17

Evelyn Huang has uploaded this change for review. ( https://review.coreboot.org/20097 Change subject: src/cpu/amd/atrr/amd_mtrr.c Fix checkpatch errors + warnings ...................................................................... src/cpu/amd/atrr/amd_mtrr.c Fix checkpatch errors + warnings Fix line over 80 characters, unnecessary braces for single statement blocks, spaces before close parantheses errors and warnings. Signed-off-by: Evelyn Huang <evhuang(a)google.com> Change-Id: I31b1932a2c1e401e56751e0c790bcc6287fb550d --- M src/cpu/amd/mtrr/amd_mtrr.c 1 file changed, 10 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/20097/1 diff --git a/src/cpu/amd/mtrr/amd_mtrr.c b/src/cpu/amd/mtrr/amd_mtrr.c index 6c0ead2..106cb79 100644 --- a/src/cpu/amd/mtrr/amd_mtrr.c +++ b/src/cpu/amd/mtrr/amd_mtrr.c @@ -103,9 +103,12 @@ const int cpu_id = cpuid_eax(0x80000001); printk(BIOS_SPEW, "CPU ID 0x80000001: %x\n", cpu_id); const int has_tom2wb = - (((cpu_id>>20 )&0xf) > 0) || // ExtendedFamily > 0 - ((((cpu_id>>8 )&0xf) == 0xf) && // Family == 0F - (((cpu_id>>16)&0xf) >= 0x4)); // Rev>=F deduced from rev tables + // ExtendedFamily > 0 + (((cpu_id>>20)&0xf) > 0) || + // Family == 0F + ((((cpu_id>>8)&0xf) == 0xf) && + // Rev>=F deduced from rev tables + (((cpu_id>>16)&0xf) >= 0x4)); if (has_tom2wb) printk(BIOS_DEBUG, "CPU is Fam 0Fh rev.F or later. We can use TOM2WB for any memory above 4GB\n"); @@ -135,9 +138,8 @@ * undefined side effects. */ msr.lo = msr.hi = 0; - for (i = IORR_FIRST; i <= IORR_LAST; i++) { + for (i = IORR_FIRST; i <= IORR_LAST; i++) wrmsr(i, msr); - } /* Enable Variable Mtrrs * Enable the RdMem and WrMem bits in the fixed mtrrs. @@ -151,12 +153,12 @@ enable_cache(); - address_bits = CONFIG_CPU_ADDR_BITS; //K8 could be 40, and GH could be 48 + //K8 could be 40, and GH could be 48 + address_bits = CONFIG_CPU_ADDR_BITS; /* AMD specific cpuid function to query number of address bits */ - if (cpuid_eax(0x80000000) >= 0x80000008) { + if (cpuid_eax(0x80000000) >= 0x80000008) address_bits = cpuid_eax(0x80000008) & 0xff; - } /* Now that I have mapped what is memory and what is not * Set up the mtrrs so we can cache the memory. -- To view, visit https://review.coreboot.org/20097 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I31b1932a2c1e401e56751e0c790bcc6287fb550d Gerrit-Change-Number: 20097 Gerrit-PatchSet: 1 Gerrit-Owner: Evelyn Huang <evhuang(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2017