Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19604
to look at the new patch set (#35).
Change subject: mainboard/intel/glkrvp: Add support for GLKRVP
......................................................................
mainboard/intel/glkrvp: Add support for GLKRVP
using SOC_INTEL_GLK
Signed-off-by: Hannah Williams <hannah.williams(a)intel.com>
Change-Id: Iab688aca6a4f5c5e32801215ba3a1a440e50fbef
---
A src/mainboard/intel/glkrvp/Kconfig
A src/mainboard/intel/glkrvp/Kconfig.name
A src/mainboard/intel/glkrvp/Makefile.inc
A src/mainboard/intel/glkrvp/acpi_tables.c
A src/mainboard/intel/glkrvp/board_info.txt
A src/mainboard/intel/glkrvp/boardid.c
A src/mainboard/intel/glkrvp/bootblock.c
A src/mainboard/intel/glkrvp/chromeos.c
A src/mainboard/intel/glkrvp/chromeos.fmd
A src/mainboard/intel/glkrvp/dsdt.asl
A src/mainboard/intel/glkrvp/ec.c
A src/mainboard/intel/glkrvp/mainboard.c
A src/mainboard/intel/glkrvp/romstage.c
A src/mainboard/intel/glkrvp/smihandler.c
A src/mainboard/intel/glkrvp/touchpad.asl
A src/mainboard/intel/glkrvp/variants/baseboard/Makefile.inc
A src/mainboard/intel/glkrvp/variants/baseboard/boardid.c
A src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb
A src/mainboard/intel/glkrvp/variants/baseboard/gpio.c
A src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/acpi/dptf.asl
A src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/ec.h
A src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/gpio.h
A src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h
A src/mainboard/intel/glkrvp/variants/baseboard/memory.c
A src/mainboard/intel/glkrvp/variants/baseboard/nhlt.c
A src/mainboard/intel/glkrvp/variants/glkrvp/include/variant/acpi/dptf.asl
A src/mainboard/intel/glkrvp/variants/glkrvp/include/variant/ec.h
A src/mainboard/intel/glkrvp/variants/glkrvp/include/variant/gpio.h
28 files changed, 1,878 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/19604/35
--
To view, visit https://review.coreboot.org/19604
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab688aca6a4f5c5e32801215ba3a1a440e50fbef
Gerrit-PatchSet: 35
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com>
Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com>
Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19603
to look at the new patch set (#51).
Change subject: soc/intel/apollolake: Bring in delta for GLK SOC
......................................................................
soc/intel/apollolake: Bring in delta for GLK SOC
Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3
Signed-off-by: Hannah Williams <hannah.williams(a)intel.com>
---
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/apollolake/Makefile.inc
R src/soc/intel/apollolake/acpi/gpio_apl.asl
C src/soc/intel/apollolake/acpi/gpio_glk.asl
M src/soc/intel/apollolake/acpi/gpiolib.asl
R src/soc/intel/apollolake/acpi/lpc_apl.asl
A src/soc/intel/apollolake/acpi/lpc_glk.asl
R src/soc/intel/apollolake/acpi/lpss_apl.asl
A src/soc/intel/apollolake/acpi/lpss_glk.asl
M src/soc/intel/apollolake/acpi/southbridge.asl
M src/soc/intel/apollolake/bootblock/bootblock.c
M src/soc/intel/apollolake/chip.c
M src/soc/intel/apollolake/chip.h
M src/soc/intel/apollolake/cpu.c
M src/soc/intel/apollolake/dsp.c
A src/soc/intel/apollolake/gpio_apl.c
A src/soc/intel/apollolake/gpio_glk.c
M src/soc/intel/apollolake/graphics.c
M src/soc/intel/apollolake/include/soc/cpu.h
M src/soc/intel/apollolake/include/soc/gpio.h
A src/soc/intel/apollolake/include/soc/gpio_apl.h
A src/soc/intel/apollolake/include/soc/gpio_glk.h
A src/soc/intel/apollolake/include/soc/pci_apl_ids.h
A src/soc/intel/apollolake/include/soc/pci_glk_ids.h
M src/soc/intel/apollolake/include/soc/pci_ids.h
M src/soc/intel/apollolake/include/soc/pcr_ids.h
M src/soc/intel/apollolake/lpc.c
M src/soc/intel/apollolake/lpc_lib.c
M src/soc/intel/apollolake/northbridge.c
M src/soc/intel/apollolake/p2sb.c
M src/soc/intel/apollolake/pmc.c
M src/soc/intel/apollolake/pmutil.c
M src/soc/intel/apollolake/romstage.c
M src/soc/intel/apollolake/sd.c
M src/soc/intel/apollolake/uart_early.c
35 files changed, 1,755 insertions(+), 264 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/19603/51
--
To view, visit https://review.coreboot.org/19603
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3
Gerrit-PatchSet: 51
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com>
Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com>
Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19759 )
Change subject: soc/intel/common/block/gpio: Port gpio code from Apollolake into common gpio
......................................................................
Patch Set 9:
(5 comments)
https://review.coreboot.org/#/c/19759/8/src/soc/intel/common/block/include/…
File src/soc/intel/common/block/include/intelblocks/gpio.h:
Line 35: };
> Presumably this has to increase if the number dwX registers increases per p
We should be able to extend this when needed and add the new ones inside a CONFIG flag which should get initialized using new macros
PS8, Line 38: gpio_t first_pad; /* first pad in community */
: gpio_t last_pad; /* last pad in community */
: uint8_t port;
: size_t num_gpi_regs;/* number of gpi registers in community */
: uint8_t gpi_offset; /* specifies offset in struct gpi_status */
: const char *name;
> Please rearrange these to make the size the smallest.
I missed to address this in patchset 9 - will fix
Line 56: const struct pad_community *gpio_get_community(gpio_t pad);
> Does this need to be exposed globally?
Yes this will be used from SOC dir
PS8, Line 87: Returns the gpio group number
> From what? PMC route settings? If it's pmc it should be specified in the co
I missed to address this in patch set 9 - will fix
https://review.coreboot.org/#/c/19759/8/src/soc/intel/common/block/include/…
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
PS8, Line 65: #define PAD_CFG0_RESET_RSMRST (3 << 30)
> I'm not sure where this originally came from but it's right for APL.
This does have a conflict for SKL but it is not used in SKL code
--
To view, visit https://review.coreboot.org/19759
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48401e92103ff0ec278fb69a3d304148a2d79aa
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com>
Gerrit-Reviewer: Divya Chellappa <divya.chella(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19849
to look at the new patch set (#5).
Change subject: console/flashsconsole: Add spi flash console for debugging
......................................................................
console/flashsconsole: Add spi flash console for debugging
If CONSOLE_SPI_FLASH config is enabled, we can write the cbmem
messages to the 'CONSOLE' area in FMAP if the area is defined
or to the 'console' fil in CBFS which allows us to grab the
log when we read the flash.
This is useful when you don't have usb debugging, and
UART lines are hard to find. Since a failure to boot would
require a hardware flasher anyways, we can get the log
at the same time.
This feature should only be used when no alternative is
found and only when we can't boot the system, because
excessive writes to the flash is not recommended.
This has been tested on purism/librem13 v2 and librem 15 v3 which
run Intel Skylake hardware. It has not been tested on other archs
or with a driver other than the fast_spi.
Change-Id: I74a297b94f6881d8c27cbe5168f161d8331c3df3
Signed-off-by: Youness Alaoui <youness.alaoui(a)puri.sm>
---
M src/console/Kconfig
M src/console/console.c
M src/drivers/spi/Makefile.inc
A src/drivers/spi/flashconsole.c
A src/include/console/flash.h
5 files changed, 278 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/19849/5
--
To view, visit https://review.coreboot.org/19849
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I74a297b94f6881d8c27cbe5168f161d8331c3df3
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19759
to look at the new patch set (#9).
Change subject: soc/intel/common/block/gpio: Port gpio code from Apollolake into common gpio
......................................................................
soc/intel/common/block/gpio: Port gpio code from Apollolake into common gpio
Change-Id: Ic48401e92103ff0ec278fb69a3d304148a2d79aa
Signed-off-by: Hannah Williams <hannah.williams(a)intel.com>
---
A src/soc/intel/common/block/gpio/Kconfig
A src/soc/intel/common/block/gpio/Makefile.inc
A src/soc/intel/common/block/gpio/gpio.c
A src/soc/intel/common/block/include/intelblocks/gpio.h
A src/soc/intel/common/block/include/intelblocks/gpio_defs.h
5 files changed, 758 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/19759/9
--
To view, visit https://review.coreboot.org/19759
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic48401e92103ff0ec278fb69a3d304148a2d79aa
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com>
Gerrit-Reviewer: Divya Chellappa <divya.chella(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>