coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: device/Kconfig: Introduce MAINBOARD_FORCE_NATIVE_VGA_INIT
by build bot (Jenkins) (Code Review) 25 May '17

25 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19813 ) Change subject: device/Kconfig: Introduce MAINBOARD_FORCE_NATIVE_VGA_INIT ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10124/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54400/ : SUCCESS -- To view, visit https://review.coreboot.org/19813 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I689aa5cadea9e1091180fd38b1dc093c6938d69c Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: WIP: google/fizz: Set PL2 to 29 Watts
by build bot (Jenkins) (Code Review) 25 May '17

25 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19783 ) Change subject: WIP: google/fizz: Set PL2 to 29 Watts ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10127/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54404/ : SUCCESS -- To view, visit https://review.coreboot.org/19783 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie152961ea38dce228efac2117928305586120709 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/fizz: Set GPP_C2 to NC
by build bot (Jenkins) (Code Review) 25 May '17

25 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19904 ) Change subject: google/fizz: Set GPP_C2 to NC ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/54403/ : SUCCESS -- To view, visit https://review.coreboot.org/19904 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68091206014621419b886b723a5681541be989bc Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: device/Kconfig: Put gfx init methods into a `choice`
by build bot (Jenkins) (Code Review) 25 May '17

25 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19814 ) Change subject: device/Kconfig: Put gfx init methods into a `choice` ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10125/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54401/ : SUCCESS -- To view, visit https://review.coreboot.org/19814 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06bc65ecf3724f299f59888a97219fdbd3d2d08b Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: fsp/gop: Add running the GOP to the choice of gfx init
by build bot (Jenkins) (Code Review) 25 May '17

25 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19815 ) Change subject: fsp/gop: Add running the GOP to the choice of gfx init ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10126/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54402/ : SUCCESS -- To view, visit https://review.coreboot.org/19815 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92f88424004a4c0abf1f39cc02e2a146bddbcedf Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc: Add AMD StoneyRidge southbridge code
by Marc Jones (Code Review) 25 May '17

25 May '17

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19722 ) Change subject: soc: Add AMD StoneyRidge southbridge code ...................................................................... Patch Set 3: (8 comments) Thanks for the comments. There are lots of things to fix. I'll see what should be done directly here and what should be follow-on and where in the stack they sit. Some may make sense after the cpu and northbridge are also added to soc/ https://review.coreboot.org/#/c/19722/3/src/soc/amd/common/Kconfig File src/soc/amd/common/Kconfig: Line 5 > You might want to avoid the issues that are being seen currently in soc/int OK, I did not realize the issue with soc/intel/common. I was trying to not add more clutter to src/amd/common/*/Kconfig at this point, so would it be more correct to source from the soc/amd/stoneyridge/Kconfig? https://review.coreboot.org/#/c/19722/3/src/soc/amd/stoneyridge/include/soc… File src/soc/amd/stoneyridge/include/soc/hudson.h: PS3, Line 17: STONEYRIDGE_H > Should the name of the file be updated? I think the file will get renamed southbridge.c. I want to rename all the hudson function names, too. https://review.coreboot.org/#/c/19722/3/src/soc/amd/stoneyridge/lpc.c File src/soc/amd/stoneyridge/lpc.c: PS3, Line 314: /* Set WideIO for as many IOs found (fall through is on purpose) */ : switch (var_num) { : case 3: : pci_write_config16(dev, 0x90, reg_var[2]); : /* fall through */ : case 2: : pci_write_config16(dev, 0x66, reg_var[1]); : /* fall through */ : case 1: : pci_write_config16(dev, 0x64, reg_var[0]); : break; : } > There was some other code you had doing this too. Is this code overriding t the G EC required earlier setup. This needs cleanup. https://review.coreboot.org/#/c/19722/3/src/soc/amd/stoneyridge/smbus.c File src/soc/amd/stoneyridge/smbus.c: PS3, Line 16: #ifndef _STONEYRIDGE_SMBUS_C_ : #define _STONEYRIDGE_SMBUS_C_ > Let's not add another place where we're including a c file. These shouldn' I fixed the c include but missed this. Thanks. PS3, Line 175: alink_ab > What's alink? It the bus that links the northbridge and the southbridge. https://review.coreboot.org/#/c/19722/3/src/soc/amd/stoneyridge/smbus_spd.c File src/soc/amd/stoneyridge/smbus_spd.c: PS3, Line 20: #include <Porting.h> : #include <AGESA.h> : #include <amdlib.h> > Where are these residing? These are vendorcode/ Line 24: #include <northbridge/amd/pi/dimmSpd.h> > What's with the northbridge stuff here? Updated with the northbridge is brought in to soc/ Line 51: if ((status & 1) == 1) continue; // HostBusy set, keep waiting > > 80 throughou tfile and the comment style needs update. -- To view, visit https://review.coreboot.org/19722 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88a868e654ad127be70ecc506f6b90b784f8d1b Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: device/Kconfig: Clarify ON_DEVICE_ROM_LOAD
by build bot (Jenkins) (Code Review) 25 May '17

25 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19805 ) Change subject: device/Kconfig: Clarify ON_DEVICE_ROM_LOAD ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10121/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54397/ : SUCCESS -- To view, visit https://review.coreboot.org/19805 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I898765f79cbf5ccce871a3598b56eda83e5efaca Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: payloads/Kconfig: Add NO_DEFAULT_PAYLOAD
by build bot (Jenkins) (Code Review) 25 May '17

25 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19808 ) Change subject: payloads/Kconfig: Add NO_DEFAULT_PAYLOAD ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10123/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54399/ : SUCCESS -- To view, visit https://review.coreboot.org/19808 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f72d4efc0a428dce377c3d003b2c00a6c8d4c08 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: device/Kconfig: Move "Display" menu below gfx options
by build bot (Jenkins) (Code Review) 25 May '17

25 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19806 ) Change subject: device/Kconfig: Move "Display" menu below gfx options ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10122/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54398/ : SUCCESS -- To view, visit https://review.coreboot.org/19806 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9de3d8f76ae10b0a77678ce2d71f840fac32379c Gerrit-PatchSet: 9 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: WIP: google/fizz: Set PL2 to 29 Watts
by Shelley Chen (Code Review) 25 May '17

25 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19783 to look at the new patch set (#6). Change subject: WIP: google/fizz: Set PL2 to 29 Watts ...................................................................... WIP: google/fizz: Set PL2 to 29 Watts PLEASE DON'T CODE REVIEW YET BUG=b:37473486, b:35775024 BRANCH=None TEST=None. Will be tested manually later. Change-Id: Ie152961ea38dce228efac2117928305586120709 Signed-off-by: Shelley Chen <shchen(a)chromium.org> --- M src/mainboard/google/fizz/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/19783/6 -- To view, visit https://review.coreboot.org/19783 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie152961ea38dce228efac2117928305586120709 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017