coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Start a nNew thread

Change in coreboot[master]: soc/intel/common/block: Add Intel common SMBus code
by Aamir Bohra (Code Review) 04 May '17

04 May '17

1 0

Change in coreboot[master]: intelmetool: Use correct type for pointer
by build bot (Jenkins) (Code Review) 04 May '17

04 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19567 ) Change subject: intelmetool: Use correct type for pointer ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53207/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9031/ : SUCCESS -- To view, visit https://review.coreboot.org/19567 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8d778e97090668ad9308a82b44c6b2b599fd6c3 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Wise (Debian) <pabs(a)debian.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Use common/blocks/uart code
by build bot (Jenkins) (Code Review) 04 May '17

04 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19492 ) Change subject: soc/intel/skylake: Use common/blocks/uart code ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53206/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9030/ : SUCCESS -- To view, visit https://review.coreboot.org/19492 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53ed687dc49524e001889f091825b2cc530546a3 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Add Intel common SMBus code
by Aamir Bohra (Code Review) 04 May '17

04 May '17

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/19372 ) Change subject: soc/intel/common/block: Add Intel common SMBus code ...................................................................... Patch Set 8: (6 comments) https://review.coreboot.org/#/c/19372/8/src/soc/intel/common/block/include/… File src/soc/intel/common/block/include/intelblocks/smbus.h: Line 20: #define SMBUS_IO_BASE 0xefa0 > This is needed to be exposed because why? Because of the weird split in imp Ok.Moved SMBUS_IO_BASE ,smbus_read8/smbus_write8 functions to smbuslib.h ,local to common block. Line 26: void smbus_common_init(void); > Please provide a comment indicating what the function does, etc. Done https://review.coreboot.org/#/c/19372/8/src/soc/intel/common/block/smbus/sm… File src/soc/intel/common/block/smbus/smbus.c: Line 100: 0xa123, /* SunRisePoint H */ > Just put these in include/device/pci_ids.h like I noted on the previous CL. Done https://review.coreboot.org/#/c/19372/8/src/soc/intel/common/block/smbus/sm… File src/soc/intel/common/block/smbus/smbuslib.c: Line 54: inb(0x80); > Is there a reason we aren't using the normal timer.h APIs? Revised implementation to use timer APIs from timer.h in PS#9.Please review. PS8, Line 167: { > no need for curlies Done PS8, Line 181: u32 > It seems you are relying on src/include/device/smbus.h as the common declar There was difference in declaration(parameter count) between early_smbus.h and device/smbus.h,hence did not pursue to unify it,Also it is being defined at many places in code,would have evolved into bigger change. -- To view, visit https://review.coreboot.org/19372 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I936143a334c31937d557c6828e5876d35b133567 Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Use intel/common/block/smbus code
by build bot (Jenkins) (Code Review) 04 May '17

04 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19373 ) Change subject: soc/intel/skylake: Use intel/common/block/smbus code ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53203/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9027/ : SUCCESS -- To view, visit https://review.coreboot.org/19373 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ca32ab594552424e4f1358302641f159a3d7e62 Gerrit-PatchSet: 10 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Use common/block/uart code
by build bot (Jenkins) (Code Review) 04 May '17

04 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19491 ) Change subject: soc/intel/apollolake: Use common/block/uart code ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53205/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9029/ : SUCCESS -- To view, visit https://review.coreboot.org/19491 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92c654d59f1642bcd7c95de80dcc641bf816b542 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: Add PCI configuration code for UART
by build bot (Jenkins) (Code Review) 04 May '17

04 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19490 ) Change subject: soc/intel/common: Add PCI configuration code for UART ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53204/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9028/ : SUCCESS -- To view, visit https://review.coreboot.org/19490 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibce5623ffb879f2427b759106d1f350601837e4b Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Add Intel common SMBus code
by build bot (Jenkins) (Code Review) 04 May '17

04 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19372 ) Change subject: soc/intel/common/block: Add Intel common SMBus code ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53202/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9026/ : SUCCESS -- To view, visit https://review.coreboot.org/19372 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I936143a334c31937d557c6828e5876d35b133567 Gerrit-PatchSet: 9 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: pci_device: add PCI device IDs for Intel platforms
by build bot (Jenkins) (Code Review) 04 May '17

04 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19541 ) Change subject: pci_device: add PCI device IDs for Intel platforms ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53201/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9025/ : SUCCESS -- To view, visit https://review.coreboot.org/19541 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0eee9409df3e6dc326b60bc82c2b715c70e7debd Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Use common/block/uart code
by Aamir Bohra (Code Review) 04 May '17

04 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19491 to look at the new patch set (#4). Change subject: soc/intel/apollolake: Use common/block/uart code ...................................................................... soc/intel/apollolake: Use common/block/uart code Change-Id: I92c654d59f1642bcd7c95de80dcc641bf816b542 Signed-off-by: Aamir Bohra <aamir.bohra(a)intel.com> --- M src/soc/intel/apollolake/include/soc/pci_ids.h M src/soc/intel/apollolake/uart.c 2 files changed, 2 insertions(+), 28 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/19491/4 -- To view, visit https://review.coreboot.org/19491 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I92c654d59f1642bcd7c95de80dcc641bf816b542 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017