Tristan Corrick has uploaded a new change for review. ( https://review.coreboot.org/19652 )
Change subject: nb/intel/gm45: Fix raminit with mixed raw card types
......................................................................
nb/intel/gm45: Fix raminit with mixed raw card types
`cardF[n]` should indicate whether the DIMM in channel n is of
raw card type F. However, `cardF[1]` was initialised with the
value meant for `cardF[0]`. This patch results in the correct
initialisation of `cardF`.
Tested on a Lenovo T400 containing two DIMMs: one of raw card
type F and the other of raw card type B. Before the patch, the
system would not boot. After the patch, the system boots with all
of the memory functional.
Change-Id: I7409df0b8c67d7efbdadae39dc718c8df7a92552
Signed-off-by: Tristan Corrick <tristancorrick86(a)gmail.com>
---
M src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/19652/1
diff --git a/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c b/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
index c5614e1..7d57a4e 100644
--- a/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
+++ b/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
@@ -211,7 +211,7 @@
const int cardF[] = {
dimms[0].card_type == 0xf,
- dimms[0].card_type == 0xf,
+ dimms[1].card_type == 0xf,
};
const unsigned int t_bound =
--
To view, visit https://review.coreboot.org/19652
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7409df0b8c67d7efbdadae39dc718c8df7a92552
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Tristan Corrick <tristancorrick86(a)gmail.com>
Stefan Ott has posted comments on this change. ( https://review.coreboot.org/19644 )
Change subject: mb/lenovo/x201: Add support for ThinkLight
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19644/1//COMMIT_MSG
Commit Message:
PS1, Line 16: BIOS the UCMS method
> Vendor bios seems to uses SMI for this on x200. also on x201?
Yes, it also uses SMI on the x201
--
To view, visit https://review.coreboot.org/19644
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80285f6630b5830766d82e3ecd174c4a51aa9066
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes