coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: mb/lenovo/x60/t60: Remove `fn_ctrl_swap` option
by Alexander Couzens (Code Review) 11 May '17

11 May '17

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/19654 ) Change subject: mb/lenovo/x60/t60: Remove `fn_ctrl_swap` option ...................................................................... Patch Set 1: Nico: which version do you tried (EC version)? Can you write that into the commit message? I'll look on my x60 at home. -- To view, visit https://review.coreboot.org/19654 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2964002406a5fcf992f0ffc3627e3f66a2bb13f Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: siemens/mc_apl1: Add usage of external RTC RX6110 SA
by Werner Zeh (Code Review) 11 May '17

11 May '17

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/19647 ) Change subject: siemens/mc_apl1: Add usage of external RTC RX6110 SA ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/19647/1/src/mainboard/siemens/mc_apl1/devic… File src/mainboard/siemens/mc_apl1/devicetree.cb: PS1, Line 44: register "user_weekday" = "1" The 1st of July 2004 was a Thursday. So you probably should set user_weekday to "4", or? -- To view, visit https://review.coreboot.org/19647 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5aceb4401f0bb059ef893dfe7d157716c82e4a76 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: drivers/i2c: Add new driver for RTC type RX6110 SA
by Werner Zeh (Code Review) 11 May '17

11 May '17

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/19625 ) Change subject: drivers/i2c: Add new driver for RTC type RX6110 SA ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/19625 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1290a10c2d5ad76a317c99c8b92a013309a605d6 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/amdk8/debug.c Fix building with CONFIG_DEBUG_SMBUS
by Swift Geek (Code Review) 11 May '17

11 May '17

Swift Geek has posted comments on this change. ( https://review.coreboot.org/19653 ) Change subject: nb/amdk8/debug.c Fix building with CONFIG_DEBUG_SMBUS ...................................................................... Patch Set 1: Code-Review+1 Tested on A8V-E deluxe -- To view, visit https://review.coreboot.org/19653 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8597a6915c65ea783a864110cb23ecb34ea0611b Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/storage: Fix array references
by build bot (Jenkins) (Code Review) 11 May '17

11 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19643 ) Change subject: drivers/storage: Fix array references ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9326/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53533/ : SUCCESS -- To view, visit https://review.coreboot.org/19643 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5c96e78417b667438a00ee22c70894a00d13291 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/storage: Fix array references
by Lee Leahy (Code Review) 11 May '17

11 May '17

Lee Leahy has posted comments on this change. ( https://review.coreboot.org/19643 ) Change subject: drivers/storage: Fix array references ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/19643/1/src/drivers/storage/storage.c File src/drivers/storage/storage.c: Line 97: decimal_units = decimal_unit_name[index]; > So it's complaining about these array accesses? The whole thing would be cl Done -- To view, visit https://review.coreboot.org/19643 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5c96e78417b667438a00ee22c70894a00d13291 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: drivers/storage: Fix array references
by Lee Leahy (Code Review) 11 May '17

11 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19643 to look at the new patch set (#2). Change subject: drivers/storage: Fix array references ...................................................................... drivers/storage: Fix array references Fix bug detected by coverity to handle the zero capacity case. Specific changes: * Reduce loop count by one to handle zero capacity case * Use structure instead of dual arrays * Move structures into display_capacity routine Coverity Issues: * 1374931 * 1374932 * 1374933 * 1374934 TEST=Build and run on Galileo Gen2 Change-Id: Ie5c96e78417b667438a00ee22c70894a00d13291 Signed-off-by: Lee Leahy <Leroy.P.Leahy(a)intel.com> --- M src/drivers/storage/storage.c 1 file changed, 31 insertions(+), 46 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/19643/2 -- To view, visit https://review.coreboot.org/19643 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie5c96e78417b667438a00ee22c70894a00d13291 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: intelmetool: Enhance missing packages help
by build bot (Jenkins) (Code Review) 11 May '17

11 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19617 ) Change subject: intelmetool: Enhance missing packages help ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9325/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53532/ : SUCCESS -- To view, visit https://review.coreboot.org/19617 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I942b3e96f5b8112166a105eb5a61f8f3cf16cb7c Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vincent Legoll <vincent.legoll(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vincent Legoll <vincent.legoll(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: intelmetool: Enhance missing packages help
by Vincent Legoll (Code Review) 11 May '17

11 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19617 to look at the new patch set (#2). Change subject: intelmetool: Enhance missing packages help ...................................................................... intelmetool: Enhance missing packages help On Ubuntu 16.04 the libpci-dev package is required. Change-Id: I942b3e96f5b8112166a105eb5a61f8f3cf16cb7c Signed-off-by: Vincent Legoll <vincent.legoll(a)gmail.com> --- M util/intelmetool/Makefile 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/19617/2 -- To view, visit https://review.coreboot.org/19617 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I942b3e96f5b8112166a105eb5a61f8f3cf16cb7c Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vincent Legoll <vincent.legoll(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vincent Legoll <vincent.legoll(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/amd/amdk8: Don't bail out on dimms on channel 1
by Arthur Heymans (Code Review) 11 May '17

11 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19655 ) Change subject: nb/amd/amdk8: Don't bail out on dimms on channel 1 ...................................................................... Patch Set 1: well the raminit incorrectly reports that no dimms are present if there are only dimms in channel1. On the other hand the raminit assumes there are dimms in channel0 that match what is in channel1... -- To view, visit https://review.coreboot.org/19655 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4a7c7c0e154bdb683d22691f4323635b37cae3 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017