Patrick Georgi has uploaded a new change for review. ( https://review.coreboot.org/19659 )
Change subject: xcompile: silence clang when referencing packed structs' members
......................................................................
xcompile: silence clang when referencing packed structs' members
clang complains that the access might be unaligned. Yes, we know. Yes,
that's exactly what we want. You have _one_ job.
Change-Id: I5400f50d8b5b462270c700f7ff90d9d517278e71
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
---
M util/xcompile/xcompile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/19659/1
diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index 347ae8e..6986b53 100755
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -250,7 +250,7 @@
CLANG_CFLAGS_${TARCH}:=${CFLAGS_CLANG}
CLANG_CFLAGS_${TARCH}+=-no-integrated-as -Qunused-arguments -m${TWIDTH}
# tone down clang compiler warnings
-CLANG_CFLAGS_${TARCH}+=-Wno-unused-variable -Wno-unused-function -Wno-tautological-compare -Wno-shift-overflow
+CLANG_CFLAGS_${TARCH}+=-Wno-unused-variable -Wno-unused-function -Wno-tautological-compare -Wno-shift-overflow -Wno-address-of-packed-member
CLANG_COMPILER_RT_${TARCH}:=${CC_RT_CLANG}
CLANG_COMPILER_RT_FLAGS_${TARCH}:=${CC_RT_EXTRA_CLANG}
--
To view, visit https://review.coreboot.org/19659
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5400f50d8b5b462270c700f7ff90d9d517278e71
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Patrick Georgi has uploaded a new change for review. ( https://review.coreboot.org/19657 )
Change subject: toolchain.inc: Use -Wstack-usage only on gcc
......................................................................
toolchain.inc: Use -Wstack-usage only on gcc
clang isn't happy with it
Change-Id: I2c22171dedc77df24e739ec26335010f0f443963
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
---
M toolchain.inc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/19657/1
diff --git a/toolchain.inc b/toolchain.inc
index 5501c32..d9b11f0 100644
--- a/toolchain.inc
+++ b/toolchain.inc
@@ -79,11 +79,13 @@
# for an example).
# (If you absolutely need a larger stack frame and are 100% sure it cannot
# cause problems, you can whitelist it with #pragma diagnostic.)
+ifeq ($(CONFIG_COMPILER_GCC),y)
CFLAGS_arm += -Wstack-usage=1536
CFLAGS_arm64 += -Wstack-usage=1536
CFLAGS_mips += -Wstack-usage=1536
CFLAGS_riscv += -Wstack-usage=1536
CFLAGS_power8 += -Wstack-usage=1536
+endif
toolchain_to_dir = \
$(foreach arch,$(ARCH_SUPPORTED),\
--
To view, visit https://review.coreboot.org/19657
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c22171dedc77df24e739ec26335010f0f443963
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Patrick Georgi has uploaded a new change for review. ( https://review.coreboot.org/19658 )
Change subject: xcompile: replace -print-librt-file-name with -print-libgcc-file-name
......................................................................
xcompile: replace -print-librt-file-name with -print-libgcc-file-name
The former only exists with a custom patch while the latter is supported
by clang and in the absense of libgcc even points to clang's own runtime
libraries.
Change-Id: I1e30d5518cf78e1d66925d6f2ccada60a43bb4f8
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
---
M util/xcompile/xcompile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/19658/1
diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index 32665f8..347ae8e 100755
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -207,7 +207,7 @@
detect_compiler_runtime() {
test -z "$CLANG" || \
- CC_RT_CLANG="$(${CLANG} ${CFLAGS_CLANG} -print-librt-file-name 2>/dev/null)"
+ CC_RT_CLANG="$(${CLANG} -print-libgcc-file-name 2>/dev/null)"
test -z "$GCC" || \
CC_RT_GCC="$(${GCC} ${CFLAGS_GCC} -print-libgcc-file-name)"
}
--
To view, visit https://review.coreboot.org/19658
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e30d5518cf78e1d66925d6f2ccada60a43bb4f8
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/19647 )
Change subject: siemens/mc_apl1: Add usage of external RTC RX6110 SA
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19647/1/src/mainboard/siemens/mc_apl1/devic…
File src/mainboard/siemens/mc_apl1/devicetree.cb:
PS1, Line 44: register "user_weekday" = "1"
> The 1st of July 2004 was a Thursday. So you probably should set user_weekda
Yes, you are right.
I will change this tomorrow morning.
--
To view, visit https://review.coreboot.org/19647
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5aceb4401f0bb059ef893dfe7d157716c82e4a76
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/19654 )
Change subject: mb/lenovo/x60/t60: Remove `fn_ctrl_swap` option
......................................................................
Patch Set 1:
On a x220 I tried to do `./ectool -w 0xce -z 0x10` and get a fn_ctrl swap.
--
To view, visit https://review.coreboot.org/19654
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2964002406a5fcf992f0ffc3627e3f66a2bb13f
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19617 )
Change subject: intelmetool: Enhance missing packages help
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/19617
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I942b3e96f5b8112166a105eb5a61f8f3cf16cb7c
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Vincent Legoll <vincent.legoll(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Vincent Legoll <vincent.legoll(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/19654 )
Change subject: mb/lenovo/x60/t60: Remove `fn_ctrl_swap` option
......................................................................
Patch Set 1:
> Nico: which version do you tried (EC version)? Can you write that
> into the commit message? I'll look on my x60 at home
[...] if it has this feature with the oem bios.
--
To view, visit https://review.coreboot.org/19654
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2964002406a5fcf992f0ffc3627e3f66a2bb13f
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No