Marty Plummer has posted comments on this change. ( https://review.coreboot.org/17669 )
Change subject: superio/fintek: Add support for Fintek F71889A.
......................................................................
Patch Set 9:
(2 comments)
> is there any board actually using this superio chip? if no
> mainboard selects this chip, the code won't get build-tested...
No, as of right now no board makes use of this superio (afaik). I'm working on it because my current board makes use of it, but there is a lot of groundwork to be dealt with (mostly am3+ ddr3 init and the glue code that makes all the things work together) before there will be a board that works.
https://review.coreboot.org/#/c/17669/6/src/superio/fintek/f71889a/superio.c
File src/superio/fintek/f71889a/superio.c:
PS6, Line 57: 0x07f8
> this reserves only 1 byte of io space; the device also uses the byte at pos
Could you explain this a bit? I based this code largely (read: exact same with a bit of tweaking to match datasheets to the best of my understanding) on the f71869ab code and both the f71889a and it are very similar for the KBC register, so I can't see how the f71869ad uses one byte and the f71889a would use two. (or for that matter, why 0x07ff signifies one byte)
https://review.coreboot.org/#/c/17669/7/src/superio/fintek/f71889a/superio.c
File src/superio/fintek/f71889a/superio.c:
Line 60: { &ops, F71889A_CIR, PNP_IO0 | PNP_IRQ0, {0x7f8, 0}, },
> the io mask is missing here
Ah, so it is! Unsure here, so I assume a single byte is enough. It has been added.
--
To view, visit https://review.coreboot.org/17669
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91c60a3b48cd4872ae7a27de8f49faa40e877a27
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marty Plummer <ntzrmtthihu777(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Marty Plummer <ntzrmtthihu777(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Marty Plummer has posted comments on this change. ( https://review.coreboot.org/17442 )
Change subject: util/superiotool/fintek.c: Add support for F71889A
......................................................................
Patch Set 7:
> are you planning to address the comment regarding the many NANA
> values I made some months ago?
Ah, entirely sorry about that. I've been rather busy with realworld concerns of late and have not had time to tinker with this. Treat reserved values as returning '0' should be sufficient for now, correct?
--
To view, visit https://review.coreboot.org/17442
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc5035ebe2c1c66213069567da757886923e5596
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marty Plummer <ntzrmtthihu777(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Marty Plummer <ntzrmtthihu777(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Bora Guvendik has abandoned this change. ( https://review.coreboot.org/18108 )
Change subject: mainboard/google/reef: run sdhci init on an AP in parallel
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/18108
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I86a8b3857685d8638c4cdcd865b16b9454496cb2
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>