Hello Arthur Heymans, Paul Menzel, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/18011
to look at the new patch set (#10).
Change subject: mainboard/lenovo/t430: Add Thinkpad T430 support
......................................................................
mainboard/lenovo/t430: Add Thinkpad T430 support
Tested and working:
* HDD LED
* Booting GNU Linux 4.9 from HDD using SeaBios
* Booting GNU Linux 4.9 from USB using SeaBios
* Native GFX init
* All Fn function keys
* Speakers
* PCIe Wifi
* Camera
* WWAN
* Fan (Dynamic Thermal Managment)
* Flashing using internal programmer
* Dual memory DIMMs running at up to DDR3-1866
* AC events
* Touchpad, trackball and keyboard
* USB3 ports running at SuperSpeed
* Ethernet
* Headphone jack
* Speaker mute
* Microphone mute
* Volume keys
* Fingerprint sensor
* Lid switch
* Thinklight
* TPM (disable SeaBios CONFIG_TCGBIOS)
* CMOS options:
** power_on_after_fail
** reboot_counter
** boot_option
** gfx_uma_size
Untested:
* Booting Windows
* Hybrid graphics
* Docking station
* VGA
Broken:
* Wifi LED is always on
Change-Id: I5403cfb80a57753e873c570d95ca535cf5f45630
Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org>
Signed-off-by: Patrick Rudolph <siro(a)das-labor.org>
---
A src/mainboard/lenovo/t430/Kconfig
A src/mainboard/lenovo/t430/Kconfig.name
A src/mainboard/lenovo/t430/Makefile.inc
A src/mainboard/lenovo/t430/acpi/ec.asl
A src/mainboard/lenovo/t430/acpi/platform.asl
A src/mainboard/lenovo/t430/acpi/superio.asl
A src/mainboard/lenovo/t430/acpi_tables.c
A src/mainboard/lenovo/t430/board_info.txt
A src/mainboard/lenovo/t430/cmos.default
A src/mainboard/lenovo/t430/cmos.layout
A src/mainboard/lenovo/t430/devicetree.cb
A src/mainboard/lenovo/t430/dsdt.asl
A src/mainboard/lenovo/t430/gpio.c
A src/mainboard/lenovo/t430/hda_verb.c
A src/mainboard/lenovo/t430/mainboard.c
A src/mainboard/lenovo/t430/romstage.c
A src/mainboard/lenovo/t430/smihandler.c
A src/mainboard/lenovo/t430/thermal.h
18 files changed, 1,080 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/18011/10
--
To view, visit https://review.coreboot.org/18011
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5403cfb80a57753e873c570d95ca535cf5f45630
Gerrit-PatchSet: 10
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19682
to look at the new patch set (#5).
Change subject: [RFC]mb/*/*: Remove rtc nvram configurable baud rate
......................................................................
[RFC]mb/*/*: Remove rtc nvram configurable baud rate
There have been discussions about removing this since it does not seem
to be used much and only creates troubles for boards without defaults,
not to mention that it was configurable on many boards that do not
even feature uart.
It is still possible to configure the baudrate through the Kconfig
option.
Change-Id: I71698d9b188eeac73670b18b757dff5fcea0df41
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/drivers/uart/util.c
M src/mainboard/adi/rcc-dff/cmos.layout
M src/mainboard/advansus/a785e-i/cmos.layout
M src/mainboard/amd/bettong/cmos.layout
M src/mainboard/amd/bimini_fam10/cmos.layout
M src/mainboard/amd/db-ft3b-lc/cmos.layout
M src/mainboard/amd/db800/cmos.layout
M src/mainboard/amd/dbm690t/cmos.layout
M src/mainboard/amd/dinar/cmos.layout
M src/mainboard/amd/f2950/cmos.layout
M src/mainboard/amd/gardenia/cmos.layout
M src/mainboard/amd/inagua/cmos.layout
M src/mainboard/amd/lamar/cmos.layout
M src/mainboard/amd/mahogany/cmos.layout
M src/mainboard/amd/mahogany_fam10/cmos.layout
M src/mainboard/amd/norwich/cmos.layout
M src/mainboard/amd/olivehill/cmos.layout
M src/mainboard/amd/olivehillplus/cmos.layout
M src/mainboard/amd/parmer/cmos.layout
M src/mainboard/amd/persimmon/cmos.layout
M src/mainboard/amd/pistachio/cmos.layout
M src/mainboard/amd/rumba/cmos.layout
M src/mainboard/amd/serengeti_cheetah/cmos.layout
M src/mainboard/amd/serengeti_cheetah_fam10/cmos.layout
M src/mainboard/amd/south_station/cmos.layout
M src/mainboard/amd/thatcher/cmos.layout
M src/mainboard/amd/tilapia_fam10/cmos.layout
M src/mainboard/amd/torpedo/cmos.layout
M src/mainboard/amd/union_station/cmos.layout
M src/mainboard/apple/macbook21/cmos.default
M src/mainboard/apple/macbook21/cmos.layout
M src/mainboard/artecgroup/dbe61/cmos.layout
M src/mainboard/asrock/939a785gmh/cmos.layout
M src/mainboard/asrock/e350m1/cmos.layout
M src/mainboard/asrock/imb-a180/cmos.layout
M src/mainboard/asus/a8n_e/cmos.default
M src/mainboard/asus/a8n_e/cmos.layout
M src/mainboard/asus/a8v-e_deluxe/cmos.layout
M src/mainboard/asus/a8v-e_se/cmos.layout
M src/mainboard/asus/dsbf/cmos.layout
M src/mainboard/asus/f2a85-m/cmos.layout
M src/mainboard/asus/k8v-x/cmos.layout
M src/mainboard/asus/kcma-d8/cmos.default
M src/mainboard/asus/kcma-d8/cmos.layout
M src/mainboard/asus/kfsn4-dre/cmos.default
M src/mainboard/asus/kfsn4-dre/cmos.layout
M src/mainboard/asus/kfsn4-dre_k8/cmos.default
M src/mainboard/asus/kfsn4-dre_k8/cmos.layout
M src/mainboard/asus/kgpe-d16/cmos.default
M src/mainboard/asus/kgpe-d16/cmos.layout
M src/mainboard/asus/m2n-e/cmos.layout
M src/mainboard/asus/m2v-mx_se/cmos.layout
M src/mainboard/asus/m2v/cmos.layout
M src/mainboard/asus/m4a78-em/cmos.layout
M src/mainboard/asus/m4a785-m/cmos.layout
M src/mainboard/asus/m4a785t-m/cmos.default
M src/mainboard/asus/m4a785t-m/cmos.layout
M src/mainboard/asus/m5a88-v/cmos.layout
M src/mainboard/asus/mew-vm/cmos.layout
M src/mainboard/asus/p5gc-mx/cmos.default
M src/mainboard/asus/p5gc-mx/cmos.layout
M src/mainboard/avalue/eax-785e/cmos.layout
M src/mainboard/bachmann/ot200/cmos.default
M src/mainboard/bachmann/ot200/cmos.layout
M src/mainboard/bap/ode_e20XX/cmos.layout
M src/mainboard/bap/ode_e21XX/cmos.layout
M src/mainboard/bcom/winnetp680/cmos.layout
M src/mainboard/biostar/am1ml/cmos.layout
M src/mainboard/broadcom/blast/cmos.layout
M src/mainboard/digitallogic/msm800sev/cmos.layout
M src/mainboard/elmex/pcm205400/cmos.layout
M src/mainboard/emulation/qemu-i440fx/cmos.default
M src/mainboard/emulation/qemu-i440fx/cmos.layout
M src/mainboard/esd/atom15/cmos.layout
M src/mainboard/getac/p470/cmos.layout
M src/mainboard/gigabyte/ga-945gcm-s2l/cmos.default
M src/mainboard/gigabyte/ga-945gcm-s2l/cmos.layout
M src/mainboard/gigabyte/ga-b75m-d3h/cmos.default
M src/mainboard/gigabyte/ga-b75m-d3h/cmos.layout
M src/mainboard/gigabyte/ga-b75m-d3v/cmos.default
M src/mainboard/gigabyte/ga-b75m-d3v/cmos.layout
M src/mainboard/gigabyte/ga-g41m-es2l/cmos.default
M src/mainboard/gigabyte/ga-g41m-es2l/cmos.layout
M src/mainboard/gigabyte/ga_2761gxdk/cmos.layout
M src/mainboard/gigabyte/m57sli/cmos.default
M src/mainboard/gigabyte/m57sli/cmos.layout
M src/mainboard/gigabyte/ma785gm/cmos.layout
M src/mainboard/gigabyte/ma785gmt/cmos.layout
M src/mainboard/gigabyte/ma78gm/cmos.layout
M src/mainboard/gizmosphere/gizmo/cmos.layout
M src/mainboard/gizmosphere/gizmo2/cmos.layout
M src/mainboard/google/auron/cmos.layout
M src/mainboard/google/beltino/cmos.layout
M src/mainboard/google/butterfly/cmos.layout
M src/mainboard/google/chell/cmos.layout
M src/mainboard/google/cyan/cmos.layout
M src/mainboard/google/glados/cmos.layout
M src/mainboard/google/jecht/cmos.layout
M src/mainboard/google/lars/cmos.layout
M src/mainboard/google/link/cmos.layout
M src/mainboard/google/parrot/cmos.layout
M src/mainboard/google/rambi/cmos.layout
M src/mainboard/google/slippy/cmos.layout
M src/mainboard/google/stout/cmos.layout
M src/mainboard/hp/abm/cmos.layout
M src/mainboard/hp/dl145_g1/cmos.layout
M src/mainboard/hp/dl145_g3/cmos.layout
M src/mainboard/hp/dl165_g6_fam10/cmos.layout
M src/mainboard/ibase/mb899/cmos.layout
M src/mainboard/iei/kino-780am2-fam10/cmos.layout
M src/mainboard/intel/baskingridge/cmos.layout
M src/mainboard/intel/bayleybay_fsp/cmos.layout
M src/mainboard/intel/camelbackmountain_fsp/cmos.layout
M src/mainboard/intel/cougar_canyon2/cmos.layout
M src/mainboard/intel/d510mo/cmos.default
M src/mainboard/intel/d510mo/cmos.layout
M src/mainboard/intel/d945gclf/cmos.default
M src/mainboard/intel/d945gclf/cmos.layout
M src/mainboard/intel/eagleheights/cmos.layout
M src/mainboard/intel/emeraldlake2/cmos.layout
M src/mainboard/intel/kblrvp/cmos.layout
M src/mainboard/intel/kunimitsu/cmos.layout
M src/mainboard/intel/littleplains/cmos.layout
M src/mainboard/intel/minnowmax/cmos.layout
M src/mainboard/intel/mohonpeak/cmos.layout
M src/mainboard/intel/stargo2/cmos.layout
M src/mainboard/intel/strago/cmos.layout
M src/mainboard/intel/wtm2/cmos.layout
M src/mainboard/iwave/iWRainbowG6/cmos.layout
M src/mainboard/iwill/dk8_htx/cmos.layout
M src/mainboard/jetway/j7f2/cmos.layout
M src/mainboard/jetway/nf81-t56n-lf/cmos.layout
M src/mainboard/jetway/pa78vm5/cmos.layout
M src/mainboard/kontron/986lcd-m/cmos.layout
M src/mainboard/kontron/kt690/cmos.layout
M src/mainboard/kontron/ktqm77/cmos.layout
M src/mainboard/lanner/em8510/cmos.layout
M src/mainboard/lenovo/g505s/cmos.layout
M src/mainboard/lenovo/l520/cmos.default
M src/mainboard/lenovo/l520/cmos.layout
M src/mainboard/lenovo/t400/cmos.default
M src/mainboard/lenovo/t400/cmos.layout
M src/mainboard/lenovo/t420/cmos.default
M src/mainboard/lenovo/t420/cmos.layout
M src/mainboard/lenovo/t420s/cmos.default
M src/mainboard/lenovo/t420s/cmos.layout
M src/mainboard/lenovo/t430s/cmos.default
M src/mainboard/lenovo/t430s/cmos.layout
M src/mainboard/lenovo/t520/cmos.default
M src/mainboard/lenovo/t520/cmos.layout
M src/mainboard/lenovo/t530/cmos.default
M src/mainboard/lenovo/t530/cmos.layout
M src/mainboard/lenovo/t60/cmos.default
M src/mainboard/lenovo/t60/cmos.layout
M src/mainboard/lenovo/x1_carbon_gen1/cmos.default
M src/mainboard/lenovo/x1_carbon_gen1/cmos.layout
M src/mainboard/lenovo/x200/cmos.default
M src/mainboard/lenovo/x200/cmos.layout
M src/mainboard/lenovo/x201/cmos.default
M src/mainboard/lenovo/x201/cmos.layout
M src/mainboard/lenovo/x220/cmos.default
M src/mainboard/lenovo/x220/cmos.layout
M src/mainboard/lenovo/x230/cmos.default
M src/mainboard/lenovo/x230/cmos.layout
M src/mainboard/lenovo/x60/cmos.default
M src/mainboard/lenovo/x60/cmos.layout
M src/mainboard/lippert/frontrunner-af/cmos.layout
M src/mainboard/lippert/frontrunner/cmos.layout
M src/mainboard/lippert/toucan-af/cmos.layout
M src/mainboard/msi/ms7135/cmos.layout
M src/mainboard/msi/ms7260/cmos.layout
M src/mainboard/msi/ms7721/cmos.layout
M src/mainboard/msi/ms9185/cmos.layout
M src/mainboard/msi/ms9282/cmos.layout
M src/mainboard/msi/ms9652_fam10/cmos.layout
M src/mainboard/nvidia/l1_2pvv/cmos.layout
M src/mainboard/packardbell/ms2290/cmos.default
M src/mainboard/packardbell/ms2290/cmos.layout
M src/mainboard/pcengines/alix1c/cmos.default
M src/mainboard/pcengines/alix1c/cmos.layout
M src/mainboard/pcengines/alix2d/cmos.layout
M src/mainboard/pcengines/apu1/cmos.default
M src/mainboard/pcengines/apu1/cmos.layout
M src/mainboard/pcengines/apu2/cmos.layout
M src/mainboard/roda/rk886ex/cmos.layout
M src/mainboard/roda/rk9/cmos.layout
M src/mainboard/roda/rv11/cmos.layout
M src/mainboard/samsung/lumpy/cmos.layout
M src/mainboard/samsung/stumpy/cmos.layout
M src/mainboard/sapphire/pureplatinumh61/cmos.default
M src/mainboard/sapphire/pureplatinumh61/cmos.layout
M src/mainboard/siemens/mc_bdx1/cmos.layout
M src/mainboard/siemens/mc_tcu3/cmos.layout
M src/mainboard/siemens/sitemp_g1p1/cmos.default
M src/mainboard/siemens/sitemp_g1p1/cmos.layout
M src/mainboard/sunw/ultra40/cmos.layout
M src/mainboard/sunw/ultra40m2/cmos.layout
M src/mainboard/supermicro/h8dme/cmos.layout
M src/mainboard/supermicro/h8dmr/cmos.layout
M src/mainboard/supermicro/h8dmr_fam10/cmos.layout
M src/mainboard/supermicro/h8qgi/cmos.layout
M src/mainboard/supermicro/h8qme_fam10/cmos.layout
M src/mainboard/supermicro/h8scm/cmos.layout
M src/mainboard/supermicro/h8scm_fam10/cmos.layout
M src/mainboard/supermicro/x7db8/cmos.layout
M src/mainboard/technexion/tim5690/cmos.layout
M src/mainboard/technexion/tim8690/cmos.layout
M src/mainboard/traverse/geos/cmos.layout
M src/mainboard/tyan/s2912/cmos.layout
M src/mainboard/tyan/s2912_fam10/cmos.layout
M src/mainboard/tyan/s8226/cmos.layout
M src/mainboard/via/epia-cn/cmos.layout
M src/mainboard/via/epia-m700/cmos.layout
M src/mainboard/via/pc2500e/cmos.layout
M src/mainboard/via/vt8454c/cmos.layout
M src/mainboard/winent/mb6047/cmos.layout
M src/mainboard/winent/pl6064/cmos.layout
M src/mainboard/wyse/s50/cmos.layout
218 files changed, 181 insertions(+), 1,690 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/19682/5
--
To view, visit https://review.coreboot.org/19682
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I71698d9b188eeac73670b18b757dff5fcea0df41
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19658 )
Change subject: xcompile: replace -print-librt-file-name with -print-libgcc-file-name
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19658
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e30d5518cf78e1d66925d6f2ccada60a43bb4f8
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Martin Roth has posted comments on this change. ( https://review.coreboot.org/14208 )
Change subject: Add CONFIG_RESERVED_SPACE_BEFORE_RESET_VECTOR
......................................................................
Patch Set 16:
(1 comment)
I'm good with this, although if Stefan or someone comes back with more details about the AMD/Nvidia solution, we might want to update it. Since the HP laptops that need this are still WIP, I'm not seeing a hurry to get it in.
https://review.coreboot.org/#/c/14208/16/src/arch/x86/Kconfig
File src/arch/x86/Kconfig:
Line 187:
Maybe add some help text here describing what this is used for?
--
To view, visit https://review.coreboot.org/14208
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I992d285a1a76883ff7a69445a0ff9efe62dbbd7f
Gerrit-PatchSet: 16
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes