coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: soc/intel/common/block:[WIP] Add GPIO common code
by Hannah Williams (Code Review) 15 May '17

15 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/18917 to look at the new patch set (#23). Change subject: soc/intel/common/block:[WIP] Add GPIO common code ...................................................................... soc/intel/common/block:[WIP] Add GPIO common code Here are some differences between APL and SKL GPIO registers DW0: PMODE: SKL[11:10] and APL[12:10] RXTXENCFG: APL[21:20] and RSVD in SKL PREGFRXSEL: APL[24] and RSVD in SKL DW1: SKL only has INTSEL and TERM whereas APL and GLK share same bit definitions for rest of the bits that are reserved in SKL (e.g. IoStandby state and term) EVMAP and EVOUTEN are not there on SKL DW1_PAD_TOL has been used only in SKL Change-Id: I3a1d56df46668bfb08206ca4a99202db5cd1da7c Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- A src/soc/intel/common/block/gpio/Kconfig A src/soc/intel/common/block/gpio/Makefile.inc A src/soc/intel/common/block/gpio/gpio.c A src/soc/intel/common/block/include/intelblocks/gpio.h A src/soc/intel/common/block/include/intelblocks/gpio_defs.h 5 files changed, 842 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/18917/23 -- To view, visit https://review.coreboot.org/18917 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3a1d56df46668bfb08206ca4a99202db5cd1da7c Gerrit-PatchSet: 23 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Dhaval Sharma <dhaval.v.sharma(a)intel.com> Gerrit-Reviewer: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Marc Herbert <marc.herbert(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: sowmya v <sowmyav235(a)gmail.com>

1 0

Change in coreboot[master]: arch/arm64: Use variables of the right size for msr/mrs opcodes
by Furquan Shaikh (Code Review) 15 May '17

15 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19661 ) Change subject: arch/arm64: Use variables of the right size for msr/mrs opcodes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19661 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c8b9fe3a1adc521e393c2e2a0216f7f425a2a3e Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/southbridge/i82801gx: Include a default SeaBIOS config file
by build bot (Jenkins) (Code Review) 15 May '17

15 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19690 ) Change subject: src/southbridge/i82801gx: Include a default SeaBIOS config file ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9405/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53623/ : SUCCESS -- To view, visit https://review.coreboot.org/19690 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6e79ea6cd0a14070b8092aefa477b9e3a0c4b1 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/southbridge/i82801gx: Include a default SeaBIOS config file
by Arthur Heymans (Code Review) 15 May '17

15 May '17

Arthur Heymans has uploaded a new change for review. ( https://review.coreboot.org/19690 ) Change subject: src/southbridge/i82801gx: Include a default SeaBIOS config file ...................................................................... src/southbridge/i82801gx: Include a default SeaBIOS config file Some ICH7 variants do not feature AHCI which will result in SeaBIOS Port Mapped I/O for disk access which is quite slow. Using DMA results in much faster disk operations. Change-Id: I6a6e79ea6cd0a14070b8092aefa477b9e3a0c4b1 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/southbridge/intel/i82801gx/Kconfig A src/southbridge/intel/i82801gx/config_seabios 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/19690/1 diff --git a/src/southbridge/intel/i82801gx/Kconfig b/src/southbridge/intel/i82801gx/Kconfig index b2265c4..003cdac 100644 --- a/src/southbridge/intel/i82801gx/Kconfig +++ b/src/southbridge/intel/i82801gx/Kconfig @@ -39,4 +39,12 @@ hex default 0x80 +config PAYLOAD_CONFIGFILE + string + default "$(top)/src/southbridge/intel/i82801gx/config_seabios" if PAYLOAD_SEABIOS + help + Some ICH7 variants do not have AHCI on which SeaBIOS will use + Port Mapped I/O for disk access by default. Using DMA will result + in much faster disk operations. + endif diff --git a/src/southbridge/intel/i82801gx/config_seabios b/src/southbridge/intel/i82801gx/config_seabios new file mode 100644 index 0000000..76d48ed --- /dev/null +++ b/src/southbridge/intel/i82801gx/config_seabios @@ -0,0 +1 @@ +CONFIG_ATA_DMA=y \ No newline at end of file -- To view, visit https://review.coreboot.org/19690 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6a6e79ea6cd0a14070b8092aefa477b9e3a0c4b1 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: util/release: Update build-release script
by Philipp Deppenwiese (Code Review) 15 May '17

15 May '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19126 ) Change subject: util/release: Update build-release script ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/19126 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa434a4911dec777004788e3cf4e3436875d929b Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/winnet/g170: disable use of upper memory for SeaBIOS
by Arthur Heymans (Code Review) 15 May '17

15 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18905 ) Change subject: mainboard/winnet/g170: disable use of upper memory for SeaBIOS ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/18905/4/src/mainboard/winnet/g170/Kconfig File src/mainboard/winnet/g170/Kconfig: Line 44: default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" if CONFIG_PAYLOAD_SEABIOS? -- To view, visit https://review.coreboot.org/18905 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69f1fe38503b0f8d6015b515637d8376726490c0 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mainboard/winnet/g170: Add ACPI support
by Arthur Heymans (Code Review) 15 May '17

15 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18901 ) Change subject: mainboard/winnet/g170: Add ACPI support ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/18901 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee3ede8683d1ea51317228d4f782af27043cc945 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/winnet/g170: Add WinNET G170 board
by Arthur Heymans (Code Review) 15 May '17

15 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18899 ) Change subject: mainboard/winnet/g170: Add WinNET G170 board ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/18899 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d7aba827fb87f69f542edd2f7ac7a66d949f865 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/winnet/g170: Copy from mainboard/bcom/winnetp680
by Arthur Heymans (Code Review) 15 May '17

15 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18898 ) Change subject: mainboard/winnet/g170: Copy from mainboard/bcom/winnetp680 ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/18898 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90b89ee634d90cfba2e56cca5b76cfd2bd7a8d0b Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: southbridge/via/vt8237r/acpi: Add IRQ routing
by Arthur Heymans (Code Review) 15 May '17

15 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18897 ) Change subject: southbridge/via/vt8237r/acpi: Add IRQ routing ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/18897/4/src/southbridge/via/vt8237r/acpi/de… File src/southbridge/via/vt8237r/acpi/default_irq_route.asl: PS4, Line 62: /* IDE (Native Mode)/SATA IRQ & INTE => IRQ20 */ : Package (4) { 0x000fffff, 0, 0x00, 20 }, : Package (4) { 0x000fffff, 1, 0x00, 20 }, : Package (4) { 0x000fffff, 2, 0x00, 20 }, : Package (4) { 0x000fffff, 3, 0x00, 20 }, : : /* USB IRQ (all 5 functions) and INTF => IRQ21 */ : Package (4) { 0x0010ffff, 0, 0x00, 21 }, : Package (4) { 0x0010ffff, 1, 0x00, 21 }, : Package (4) { 0x0010ffff, 2, 0x00, 21 }, : Package (4) { 0x0010ffff, 3, 0x00, 21 }, : : /* AC’97 / MC’97 IRQ and INTG => IRQ22 */ : Package (4) { 0x0011ffff, 0, 0x00, 22 }, : Package (4) { 0x0011ffff, 1, 0x00, 22 }, : Package (4) { 0x0011ffff, 2, 0x00, 22 }, : Package (4) { 0x0011ffff, 3, 0x00, 22 }, : : /* LAN IRQ and INTH => IRQ23 */ : Package (4) { 0x0012ffff, 0, 0x00, 23 }, : Package (4) { 0x0012ffff, 1, 0x00, 23 }, : Package (4) { 0x0012ffff, 2, 0x00, 23 }, : Package (4) { 0x0012ffff, 3, 0x00, 23 } hardwired in APIC mode? -- To view, visit https://review.coreboot.org/18897 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a0cdafc19159fe6c38e4dde08ad0bf2bd0dd6b8 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017