coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: mainboard/winnet/g170: Initialize the IRQ routing
by Arthur Heymans (Code Review) 15 May '17

15 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18900 ) Change subject: mainboard/winnet/g170: Initialize the IRQ routing ...................................................................... Patch Set 5: Code-Review+1 On Intel hardware we often map everything to 11 but I guess this is fine too. -- To view, visit https://review.coreboot.org/18900 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c7a7d584a2c47471456ab54ef6da815a2dc4e7c Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: vexpress: change to write32
by Philippe Mathieu-Daudé (Code Review) 15 May '17

15 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19685 ) Change subject: vexpress: change to write32 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/19685 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fcc83328441ccfb34ee63a7406d26e393633c21 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/release: Update build-release script
by Philippe Mathieu-Daudé (Code Review) 15 May '17

15 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19126 ) Change subject: util/release: Update build-release script ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/19126 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa434a4911dec777004788e3cf4e3436875d929b Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/lenovo/t430: Add Thinkpad T430 support
by build bot (Jenkins) (Code Review) 14 May '17

14 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18011 ) Change subject: mainboard/lenovo/t430: Add Thinkpad T430 support ...................................................................... Patch Set 12: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9404/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53622/ : SUCCESS -- To view, visit https://review.coreboot.org/18011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5403cfb80a57753e873c570d95ca535cf5f45630 Gerrit-PatchSet: 12 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/lenovo/t430: Add Thinkpad T430 support
by Patrick Rudolph (Code Review) 14 May '17

14 May '17

Hello Arthur Heymans, Paul Menzel, Philipp Deppenwiese, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/18011 to look at the new patch set (#12). Change subject: mainboard/lenovo/t430: Add Thinkpad T430 support ...................................................................... mainboard/lenovo/t430: Add Thinkpad T430 support Tested and working: * HDD LED * Booting GNU Linux 4.9 from HDD using SeaBios * Booting GNU Linux 4.9 from USB using SeaBios * Native GFX init * All Fn function keys * Speakers * PCIe Wifi * Camera * WWAN * Fan (Dynamic Thermal Managment) * Flashing using internal programmer * Dual memory DIMMs running at up to DDR3-1866 * AC events * Touchpad, trackball and keyboard * USB3 ports running at SuperSpeed * Ethernet * Headphone jack * Speaker mute * Microphone mute * Volume keys * Fingerprint sensor * Lid switch * Thinklight * TPM (disable SeaBios CONFIG_TCGBIOS) * CMOS options: ** power_on_after_fail ** reboot_counter ** boot_option ** gfx_uma_size Untested: * Booting Windows * Hybrid graphics * Docking station * VGA Broken: * Wifi LED is always on Change-Id: I5403cfb80a57753e873c570d95ca535cf5f45630 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- A src/mainboard/lenovo/t430/Kconfig A src/mainboard/lenovo/t430/Kconfig.name A src/mainboard/lenovo/t430/Makefile.inc A src/mainboard/lenovo/t430/acpi/ec.asl A src/mainboard/lenovo/t430/acpi/platform.asl A src/mainboard/lenovo/t430/acpi/superio.asl A src/mainboard/lenovo/t430/acpi_tables.c A src/mainboard/lenovo/t430/board_info.txt A src/mainboard/lenovo/t430/cmos.default A src/mainboard/lenovo/t430/cmos.layout A src/mainboard/lenovo/t430/devicetree.cb A src/mainboard/lenovo/t430/dsdt.asl A src/mainboard/lenovo/t430/gpio.c A src/mainboard/lenovo/t430/hda_verb.c A src/mainboard/lenovo/t430/mainboard.c A src/mainboard/lenovo/t430/romstage.c A src/mainboard/lenovo/t430/smihandler.c A src/mainboard/lenovo/t430/thermal.h 18 files changed, 1,081 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/18011/12 -- To view, visit https://review.coreboot.org/18011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5403cfb80a57753e873c570d95ca535cf5f45630 Gerrit-PatchSet: 12 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/lenovo/t430: Add Thinkpad T430 support
by Patrick Rudolph (Code Review) 14 May '17

14 May '17

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/18011 ) Change subject: mainboard/lenovo/t430: Add Thinkpad T430 support ...................................................................... Patch Set 11: (3 comments) https://review.coreboot.org/#/c/18011/11/src/mainboard/lenovo/t430/romstage… File src/mainboard/lenovo/t430/romstage.c: PS11, Line 36: 0x10001fe0 > Did you check that these bits are not already set? How can you no PS11, Line 36: PCH_DISABLE_ALWAYS > The name already says that this doesn't belong into mainboard code, sigh. B I kept the reserved values only Line 39: /* FIXME: used T530 values here */ > Can't this be decoded easily with autoport? Autoport wasn't able to generate useful values, that's why t530 values are used -- To view, visit https://review.coreboot.org/18011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5403cfb80a57753e873c570d95ca535cf5f45630 Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: nb/intel/sandybridge: Hide additional nb devices
by Arthur Heymans (Code Review) 14 May '17

14 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19689 ) Change subject: nb/intel/sandybridge: Hide additional nb devices ...................................................................... Patch Set 1: Code-Review+2 my bad. ivy bridge only... -- To view, visit https://review.coreboot.org/19689 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64a19e2bbdb1640e1d732f6e4486f73cbb0bda81 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/sandybridge: Hide additional nb devices
by Arthur Heymans (Code Review) 14 May '17

14 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19689 ) Change subject: nb/intel/sandybridge: Hide additional nb devices ...................................................................... Patch Set 1: Code-Review+1 Those don't seem to be documented. maybe add a comment about this? -- To view, visit https://review.coreboot.org/19689 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64a19e2bbdb1640e1d732f6e4486f73cbb0bda81 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/lenovo/t430: Add Thinkpad T430 support
by build bot (Jenkins) (Code Review) 14 May '17

14 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18011 ) Change subject: mainboard/lenovo/t430: Add Thinkpad T430 support ...................................................................... Patch Set 11: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9403/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53621/ : SUCCESS -- To view, visit https://review.coreboot.org/18011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5403cfb80a57753e873c570d95ca535cf5f45630 Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/lenovo/t430: Add Thinkpad T430 support
by Patrick Rudolph (Code Review) 14 May '17

14 May '17

Hello Arthur Heymans, Paul Menzel, Philipp Deppenwiese, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/18011 to look at the new patch set (#11). Change subject: mainboard/lenovo/t430: Add Thinkpad T430 support ...................................................................... mainboard/lenovo/t430: Add Thinkpad T430 support Tested and working: * HDD LED * Booting GNU Linux 4.9 from HDD using SeaBios * Booting GNU Linux 4.9 from USB using SeaBios * Native GFX init * All Fn function keys * Speakers * PCIe Wifi * Camera * WWAN * Fan (Dynamic Thermal Managment) * Flashing using internal programmer * Dual memory DIMMs running at up to DDR3-1866 * AC events * Touchpad, trackball and keyboard * USB3 ports running at SuperSpeed * Ethernet * Headphone jack * Speaker mute * Microphone mute * Volume keys * Fingerprint sensor * Lid switch * Thinklight * TPM (disable SeaBios CONFIG_TCGBIOS) * CMOS options: ** power_on_after_fail ** reboot_counter ** boot_option ** gfx_uma_size Untested: * Booting Windows * Hybrid graphics * Docking station * VGA Broken: * Wifi LED is always on Change-Id: I5403cfb80a57753e873c570d95ca535cf5f45630 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- A src/mainboard/lenovo/t430/Kconfig A src/mainboard/lenovo/t430/Kconfig.name A src/mainboard/lenovo/t430/Makefile.inc A src/mainboard/lenovo/t430/acpi/ec.asl A src/mainboard/lenovo/t430/acpi/platform.asl A src/mainboard/lenovo/t430/acpi/superio.asl A src/mainboard/lenovo/t430/acpi_tables.c A src/mainboard/lenovo/t430/board_info.txt A src/mainboard/lenovo/t430/cmos.default A src/mainboard/lenovo/t430/cmos.layout A src/mainboard/lenovo/t430/devicetree.cb A src/mainboard/lenovo/t430/dsdt.asl A src/mainboard/lenovo/t430/gpio.c A src/mainboard/lenovo/t430/hda_verb.c A src/mainboard/lenovo/t430/mainboard.c A src/mainboard/lenovo/t430/romstage.c A src/mainboard/lenovo/t430/smihandler.c A src/mainboard/lenovo/t430/thermal.h 18 files changed, 1,080 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/18011/11 -- To view, visit https://review.coreboot.org/18011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5403cfb80a57753e873c570d95ca535cf5f45630 Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017