coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: vexpress: charge to write32
by Vladimir Serbinenko (Code Review) 14 May '17

14 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19685 to look at the new patch set (#2). Change subject: vexpress: charge to write32 ...................................................................... vexpress: charge to write32 Change-Id: I5fcc83328441ccfb34ee63a7406d26e393633c21 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- M src/mainboard/emulation/qemu-armv7/mainboard.c 1 file changed, 8 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/19685/2 -- To view, visit https://review.coreboot.org/19685 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5fcc83328441ccfb34ee63a7406d26e393633c21 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: vexpress: charge to write32
by build bot (Jenkins) (Code Review) 14 May '17

14 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19685 ) Change subject: vexpress: charge to write32 ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/53611/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/9395/ : SUCCESS -- To view, visit https://review.coreboot.org/19685 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fcc83328441ccfb34ee63a7406d26e393633c21 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: vexpress: charge to write32
by Vladimir Serbinenko (Code Review) 14 May '17

14 May '17

Vladimir Serbinenko has uploaded a new change for review. ( https://review.coreboot.org/19685 ) Change subject: vexpress: charge to write32 ...................................................................... vexpress: charge to write32 Change-Id: I5fcc83328441ccfb34ee63a7406d26e393633c21 --- M src/mainboard/emulation/qemu-armv7/mainboard.c 1 file changed, 8 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/19685/1 diff --git a/src/mainboard/emulation/qemu-armv7/mainboard.c b/src/mainboard/emulation/qemu-armv7/mainboard.c index c1fcc6a..39c2361 100644 --- a/src/mainboard/emulation/qemu-armv7/mainboard.c +++ b/src/mainboard/emulation/qemu-armv7/mainboard.c @@ -21,25 +21,26 @@ #include <halt.h> #include "mainboard.h" #include <edid.h> +#include <arch/io.h> static void init_gfx(void) { - volatile uint32_t *pl111; + uint32_t *pl111; struct edid edid; /* width is at most 4096 */ /* height is at most 1024 */ int width = 800, height = 600; uint32_t framebuffer = 0x4c000000; pl111 = (uint32_t *) 0x10020000; - pl111[0] = (width / 4) - 4; - pl111[1] = height - 1; + write32(pl111, (width / 4) - 4); + write32(pl111 + 1, height - 1); /* registers 2, 3 and 5 are ignored by qemu. Set them correctly if we ever go for real hw. */ /* framebuffer adress offset. Has to be in vram. */ - pl111[4] = framebuffer; - pl111[7] = 0; - pl111[10] = 0xff; - pl111[6] = (5 << 1) | 0x801; + write32(pl111 + 4, framebuffer); + write32(pl111 + 7, 0); + write32(pl111 + 10, 0xff); + write32(pl111 + 6, (5 << 1) | 0x801); edid.framebuffer_bits_per_pixel = 32; edid.bytes_per_line = width * 4; -- To view, visit https://review.coreboot.org/19685 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5fcc83328441ccfb34ee63a7406d26e393633c21 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com>

1 0

Change in coreboot[master]: vexpress: add gfx init
by Vladimir Serbinenko (Code Review) 14 May '17

14 May '17

Vladimir Serbinenko has submitted this change and it was merged. ( https://review.coreboot.org/13749 ) Change subject: vexpress: add gfx init ...................................................................... vexpress: add gfx init Change-Id: I0eff29b74d7df331dcbf2c25799eaae4911e54fc Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: https://review.coreboot.org/13749 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/emulation/qemu-armv7/Kconfig M src/mainboard/emulation/qemu-armv7/mainboard.c 2 files changed, 31 insertions(+), 0 deletions(-) Approvals: Arthur Heymans: Looks good to me, approved build bot (Jenkins): Verified Objections: Philippe Mathieu-Daudé: I would prefer that you didn't submit this diff --git a/src/mainboard/emulation/qemu-armv7/Kconfig b/src/mainboard/emulation/qemu-armv7/Kconfig index 76bdb32..1a65ffb 100644 --- a/src/mainboard/emulation/qemu-armv7/Kconfig +++ b/src/mainboard/emulation/qemu-armv7/Kconfig @@ -27,6 +27,8 @@ select DRIVERS_UART_PL011 select BOOTBLOCK_CONSOLE select CONSOLE_SERIAL + select MAINBOARD_HAS_NATIVE_VGA_INIT + select MAINBOARD_DO_NATIVE_VGA_INIT select ARCH_BOOTBLOCK_ARMV7 select ARCH_ROMSTAGE_ARMV7 select ARCH_RAMSTAGE_ARMV7 diff --git a/src/mainboard/emulation/qemu-armv7/mainboard.c b/src/mainboard/emulation/qemu-armv7/mainboard.c index eced9ae..c1fcc6a 100644 --- a/src/mainboard/emulation/qemu-armv7/mainboard.c +++ b/src/mainboard/emulation/qemu-armv7/mainboard.c @@ -20,6 +20,34 @@ #include <string.h> #include <halt.h> #include "mainboard.h" +#include <edid.h> + +static void init_gfx(void) +{ + volatile uint32_t *pl111; + struct edid edid; + /* width is at most 4096 */ + /* height is at most 1024 */ + int width = 800, height = 600; + uint32_t framebuffer = 0x4c000000; + pl111 = (uint32_t *) 0x10020000; + pl111[0] = (width / 4) - 4; + pl111[1] = height - 1; + /* registers 2, 3 and 5 are ignored by qemu. Set them correctly if + we ever go for real hw. */ + /* framebuffer adress offset. Has to be in vram. */ + pl111[4] = framebuffer; + pl111[7] = 0; + pl111[10] = 0xff; + pl111[6] = (5 << 1) | 0x801; + + edid.framebuffer_bits_per_pixel = 32; + edid.bytes_per_line = width * 4; + edid.x_resolution = width; + edid.y_resolution = height; + + set_vbe_mode_info_valid(&edid, framebuffer); +} static void mainboard_enable(device_t dev) { @@ -33,6 +61,7 @@ printk(BIOS_DEBUG, "%d MiB of RAM discovered\n", discovered); ram_resource(dev, 0, 0x60000000 >> 10, discovered << 10); cbmem_recovery(0); + init_gfx(); } struct chip_operations mainboard_ops = { -- To view, visit https://review.coreboot.org/13749 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eff29b74d7df331dcbf2c25799eaae4911e54fc Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/common: Add sanity check of PCR_BASE_ADDRESS
by build bot (Jenkins) (Code Review) 14 May '17

14 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19684 ) Change subject: soc/intel/common: Add sanity check of PCR_BASE_ADDRESS ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9394/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53610/ : SUCCESS -- To view, visit https://review.coreboot.org/19684 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I396aa1a3e89507c90e17229a986de5d2c0887c9c Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: Add sanity check of PCR_BASE_ADDRESS
by Lijian Zhao (Code Review) 14 May '17

14 May '17

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/19684 ) Change subject: soc/intel/common: Add sanity check of PCR_BASE_ADDRESS ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/19684/2/src/soc/intel/common/block/pcr/pcr.c File src/soc/intel/common/block/pcr/pcr.c: Line 21: #if (CONFIG_PCR_BASE_ADDRESS == 0) > If you want you could add the following first: Added. -- To view, visit https://review.coreboot.org/19684 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I396aa1a3e89507c90e17229a986de5d2c0887c9c Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/intel/common: Add sanity check of PCR_BASE_ADDRESS
by Lijian Zhao (Code Review) 14 May '17

14 May '17

Hello Aaron Durbin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19684 to look at the new patch set (#3). Change subject: soc/intel/common: Add sanity check of PCR_BASE_ADDRESS ...................................................................... soc/intel/common: Add sanity check of PCR_BASE_ADDRESS PCR_BASE_ADRESS may be zero if SOC Kconfig didn't define the non zero default value. TEST=Remove the PCR_BASE_ADDRESS config in Apollolake Kconfig file and build. BUG=None Change-Id: I396aa1a3e89507c90e17229a986de5d2c0887c9c Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/soc/intel/common/block/pcr/pcr.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/19684/3 -- To view, visit https://review.coreboot.org/19684 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I396aa1a3e89507c90e17229a986de5d2c0887c9c Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/lint: Give better warning for help spacing issue
by build bot (Jenkins) (Code Review) 14 May '17

14 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19155 ) Change subject: util/lint: Give better warning for help spacing issue ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9393/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53609/ : SUCCESS -- To view, visit https://review.coreboot.org/19155 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46375738a18903b266ea9fff3102a1a91235e609 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: .gitignore: ignore blobtool binary
by build bot (Jenkins) (Code Review) 14 May '17

14 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19296 ) Change subject: .gitignore: ignore blobtool binary ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9392/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53608/ : SUCCESS -- To view, visit https://review.coreboot.org/19296 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fa1548ba1906db80ce3119eec58de9629f91ed7 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: .gitignore: ignore blobtool binary
by Arthur Heymans (Code Review) 14 May '17

14 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19296 ) Change subject: .gitignore: ignore blobtool binary ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/19296 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fa1548ba1906db80ce3119eec58de9629f91ed7 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017