coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: mb/google/poppy: Update SPD data
by Naresh Solanki (Code Review) 15 May '17

15 May '17

Naresh Solanki has uploaded a new change for review. ( https://review.coreboot.org/19692 ) Change subject: mb/google/poppy: Update SPD data ...................................................................... mb/google/poppy: Update SPD data Though SPD is rightly rightly, it displays wrong part number during boot in Coreboot logs. So correct part number info in SPD. TEST= Build for Soraka & make sure part number is rightly printed. Change-Id: I67f676fb6ee9d685fa7aa41fdc4b00355e6d33c7 Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> --- M src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/19692/1 diff --git a/src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex b/src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex index 95716be..c81b4a5 100644 --- a/src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex +++ b/src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex @@ -6,7 +6,7 @@ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80 AD 01 00 00 00 00 00 00 00 00 -48 39 43 43 4E 4E 4E 43 50 54 41 4C 42 52 2D 4E +48 39 43 43 4E 4E 4E 42 4B 54 41 4C 42 52 2D 4E 54 44 00 00 80 AD 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -- To view, visit https://review.coreboot.org/19692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I67f676fb6ee9d685fa7aa41fdc4b00355e6d33c7 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com>

1 0

Change in coreboot[master]: rockchip/rk3399: Add MIPI driver
by Anonymous Coward (Code Review) 15 May '17

15 May '17

nickey.yang(a)rock-chips.com has posted comments on this change. ( https://review.coreboot.org/19477 ) Change subject: rockchip/rk3399: Add MIPI driver ...................................................................... Patch Set 7: > (2 comments) Julius datasheet https://drive.google.com/file/d/0B0DsVWbj2qyLQW5OMmdXSmZUWjg/view?usp=shari… -- To view, visit https://review.coreboot.org/19477 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02475eefb187c619c614b1cd20e97074bc8d917f Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: nickey.yang(a)rock-chips.com Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sean Paul <seanpaul(a)chromium.org> Gerrit-Reviewer: Shunqian Zheng <zhengsq(a)rock-chips.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nickey.yang(a)rock-chips.com Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block:[WIP] Add GPIO common code
by Furquan Shaikh (Code Review) 15 May '17

15 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/18917 ) Change subject: soc/intel/common/block:[WIP] Add GPIO common code ...................................................................... Patch Set 23: (29 comments) https://review.coreboot.org/#/c/18917/23/src/soc/intel/common/block/gpio/gp… File src/soc/intel/common/block/gpio/gpio.c: PS23, Line 35: gpio_get_community %s and use __func__ PS23, Line 39: int Shouldn't this be uint16_t? pcr_read32 expects offset as a uint16_t. Same with pcr_write32 below. Line 44: extra blank line PS23, Line 46: too many tabs? PS23, Line 50: return You don't need this. PS23, Line 58: - space around - PS23, Line 58: / space around / PS23, Line 64: reg_base + : (index * reg_size) You can save this in a variable reg_offset = reg_base + index * reg_size; That way you don't need to calculate it again. PS23, Line 66: return Why do you need an explicit return? PS23, Line 72: int index; There is a mix of two/three different ways for declaring variables in this file: <datatype><tab><variable_name> <datatype><tab><tab><variable_name> <datatype><space><variable_name> Can you please use a single consistent way? PS23, Line 74: - space around - PS23, Line 74: / space around / PS23, Line 77: extra space PS23, Line 79: extra space PS23, Line 79: extra space Line 81: } same comments as gpio_set_bit above. PS23, Line 87: = 0 There is no need to set this to 0. It is set before using in the for loop. PS23, Line 93: community_count nit: All other functions in this file seem to refer to this as num_communities. It might help to use the same name in this function as well. Line 121: for (i = 0; i < num_communities; i++) { shouldn't index be set to: index = comm->gpi_offset? PS23, Line 135: print_gpi_status Would it help if the print_gpi_status was moved in the loop above where sts->grp[index] &= smi_en; is done? Then you can avoid 2 loops in print_gpi_sts and just loop over bit set. PS23, Line 162: soc_gpio_configure_itss Might be better to name this something like: gpio_soc_configure_itss, so that it still starts with the same prefix "gpio" and has "soc" in the name to indicate the SoC has to implement this. PS23, Line 171: soc_gpio_get_pad_config_offset Same comment as above. PS23, Line 189: printk(BIOS_DEBUG, "gpio_padcfg [0x%02x, %d] DW0 [0x%08x : 0x%08x] " : "DW1 [0x%08x : 0x%08x]\n", : comm->port, : (cfg->pad - comm->first_pad), : pad_conf0,/* old value */ : cfg->pad_config0, /* new value */ : pad_conf1,/* old value */ : cfg->pad_config1); /* new value */ Should this be hidden behind a config so that it doesn't fill up the bios logs? PS23, Line 212: if space after if PS23, Line 215: if space after if PS23, Line 216: { this should go to the previous line. PS23, Line 232: /* Calculate Address of DW0 register for given GPIO : * pad - GPIO number : * returns - address of GPIO : */ this should be put before the function PS23, Line 245: /* Get the port id of given pad : * pad - GPIO number : * returns - given pad port id : */ same comment as above. PS23, Line 256: DN_20K Shouldn't this be accepted as an input? -- To view, visit https://review.coreboot.org/18917 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a1d56df46668bfb08206ca4a99202db5cd1da7c Gerrit-PatchSet: 23 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Dhaval Sharma <dhaval.v.sharma(a)intel.com> Gerrit-Reviewer: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Marc Herbert <marc.herbert(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: sowmya v <sowmyav235(a)gmail.com> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/google/soraka: Update Camera sensor for soraka
by build bot (Jenkins) (Code Review) 15 May '17

15 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19639 ) Change subject: mb/google/soraka: Update Camera sensor for soraka ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9412/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53633/ : SUCCESS -- To view, visit https://review.coreboot.org/19639 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd39a25da47e379cca3f8748250b3ce1ff61e50 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/soraka: Update Camera sensor for soraka
by Naresh Solanki (Code Review) 15 May '17

15 May '17

Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/19639 ) Change subject: mb/google/soraka: Update Camera sensor for soraka ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/19639/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/soraka/devicetree.cb: PS1, Line 393: 10 This need to be changed to 36. -- To view, visit https://review.coreboot.org/19639 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd39a25da47e379cca3f8748250b3ce1ff61e50 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/google/soraka: Update Camera sensor for soraka
by Naresh Solanki (Code Review) 15 May '17

15 May '17

Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/19639 ) Change subject: mb/google/soraka: Update Camera sensor for soraka ...................................................................... Patch Set 1: Will rebase this. Also UF camera I2C address will be updated. -- To view, visit https://review.coreboot.org/19639 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd39a25da47e379cca3f8748250b3ce1ff61e50 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy/variants/soraka: Enable H1 I2C TPM
by Naresh Solanki (Code Review) 15 May '17

15 May '17

Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/19519 ) Change subject: mainboard/google/poppy/variants/soraka: Enable H1 I2C TPM ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/19519 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9947dce9b7f755971f0199f043af8d251d275ab Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.corp-partner.google.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/soraka: Update Camera sensor for soraka
by Naresh Solanki (Code Review) 15 May '17

15 May '17

Naresh Solanki has uploaded a new change for review. ( https://review.coreboot.org/19639 ) Change subject: mb/google/soraka: Update Camera sensor for soraka ...................................................................... mb/google/soraka: Update Camera sensor for soraka Update camera sensor for soraka to OV 13858. Change-Id: I4dd39a25da47e379cca3f8748250b3ce1ff61e50 Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> --- M src/mainboard/google/poppy/variants/soraka/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/19639/1 diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb index 39739e8..d7fe0e8 100644 --- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb +++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb @@ -229,9 +229,9 @@ device i2c 4d on end end chip drivers/intel/mipi_camera - register "acpi_hid" = ""OVTID850"" + register "acpi_hid" = ""OVTID858"" register "acpi_name" = ""CAM0"" - register "chip_name" = ""OV 13850 Camera"" + register "chip_name" = ""OV 13858 Camera"" register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" # Camera SSDB buffer -- To view, visit https://review.coreboot.org/19639 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4dd39a25da47e379cca3f8748250b3ce1ff61e50 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>

1 0

Change in coreboot[master]: nb/intel/sandybridge: Use macros to determine min and max of...
by build bot (Jenkins) (Code Review) 15 May '17

15 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19691 ) Change subject: nb/intel/sandybridge: Use macros to determine min and max of timA ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9411/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53632/ : SUCCESS -- To view, visit https://review.coreboot.org/19691 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4387a4f4092053dab273191a73edb0ef31a79f6 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/sandybridge: Use macros to determine min and max of...
by Arthur Heymans (Code Review) 15 May '17

15 May '17

Arthur Heymans has uploaded a new change for review. ( https://review.coreboot.org/19691 ) Change subject: nb/intel/sandybridge: Use macros to determine min and max of timA ...................................................................... nb/intel/sandybridge: Use macros to determine min and max of timA This improves readability. Change-Id: Ib4387a4f4092053dab273191a73edb0ef31a79f6 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 12 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/19691/1 diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index e9d38c9..be0589d 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -1020,30 +1020,18 @@ shift = 0; FOR_ALL_LANES { - if (post_timA_min_high > - ((ctrl->timings[channel][slotrank].lanes[lane]. - timA + shift) >> 6)) - post_timA_min_high = - ((ctrl->timings[channel][slotrank]. - lanes[lane].timA + shift) >> 6); - if (pre_timA_min_high > - (ctrl->timings[channel][slotrank].lanes[lane]. - timA >> 6)) - pre_timA_min_high = - (ctrl->timings[channel][slotrank]. - lanes[lane].timA >> 6); - if (post_timA_max_high < - ((ctrl->timings[channel][slotrank].lanes[lane]. - timA + shift) >> 6)) - post_timA_max_high = - ((ctrl->timings[channel][slotrank]. - lanes[lane].timA + shift) >> 6); - if (pre_timA_max_high < - (ctrl->timings[channel][slotrank].lanes[lane]. - timA >> 6)) - pre_timA_max_high = - (ctrl->timings[channel][slotrank]. - lanes[lane].timA >> 6); + post_timA_min_high = MIN(post_timA_min_high, + (ctrl->timings[channel][slotrank].lanes[lane]. + timA + shift) >> 6); + pre_timA_min_high = MIN(pre_timA_min_high, + ctrl->timings[channel][slotrank].lanes[lane]. + timA >> 6); + post_timA_max_high = MAX(post_timA_max_high, + (ctrl->timings[channel][slotrank].lanes[lane]. + timA + shift) >> 6); + pre_timA_max_high = MAX(pre_timA_max_high, + ctrl->timings[channel][slotrank].lanes[lane]. + timA >> 6); } if (pre_timA_max_high - pre_timA_min_high < -- To view, visit https://review.coreboot.org/19691 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib4387a4f4092053dab273191a73edb0ef31a79f6 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017