Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19793 )
Change subject: soc/intel/apollolake: Use MCH_BASE_ADDRESS macro for APL
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19793/1/src/soc/intel/apollolake/chip.c
File src/soc/intel/apollolake/chip.c:
PS1, Line 277:
need to remove some space
--
To view, visit https://review.coreboot.org/19793
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iace1cf786b08221c3955101186509ac5161c3841
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-HasComments: Yes
Hello V Sowmya, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19668
to look at the new patch set (#3).
Change subject: soc/intel/common/block: Add Intel common systemagent support
......................................................................
soc/intel/common/block: Add Intel common systemagent support
Add Intel common systemagent support for romstage and ramstage.
Include soc specific macros need to compile stemagent common code.
Change-Id: I969ff187e3d4199864cb2e9c9a13f4d04158e27c
Signed-off-by: V Sowmya <v.sowmya(a)intel.com>
Signed-off-by: Subrata Banik <subrata.banik(a)intel.com>
---
M src/soc/intel/apollolake/include/soc/systemagent.h
M src/soc/intel/common/block/include/intelblocks/systemagent.h
M src/soc/intel/common/block/systemagent/Kconfig
M src/soc/intel/common/block/systemagent/Makefile.inc
M src/soc/intel/common/block/systemagent/systemagent.c
A src/soc/intel/common/block/systemagent/systemagent_early.c
M src/soc/intel/skylake/include/soc/systemagent.h
7 files changed, 688 insertions(+), 49 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/19668/3
--
To view, visit https://review.coreboot.org/19668
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I969ff187e3d4199864cb2e9c9a13f4d04158e27c
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>