coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: soc/mediatek/mt8173: Move spi driver to use spi_bus_map
by Julius Werner (Code Review) 20 May '17

20 May '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19770 ) Change subject: soc/mediatek/mt8173: Move spi driver to use spi_bus_map ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/19770/3/src/soc/mediatek/mt8173/spi.c File src/soc/mediatek/mt8173/spi.c: Line 305: .max_xfer_size = 65535, Actually all of the above don't matter anyway because it's a programmer-speicfic probe that will overwrite read/write/erase directly. Some of them (e.g. claim/release) are completely wrong and would do bad things if they ever actually got called. Maybe better to leave them NULL? -- To view, visit https://review.coreboot.org/19770 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0d6e4e8185ce1285b671af5ebcead1d42e049bc Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/rockchip: Move spi driver to use spi_bus_map
by Julius Werner (Code Review) 20 May '17

20 May '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19771 ) Change subject: soc/rockchip: Move spi driver to use spi_bus_map ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/19771 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66b1b9635ece2381f62f2a9d6f5744d639d59163 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: Consolidate reset API, add generic reset_prepare mechanism
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19789 ) Change subject: Consolidate reset API, add generic reset_prepare mechanism ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9810/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54073/ : SUCCESS -- To view, visit https://review.coreboot.org/19789 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41b89ce4a923102f0748922496e1dd9bce8a610f Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch: Unify basic cache clearing API
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19788 ) Change subject: arch: Unify basic cache clearing API ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9809/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54072/ : SUCCESS -- To view, visit https://review.coreboot.org/19788 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c1723a287f76cd4118ef38a445339840601aeea Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/intel/gma: Drop unused INTEL_DP
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19803 ) Change subject: drivers/intel/gma: Drop unused INTEL_DP ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9808/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54071/ : SUCCESS -- To view, visit https://review.coreboot.org/19803 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I786848cd48c6fcfecf9b72c60623cadcfcbb7db7 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/haswell: Fix up C NGI remnants
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19802 ) Change subject: nb/intel/haswell: Fix up C NGI remnants ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9807/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54070/ : SUCCESS -- To view, visit https://review.coreboot.org/19802 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cd5e99b9954a68837de85b49b4389b668e00cf4 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch: Unify basic cache clearing API
by Julius Werner (Code Review) 20 May '17

20 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19788 to look at the new patch set (#3). Change subject: arch: Unify basic cache clearing API ...................................................................... arch: Unify basic cache clearing API Caching is a very architecture-specific thing, but most architectures have a cache in general. Therefore it can be useful to have a generic architecture-independent API to perform simple cache management tasks from common code. We have already standardized on the dcache_clean/invalidate naming scheme that originally comes from ARM in libpayload, so let's just do the same for coreboot. Unlike libpayload, there are other things than just DMA coherency we may want to achieve with those functions, so actually implement them for real even on architectures with cache-snooping DMA like x86. (In the future, we may find applications like this in libpayload as well and should probably rethink the API there... maybe move the current functionality to a separate dma_map/unmap API instead. But that's beyond scope of this patch.) Change-Id: I2c1723a287f76cd4118ef38a445339840601aeea Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/arch/mips/include/arch/cache.h A src/arch/power8/include/arch/cache.h A src/arch/riscv/include/arch/cache.h M src/arch/x86/include/arch/cache.h 4 files changed, 107 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/19788/3 -- To view, visit https://review.coreboot.org/19788 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2c1723a287f76cd4118ef38a445339840601aeea Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Kconfig: Introduce HAVE_(VBE_)LINEAR_FRAMEBUFFER
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19800 ) Change subject: Kconfig: Introduce HAVE_(VBE_)LINEAR_FRAMEBUFFER ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9802/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54065/ : SUCCESS -- To view, visit https://review.coreboot.org/19800 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff6dac5a5f61af49456bc6312e7a376def02ab00 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/x86: Add function to determine if we're currently runni...
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19787 ) Change subject: arch/x86: Add function to determine if we're currently running from CAR ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9804/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54067/ : SUCCESS -- To view, visit https://review.coreboot.org/19787 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7ad0896a691ef6e89e622b985417fedc43579c1 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch: Unify basic cache clearing API
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19788 ) Change subject: arch: Unify basic cache clearing API ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9805/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54068/ : SUCCESS -- To view, visit https://review.coreboot.org/19788 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c1723a287f76cd4118ef38a445339840601aeea Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017