coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: soc/samsung/exynos5420: Move spi driver to use spi_bus_map
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19777 ) Change subject: soc/samsung/exynos5420: Move spi driver to use spi_bus_map ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9797/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54060/ : SUCCESS -- To view, visit https://review.coreboot.org/19777 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic937cbf93b87f5e43f7d70140b47fa97bcd7757e Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/marvell/bg4cd: Get rid of spi.c
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19775 ) Change subject: soc/marvell/bg4cd: Get rid of spi.c ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9795/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54058/ : SUCCESS -- To view, visit https://review.coreboot.org/19775 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53f0782fc8bd75ec569b74e4b199df5af481443d Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/broadcom/cygnus: Move spi driver to use spi_bus_map
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19773 ) Change subject: soc/broadcom/cygnus: Move spi driver to use spi_bus_map ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9793/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54056/ : SUCCESS -- To view, visit https://review.coreboot.org/19773 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b242dd6226e392ed0f403051843b3ae02cd9a4 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/marvell/armada38x: Move spi driver to use spi_bus_map
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19774 ) Change subject: soc/marvell/armada38x: Move spi driver to use spi_bus_map ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9794/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54057/ : SUCCESS -- To view, visit https://review.coreboot.org/19774 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I795ecd825d03a3a915222da5e920bfd581567d5f Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/nvidia/tegra*: Move spi driver to use spi_bus_map
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19769 ) Change subject: soc/nvidia/tegra*: Move spi driver to use spi_bus_map ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9789/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54053/ : SUCCESS -- To view, visit https://review.coreboot.org/19769 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I873b96d286655a814554bfd89f899ee87302b06d Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/mediatek/mt8173: Move spi driver to use spi_bus_map
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19770 ) Change subject: soc/mediatek/mt8173: Move spi driver to use spi_bus_map ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9790/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54052/ : SUCCESS -- To view, visit https://review.coreboot.org/19770 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0d6e4e8185ce1285b671af5ebcead1d42e049bc Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/rockchip: Move spi driver to use spi_bus_map
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19771 ) Change subject: soc/rockchip: Move spi driver to use spi_bus_map ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9791/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54054/ : SUCCESS -- To view, visit https://review.coreboot.org/19771 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66b1b9635ece2381f62f2a9d6f5744d639d59163 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/imgtec/pistachio: Move spi driver to use spi_bus_map
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19772 ) Change subject: soc/imgtec/pistachio: Move spi driver to use spi_bus_map ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9792/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54055/ : SUCCESS -- To view, visit https://review.coreboot.org/19772 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4ec74fccaf25900537ccd5c146bb0a333a2754c Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: Consolidate reset API, add generic reset_prepare mechanism
by Julius Werner (Code Review) 20 May '17

20 May '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19789 ) Change subject: Consolidate reset API, add generic reset_prepare mechanism ...................................................................... Patch Set 1: (4 comments) https://review.coreboot.org/#/c/19789/1/src/include/reset.h File src/include/reset.h: Line 7: __attribute__((noreturn)) void hard_reset(void); > The thing is hard_reset() on x86 actually is a cold reset which drops power Okay, I'll try to clarify the descriptions a little more. So the only difference between soft_reset and hard_reset is DRAM? Or is soft_reset a vague "some but not all board components will be reset"? Maybe we should come up with a platform-independent list of what should and shouldn't be reset for each level. For example, if we can say that all soft_resets should reset the TPM we could switch vboot to that and have a better chance of persisting RAM. (My Falco has little trouble persisting RAM across a hard_reset... I think dropping power even for a second or two often doesn't do much more that a slight bit of corruption.) The other question is of course why we even need so many resets in the first place. We seem to hardly use most of them, and where we do it's often not quite clear why a particular type is chosen. Maybe less would be better there? Line 23: GLOBAL_RESET, > Global's actually harder than hard. Oh... hmm... okay. I'd still like hard_reset() to be the general fallback because it's the most commonly implemented one right now (and the one that has a Kconfig to check for), but I can change the order here. https://review.coreboot.org/#/c/19789/1/src/lib/reset.c File src/lib/reset.c: Line 41: dcache_clean_all(); > I don't know how this works if caching is disabled on x86 systems. It might Do you mean disabled by CR0 or some more magical mechanism? For the former I'm pretty sure it just flushes the cache anyway with whatever was still in it... for example, my Intel manual says in in section 11.5.3 (Preventing Caching): > To disable the L1, L2, and L3 caches after they have been enabled and have received cache fills, perform the following steps: > 1. Enter the no-fill cache mode. (Set the CD flag in control register CR0 to 1 and the NW flag to 0. > 2. Flush all caches using the WBINVD instruction. > ... Line 47: printk(BIOS_INFO, "%s() called!\n", __func__); > We need these printks() everywhere? I just thought a general "I'm resetting now" print would be useful to have? Might make it easier to understand if your code intentionally reset or had some weird power glitch, watchdog, etc. event. -- To view, visit https://review.coreboot.org/19789 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41b89ce4a923102f0748922496e1dd9bce8a610f Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/nvidia/tegra*: Move spi driver to use spi_bus_map
by build bot (Jenkins) (Code Review) 20 May '17

20 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19769 ) Change subject: soc/nvidia/tegra*: Move spi driver to use spi_bus_map ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/54047/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/9784/ : SUCCESS -- To view, visit https://review.coreboot.org/19769 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I873b96d286655a814554bfd89f899ee87302b06d Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017