Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19143 )
Change subject: nb/x4x/raminit: Rewrite SPD decode and timing selection
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/#/c/19143/16/src/northbridge/intel/x4x/raminit.c
File src/northbridge/intel/x4x/raminit.c:
Line 256: i2c_block_read(device, 0, num_bytes, raw_spd);
> fallback to spd_read_byte if i2c_block_read returns a failure ?
thx, not sure if it properly returns failure but I'll definitly check it out.
--
To view, visit https://review.coreboot.org/19143
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I760eeaa3bd4f2bc25a517ddb1b9533c971454071
Gerrit-PatchSet: 16
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com>
Gerrit-HasComments: Yes