coreboot-gerrit March 2017

coreboot-gerrit@coreboot.org

1 participants
2925 discussions

Change in coreboot[master]: mainboard: Add Sapphire Pure Platinum H61
by Patrick Rudolph (Code Review) 26 Mar '17

26 Mar '17

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/18564 ) Change subject: mainboard: Add Sapphire Pure Platinum H61 ...................................................................... Patch Set 13: Code-Review+1 Please provide raminit logs for both failing and working case. Did you try the pending ivybridge raminit patches? They might increase raminit stability. -- To view, visit https://review.coreboot.org/18564 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aca2cfc4708c1728ae03ee4f6bc59d976c28a0 Gerrit-PatchSet: 13 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/pi/hudson: Add fanless SMU firmware
by build bot (Jenkins) (Code Review) 25 Mar '17

25 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18991 ) Change subject: amd/pi/hudson: Add fanless SMU firmware ...................................................................... Patch Set 2: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/50684/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/6669/ : SUCCESS -- To view, visit https://review.coreboot.org/18991 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b80ccf8fd9644f9a9d300e6c67aed9834a2c7a7 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/pi/hudson: Reduce amdfw space requirement
by build bot (Jenkins) (Code Review) 25 Mar '17

25 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18990 ) Change subject: amd/pi/hudson: Reduce amdfw space requirement ...................................................................... Patch Set 2: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/50683/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/6668/ : SUCCESS -- To view, visit https://review.coreboot.org/18990 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I139f3bfdb319af803fef64e7bd848e95945f41aa Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: northbridge/amd/stoney: Add FT4 package
by build bot (Jenkins) (Code Review) 25 Mar '17

25 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18989 ) Change subject: northbridge/amd/stoney: Add FT4 package ...................................................................... Patch Set 2: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/50682/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/6667/ : SUCCESS -- To view, visit https://review.coreboot.org/18989 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bb15bc4c85c5b4d3d5a6c926c4bc346a282ef27 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: HOLD 3rdparty/blobs: Update for AMD Stoney Ridge
by build bot (Jenkins) (Code Review) 25 Mar '17

25 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18988 ) Change subject: HOLD 3rdparty/blobs: Update for AMD Stoney Ridge ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/50681/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/6666/ : SUCCESS -- To view, visit https://review.coreboot.org/18988 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c9b5ded6b494fac1553cc2ec7756a7a47386ecf Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: HOLD 3rdparty/blobs: Update for AMD Stoney Ridge
by Marshall Dawson (Code Review) 25 Mar '17

25 Mar '17

Hello build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18988 to look at the new patch set (#2). Change subject: HOLD 3rdparty/blobs: Update for AMD Stoney Ridge ...................................................................... HOLD 3rdparty/blobs: Update for AMD Stoney Ridge Add the binaryPI file for the FT4 package and add SMU firmware to be consumed by fanless OPNs. Change-Id: I1c9b5ded6b494fac1553cc2ec7756a7a47386ecf Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/18988/2 -- To view, visit https://review.coreboot.org/18988 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1c9b5ded6b494fac1553cc2ec7756a7a47386ecf Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: HOLD 3rdparty/blobs: Update for AMD Stoney Ridge
by Martin Roth (Code Review) 25 Mar '17

25 Mar '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18988 ) Change subject: HOLD 3rdparty/blobs: Update for AMD Stoney Ridge ...................................................................... Patch Set 1: Is this trying to update the blobs tree after the new blobs are merged? I think that's confusing the builder because it can't actually pull them yet. -- To view, visit https://review.coreboot.org/18988 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c9b5ded6b494fac1553cc2ec7756a7a47386ecf Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/fsp_baytrail: transition away from device_t
by Martin Roth (Code Review) 25 Mar '17

25 Mar '17

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/17319 ) Change subject: soc/intel/fsp_baytrail: transition away from device_t ...................................................................... soc/intel/fsp_baytrail: transition away from device_t Replace the use of the old device_t definition inside soc/intel/fsp_baytrail. Change-Id: I2791346289c04049e6f032c8e120e4be9ba6657f Signed-off-by: Antonello Dettori <dev(a)dettori.io> Reviewed-on: https://review.coreboot.org/17319 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/soc/intel/fsp_baytrail/include/soc/acpi.h M src/soc/intel/fsp_baytrail/pmutil.c M src/soc/intel/fsp_baytrail/smihandler.c M src/soc/intel/fsp_baytrail/spi.c 4 files changed, 8 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/src/soc/intel/fsp_baytrail/include/soc/acpi.h b/src/soc/intel/fsp_baytrail/include/soc/acpi.h index 7dfec72..388ebc2 100644 --- a/src/soc/intel/fsp_baytrail/include/soc/acpi.h +++ b/src/soc/intel/fsp_baytrail/include/soc/acpi.h @@ -26,9 +26,12 @@ void acpi_fill_in_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt); unsigned long acpi_madt_irq_overrides(unsigned long current); void acpi_init_gnvs(global_nvs_t *gnvs); + +#ifndef __SIMPLE_DEVICE__ unsigned long southcluster_write_acpi_tables(device_t device, unsigned long current, struct acpi_rsdp *rsdp); void southcluster_inject_dsdt(device_t device); +#endif #endif /* _BAYTRAIL_ACPI_H_ */ diff --git a/src/soc/intel/fsp_baytrail/pmutil.c b/src/soc/intel/fsp_baytrail/pmutil.c index 3759174..a588412 100644 --- a/src/soc/intel/fsp_baytrail/pmutil.c +++ b/src/soc/intel/fsp_baytrail/pmutil.c @@ -24,9 +24,9 @@ #if defined(__SMM__) -static const device_t pcu_dev = PCI_DEV(0, PCU_DEV, 0); +static const pci_devfn_t pcu_dev = PCI_DEV(0, PCU_DEV, 0); -static inline device_t get_pcu_dev(void) +static inline pci_devfn_t get_pcu_dev(void) { return pcu_dev; } diff --git a/src/soc/intel/fsp_baytrail/smihandler.c b/src/soc/intel/fsp_baytrail/smihandler.c index 8b0c847..48c828b 100644 --- a/src/soc/intel/fsp_baytrail/smihandler.c +++ b/src/soc/intel/fsp_baytrail/smihandler.c @@ -67,7 +67,7 @@ for (slot = 0; slot < 0x20; slot++) { for (func = 0; func < 8; func++) { u32 reg32; - device_t dev = PCI_DEV(bus, slot, func); + pci_devfn_t dev = PCI_DEV(bus, slot, func); val = pci_read_config32(dev, PCI_VENDOR_ID); diff --git a/src/soc/intel/fsp_baytrail/spi.c b/src/soc/intel/fsp_baytrail/spi.c index dee7440..409e796 100644 --- a/src/soc/intel/fsp_baytrail/spi.c +++ b/src/soc/intel/fsp_baytrail/spi.c @@ -251,12 +251,13 @@ static ich9_spi_regs *spi_regs(void) { - device_t dev; uint32_t sbase; #ifdef __SMM__ + pci_devfn_t dev; dev = PCI_DEV(0, LPC_DEV, LPC_FUNC); #else + device_t dev; dev = dev_find_slot(0, PCI_DEVFN(LPC_DEV, LPC_FUNC)); #endif pci_read_config_dword(dev, SBASE, &sbase); -- To view, visit https://review.coreboot.org/17319 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2791346289c04049e6f032c8e120e4be9ba6657f Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Antonello Dettori <dev(a)dettori.io> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: mb/lenovo/s230u: Fix USBDEBUG check
by Martin Roth (Code Review) 25 Mar '17

25 Mar '17

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/18974 ) Change subject: mb/lenovo/s230u: Fix USBDEBUG check ...................................................................... mb/lenovo/s230u: Fix USBDEBUG check - Change preprocessor #if to standard C if. This will get optimized out if the config option is disabled, but lets the compiler check the contents. - CONFIG_USBDEBUG is always going to be defined even if it's disabled, so this check is not going to work as expected. See the coreboot Kconfig documentation in /Documentation/core/Kconfig.md Change-Id: Ia63438d9525e79307d9229ad3ffa2962978611d8 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/18974 Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Tested-by: build bot (Jenkins) --- M src/mainboard/lenovo/s230u/romstage.c 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Philippe Mathieu-Daudé: Looks good to me, but someone else must approve build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/src/mainboard/lenovo/s230u/romstage.c b/src/mainboard/lenovo/s230u/romstage.c index ce75165..ad5f021 100644 --- a/src/mainboard/lenovo/s230u/romstage.c +++ b/src/mainboard/lenovo/s230u/romstage.c @@ -51,10 +51,9 @@ CONFIG_EC_BASE_ADDRESS | 1); pci_write_config16(PCI_DEV(0, 0x1f, 0), 0xd8, 0xffc0); - #ifdef CONFIG_USBDEBUG /* Enable external USB port power. */ - ec_mm_set_bit(0x3b, 4); - #endif + if (IS_ENABLED(CONFIG_USBDEBUG)) + ec_mm_set_bit(0x3b, 4); } void rcba_config(void) -- To view, visit https://review.coreboot.org/18974 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia63438d9525e79307d9229ad3ffa2962978611d8 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: amd/pi/hudson: Add alternate method for including amdfw
by build bot (Jenkins) (Code Review) 25 Mar '17

25 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18435 ) Change subject: amd/pi/hudson: Add alternate method for including amdfw ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/6661/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/50677/ : SUCCESS -- To view, visit https://review.coreboot.org/18435 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38029bc03e5db260424cca293b1a7bceea4d0d75 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2017