coreboot-gerrit March 2017

coreboot-gerrit@coreboot.org

1 participants
2925 discussions

Change in coreboot[master]: elmex/pcm205400: Switch away from AGESA_LEGACY
by Martin Roth (Code Review) 27 Mar '17

27 Mar '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18711 ) Change subject: elmex/pcm205400: Switch away from AGESA_LEGACY ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/18711 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5181af1b8a779faa8821eb5cbac30542b5ff6ec7 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: asrock/e350m1: Switch away from AGESA_LEGACY
by Martin Roth (Code Review) 27 Mar '17

27 Mar '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18710 ) Change subject: asrock/e350m1: Switch away from AGESA_LEGACY ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/18710 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I335494b3339f2e5da7b1b0483b557a6eb211dfc1 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: pcengines/apu1: Switch away from AGESA_LEGACY
by Martin Roth (Code Review) 27 Mar '17

27 Mar '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18709 ) Change subject: pcengines/apu1: Switch away from AGESA_LEGACY ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/18709 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bc357b202e6fc769dd4964a4bb774897e9fd20b Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: gizmosphere/gizmo: Switch away from AGESA_LEGACY
by Martin Roth (Code Review) 27 Mar '17

27 Mar '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18708 ) Change subject: gizmosphere/gizmo: Switch away from AGESA_LEGACY ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/18708 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab25dfb4811a325e66757c3969db1766a29ecd7f Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: AGESA: Fork for new cache-as-ram init code
by Martin Roth (Code Review) 27 Mar '17

27 Mar '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18620 ) Change subject: AGESA: Fork for new cache-as-ram init code ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/18620 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I256b675b1ab9e13c2bcc956e0d67c6c03e91f2ed Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/torpedo: Switch away from AGESA_LEGACY
by Martin Roth (Code Review) 27 Mar '17

27 Mar '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18994 ) Change subject: amd/torpedo: Switch away from AGESA_LEGACY ...................................................................... Patch Set 2: Feel free to abandon this if you want to use your patch, or we can rebase that on top of this. Whatever you want. -- To view, visit https://review.coreboot.org/18994 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id074f3656801d412efb9485a6e2578beb9782259 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/torpedo: Switch away from AGESA_LEGACY
by Martin Roth (Code Review) 27 Mar '17

27 Mar '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18994 ) Change subject: amd/torpedo: Switch away from AGESA_LEGACY ...................................................................... Patch Set 2: Ok. If there's a reason to keep it, I'm fine with it. I'll try to get my torpedo up and running. -- To view, visit https://review.coreboot.org/18994 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id074f3656801d412efb9485a6e2578beb9782259 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: AGESA: Introduce AGESA_LEGACY and its counterpart
by Martin Roth (Code Review) 27 Mar '17

27 Mar '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18619 ) Change subject: AGESA: Introduce AGESA_LEGACY and its counterpart ...................................................................... Patch Set 4: Code-Review+2 (4 comments) https://review.coreboot.org/#/c/18619/4/src/cpu/amd/agesa/family12/romstage… File src/cpu/amd/agesa/family12/romstage.c: PS4, Line 16: #include <stdint.h> : #include <string.h> : #include <device/pci_def.h> : #include <device/pci_ids.h> : #include <arch/io.h> : #include <arch/stages.h> : #include <device/pnp_def.h> : #include <cpu/x86/lapic.h> : #include <console/console.h> : #include <commonlib/loglevel.h> : #include <cpu/amd/car.h> : #include <northbridge/amd/agesa/agesawrapper.h> : #include <northbridge/amd/agesa/agesa_helper.h> : #include <northbridge/amd/agesa/state_machine.h> : #include <cpu/x86/bist.h> : #include <superio/smsc/kbc1100/kbc1100.h> : #include <cpu/x86/lapic.h> : #include "sb_cimx.h" : #include "SbPlatform.h" : #include <arch/cpu.h> : #include "platform_cfg.h" > Cleanups for all boards are already in the queue, just squashed currently t So you clean up the includes in the cpu romstage.c files when you do the mainboards? I guess I missed that. https://review.coreboot.org/#/c/18619/4/src/cpu/amd/agesa/family14/romstage… File src/cpu/amd/agesa/family14/romstage.c: Line 104: > See commit adding AGESA_LEGACY_WRAPPER, pleanty of places in both platform Great. Thanks. https://review.coreboot.org/#/c/18619/4/src/northbridge/amd/agesa/state_mac… File src/northbridge/amd/agesa/state_machine.h: PS4, Line 16: _STATE_MACHINE_H_ > Reasoning is here https://review.coreboot.org/#/c/18628/6 Fair enough. PS4, Line 26: board_BeforeAgesa > Ańything we pull from agesa header files is camelcase as well. Bleh. -- To view, visit https://review.coreboot.org/18619 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id01931e185a023039a60af16a678de9966db8d65 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: AGESA: Fork for new cache-as-ram init code
by Martin Roth (Code Review) 27 Mar '17

27 Mar '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18620 ) Change subject: AGESA: Fork for new cache-as-ram init code ...................................................................... Patch Set 4: Makes sense to me. Does it get renamed back at the end? If so then I agree that there's no need to update the name in the comments. If not, it might be confusing. -- To view, visit https://review.coreboot.org/18620 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I256b675b1ab9e13c2bcc956e0d67c6c03e91f2ed Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: AGESA: Introduce AGESA_LEGACY and its counterpart
by Martin Roth (Code Review) 27 Mar '17

27 Mar '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18619 ) Change subject: AGESA: Introduce AGESA_LEGACY and its counterpart ...................................................................... Patch Set 4: (4 comments) https://review.coreboot.org/#/c/18619/4/src/cpu/amd/agesa/family12/romstage… File src/cpu/amd/agesa/family12/romstage.c: PS4, Line 16: #include <stdint.h> : #include <string.h> : #include <device/pci_def.h> : #include <device/pci_ids.h> : #include <arch/io.h> : #include <arch/stages.h> : #include <device/pnp_def.h> : #include <cpu/x86/lapic.h> : #include <console/console.h> : #include <commonlib/loglevel.h> : #include <cpu/amd/car.h> : #include <northbridge/amd/agesa/agesawrapper.h> : #include <northbridge/amd/agesa/agesa_helper.h> : #include <northbridge/amd/agesa/state_machine.h> : #include <cpu/x86/bist.h> : #include <superio/smsc/kbc1100/kbc1100.h> : #include <cpu/x86/lapic.h> : #include "sb_cimx.h" : #include "SbPlatform.h" : #include <arch/cpu.h> : #include "platform_cfg.h" These are the includes that are actually needed. I suspect the other platforms can be cleaned up similarly in a follow-on patch. #include <arch/stages.h> #include <cpu/amd/car.h> #include <cpu/x86/bist.h> #include <cpu/x86/lapic.h> #include <northbridge/amd/agesa/agesawrapper.h> #include <northbridge/amd/agesa/agesa_helper.h> #include <northbridge/amd/agesa/state_machine.h> #include "sb_cimx.h" #include "SbPlatform.h" https://review.coreboot.org/#/c/18619/4/src/cpu/amd/agesa/family14/romstage… File src/cpu/amd/agesa/family14/romstage.c: Line 104: It might be nice to add a couple of additional places that the mainboard can hook. Something like: board_after_agesa(cb); board_end_romstage(cb); https://review.coreboot.org/#/c/18619/4/src/northbridge/amd/agesa/state_mac… File src/northbridge/amd/agesa/state_machine.h: PS4, Line 16: _STATE_MACHINE_H_ I'm not crazy about the name - I think something more generic like agesa_sysinfo.h might be more appropriate. PS4, Line 26: board_BeforeAgesa why is this camelcase? board_before_agesa(); -- To view, visit https://review.coreboot.org/18619 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id01931e185a023039a60af16a678de9966db8d65 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2017