coreboot-gerrit March 2017

coreboot-gerrit@coreboot.org

1 participants
2925 discussions

Change in coreboot[master]: drivers/storage: Get SD/MMC driver to build
by Lee Leahy (Code Review) 27 Mar '17

27 Mar '17

Hello Andrey Petrov, Aaron Durbin, Bora Guvendik, build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19007 to look at the new patch set (#2). Change subject: drivers/storage: Get SD/MMC driver to build ...................................................................... drivers/storage: Get SD/MMC driver to build Add the Kconfig and Makefile and make necessary edits to get the code to build. TEST=Build for reef Change-Id: I0cce2d3001ab1b3d7bbbb37f07001eef50af1924 Signed-off-by: Lee Leahy <Leroy.P.Leahy(a)intel.com> --- A src/drivers/storage/Kconfig A src/drivers/storage/Makefile.inc M src/drivers/storage/mmc.c M src/drivers/storage/sdhci.c A src/drivers/storage/storage.h M src/include/device/mmc.h M src/include/device/sdhci.h 7 files changed, 206 insertions(+), 147 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/19007/2 -- To view, visit https://review.coreboot.org/19007 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0cce2d3001ab1b3d7bbbb37f07001eef50af1924 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: include/device: Move mmc.h and sdhci.h into include/device
by Lee Leahy (Code Review) 27 Mar '17

27 Mar '17

Hello Andrey Petrov, Aaron Durbin, Bora Guvendik, build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19006 to look at the new patch set (#2). Change subject: include/device: Move mmc.h and sdhci.h into include/device ...................................................................... include/device: Move mmc.h and sdhci.h into include/device Move include files from drivers/storage into include/device. TEST=None Change-Id: Ief907499420dfe0b217494d1a4981bb9b93bee91 Signed-off-by: Lee Leahy <Leroy.P.Leahy(a)intel.com> --- A src/drivers/storage/mmc.c A src/drivers/storage/sdhci.c A src/include/device/mmc.h A src/include/device/sdhci.h 4 files changed, 2,865 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/19006/2 -- To view, visit https://review.coreboot.org/19006 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ief907499420dfe0b217494d1a4981bb9b93bee91 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: intel/minnow3: Clean up Kconfig, devicetree and FMAP
by build bot (Jenkins) (Code Review) 27 Mar '17

27 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18963 ) Change subject: intel/minnow3: Clean up Kconfig, devicetree and FMAP ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50732/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6709/ : SUCCESS -- To view, visit https://review.coreboot.org/18963 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I620dcbcd622f9326917c74b2a38984d9e49cff2b Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/storage: Work around GCC data flow issue
by build bot (Jenkins) (Code Review) 27 Mar '17

27 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19005 ) Change subject: drivers/storage: Work around GCC data flow issue ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50731/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6708/ : SUCCESS -- To view, visit https://review.coreboot.org/19005 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46d7d87265b1011f719ebcb32f63443f2de8e266 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: [Not For Merge] nb/intel/i945: Remove unused #define REFRESH_*
by Arthur Heymans (Code Review) 27 Mar '17

27 Mar '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19016 ) Change subject: [Not For Merge] nb/intel/i945: Remove unused #define REFRESH_* ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/19016/1/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c: PS1, Line 848: if (refresh == 2) { : sysinfo->refresh = 1; > I wonder, if this ever hit the 15.6us case. Remind me, how many rows do we 15.6 is pretty standard on ddr2. (and is set as default before loop here) I think there are typically 13-14 rows -- To view, visit https://review.coreboot.org/19016 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70d5437face1a3ff4cacda4cb3f9a67d2ca4c403 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: drivers/storage: Add depthcharge SD/EMMC driver
by build bot (Jenkins) (Code Review) 27 Mar '17

27 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19004 ) Change subject: drivers/storage: Add depthcharge SD/EMMC driver ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50730/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6707/ : SUCCESS -- To view, visit https://review.coreboot.org/19004 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b3c2b7eabbb64d3760c0da154a5c434d48ee53 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/storage: Add depthcharge SD/EMMC driver
by Lee Leahy (Code Review) 27 Mar '17

27 Mar '17

Lee Leahy has posted comments on this change. ( https://review.coreboot.org/19004 ) Change subject: drivers/storage: Add depthcharge SD/EMMC driver ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/19004/1/src/drivers/storage/mmc.c File src/drivers/storage/mmc.c: PS1, Line 28: #include "drivers/s Deleting to pass the lint test. -- To view, visit https://review.coreboot.org/19004 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b3c2b7eabbb64d3760c0da154a5c434d48ee53 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: drivers/storage: Add depthcharge SD/EMMC driver
by Lee Leahy (Code Review) 27 Mar '17

27 Mar '17

Hello Andrey Petrov, Aaron Durbin, Bora Guvendik, build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19004 to look at the new patch set (#2). Change subject: drivers/storage: Add depthcharge SD/EMMC driver ...................................................................... drivers/storage: Add depthcharge SD/EMMC driver Copy the SD/MMC driver from depthcharge revision 59c7166a85d2f17085914fc9444c9444160c77f8 into coreboot. Removed #include "config.h" from mmc.c to allow the lint tests to pass. TEST=Does not build Change-Id: Ib2b3c2b7eabbb64d3760c0da154a5c434d48ee53 Signed-off-by: Lee Leahy <Leroy.P.Leahy(a)intel.com> --- A src/drivers/storage/mmc.c A src/drivers/storage/mmc.h A src/drivers/storage/sdhci.c A src/drivers/storage/sdhci.h 4 files changed, 2,863 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/19004/2 -- To view, visit https://review.coreboot.org/19004 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib2b3c2b7eabbb64d3760c0da154a5c434d48ee53 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: mainboard/lenovo/x60: Add TPM 1.2 mainboard support
by Martin Roth (Code Review) 27 Mar '17

27 Mar '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/13410 ) Change subject: mainboard/lenovo/x60: Add TPM 1.2 mainboard support ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/13410/1//COMMIT_MSG Commit Message: PS1, Line 10: Add TPM 1.2 mainboard support wrap please. -- To view, visit https://review.coreboot.org/13410 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e65b37507c111af1c0c56822327d5497f58f085 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Denis Carikli <GNUtoo(a)no-log.org> Gerrit-Reviewer: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mainboard/google/reef: turn off DMIC_CLK_B1 in S0ix
by build bot (Jenkins) (Code Review) 27 Mar '17

27 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19018 ) Change subject: mainboard/google/reef: turn off DMIC_CLK_B1 in S0ix ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50729/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6706/ : SUCCESS -- To view, visit https://review.coreboot.org/19018 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic46d4c7b30b945eba47a05d78386f48e4a675a03 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com> Gerrit-Reviewer: Venkateswarlu V Vinjamuri <venkateswarlu.v.vinjamuri(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2017