coreboot-gerrit March 2017

coreboot-gerrit@coreboot.org

1 participants
2925 discussions

Change in coreboot[master]: vboot: Compile bootmode.c conditionally based on CONFIG_VBOOT
by Julius Werner (Code Review) 27 Mar '17

27 Mar '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/18982 ) Change subject: vboot: Compile bootmode.c conditionally based on CONFIG_VBOOT ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/18982/2/src/vboot/vboot_common.h File src/vboot/vboot_common.h: Line 114: int vboot_recovery_mode_memory_retrain(void) { return 0; } > Why not make these static inline? Right, I should have. -- To view, visit https://review.coreboot.org/18982 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83e1b3e0f34f75c2395b4c464651e373724b2e6 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: chromeos / broadwell / jecht: Make save_chromeos_gpios() jec...
by Julius Werner (Code Review) 27 Mar '17

27 Mar '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/18981 ) Change subject: chromeos / broadwell / jecht: Make save_chromeos_gpios() jecht-specific ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/18981/2/src/soc/intel/broadwell/romstage/ro… File src/soc/intel/broadwell/romstage/romstage.c: Line 41: void __attribute__((weak)) save_chromeos_gpios(void) > I'd just nuke this from broadwell entirely and implement it in ject mainboa Okay, will do (but I don't have a Jecht to test this on). -- To view, visit https://review.coreboot.org/18981 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cf67a75a052d1c86eda0393b6a9fbbe255fedf8 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: vboot: Remove VBOOT_DYNAMIC_WORK_BUFFER Kconfig option
by Julius Werner (Code Review) 27 Mar '17

27 Mar '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/18979 ) Change subject: vboot: Remove VBOOT_DYNAMIC_WORK_BUFFER Kconfig option ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/18979/1/src/vboot/vboot_loader.c File src/vboot/vboot_loader.c: Line 153: if (ENV_ROMSTAGE && IS_ENABLED(CONFIG_VBOOT_STARTS_IN_ROMSTAGE)) { > If you are not going to support the following combination then you should m Right, my later patch does that. I first wrote all of this in one go and then overlooked this dependency when I separated it into individual patches. Are you okay with me just submitting these together, so I don't have to shuffle everything around again? -- To view, visit https://review.coreboot.org/18979 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f953c8d2a8dcb3f65b07f548184d6dd0eb688fe Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: vboot: Compile bootmode.c conditionally based on CONFIG_VBOOT
by Julius Werner (Code Review) 27 Mar '17

27 Mar '17

Hello Aaron Durbin, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18982 to look at the new patch set (#3). Change subject: vboot: Compile bootmode.c conditionally based on CONFIG_VBOOT ...................................................................... vboot: Compile bootmode.c conditionally based on CONFIG_VBOOT Currently, src/vboot/bootmode.c gets compiled even if vboot is disabled. It seems that this was only done to support calling certain developer/recovery mode functions in this case. There is no reason to compile the whole file for that -- we can just differentiate with a stub in the header instead, which is what other parts of coreboot usually do for cases like this. Change-Id: If83e1b3e0f34f75c2395b4c464651e373724b2e6 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/vboot/Makefile.inc M src/vboot/bootmode.c M src/vboot/vboot_common.h 3 files changed, 8 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/18982/3 -- To view, visit https://review.coreboot.org/18982 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If83e1b3e0f34f75c2395b4c464651e373724b2e6 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: vboot: Move remaining features out of vendorcode/google/chro...
by Julius Werner (Code Review) 27 Mar '17

27 Mar '17

Hello Aaron Durbin, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18984 to look at the new patch set (#3). Change subject: vboot: Move remaining features out of vendorcode/google/chromeos ...................................................................... vboot: Move remaining features out of vendorcode/google/chromeos This patch attempts to finish the separation between CONFIG_VBOOT and CONFIG_CHROMEOS by moving the remaining options and code (including image generation code for things like FWID and GBB flags, which are intrinsic to vboot itself) from src/vendorcode/google/chromeos to src/vboot. Also taking this opportunity to namespace all VBOOT Kconfig options, and clean up menuconfig visibility for them (i.e. some options were visible even though they were tied to the hardware while others were invisible even though it might make sense to change them). Some Chrome OS boards previously didn't have a hardcoded vboot configuration (e.g. STARTS_IN_BOOTBLOCK/_ROMSTAGE, SEPARATE_VERSTAGE, etc.) selected from their SoC and mainboard Kconfig files, and instead relied on the Chrome OS build system to pass in those options separately. Since there is usually only one "best" vboot configuration for a certain board and there is often board or SoC code specifically written with that configuration in mind (e.g. memlayout), these options should not be adjustable in menuconfig and instead always get selected by board and SoC Makefiles (as opposed to some external build system). CQ-DEPEND=CL:459088 Change-Id: I3e2e31150ebf5a96b6fe507ebeb53a41ecf88122 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/arch/x86/assembly_entry.S M src/arch/x86/bootblock_simple.c M src/arch/x86/car.ld M src/ec/google/chromeec/Kconfig M src/ec/google/chromeec/switches.c M src/include/memlayout.h M src/lib/Makefile.inc M src/mainboard/google/auron/Kconfig M src/mainboard/google/beltino/Kconfig M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/chell/Kconfig M src/mainboard/google/cosmos/Kconfig M src/mainboard/google/cyan/Kconfig M src/mainboard/google/daisy/Kconfig M src/mainboard/google/eve/Kconfig M src/mainboard/google/fizz/Kconfig M src/mainboard/google/foster/Kconfig M src/mainboard/google/gale/Kconfig M src/mainboard/google/glados/Kconfig M src/mainboard/google/gru/Kconfig M src/mainboard/google/jecht/Kconfig M src/mainboard/google/lars/Kconfig M src/mainboard/google/link/Kconfig M src/mainboard/google/nyan/Kconfig M src/mainboard/google/nyan_big/Kconfig M src/mainboard/google/nyan_blaze/Kconfig M src/mainboard/google/oak/Kconfig M src/mainboard/google/parrot/Kconfig M src/mainboard/google/peach_pit/Kconfig M src/mainboard/google/poppy/Kconfig M src/mainboard/google/purin/Kconfig M src/mainboard/google/rambi/Kconfig M src/mainboard/google/reef/Kconfig M src/mainboard/google/rotor/Kconfig M src/mainboard/google/slippy/Kconfig M src/mainboard/google/smaug/Kconfig M src/mainboard/google/storm/Kconfig M src/mainboard/google/stout/Kconfig M src/mainboard/google/veyron/Kconfig M src/mainboard/google/veyron_mickey/Kconfig M src/mainboard/google/veyron_rialto/Kconfig M src/mainboard/intel/baskingridge/Kconfig M src/mainboard/intel/emeraldlake2/Kconfig M src/mainboard/intel/galileo/Kconfig M src/mainboard/intel/kblrvp/Kconfig M src/mainboard/intel/kunimitsu/Kconfig M src/mainboard/intel/strago/Kconfig M src/mainboard/intel/wtm2/Kconfig M src/mainboard/samsung/lumpy/Kconfig M src/mainboard/samsung/stumpy/Kconfig M src/northbridge/intel/haswell/Kconfig M src/northbridge/intel/sandybridge/Kconfig M src/soc/broadcom/cygnus/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/baytrail/Kconfig M src/soc/intel/braswell/Kconfig M src/soc/intel/broadwell/Kconfig M src/soc/intel/quark/romstage/fsp1_1.c M src/soc/intel/skylake/Kconfig M src/soc/marvell/armada38x/Kconfig M src/soc/marvell/bg4cd/Kconfig M src/soc/marvell/mvmap2315/Kconfig M src/soc/mediatek/mt8173/Kconfig M src/soc/nvidia/tegra124/Kconfig M src/soc/nvidia/tegra210/Kconfig M src/soc/qualcomm/ipq40xx/Kconfig M src/soc/qualcomm/ipq806x/Kconfig M src/soc/rockchip/rk3288/Kconfig M src/soc/rockchip/rk3399/Kconfig M src/soc/samsung/exynos5250/Kconfig M src/soc/samsung/exynos5420/Kconfig M src/vboot/Kconfig M src/vboot/Makefile.inc M src/vboot/bootmode.c M src/vboot/vboot_handoff.c M src/vboot/vboot_loader.c M src/vboot/vboot_logic.c M src/vboot/verstage.c M src/vendorcode/google/chromeos/Kconfig M src/vendorcode/google/chromeos/Makefile.inc D src/vendorcode/google/chromeos/chromeos.c 81 files changed, 597 insertions(+), 574 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/18984/3 -- To view, visit https://review.coreboot.org/18984 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3e2e31150ebf5a96b6fe507ebeb53a41ecf88122 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: vboot: Disallow separate verstage after romstage, try to cla...
by Julius Werner (Code Review) 27 Mar '17

27 Mar '17

Hello Aaron Durbin, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18983 to look at the new patch set (#3). Change subject: vboot: Disallow separate verstage after romstage, try to clarify logic ...................................................................... vboot: Disallow separate verstage after romstage, try to clarify logic No board has ever tried to combine CONFIG_SEPARATE_VERSTAGE with CONFIG_VBOOT_STARTS_IN_ROMSTAGE. There are probably many reasons why this wouldn't work (e.g. x86 CAR migration logic currently always assumes verstage code to run pre-migration). It would also not really make sense: the reason we use separate verstages is to decrease bootblock size (mitigating the boot speed cost of slow boot ROM SPI drivers) and to allow the SRAM-saving RETURN_FROM_VERSTAGE trick, neither of which would apply to the after-romstage case. It is better to just forbid that case explicitly and give programmers more guarantees about what the verstage is (e.g. now the assumption that it runs pre-RAM is always valid). Since Kconfig dependencies aren't always guaranteed in the face of 'select' statements, also add some explicit compile-time assertions to the vboot code. We can simplify some of the loader logic which now no longer needs to provide for the forbidden case. In addition, also try to make some of the loader logic more readable by writing it in a more functional style that allows us to put more assertions about which cases should be unreachable in there, which will hopefully make it more robust and fail-fast with future changes (e.g. addition of new stages). Change-Id: Iaf60040af4eff711d9b80ee0e5950ce05958b3aa Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/include/memlayout.h M src/vboot/Kconfig M src/vboot/vboot_loader.c 3 files changed, 50 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/18983/3 -- To view, visit https://review.coreboot.org/18983 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iaf60040af4eff711d9b80ee0e5950ce05958b3aa Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: chromeos / broadwell / jecht: Make save_chromeos_gpios() jec...
by Julius Werner (Code Review) 27 Mar '17

27 Mar '17

Hello Aaron Durbin, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18981 to look at the new patch set (#3). Change subject: chromeos / broadwell / jecht: Make save_chromeos_gpios() jecht-specific ...................................................................... chromeos / broadwell / jecht: Make save_chromeos_gpios() jecht-specific This callback was only required for a single mainboard, and it can easily be moved to mainboard-specific code. This patch removes it from the global namespace and isolates it to the Jecht board. (This makes it easier to separate vboot and chromeos code in a later patch.) Change-Id: I9cf67a75a052d1c86eda0393b6a9fbbe255fedf8 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/jecht/chromeos.c M src/mainboard/google/jecht/onboard.h M src/mainboard/google/jecht/romstage.c M src/soc/intel/broadwell/romstage/romstage.c M src/vendorcode/google/chromeos/chromeos.c M src/vendorcode/google/chromeos/chromeos.h 6 files changed, 7 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/18981/3 -- To view, visit https://review.coreboot.org/18981 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9cf67a75a052d1c86eda0393b6a9fbbe255fedf8 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: abuild: Treat command line for recursive invocations as bash...
by Julius Werner (Code Review) 27 Mar '17

27 Mar '17

Hello Aaron Durbin, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18975 to look at the new patch set (#2). Change subject: abuild: Treat command line for recursive invocations as bash array ...................................................................... abuild: Treat command line for recursive invocations as bash array This fix changes the $cmdline variable that is used for recursive parallel abuild invocations through xargs from a string to a true bash array (like $@). This allows bash to properly preserve and pass on whitespace in parameters, like you get from invocations such as: util/abuild/abuild -c 32 -t "MY_FIRST_BOARD MY_SECOND_BOARD" Also add a mechanism to better spread CPUs across targets, since otherwise we can leave a lot of CPUs idle if we're trying to build only a few boards in parallel. Change-Id: I76a1c6456ef8ab21286fdc1636d659a3b76bc5d7 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M util/abuild/abuild 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/18975/2 -- To view, visit https://review.coreboot.org/18975 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I76a1c6456ef8ab21286fdc1636d659a3b76bc5d7 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: vboot: Assume EC_SOFTWARE_SYNC and VIRTUAL_DEV_SWITCH by def...
by Julius Werner (Code Review) 27 Mar '17

27 Mar '17

Hello Aaron Durbin, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18980 to look at the new patch set (#3). Change subject: vboot: Assume EC_SOFTWARE_SYNC and VIRTUAL_DEV_SWITCH by default ...................................................................... vboot: Assume EC_SOFTWARE_SYNC and VIRTUAL_DEV_SWITCH by default The virtualized developer switch was invented five years ago and has been used on every vboot system ever since. We shouldn't need to specify it again and again for every new board. This patch flips the Kconfig logic around and replaces CONFIG_VIRTUAL_DEV_SWITCH with CONFIG_PHYSICAL_DEV_SWITCH, so that only a few ancient boards need to set it and it fits better with CONFIG_PHYSICAL_REC_SWITCH. (Also set the latter for Lumpy which seems to have been omitted incorrectly, and hide it from menuconfig since it's a hardware parameter that shouldn't be configurable.) Since almost all our developer switches are virtual, it doesn't make sense for every board to pass a non-existent or non-functional developer mode switch in the coreboot tables, so let's get rid of that. It's also dangerously confusing for many boards to define a get_developer_mode() function that reads an actual pin (often from a debug header) which will not be honored by coreboot because CONFIG_PHYSICAL_DEV_SWITCH isn't set. Therefore, this patch removes all those non-functional instances of that function. In the future, either the board has a physical dev switch and must define it, or it doesn't and must not. In a similar sense (and since I'm touching so many board configs anyway), it's annoying that we have to keep selecting EC_SOFTWARE_SYNC. Instead, it should just be assumed by default whenever a Chrome EC is present in the system. This way, it can also still be overridden by menuconfig. CQ-DEPEND=CL:459701 Change-Id: If9cbaa7df530580a97f00ef238e3d9a8a86a4a7f Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/auron/Kconfig M src/mainboard/google/auron/chromeos.c M src/mainboard/google/beltino/Kconfig M src/mainboard/google/beltino/chromeos.c M src/mainboard/google/butterfly/chromeos.c M src/mainboard/google/chell/chromeos.c M src/mainboard/google/cosmos/chromeos.c M src/mainboard/google/cyan/Kconfig M src/mainboard/google/cyan/chromeos.c M src/mainboard/google/daisy/chromeos.c M src/mainboard/google/eve/chromeos.c M src/mainboard/google/fizz/chromeos.c M src/mainboard/google/foster/Kconfig M src/mainboard/google/foster/chromeos.c M src/mainboard/google/gale/Kconfig M src/mainboard/google/gale/chromeos.c M src/mainboard/google/glados/chromeos.c M src/mainboard/google/gru/Kconfig M src/mainboard/google/jecht/Kconfig M src/mainboard/google/jecht/chromeos.c M src/mainboard/google/lars/chromeos.c M src/mainboard/google/link/chromeos.c M src/mainboard/google/nyan/Kconfig M src/mainboard/google/nyan/chromeos.c M src/mainboard/google/nyan_big/Kconfig M src/mainboard/google/nyan_big/chromeos.c M src/mainboard/google/nyan_blaze/Kconfig M src/mainboard/google/nyan_blaze/chromeos.c M src/mainboard/google/oak/Kconfig M src/mainboard/google/oak/chromeos.c M src/mainboard/google/parrot/chromeos.c M src/mainboard/google/peach_pit/chromeos.c M src/mainboard/google/poppy/chromeos.c M src/mainboard/google/purin/chromeos.c M src/mainboard/google/rambi/Kconfig M src/mainboard/google/rambi/chromeos.c M src/mainboard/google/reef/chromeos.c M src/mainboard/google/rotor/chromeos.c M src/mainboard/google/slippy/Kconfig M src/mainboard/google/slippy/chromeos.c M src/mainboard/google/smaug/Kconfig M src/mainboard/google/smaug/chromeos.c M src/mainboard/google/storm/Kconfig M src/mainboard/google/storm/chromeos.c M src/mainboard/google/stout/chromeos.c M src/mainboard/google/urara/chromeos.c M src/mainboard/google/veyron/Kconfig M src/mainboard/google/veyron/chromeos.c M src/mainboard/google/veyron_mickey/Kconfig M src/mainboard/google/veyron_mickey/chromeos.c M src/mainboard/google/veyron_rialto/Kconfig M src/mainboard/google/veyron_rialto/chromeos.c M src/mainboard/intel/baskingridge/chromeos.c M src/mainboard/intel/emeraldlake2/chromeos.c M src/mainboard/intel/galileo/vboot.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kunimitsu/chromeos.c M src/mainboard/intel/strago/Kconfig M src/mainboard/intel/strago/chromeos.c M src/mainboard/intel/wtm2/chromeos.c M src/mainboard/samsung/lumpy/Kconfig M src/mainboard/samsung/stumpy/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/skylake/Kconfig M src/vboot/bootmode.c M src/vboot/vboot_logic.c M src/vendorcode/google/chromeos/Kconfig M src/vendorcode/google/chromeos/chromeos.c 68 files changed, 16 insertions(+), 287 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/18980/3 -- To view, visit https://review.coreboot.org/18980 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If9cbaa7df530580a97f00ef238e3d9a8a86a4a7f Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: abuild: Treat command line for recursive invocations as bash...
by Julius Werner (Code Review) 27 Mar '17

27 Mar '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/18975 ) Change subject: abuild: Treat command line for recursive invocations as bash array ...................................................................... Patch Set 1: Sorry, you are faster with your emails than my last minute checks before uploading. ;) -- To view, visit https://review.coreboot.org/18975 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76a1c6456ef8ab21286fdc1636d659a3b76bc5d7 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2017