coreboot-gerrit March 2017

coreboot-gerrit@coreboot.org

1 participants
2925 discussions

Change in coreboot[master]: abuild: Treat command line for recursive invocations as bash...
by Julius Werner (Code Review) 27 Mar '17

27 Mar '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/18975 ) Change subject: abuild: Treat command line for recursive invocations as bash array ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/18975/2//COMMIT_MSG Commit Message: Line 18: a few boards in parallel. > They had issues on the build servers where build the world took longer when Right. I'm still keeping the same CPU count constraint (minus rounding, but I can also make it round down if that's a huge concern... I don't think it should be). I'm just optimizing the case where you have way more CPUs than boards to build. Previously, if you had 32 CPUs and tried to build 5 boards it would build them all in parallel but with 1 CPU each. With my patch, they will each invoke make with div_round_up(32, 5) == 7 CPUs. In a case where you build more boards than you have CPUs (like "build the world"), my patch shouldn't change anything (32 xargs processes with 1 CPU each). https://review.coreboot.org/#/c/18975/2/util/abuild/abuild File util/abuild/abuild: PS2, Line 787: -c $cpus_per_target > Now you're changing the -c parameter to abuild? This is replacing the hardcoded '-c 1' from above (which is why that can no longer be part of $cmdline). I'm calculating the optimal amount of CPUs per board down here and then using that number (rounded up, so the minimum would still be '-c 1'). -- To view, visit https://review.coreboot.org/18975 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76a1c6456ef8ab21286fdc1636d659a3b76bc5d7 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: vboot: Disallow separate verstage after romstage, try to cla...
by build bot (Jenkins) (Code Review) 27 Mar '17

27 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18983 ) Change subject: vboot: Disallow separate verstage after romstage, try to clarify logic ...................................................................... Patch Set 4: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/50773/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/6750/ : SUCCESS -- To view, visit https://review.coreboot.org/18983 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf60040af4eff711d9b80ee0e5950ce05958b3aa Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: vboot: Assume EC_SOFTWARE_SYNC and VIRTUAL_DEV_SWITCH by def...
by build bot (Jenkins) (Code Review) 27 Mar '17

27 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18980 ) Change subject: vboot: Assume EC_SOFTWARE_SYNC and VIRTUAL_DEV_SWITCH by default ...................................................................... Patch Set 4: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/50771/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/6749/ : SUCCESS -- To view, visit https://review.coreboot.org/18980 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9cbaa7df530580a97f00ef238e3d9a8a86a4a7f Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: chromeos / broadwell / jecht: Make save_chromeos_gpios() jec...
by build bot (Jenkins) (Code Review) 27 Mar '17

27 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18981 ) Change subject: chromeos / broadwell / jecht: Make save_chromeos_gpios() jecht-specific ...................................................................... Patch Set 4: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/50770/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/6748/ : SUCCESS -- To view, visit https://review.coreboot.org/18981 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cf67a75a052d1c86eda0393b6a9fbbe255fedf8 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: vboot: Compile bootmode.c conditionally based on CONFIG_VBOOT
by build bot (Jenkins) (Code Review) 27 Mar '17

27 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18982 ) Change subject: vboot: Compile bootmode.c conditionally based on CONFIG_VBOOT ...................................................................... Patch Set 4: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/50772/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/6747/ : SUCCESS -- To view, visit https://review.coreboot.org/18982 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83e1b3e0f34f75c2395b4c464651e373724b2e6 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: vboot: Move remaining features out of vendorcode/google/chro...
by Julius Werner (Code Review) 27 Mar '17

27 Mar '17

Hello Aaron Durbin, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18984 to look at the new patch set (#4). Change subject: vboot: Move remaining features out of vendorcode/google/chromeos ...................................................................... vboot: Move remaining features out of vendorcode/google/chromeos This patch attempts to finish the separation between CONFIG_VBOOT and CONFIG_CHROMEOS by moving the remaining options and code (including image generation code for things like FWID and GBB flags, which are intrinsic to vboot itself) from src/vendorcode/google/chromeos to src/vboot. Also taking this opportunity to namespace all VBOOT Kconfig options, and clean up menuconfig visibility for them (i.e. some options were visible even though they were tied to the hardware while others were invisible even though it might make sense to change them). Some Chrome OS boards previously didn't have a hardcoded vboot configuration (e.g. STARTS_IN_BOOTBLOCK/_ROMSTAGE, SEPARATE_VERSTAGE, etc.) selected from their SoC and mainboard Kconfig files, and instead relied on the Chrome OS build system to pass in those options separately. Since there is usually only one "best" vboot configuration for a certain board and there is often board or SoC code specifically written with that configuration in mind (e.g. memlayout), these options should not be adjustable in menuconfig and instead always get selected by board and SoC Makefiles (as opposed to some external build system). CQ-DEPEND=CL:459088 Change-Id: I3e2e31150ebf5a96b6fe507ebeb53a41ecf88122 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/arch/x86/assembly_entry.S M src/arch/x86/bootblock_simple.c M src/arch/x86/car.ld M src/ec/google/chromeec/Kconfig M src/ec/google/chromeec/switches.c M src/include/memlayout.h M src/lib/Makefile.inc M src/mainboard/google/auron/Kconfig M src/mainboard/google/beltino/Kconfig M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/chell/Kconfig M src/mainboard/google/cosmos/Kconfig M src/mainboard/google/cyan/Kconfig M src/mainboard/google/daisy/Kconfig M src/mainboard/google/eve/Kconfig M src/mainboard/google/fizz/Kconfig M src/mainboard/google/foster/Kconfig M src/mainboard/google/gale/Kconfig M src/mainboard/google/glados/Kconfig M src/mainboard/google/gru/Kconfig M src/mainboard/google/jecht/Kconfig M src/mainboard/google/lars/Kconfig M src/mainboard/google/link/Kconfig M src/mainboard/google/nyan/Kconfig M src/mainboard/google/nyan_big/Kconfig M src/mainboard/google/nyan_blaze/Kconfig M src/mainboard/google/oak/Kconfig M src/mainboard/google/parrot/Kconfig M src/mainboard/google/peach_pit/Kconfig M src/mainboard/google/poppy/Kconfig M src/mainboard/google/purin/Kconfig M src/mainboard/google/rambi/Kconfig M src/mainboard/google/reef/Kconfig M src/mainboard/google/rotor/Kconfig M src/mainboard/google/slippy/Kconfig M src/mainboard/google/smaug/Kconfig M src/mainboard/google/storm/Kconfig M src/mainboard/google/stout/Kconfig M src/mainboard/google/veyron/Kconfig M src/mainboard/google/veyron_mickey/Kconfig M src/mainboard/google/veyron_rialto/Kconfig M src/mainboard/intel/baskingridge/Kconfig M src/mainboard/intel/emeraldlake2/Kconfig M src/mainboard/intel/galileo/Kconfig M src/mainboard/intel/kblrvp/Kconfig M src/mainboard/intel/kunimitsu/Kconfig M src/mainboard/intel/strago/Kconfig M src/mainboard/intel/wtm2/Kconfig M src/mainboard/samsung/lumpy/Kconfig M src/mainboard/samsung/stumpy/Kconfig M src/northbridge/intel/haswell/Kconfig M src/northbridge/intel/sandybridge/Kconfig M src/soc/broadcom/cygnus/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/baytrail/Kconfig M src/soc/intel/braswell/Kconfig M src/soc/intel/broadwell/Kconfig M src/soc/intel/quark/romstage/fsp1_1.c M src/soc/intel/skylake/Kconfig M src/soc/marvell/armada38x/Kconfig M src/soc/marvell/bg4cd/Kconfig M src/soc/marvell/mvmap2315/Kconfig M src/soc/mediatek/mt8173/Kconfig M src/soc/nvidia/tegra124/Kconfig M src/soc/nvidia/tegra210/Kconfig M src/soc/qualcomm/ipq40xx/Kconfig M src/soc/qualcomm/ipq806x/Kconfig M src/soc/rockchip/rk3288/Kconfig M src/soc/rockchip/rk3399/Kconfig M src/soc/samsung/exynos5250/Kconfig M src/soc/samsung/exynos5420/Kconfig M src/vboot/Kconfig M src/vboot/Makefile.inc M src/vboot/bootmode.c M src/vboot/vboot_handoff.c M src/vboot/vboot_loader.c M src/vboot/vboot_logic.c M src/vboot/verstage.c M src/vendorcode/google/chromeos/Kconfig M src/vendorcode/google/chromeos/Makefile.inc D src/vendorcode/google/chromeos/chromeos.c 81 files changed, 597 insertions(+), 574 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/18984/4 -- To view, visit https://review.coreboot.org/18984 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3e2e31150ebf5a96b6fe507ebeb53a41ecf88122 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: Remove libverstage as separate library and source file class
by Julius Werner (Code Review) 27 Mar '17

27 Mar '17

Hello Aaron Durbin, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18302 to look at the new patch set (#7). Change subject: Remove libverstage as separate library and source file class ...................................................................... Remove libverstage as separate library and source file class In builds without CONFIG_VBOOT_SEPARATE_VERSTAGE, verstage files are linked directly into the bootblock or the romstage. However, they're still compiled with a separate "libverstage" source file class, linked into an intermediate library and then linked into the final destination stage. There is no obvious benefit to doing it this way and it's unclear why it was chosen in the first place... there are, however, obvious disadvantages: it can result in code that is used by both libverstage and the host stage to occur twice in the output binary. It also means that libverstage files have their separate compiler flags that are not necessarily aligned with the host stage, which can lead to weird effects like <rules.h> macros not being set the way you would expect. In fact, VBOOT_STARTS_IN_ROMSTAGE configurations are currently broken on x86 because their libverstage code that gets compiled into the romstage sets ENV_VERSTAGE, but CAR migration code expects all ENV_VERSTAGE code to run pre-migration. This patch resolves these problems by removing the separate library. There is no more difference between the 'verstage' and 'libverstage' classes, and the source files added to them are just treated the same way a bootblock or romstage source files in configurations where the verstage is linked into either of these respective stages (allowing for the normal object code deduplication and causing those files to be compiled with the same flags as the host stage's files). Tested this whole series by booting a Kevin, an Elm (both with and without SEPARATE_VERSTAGE) and a Falco in normal and recovery mode. Change-Id: I6bb84a9bf1cd54f2e02ca1f665740a9c88d88df4 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M Makefile M Makefile.inc M src/arch/arm/Makefile.inc M src/arch/arm/armv4/Makefile.inc M src/arch/arm/armv7/Makefile.inc M src/arch/arm64/Makefile.inc M src/arch/arm64/armv8/Makefile.inc M src/arch/x86/Makefile.inc M src/drivers/i2c/ww_ring/Makefile.inc M src/lib/Makefile.inc M src/soc/qualcomm/ipq40xx/Makefile.inc M src/soc/qualcomm/ipq806x/Makefile.inc M src/soc/rockchip/rk3288/Makefile.inc M src/vboot/Makefile.inc M toolchain.inc 15 files changed, 36 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/18302/7 -- To view, visit https://review.coreboot.org/18302 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6bb84a9bf1cd54f2e02ca1f665740a9c88d88df4 Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: vboot: Assume EC_SOFTWARE_SYNC and VIRTUAL_DEV_SWITCH by def...
by Julius Werner (Code Review) 27 Mar '17

27 Mar '17

Hello Aaron Durbin, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18980 to look at the new patch set (#4). Change subject: vboot: Assume EC_SOFTWARE_SYNC and VIRTUAL_DEV_SWITCH by default ...................................................................... vboot: Assume EC_SOFTWARE_SYNC and VIRTUAL_DEV_SWITCH by default The virtualized developer switch was invented five years ago and has been used on every vboot system ever since. We shouldn't need to specify it again and again for every new board. This patch flips the Kconfig logic around and replaces CONFIG_VIRTUAL_DEV_SWITCH with CONFIG_PHYSICAL_DEV_SWITCH, so that only a few ancient boards need to set it and it fits better with CONFIG_PHYSICAL_REC_SWITCH. (Also set the latter for Lumpy which seems to have been omitted incorrectly, and hide it from menuconfig since it's a hardware parameter that shouldn't be configurable.) Since almost all our developer switches are virtual, it doesn't make sense for every board to pass a non-existent or non-functional developer mode switch in the coreboot tables, so let's get rid of that. It's also dangerously confusing for many boards to define a get_developer_mode() function that reads an actual pin (often from a debug header) which will not be honored by coreboot because CONFIG_PHYSICAL_DEV_SWITCH isn't set. Therefore, this patch removes all those non-functional instances of that function. In the future, either the board has a physical dev switch and must define it, or it doesn't and must not. In a similar sense (and since I'm touching so many board configs anyway), it's annoying that we have to keep selecting EC_SOFTWARE_SYNC. Instead, it should just be assumed by default whenever a Chrome EC is present in the system. This way, it can also still be overridden by menuconfig. CQ-DEPEND=CL:459701 Change-Id: If9cbaa7df530580a97f00ef238e3d9a8a86a4a7f Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/auron/Kconfig M src/mainboard/google/auron/chromeos.c M src/mainboard/google/beltino/Kconfig M src/mainboard/google/beltino/chromeos.c M src/mainboard/google/butterfly/chromeos.c M src/mainboard/google/chell/chromeos.c M src/mainboard/google/cosmos/chromeos.c M src/mainboard/google/cyan/Kconfig M src/mainboard/google/cyan/chromeos.c M src/mainboard/google/daisy/chromeos.c M src/mainboard/google/eve/chromeos.c M src/mainboard/google/fizz/chromeos.c M src/mainboard/google/foster/Kconfig M src/mainboard/google/foster/chromeos.c M src/mainboard/google/gale/Kconfig M src/mainboard/google/gale/chromeos.c M src/mainboard/google/glados/chromeos.c M src/mainboard/google/gru/Kconfig M src/mainboard/google/jecht/Kconfig M src/mainboard/google/jecht/chromeos.c M src/mainboard/google/lars/chromeos.c M src/mainboard/google/link/chromeos.c M src/mainboard/google/nyan/Kconfig M src/mainboard/google/nyan/chromeos.c M src/mainboard/google/nyan_big/Kconfig M src/mainboard/google/nyan_big/chromeos.c M src/mainboard/google/nyan_blaze/Kconfig M src/mainboard/google/nyan_blaze/chromeos.c M src/mainboard/google/oak/Kconfig M src/mainboard/google/oak/chromeos.c M src/mainboard/google/parrot/chromeos.c M src/mainboard/google/peach_pit/chromeos.c M src/mainboard/google/poppy/chromeos.c M src/mainboard/google/purin/chromeos.c M src/mainboard/google/rambi/Kconfig M src/mainboard/google/rambi/chromeos.c M src/mainboard/google/reef/chromeos.c M src/mainboard/google/rotor/chromeos.c M src/mainboard/google/slippy/Kconfig M src/mainboard/google/slippy/chromeos.c M src/mainboard/google/smaug/Kconfig M src/mainboard/google/smaug/chromeos.c M src/mainboard/google/storm/Kconfig M src/mainboard/google/storm/chromeos.c M src/mainboard/google/stout/chromeos.c M src/mainboard/google/urara/chromeos.c M src/mainboard/google/veyron/Kconfig M src/mainboard/google/veyron/chromeos.c M src/mainboard/google/veyron_mickey/Kconfig M src/mainboard/google/veyron_mickey/chromeos.c M src/mainboard/google/veyron_rialto/Kconfig M src/mainboard/google/veyron_rialto/chromeos.c M src/mainboard/intel/baskingridge/chromeos.c M src/mainboard/intel/emeraldlake2/chromeos.c M src/mainboard/intel/galileo/vboot.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kunimitsu/chromeos.c M src/mainboard/intel/strago/Kconfig M src/mainboard/intel/strago/chromeos.c M src/mainboard/intel/wtm2/chromeos.c M src/mainboard/samsung/lumpy/Kconfig M src/mainboard/samsung/stumpy/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/skylake/Kconfig M src/vboot/bootmode.c M src/vboot/vboot_handoff.c M src/vboot/vboot_logic.c M src/vendorcode/google/chromeos/Kconfig M src/vendorcode/google/chromeos/chromeos.c 69 files changed, 17 insertions(+), 288 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/18980/4 -- To view, visit https://review.coreboot.org/18980 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If9cbaa7df530580a97f00ef238e3d9a8a86a4a7f Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: Remove libverstage as separate library and source file class
by build bot (Jenkins) (Code Review) 27 Mar '17

27 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18302 ) Change subject: Remove libverstage as separate library and source file class ...................................................................... Patch Set 6: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/50769/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/6746/ : SUCCESS -- To view, visit https://review.coreboot.org/18302 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb84a9bf1cd54f2e02ca1f665740a9c88d88df4 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: vboot: Move remaining features out of vendorcode/google/chro...
by build bot (Jenkins) (Code Review) 27 Mar '17

27 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18984 ) Change subject: vboot: Move remaining features out of vendorcode/google/chromeos ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/50768/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/6744/ : SUCCESS -- To view, visit https://review.coreboot.org/18984 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e2e31150ebf5a96b6fe507ebeb53a41ecf88122 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2017