coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: google/gru: Adjust to incorrect strapping resistors on Kevin
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22891 ) Change subject: google/gru: Adjust to incorrect strapping resistors on Kevin ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19351/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64562/ : SUCCESS -- To view, visit https://review.coreboot.org/22891 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855 Gerrit-Change-Number: 22891 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 02:25:23 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Adjust to incorrect strapping resistors on Kevin
by Julius Werner (Code Review) 15 Dec '17

15 Dec '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/22891 ) Change subject: google/gru: Adjust to incorrect strapping resistors on Kevin ...................................................................... Patch Set 1: > Why not apply this change to all boards? The code 1 bucket is oversized at the moment. Because... that's... less correct? I mean, my Scarlet actually reads 42. And it doesn't matter anyway (until it does), but it seems like we should apply the tolerance we have equally on all sides, right? -- To view, visit https://review.coreboot.org/22891 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855 Gerrit-Change-Number: 22891 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 02:24:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Adjust to incorrect strapping resistors on Kevin
by Julius Werner (Code Review) 15 Dec '17

15 Dec '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/22891 ) Change subject: google/gru: Adjust to incorrect strapping resistors on Kevin ...................................................................... Patch Set 1: As usual I made all the numbers up and am relying on David to check the math. Since this doesn't actually seem to be the answer to b/70692504 I'll probably not going to rush this in before I'm gone next week, but I thought I might as well put it up anyway. -- To view, visit https://review.coreboot.org/22891 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855 Gerrit-Change-Number: 22891 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 02:23:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Adjust to incorrect strapping resistors on Kevin
by David Schneider (Code Review) 15 Dec '17

15 Dec '17

David Schneider has posted comments on this change. ( https://review.coreboot.org/22891 ) Change subject: google/gru: Adjust to incorrect strapping resistors on Kevin ...................................................................... Patch Set 1: Why not apply this change to all boards? The code 1 bucket is oversized at the moment. -- To view, visit https://review.coreboot.org/22891 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855 Gerrit-Change-Number: 22891 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 02:22:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Adjust to incorrect strapping resistors on Kevin
by Julius Werner (Code Review) 15 Dec '17

15 Dec '17

Hello Lin Huang, David Schneider, Philip Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/22891 to review the following change. Change subject: google/gru: Adjust to incorrect strapping resistors on Kevin ...................................................................... google/gru: Adjust to incorrect strapping resistors on Kevin It seems that RAM code 0 has been strapped with an incorrect resistor on Kevin. The resulting voltage divide still puts it well within the ADC value bucket reserved for that slot, but a little closer to the edge than necessary. While this doesn't seem to cause any immediate problems on its own, it still doesn't hurt to fix it (if only for the documentation value). On other boards (at least on my Scarlet) the strapping seems to be correct. Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/gru/boardid.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/22891/1 diff --git a/src/mainboard/google/gru/boardid.c b/src/mainboard/google/gru/boardid.c index 6d18648..22730a2 100644 --- a/src/mainboard/google/gru/boardid.c +++ b/src/mainboard/google/gru/boardid.c @@ -22,7 +22,11 @@ static const int id_readings[] = { /* ID : Volts : ADC value : Bucket */ /* == ===== ========= ========== */ +#if IS_ENABLED(CONFIG_BOARD_GOOGLE_KEVIN) +/* 0 : 0.109V: 62 : 0 - 81 */ 91, +#else /* 0 : 0.074V: 42 : 0 - 81 */ 81, +#endif /* 1 : 0.211V: 120 : 82 - 150 */ 150, /* 2 : 0.319V: 181 : 151 - 211 */ 211, /* 3 : 0.427V: 242 : 212 - 274 */ 274, -- To view, visit https://review.coreboot.org/22891 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855 Gerrit-Change-Number: 22891 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org>

1 0

Change in coreboot[master]: google/gru: Prettify strapping ID ADC table
by Julius Werner (Code Review) 15 Dec '17

15 Dec '17

Hello Lin Huang, David Schneider, Philip Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/22890 to review the following change. Change subject: google/gru: Prettify strapping ID ADC table ...................................................................... google/gru: Prettify strapping ID ADC table This patch shifts some comments around to make it easier to replace values in the ADC strapping bucket table with compile-time conditionals. Change-Id: Ic51917d3961a51d4e725ff824fb59aeefe149855 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/gru/boardid.c 1 file changed, 20 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/22890/1 diff --git a/src/mainboard/google/gru/boardid.c b/src/mainboard/google/gru/boardid.c index af56f1d..6d18648 100644 --- a/src/mainboard/google/gru/boardid.c +++ b/src/mainboard/google/gru/boardid.c @@ -19,29 +19,26 @@ #include <stdlib.h> #include <soc/saradc.h> -/* - * ID info: - * ID : Volts : ADC value : Bucket - * == ===== ========= =========== - * 0 : 0.074V: 42 : 0 - 81 - * 1 : 0.211V: 120 : 82 - 150 - * 2 : 0.319V: 181 : 151 - 211 - * 3 : 0.427V: 242 : 212 - 274 - * 4 : 0.542V: 307 : 275 - 342 - * 5 : 0.666V: 378 : 343 - 411 - * 6 : 0.781V: 444 : 412 - 477 - * 7 : 0.900V: 511 : 478 - 545 - * 8 : 1.023V: 581 : 546 - 613 - * 9 : 1.137V: 646 : 614 - 675 - * 10 : 1.240V: 704 : 676 - 733 - * 11 : 1.343V: 763 : 734 - 795 - * 12 : 1.457V: 828 : 796 - 861 - * 13 : 1.576V: 895 : 862 - 925 - * 14 : 1.684V: 956 : 926 - 989 - * 15 : 1.800V: 1023 : 990 - 1023 - */ -static const int id_readings[] = { 81, 150, 211, 274, 342, 411, 477, 545, - 613, 675, 733, 795, 861, 925, 989, 1023 }; +static const int id_readings[] = { +/* ID : Volts : ADC value : Bucket */ +/* == ===== ========= ========== */ +/* 0 : 0.074V: 42 : 0 - 81 */ 81, +/* 1 : 0.211V: 120 : 82 - 150 */ 150, +/* 2 : 0.319V: 181 : 151 - 211 */ 211, +/* 3 : 0.427V: 242 : 212 - 274 */ 274, +/* 4 : 0.542V: 307 : 275 - 342 */ 342, +/* 5 : 0.666V: 378 : 343 - 411 */ 411, +/* 6 : 0.781V: 444 : 412 - 477 */ 477, +/* 7 : 0.900V: 511 : 478 - 545 */ 545, +/* 8 : 1.023V: 581 : 546 - 613 */ 613, +/* 9 : 1.137V: 646 : 614 - 675 */ 675, +/* 10 : 1.240V: 704 : 676 - 733 */ 733, +/* 11 : 1.343V: 763 : 734 - 795 */ 795, +/* 12 : 1.457V: 828 : 796 - 861 */ 861, +/* 13 : 1.576V: 895 : 862 - 925 */ 925, +/* 14 : 1.684V: 956 : 926 - 989 */ 989, +/* 15 : 1.800V: 1023 : 990 - 1023 */ 1023 +}; _Static_assert(ARRAY_SIZE(id_readings) == 16, "Yo' messed up da table, bruh!"); static int cached_board_id = -1; static int cached_ram_id = -1; -- To view, visit https://review.coreboot.org/22890 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic51917d3961a51d4e725ff824fb59aeefe149855 Gerrit-Change-Number: 22890 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org>

1 0

Change in coreboot[master]: soc/amd: Move stoneyridge features out of agesawrapper
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22886 ) Change subject: soc/amd: Move stoneyridge features out of agesawrapper ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19345/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64556/ : SUCCESS -- To view, visit https://review.coreboot.org/22886 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I706edbb6a048b64389ba3077d5df0fe6155070b3 Gerrit-Change-Number: 22886 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 01:02:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Improve misc. formatting in AGESA wrapper
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22889 ) Change subject: soc/amd/common: Improve misc. formatting in AGESA wrapper ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19349/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64560/ : SUCCESS -- To view, visit https://review.coreboot.org/22889 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40985e0cf50df6aa4d830937e7f6b6e7908f72fe Gerrit-Change-Number: 22889 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 00:56:44 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Uncomment InitLate AmdReleaseStruct()
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22888 ) Change subject: soc/amd/common: Uncomment InitLate AmdReleaseStruct() ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19348/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64559/ : SUCCESS -- To view, visit https://review.coreboot.org/22888 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ff94ec2acdc845c5e4b4ed7088061cfc0c55f3 Gerrit-Change-Number: 22888 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 00:54:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Make AGESA wrapper build in any stage
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22885 ) Change subject: soc/amd/common: Make AGESA wrapper build in any stage ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19346/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64557/ : SUCCESS -- To view, visit https://review.coreboot.org/22885 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a35141f212f340c157d57fde8daf93c0c383af8 Gerrit-Change-Number: 22885 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 00:50:23 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017