coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: soc/intel/common: Add API to restore power failure into PMC common code
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22838 ) Change subject: soc/intel/common: Add API to restore power failure into PMC common code ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19360/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64572/ : SUCCESS -- To view, visit https://review.coreboot.org/22838 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ce2cc77745d00a8cfe3eed7c6372af77e063d02 Gerrit-Change-Number: 22838 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Fri, 15 Dec 2017 14:03:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/kunimitsu: Use spd_bin.h header file
by Elyes HAOUAS (Code Review) 15 Dec '17

15 Dec '17

Elyes HAOUAS has abandoned this change. ( https://review.coreboot.org/22877 ) Change subject: mb/intel/kunimitsu: Use spd_bin.h header file ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/22877 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I64280d6b4e5a697b411a4e0ef15bb17ad61137e8 Gerrit-Change-Number: 22877 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/snappy: add reset pin for Melfas touch controller
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22858 ) Change subject: mb/google/snappy: add reset pin for Melfas touch controller ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19359/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64571/ : SUCCESS -- To view, visit https://review.coreboot.org/22858 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0451ff0c3df97cb2474e30542a2f46ba67d82a Gerrit-Change-Number: 22858 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quantatw.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 04:30:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Adjust to incorrect strapping resistors on Kevin
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22891 ) Change subject: google/gru: Adjust to incorrect strapping resistors on Kevin ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19358/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64570/ : SUCCESS -- To view, visit https://review.coreboot.org/22891 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855 Gerrit-Change-Number: 22891 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 04:04:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Prettify strapping ID ADC table
by David Schneider (Code Review) 15 Dec '17

15 Dec '17

David Schneider has posted comments on this change. ( https://review.coreboot.org/22890 ) Change subject: google/gru: Prettify strapping ID ADC table ...................................................................... Patch Set 1: Code-Review+1 it's so pretty... -- To view, visit https://review.coreboot.org/22890 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic51917d3961a51d4e725ff824fb59aeefe149855 Gerrit-Change-Number: 22890 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 03:56:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Adjust to incorrect strapping resistors on Kevin
by David Schneider (Code Review) 15 Dec '17

15 Dec '17

David Schneider has posted comments on this change. ( https://review.coreboot.org/22891 ) Change subject: google/gru: Adjust to incorrect strapping resistors on Kevin ...................................................................... Patch Set 2: Code-Review+1 > Patch Set 1: > > (1 comment) > > > Every other bucket is ~60 wide, with 30 on each side...except for bucket 1, which has 30 on the high side and 40 on the low side. > > Yeah, but I still don't see the value in changing that. The buckets are skewed but that's the way they were designed. If I put a number in there that's not the arithmetic mean between the target points it's just going to confuse someone later. It's about documentation too... if I didn't split it up I'd still have to put a comment explaining that Kevin is special which takes up about the same amount of space. This is the easiest way to just represent that right in the code. Okay, this way is fine, then. -- To view, visit https://review.coreboot.org/22891 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855 Gerrit-Change-Number: 22891 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 03:54:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Adjust to incorrect strapping resistors on Kevin
by Julius Werner (Code Review) 15 Dec '17

15 Dec '17

Hello Lin Huang, David Schneider, Philip Chen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22891 to look at the new patch set (#2). Change subject: google/gru: Adjust to incorrect strapping resistors on Kevin ...................................................................... google/gru: Adjust to incorrect strapping resistors on Kevin It seems that RAM code 0 has been strapped with an incorrect resistor on Kevin. The resulting voltage divide still puts it well within the ADC value bucket reserved for that slot, but a little closer to the edge than necessary. While this doesn't seem to cause any immediate problems on its own, it still doesn't hurt to fix it (if only for the documentation value). On other boards (at least on my Scarlet) the strapping seems to be correct. Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/gru/boardid.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/22891/2 -- To view, visit https://review.coreboot.org/22891 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855 Gerrit-Change-Number: 22891 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: google/gru: Adjust to incorrect strapping resistors on Kevin
by Julius Werner (Code Review) 15 Dec '17

15 Dec '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/22891 ) Change subject: google/gru: Adjust to incorrect strapping resistors on Kevin ...................................................................... Patch Set 1: (1 comment) > Every other bucket is ~60 wide, with 30 on each side...except for bucket 1, which has 30 on the high side and 40 on the low side. Yeah, but I still don't see the value in changing that. The buckets are skewed but that's the way they were designed. If I put a number in there that's not the arithmetic mean between the target points it's just going to confuse someone later. It's about documentation too... if I didn't split it up I'd still have to put a comment explaining that Kevin is special which takes up about the same amount of space. This is the easiest way to just represent that right in the code. https://review.coreboot.org/#/c/22891/1/src/mainboard/google/gru/boardid.c File src/mainboard/google/gru/boardid.c: https://review.coreboot.org/#/c/22891/1/src/mainboard/google/gru/boardid.c@… PS1, Line 26: 81 > math looks right, but comment is wrong Thanks, fixed. -- To view, visit https://review.coreboot.org/22891 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855 Gerrit-Change-Number: 22891 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 03:43:42 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: google/gru: Adjust to incorrect strapping resistors on Kevin
by David Schneider (Code Review) 15 Dec '17

15 Dec '17

David Schneider has posted comments on this change. ( https://review.coreboot.org/22891 ) Change subject: google/gru: Adjust to incorrect strapping resistors on Kevin ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > > Why not apply this change to all boards? The code 1 bucket is oversized at the moment. > > Because... that's... less correct? I mean, my Scarlet actually reads 42. And it doesn't matter anyway (until it does), but it seems like we should apply the tolerance we have equally on all sides, right? Every other bucket is ~60 wide, with 30 on each side...except for bucket 1, which has 30 on the high side and 40 on the low side. So using the new value for everything makes the buckets more consistent. (And before you say that it makes bucket 0 relatively large, note that since we don't have 0.000V as a distinct bucket, bucket 0 is actually 1.5 buckets. Such a theoretical -1 bucket, if we had it, would result in an additional threshold of 31.) https://review.coreboot.org/#/c/22891/1/src/mainboard/google/gru/boardid.c File src/mainboard/google/gru/boardid.c: https://review.coreboot.org/#/c/22891/1/src/mainboard/google/gru/boardid.c@… PS1, Line 26: 81 math looks right, but comment is wrong -- To view, visit https://review.coreboot.org/22891 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855 Gerrit-Change-Number: 22891 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 02:30:14 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: google/gru: Prettify strapping ID ADC table
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22890 ) Change subject: google/gru: Prettify strapping ID ADC table ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19350/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64561/ : SUCCESS -- To view, visit https://review.coreboot.org/22890 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic51917d3961a51d4e725ff824fb59aeefe149855 Gerrit-Change-Number: 22890 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 02:26:37 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017