mail.coreboot.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2024
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
List overview
Download
coreboot-gerrit
December 2017
----- 2024 -----
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
coreboot-gerrit@coreboot.org
1 participants
1557 discussions
Start a n
N
ew thread
Change in coreboot[master]: soc/amd/common: Make agesa_heap_base non-static
by build bot (Jenkins) (Code Review)
15 Dec '17
15 Dec '17
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/22721
) Change subject: soc/amd/common: Make agesa_heap_base non-static ...................................................................... Patch Set 2: Verified+1 Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/19386/
: SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/64599/
: SUCCESS -- To view, visit
https://review.coreboot.org/22721
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic607432fd6500ef69b5d47793896cf12a699d8b7 Gerrit-Change-Number: 22721 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 20:11:52 +0000 Gerrit-HasComments: No
1
0
0
0
Change in coreboot[master]: amd/stoneyridge: Move SB index/data pairs to iomap.h
by build bot (Jenkins) (Code Review)
15 Dec '17
15 Dec '17
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/22723
) Change subject: amd/stoneyridge: Move SB index/data pairs to iomap.h ...................................................................... Patch Set 2: Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/19388/
: SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/64601/
: SUCCESS -- To view, visit
https://review.coreboot.org/22723
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a59adc974a8a90bfc586188b829a7252356b3cb Gerrit-Change-Number: 22723 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 20:09:04 +0000 Gerrit-HasComments: No
1
0
0
0
Change in coreboot[master]: amd/stoneyridge: Move acpi_get_sleep_type to sb_util
by build bot (Jenkins) (Code Review)
15 Dec '17
15 Dec '17
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/22722
) Change subject: amd/stoneyridge: Move acpi_get_sleep_type to sb_util ...................................................................... Patch Set 2: Verified+1 Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/19387/
: SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/64600/
: SUCCESS -- To view, visit
https://review.coreboot.org/22722
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7ba709bb867fb00ed6c7fa7526de087a3b9b3ca Gerrit-Change-Number: 22722 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 20:07:48 +0000 Gerrit-HasComments: No
1
0
0
0
Change in coreboot[master]: soc/amd/common: Define regions in AGESA cbmem
by build bot (Jenkins) (Code Review)
15 Dec '17
15 Dec '17
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/22720
) Change subject: soc/amd/common: Define regions in AGESA cbmem ...................................................................... Patch Set 2: Verified+1 Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/19385/
: SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/64598/
: SUCCESS -- To view, visit
https://review.coreboot.org/22720
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06c137f56516f3a04091d1191cd657a0aa07320b Gerrit-Change-Number: 22720 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 20:04:00 +0000 Gerrit-HasComments: No
1
0
0
0
Change in coreboot[master]: amd/stoneyridge: Define MTRR structures for S3 save
by build bot (Jenkins) (Code Review)
15 Dec '17
15 Dec '17
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/22719
) Change subject: amd/stoneyridge: Define MTRR structures for S3 save ...................................................................... Patch Set 2: Verified+1 Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/19384/
: SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/64597/
: SUCCESS -- To view, visit
https://review.coreboot.org/22719
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33a0be676d44baf53f57cc27244ea1faf06e3bdd Gerrit-Change-Number: 22719 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 20:01:48 +0000 Gerrit-HasComments: No
1
0
0
0
Change in coreboot[master]: amd/stoneyridge: Skip VGA initialization on S3 resume
by build bot (Jenkins) (Code Review)
15 Dec '17
15 Dec '17
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/22718
) Change subject: amd/stoneyridge: Skip VGA initialization on S3 resume ...................................................................... Patch Set 2: Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/19383/
: SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/64596/
: SUCCESS -- To view, visit
https://review.coreboot.org/22718
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I222cc7fcf5e58f451cee9621a1b876346226af09 Gerrit-Change-Number: 22718 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 20:00:49 +0000 Gerrit-HasComments: No
1
0
0
0
Change in coreboot[master]: NOT_FOR_MERGE soc/amd/common: Add S3 region to Kconfig
by build bot (Jenkins) (Code Review)
15 Dec '17
15 Dec '17
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/22717
) Change subject: NOT_FOR_MERGE soc/amd/common: Add S3 region to Kconfig ...................................................................... Patch Set 2: Verified+1 Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/19382/
: SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/64595/
: SUCCESS -- To view, visit
https://review.coreboot.org/22717
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cc8c6a9dbf0e76d41e94d535c6afd9b93f2eb32 Gerrit-Change-Number: 22717 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 20:00:12 +0000 Gerrit-HasComments: No
1
0
0
0
Change in libgfxinit[master]: [UNTESTED] gma: Allow arbitary framebuffer updates
by Nico Huber (Code Review)
15 Dec '17
15 Dec '17
Nico Huber has uploaded this change for review. (
https://review.coreboot.org/22905
Change subject: [UNTESTED] gma: Allow arbitary framebuffer updates ...................................................................... [UNTESTED] gma: Allow arbitary framebuffer updates Change-Id: I780bd0a2733222008f5243483656655f1eb2b58e --- M common/hw-gfx-gma-config_helpers.adb M common/hw-gfx-gma-config_helpers.ads M common/hw-gfx-gma-pipe_setup.adb M common/hw-gfx-gma-pipe_setup.ads M common/hw-gfx-gma.adb M gfxtest/hw-gfx-gma-gfx_test.adb 6 files changed, 81 insertions(+), 36 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/05/22905/1 diff --git a/common/hw-gfx-gma-config_helpers.adb b/common/hw-gfx-gma-config_helpers.adb index f2b4ef6..5e5be5d 100644 --- a/common/hw-gfx-gma-config_helpers.adb +++ b/common/hw-gfx-gma-config_helpers.adb @@ -181,9 +181,9 @@ -- Validates that a given configuration should work with -- a given framebuffer. function Validate_Config - (FB : Framebuffer_Type; - Port_Cfg : Port_Config; - Pipe : Pipe_Index) + (FB : Framebuffer_Type; + Mode : Mode_Type; + Pipe : Pipe_Index) return Boolean is begin @@ -197,11 +197,11 @@ -- Plane_Control) -- 90 degree rotations are only supported with Y-tiling return - ((Rotated_Width (FB) = Port_Cfg.Mode.H_Visible and - Rotated_Height (FB) = Port_Cfg.Mode.V_Visible) or + ((Rotated_Width (FB) = Mode.H_Visible and + Rotated_Height (FB) = Mode.V_Visible) or (Rotated_Width (FB) <= Config.Maximum_Scalable_Width (Pipe) and - Rotated_Width (FB) <= Port_Cfg.Mode.H_Visible and - Rotated_Height (FB) <= Port_Cfg.Mode.V_Visible)) and + Rotated_Width (FB) <= Mode.H_Visible and + Rotated_Height (FB) <= Mode.V_Visible)) and (FB.Offset /= VGA_PLANE_FRAMEBUFFER_OFFSET or Pipe = Primary) and (FB.Offset = VGA_PLANE_FRAMEBUFFER_OFFSET or (FB.BPC = 8 and Valid_Stride (FB) and diff --git a/common/hw-gfx-gma-config_helpers.ads b/common/hw-gfx-gma-config_helpers.ads index 1dc2390..4853634 100644 --- a/common/hw-gfx-gma-config_helpers.ads +++ b/common/hw-gfx-gma-config_helpers.ads @@ -40,15 +40,15 @@ use type HW.Pos32; pragma Warnings (GNAT, On, """Integer_32"" is already use-visible *"); function Validate_Config - (FB : Framebuffer_Type; - Port_Cfg : Port_Config; - Pipe : Pipe_Index) + (FB : Framebuffer_Type; + Mode : Mode_Type; + Pipe : Pipe_Index) return Boolean with Post => (if Validate_Config'Result then - Rotated_Width (FB) <= Port_Cfg.Mode.H_Visible and - Rotated_Height (FB) <= Port_Cfg.Mode.V_Visible and + Rotated_Width (FB) <= Mode.H_Visible and + Rotated_Height (FB) <= Mode.V_Visible and (FB.Offset = VGA_PLANE_FRAMEBUFFER_OFFSET or FB.Height + FB.Start_Y <= FB.V_Stride)); diff --git a/common/hw-gfx-gma-pipe_setup.adb b/common/hw-gfx-gma-pipe_setup.adb index e64edc9..7c919c2 100644 --- a/common/hw-gfx-gma-pipe_setup.adb +++ b/common/hw-gfx-gma-pipe_setup.adb @@ -206,7 +206,6 @@ Registers.Write (Controller.DSPSTRIDE, Word32 (Pixel_To_Bytes (FB.Stride, FB))); - Registers.Write (Controller.DSPSURF, FB.Offset and 16#ffff_f000#); if Config.Has_DSP_Linoff then Registers.Write (Controller.DSPLINOFF, 0); end if; @@ -214,6 +213,7 @@ (Register => Controller.DSPTILEOFF, Value => Shift_Left (Word32 (FB.Start_Y), 16) or Word32 (FB.Start_X)); + Registers.Write (Controller.DSPSURF, FB.Offset and 16#ffff_f000#); end if; end Setup_Hires_Plane; @@ -439,25 +439,34 @@ ---------------------------------------------------------------------------- + procedure Setup_Pipe + (Pipe : Pipe_Index; + Mode : Mode_Type; + Framebuffer : Framebuffer_Type) + is + -- Enable dithering if framebuffer BPC differs from port BPC, + -- as smooth gradients look really bad without. + Dither : constant Boolean := Framebuffer.BPC /= Mode.BPC; + begin + pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity)); + + Setup_Display (Controllers (Pipe), Framebuffer, Mode.BPC, Dither); + Setup_Scaling (Controllers (Pipe), Mode, Framebuffer); + end Setup_Pipe; + procedure On (Pipe : Pipe_Index; Port_Cfg : Port_Config; Framebuffer : Framebuffer_Type) is - -- Enable dithering if framebuffer BPC differs from port BPC, - -- as smooth gradients look really bad without. - Dither : constant Boolean := Framebuffer.BPC /= Port_Cfg.Mode.BPC; begin pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity)); Transcoder.Setup (Pipe, Port_Cfg); - Setup_Display - (Controllers (Pipe), Framebuffer, Port_Cfg.Mode.BPC, Dither); + Setup_Pipe (Pipe, Port_Cfg.Mode, Framebuffer); - Setup_Scaling (Controllers (Pipe), Port_Cfg.Mode, Framebuffer); - - Transcoder.On (Pipe, Port_Cfg, Dither); + Transcoder.On (Pipe, Port_Cfg, Framebuffer.BPC /= Port_Cfg.Mode.BPC); end On; ---------------------------------------------------------------------------- @@ -531,16 +540,5 @@ Transcoder.Clk_Off (Pipe); end loop; end All_Off; - - ---------------------------------------------------------------------------- - - procedure Update_Offset (Pipe : Pipe_Index; Framebuffer : Framebuffer_Type) - is - begin - pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity)); - - Registers.Write - (Controllers (Pipe).DSPSURF, Framebuffer.Offset and 16#ffff_f000#); - end Update_Offset; end HW.GFX.GMA.Pipe_Setup; diff --git a/common/hw-gfx-gma-pipe_setup.ads b/common/hw-gfx-gma-pipe_setup.ads index 3ef5dcf..11c716a 100644 --- a/common/hw-gfx-gma-pipe_setup.ads +++ b/common/hw-gfx-gma-pipe_setup.ads @@ -36,7 +36,16 @@ procedure All_Off; - procedure Update_Offset (Pipe : Pipe_Index; Framebuffer : Framebuffer_Type); + procedure Setup_Pipe + (Pipe : Pipe_Index; + Mode : Mode_Type; + Framebuffer : Framebuffer_Type) + with + Pre => + Rotated_Width (Framebuffer) <= Mode.H_Visible and + Rotated_Height (Framebuffer) <= Mode.V_Visible and + (Framebuffer.Offset = VGA_PLANE_FRAMEBUFFER_OFFSET or + Framebuffer.Height + Framebuffer.Start_Y <= Framebuffer.V_Stride); private diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index 420c1a3..798210a 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -109,7 +109,7 @@ if Success then Success := Config_Helpers.Validate_Config - (Pipe_Cfg.Framebuffer, Port_Cfg, Pipe); + (Pipe_Cfg.Framebuffer, Port_Cfg.Mode, Pipe); end if; if Success then @@ -284,9 +284,12 @@ -- update framebuffer offset only elsif New_Config.Port /= Disabled and - Cur_Config.Framebuffer /= New_Config.Framebuffer + Cur_Config.Framebuffer /= New_Config.Framebuffer and + Config_Helpers.Validate_Config + (New_Config.Framebuffer, New_Config.Mode, Pipe) then - Display_Controller.Update_Offset (Pipe, New_Config.Framebuffer); + Display_Controller.Setup_Pipe + (Pipe, New_Config.Mode, New_Config.Framebuffer); Cur_Config := New_Config; end if; end; diff --git a/gfxtest/hw-gfx-gma-gfx_test.adb b/gfxtest/hw-gfx-gma-gfx_test.adb index 833240f..c3caade 100644 --- a/gfxtest/hw-gfx-gma-gfx_test.adb +++ b/gfxtest/hw-gfx-gma-gfx_test.adb @@ -1,3 +1,4 @@ +with Ada.Numerics.Discrete_Random; with Ada.Unchecked_Conversion; with Ada.Command_Line; with Interfaces.C; @@ -13,6 +14,8 @@ package body HW.GFX.GMA.GFX_Test is pragma Disable_Atomic_Synchronization; + + package R is new Ada.Numerics.Discrete_Random (Pos_Type); Start_X : constant := 0; Start_Y : constant := 0; @@ -369,6 +372,38 @@ end if; end loop; + if Delay_S > 16 then -- getting bored? + declare + New_Pipes : GMA.Pipe_Configs := Pipes; + Gen : R.Generator; + begin + Time.M_Delay (12_000); + Delay_S := Delay_S - 12; + while Delay_S > 4 loop + Time.M_Delay (4_000); + Delay_S := Delay_S - 4; + for Pipe in GMA.Pipe_Index loop + New_Pipes (Pipe).Framebuffer.Start_X := + R.Random (Gen) mod Pipes (Pipe).Framebuffer.Width / 2; + New_Pipes (Pipe).Framebuffer.Start_Y := + R.Random (Gen) mod Pipes (Pipe).Framebuffer.Height / 2; + New_Pipes (Pipe).Framebuffer.Width := + Width_Type'Max (320, + Pipes (Pipe).Framebuffer.Width + - Pipes (Pipe).Framebuffer.Start_X + - R.Random (Gen) mod + Pipes (Pipe).Framebuffer.Width / 2); + New_Pipes (Pipe).Framebuffer.Height := + Height_Type'Max (200, + Pipes (Pipe).Framebuffer.Height + - Pipes (Pipe).Framebuffer.Start_Y + - R.Random (Gen) mod + Pipes (Pipe).Framebuffer.Height / 2); + end loop; + GMA.Update_Outputs (New_Pipes); + end loop; + end; + end if; Time.M_Delay (Delay_S * 1_000); for Pipe in GMA.Pipe_Index loop -- To view, visit
https://review.coreboot.org/22905
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I780bd0a2733222008f5243483656655f1eb2b58e Gerrit-Change-Number: 22905 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
1
0
0
0
Change in coreboot[master]: soc/amd/common: Make AGESA wrapper build in any stage
by build bot (Jenkins) (Code Review)
15 Dec '17
15 Dec '17
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/22885
) Change subject: soc/amd/common: Make AGESA wrapper build in any stage ...................................................................... Patch Set 2: Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/19376/
: SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/64589/
: SUCCESS -- To view, visit
https://review.coreboot.org/22885
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a35141f212f340c157d57fde8daf93c0c383af8 Gerrit-Change-Number: 22885 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 19:55:29 +0000 Gerrit-HasComments: No
1
0
0
0
Change in coreboot[master]: soc/amd/common: Improve misc. formatting in AGESA wrapper
by build bot (Jenkins) (Code Review)
15 Dec '17
15 Dec '17
build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/22889
) Change subject: soc/amd/common: Improve misc. formatting in AGESA wrapper ...................................................................... Patch Set 2: Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/19381/
: SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/64594/
: SUCCESS -- To view, visit
https://review.coreboot.org/22889
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40985e0cf50df6aa4d830937e7f6b6e7908f72fe Gerrit-Change-Number: 22889 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 19:54:45 +0000 Gerrit-HasComments: No
1
0
0
0
← Newer
1
...
63
64
65
66
67
68
69
...
156
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
Results per page:
10
25
50
100
200