coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: [wip]soc/intel/cannonlake: Correct PMC/GPIO routing information
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22908 ) Change subject: [wip]soc/intel/cannonlake: Correct PMC/GPIO routing information ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64630/ : SUCCESS -- To view, visit https://review.coreboot.org/22908 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1edb83edabc72e8a762b129cf51dcd936cd37ddf Gerrit-Change-Number: 22908 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 22:20:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [wip]soc/intel/cannonlake: Correct PMC/GPIO routing information
by Lijian Zhao (Code Review) 15 Dec '17

15 Dec '17

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/22908 ) Change subject: [wip]soc/intel/cannonlake: Correct PMC/GPIO routing information ...................................................................... Patch Set 2: I think the following changes may be added here as well 1. add pmc_gpio_gpe programming in bootblock 2. add pmc_gpp define into chip.h 3. increast bootblock size -- To view, visit https://review.coreboot.org/22908 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1edb83edabc72e8a762b129cf51dcd936cd37ddf Gerrit-Change-Number: 22908 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 22:17:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [wip]soc/intel/cannonlake: Correct PMC/GPIO routing information
by Caveh Jalali (Code Review) 15 Dec '17

15 Dec '17

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/22908 ) Change subject: [wip]soc/intel/cannonlake: Correct PMC/GPIO routing information ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22908 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1edb83edabc72e8a762b129cf51dcd936cd37ddf Gerrit-Change-Number: 22908 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 22:13:29 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [wip]soc/intel/cannonlake: Correct PMC/GPIO routing information
by Lijian Zhao (Code Review) 15 Dec '17

15 Dec '17

Hello Nick Vaccaro, Caveh Jalali, Bora Guvendik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22908 to look at the new patch set (#2). Change subject: [wip]soc/intel/cannonlake: Correct PMC/GPIO routing information ...................................................................... [wip]soc/intel/cannonlake: Correct PMC/GPIO routing information PMC and GPIO DWx definition is not identical, hence update that to correct information. For cannonlake lp PCH, GPIO group C, group E and group GPD is different for PMC GPIO_CFG and GPIO MISCCFG. TEST=Boot up into OS, and manually check PMC GPE status Change-Id: I1edb83edabc72e8a762b129cf51dcd936cd37ddf Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/soc/intel/cannonlake/gpio.c M src/soc/intel/cannonlake/include/soc/pmc.h 2 files changed, 20 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/22908/2 -- To view, visit https://review.coreboot.org/22908 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1edb83edabc72e8a762b129cf51dcd936cd37ddf Gerrit-Change-Number: 22908 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/cannonlake: provide LPDDR4 memory init
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22204 ) Change subject: soc/intel/cannonlake: provide LPDDR4 memory init ...................................................................... Patch Set 20: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19415/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64628/ : SUCCESS -- To view, visit https://review.coreboot.org/22204 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a43ea121e663b866eaca3930eca61f30bb52834 Gerrit-Change-Number: 22204 Gerrit-PatchSet: 20 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Anonymous Coward #1001775 Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Maximilian Schander <coreboot(a)mimoja.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 21:55:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/zoombini: Provide memory configuration variant API
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22205 ) Change subject: mainboard/google/zoombini: Provide memory configuration variant API ...................................................................... Patch Set 21: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19414/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64627/ : SUCCESS -- To view, visit https://review.coreboot.org/22205 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I449ab56dfc7a75752944b58ba6291b5ee32f81ad Gerrit-Change-Number: 22205 Gerrit-PatchSet: 21 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Anonymous Coward #1001775 Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 21:44:44 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/zoombini/variants/meowth: add new board
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22401 ) Change subject: mainboard/google/zoombini/variants/meowth: add new board ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19416/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64629/ : SUCCESS -- To view, visit https://review.coreboot.org/22401 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6ed7ebb4a00a87fc93fc694d74c08a716380a54 Gerrit-Change-Number: 22401 Gerrit-PatchSet: 7 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 21:36:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/soc/intel/cannonlake: Add gpio groups
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22572 ) Change subject: src/soc/intel/cannonlake: Add gpio groups ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19412/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64625/ : SUCCESS -- To view, visit https://review.coreboot.org/22572 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00be5e9bf25f1723a3d9e177588135d63ab89662 Gerrit-Change-Number: 22572 Gerrit-PatchSet: 6 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 21:28:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Correct PMC/GPIO routing information
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22908 ) Change subject: soc/intel/cannonlake: Correct PMC/GPIO routing information ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19413/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64626/ : SUCCESS -- To view, visit https://review.coreboot.org/22908 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1edb83edabc72e8a762b129cf51dcd936cd37ddf Gerrit-Change-Number: 22908 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 21:23:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add GPIO community 3 definition
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22482 ) Change subject: soc/intel/cannonlake: Add GPIO community 3 definition ...................................................................... Patch Set 11: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19410/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64624/ : SUCCESS -- To view, visit https://review.coreboot.org/22482 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73b7803c73446660f5c25b1263e47bb50a955c56 Gerrit-Change-Number: 22482 Gerrit-PatchSet: 11 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 21:21:04 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017