coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: soc/intel/common: Fix logic escape in heci code
by Lijian Zhao (Code Review) 16 Dec '17

16 Dec '17

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/22910 Change subject: soc/intel/common: Fix logic escape in heci code ...................................................................... soc/intel/common: Fix logic escape in heci code If heci get timed out, there's no need to read back reply message to decide the heci recive is successful or not. BUG=b:707290799 TEST=Boot up method board without battery, and confirm hard reset got trigged after heci time out Change-Id: I7c1655284d7027294d8ff5d6a5dbbebe4cbd0c47 Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/soc/intel/cannonlake/reset.c M src/soc/intel/common/block/cse/cse.c 2 files changed, 5 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/22910/1 diff --git a/src/soc/intel/cannonlake/reset.c b/src/soc/intel/cannonlake/reset.c index 03f9cb8..60b6bd3 100644 --- a/src/soc/intel/cannonlake/reset.c +++ b/src/soc/intel/cannonlake/reset.c @@ -67,14 +67,7 @@ reply_size = sizeof(reply); memset(&reply, 0, reply_size); - heci_receive(&reply, &reply_size); - /* get reply result from HECI MSG */ - if (reply.result != 0) { - printk(BIOS_DEBUG, "%s: Exit with Failure\n", __func__); - return -1; - } - printk(BIOS_DEBUG, "%s: Exit with Success\n", __func__); - return 0; + return heci_receive(&reply, &reply_size); } void do_global_reset(void) diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index 370074e..e3c1d71 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -438,6 +438,10 @@ */ do { received = recv_one_message(&hdr, p, left); + if (received == 0) { + printk(BIOS_ERR, "HECI: Failed t\n"); + return 1; + } left -= received; p += received; /* If we read out everything ping to send more */ -- To view, visit https://review.coreboot.org/22910 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7c1655284d7027294d8ff5d6a5dbbebe4cbd0c47 Gerrit-Change-Number: 22910 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com>

1 0

Change in coreboot[master]: soc/amd: Move stoneyridge features out of agesawrapper
by build bot (Jenkins) (Code Review) 16 Dec '17

16 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22886 ) Change subject: soc/amd: Move stoneyridge features out of agesawrapper ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19438/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64653/ : SUCCESS -- To view, visit https://review.coreboot.org/22886 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I706edbb6a048b64389ba3077d5df0fe6155070b3 Gerrit-Change-Number: 22886 Gerrit-PatchSet: 4 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 16 Dec 2017 00:48:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Uncomment InitLate AmdReleaseStruct()
by build bot (Jenkins) (Code Review) 16 Dec '17

16 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22888 ) Change subject: soc/amd/common: Uncomment InitLate AmdReleaseStruct() ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19437/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64652/ : SUCCESS -- To view, visit https://review.coreboot.org/22888 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ff94ec2acdc845c5e4b4ed7088061cfc0c55f3 Gerrit-Change-Number: 22888 Gerrit-PatchSet: 4 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 16 Dec 2017 00:45:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: spi/tpm: Clear pending irqs during tpm2_init
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22909 ) Change subject: spi/tpm: Clear pending irqs during tpm2_init ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19429/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64644/ : SUCCESS -- To view, visit https://review.coreboot.org/22909 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie099da9f2b3c4da417648ae10a5ba356b7a093ff Gerrit-Change-Number: 22909 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 23:43:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Uncomment InitLate AmdReleaseStruct()
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22888 ) Change subject: soc/amd/common: Uncomment InitLate AmdReleaseStruct() ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19427/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64642/ : SUCCESS -- To view, visit https://review.coreboot.org/22888 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ff94ec2acdc845c5e4b4ed7088061cfc0c55f3 Gerrit-Change-Number: 22888 Gerrit-PatchSet: 3 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 23:43:47 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Improve misc. formatting in AGESA wrapper
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22889 ) Change subject: soc/amd/common: Improve misc. formatting in AGESA wrapper ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19428/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64643/ : SUCCESS -- To view, visit https://review.coreboot.org/22889 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40985e0cf50df6aa4d830937e7f6b6e7908f72fe Gerrit-Change-Number: 22889 Gerrit-PatchSet: 3 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 23:36:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: spi/tpm: Clear pending irqs during tpm2_init
by Shelley Chen (Code Review) 15 Dec '17

15 Dec '17

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/22909 Change subject: spi/tpm: Clear pending irqs during tpm2_init ...................................................................... spi/tpm: Clear pending irqs during tpm2_init Seeing some instances were cr50 spi driver is starting a new transaction without getting a ready interrupt from cr50, which means that there are pending interrupts. Clearing these to be sure there are not any stale irqs for the next transaction. BUG=b:69567837 BRANCH=None TEST=run FAFT and see if any 0x2b recovery boots occur Change-Id: Ie099da9f2b3c4da417648ae10a5ba356b7a093ff Signed-off-by: Shelley Chen <shchen(a)chromium.org> --- M src/drivers/spi/tpm/tpm.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/22909/1 diff --git a/src/drivers/spi/tpm/tpm.c b/src/drivers/spi/tpm/tpm.c index e1fec28..ceec0b0 100644 --- a/src/drivers/spi/tpm/tpm.c +++ b/src/drivers/spi/tpm/tpm.c @@ -429,6 +429,9 @@ memcpy(spi_slave, spi_if, sizeof(*spi_if)); + /* clear any pending irqs */ + tis_plat_irq_status(); + /* * 150 ms should be enough to synchronize with the TPM even under the * worst nested reset request conditions. In vast majority of cases -- To view, visit https://review.coreboot.org/22909 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie099da9f2b3c4da417648ae10a5ba356b7a093ff Gerrit-Change-Number: 22909 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com>

1 0

Change in coreboot[master]: soc/amd: Move stoneyridge features out of agesawrapper
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22886 ) Change subject: soc/amd: Move stoneyridge features out of agesawrapper ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19425/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64640/ : SUCCESS -- To view, visit https://review.coreboot.org/22886 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I706edbb6a048b64389ba3077d5df0fe6155070b3 Gerrit-Change-Number: 22886 Gerrit-PatchSet: 3 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 23:31:16 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Factor out InitPost printed results to function
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22887 ) Change subject: soc/amd/common: Factor out InitPost printed results to function ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19426/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64641/ : SUCCESS -- To view, visit https://review.coreboot.org/22887 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d288e76e7510528659436e61fdfa1d5db01f06c Gerrit-Change-Number: 22887 Gerrit-PatchSet: 3 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 23:29:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/zoombini: Provide memory configuration variant API
by build bot (Jenkins) (Code Review) 15 Dec '17

15 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22205 ) Change subject: mainboard/google/zoombini: Provide memory configuration variant API ...................................................................... Patch Set 23: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19422/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64637/ : SUCCESS -- To view, visit https://review.coreboot.org/22205 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I449ab56dfc7a75752944b58ba6291b5ee32f81ad Gerrit-Change-Number: 22205 Gerrit-PatchSet: 23 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Anonymous Coward #1001775 Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 15 Dec 2017 23:24:12 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017