coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: soc/intel: Treat time-out as failure in HECI
by build bot (Jenkins) (Code Review) 18 Dec '17

18 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22910 ) Change subject: soc/intel: Treat time-out as failure in HECI ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19532/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64753/ : SUCCESS -- To view, visit https://review.coreboot.org/22910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c1655284d7027294d8ff5d6a5dbbebe4cbd0c47 Gerrit-Change-Number: 22910 Gerrit-PatchSet: 5 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Dec 2017 19:10:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/common: Implement InitLate AmdReleaseStruct()
by build bot (Jenkins) (Code Review) 18 Dec '17

18 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22888 ) Change subject: soc/amd/common: Implement InitLate AmdReleaseStruct() ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19531/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64752/ : SUCCESS -- To view, visit https://review.coreboot.org/22888 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ff94ec2acdc845c5e4b4ed7088061cfc0c55f3 Gerrit-Change-Number: 22888 Gerrit-PatchSet: 6 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Dec 2017 18:59:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: opencellular/rotundu: Introduce variants for OC
by build bot (Jenkins) (Code Review) 18 Dec '17

18 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22924 ) Change subject: opencellular/rotundu: Introduce variants for OC ...................................................................... Patch Set 6: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/64751/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/19530/ : SUCCESS -- To view, visit https://review.coreboot.org/22924 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id20e9d4ed7ac071d25a69eee63c9ec544d2ad152 Gerrit-Change-Number: 22924 Gerrit-PatchSet: 6 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Dec 2017 18:52:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/common: Uncomment InitLate AmdReleaseStruct()
by build bot (Jenkins) (Code Review) 18 Dec '17

18 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22888 ) Change subject: soc/amd/common: Uncomment InitLate AmdReleaseStruct() ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19529/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64750/ : SUCCESS -- To view, visit https://review.coreboot.org/22888 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ff94ec2acdc845c5e4b4ed7088061cfc0c55f3 Gerrit-Change-Number: 22888 Gerrit-PatchSet: 5 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Dec 2017 18:08:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/common/block/pci: Fix validation of pointer
by build bot (Jenkins) (Code Review) 18 Dec '17

18 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22934 ) Change subject: soc/amd/common/block/pci: Fix validation of pointer ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19527/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64748/ : SUCCESS -- To view, visit https://review.coreboot.org/22934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ee9a362600dbd6325254d7431172501181b52b0 Gerrit-Change-Number: 22934 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Dec 2017 17:24:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: opencellular/rotundu: Fix EMMC support
by build bot (Jenkins) (Code Review) 18 Dec '17

18 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22924 ) Change subject: opencellular/rotundu: Fix EMMC support ...................................................................... Patch Set 5: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/64749/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/19528/ : SUCCESS -- To view, visit https://review.coreboot.org/22924 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id20e9d4ed7ac071d25a69eee63c9ec544d2ad152 Gerrit-Change-Number: 22924 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Dec 2017 17:19:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/common/block/pci: Fix validation of pointer
by Richard Spiegel (Code Review) 18 Dec '17

18 Dec '17

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/22934 Change subject: soc/amd/common/block/pci: Fix validation of pointer ...................................................................... soc/amd/common/block/pci: Fix validation of pointer Procedure write_pci_int_table() does not validates intr_data_ptr. It must be validated together with picr_data_ptr and idx_name. BUG=b:69868534 TEST=Build fake kahlee with intr_data_ptr not initialized, boot and see error message. Than build correct kahlee and verify that error message is gone. Change-Id: I5ee9a362600dbd6325254d7431172501181b52b0 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/soc/amd/common/block/pci/amd_pci_util.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/22934/1 diff --git a/src/soc/amd/common/block/pci/amd_pci_util.c b/src/soc/amd/common/block/pci/amd_pci_util.c index c5659cb..74bb533 100644 --- a/src/soc/amd/common/block/pci/amd_pci_util.c +++ b/src/soc/amd/common/block/pci/amd_pci_util.c @@ -59,11 +59,12 @@ const struct irq_idx_name *idx_name; idx_name = sb_get_apic_reg_association(&limit); - if (picr_data_ptr == NULL || idx_name == NULL) { + if (picr_data_ptr == NULL || intr_data_ptr == NULL || + idx_name == NULL) { printk(BIOS_ERR, "Warning: Can't write PCI_INTR 0xC00/0xC01" " registers because\n" - "'mainboard_picr_data' or" - " irq_association' tables are NULL\n"); + "'mainboard_picr_data' or 'mainboard_intr_data'" + " or 'irq_association'\ntables are NULL\n"); return; } -- To view, visit https://review.coreboot.org/22934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5ee9a362600dbd6325254d7431172501181b52b0 Gerrit-Change-Number: 22934 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: drivers/mrc_cache: Make CACHE_MRC_SETTINGS not selectable
by build bot (Jenkins) (Code Review) 18 Dec '17

18 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22933 ) Change subject: drivers/mrc_cache: Make CACHE_MRC_SETTINGS not selectable ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19526/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64747/ : SUCCESS -- To view, visit https://review.coreboot.org/22933 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf026a297204868d485be270ccee7e0bec0ac73b Gerrit-Change-Number: 22933 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Dec 2017 16:15:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/mrc_cache: Make CACHE_MRC_SETTINGS not selectable
by Arthur Heymans (Code Review) 18 Dec '17

18 Dec '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/22933 Change subject: drivers/mrc_cache: Make CACHE_MRC_SETTINGS not selectable ...................................................................... drivers/mrc_cache: Make CACHE_MRC_SETTINGS not selectable Don't allow the user to select this manually, since it doesn't build on platforms that don't use it. Don't set the bool value so that it doesn't show as not selected in the .config file of platforms that don't use this. Change-Id: Icf026a297204868d485be270ccee7e0bec0ac73b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/drivers/mrc_cache/Kconfig 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/22933/1 diff --git a/src/drivers/mrc_cache/Kconfig b/src/drivers/mrc_cache/Kconfig index 3e0bdda..93ae6c6 100644 --- a/src/drivers/mrc_cache/Kconfig +++ b/src/drivers/mrc_cache/Kconfig @@ -1,6 +1,7 @@ config CACHE_MRC_SETTINGS - bool "Save cached MRC settings" - default n + bool + help + Save cached MRC settings if CACHE_MRC_SETTINGS -- To view, visit https://review.coreboot.org/22933 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icf026a297204868d485be270ccee7e0bec0ac73b Gerrit-Change-Number: 22933 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: mb/google/poppy: Enable speaker and codec for nami
by build bot (Jenkins) (Code Review) 18 Dec '17

18 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22861 ) Change subject: mb/google/poppy: Enable speaker and codec for nami ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19525/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64746/ : SUCCESS -- To view, visit https://review.coreboot.org/22861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf4059f8ea3d5e34f33f0be227897a8cca636fa Gerrit-Change-Number: 22861 Gerrit-PatchSet: 6 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Dec 2017 14:24:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017