coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: mb/asrock/g41c-gs: Add decode range for Environment Controller
by build bot (Jenkins) (Code Review) 30 Dec '17

30 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23048 ) Change subject: mb/asrock/g41c-gs: Add decode range for Environment Controller ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19851/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65103/ : SUCCESS -- To view, visit https://review.coreboot.org/23048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibff3dffaf0f5c32c3b12336a23839dee501e7160 Gerrit-Change-Number: 23048 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Dec 2017 14:38:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/asrock/g41c-gs: Add decode range for Environment Controller
by Arthur Heymans (Code Review) 30 Dec '17

30 Dec '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23048 Change subject: mb/asrock/g41c-gs: Add decode range for Environment Controller ...................................................................... mb/asrock/g41c-gs: Add decode range for Environment Controller This seems to have been forgotten in the original patch which added the Asrock G41C-GS R2.0, but all variants have a similar SuperIO and set the Environment Controller IO decode address to the same value. TEST: see if the Linux module w832627dhg can properly read the sensors fan/temp/etc... (currently not further configured so values could be garbage). Change-Id: Ibff3dffaf0f5c32c3b12336a23839dee501e7160 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/asrock/g41c-gs/romstage.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/23048/1 diff --git a/src/mainboard/asrock/g41c-gs/romstage.c b/src/mainboard/asrock/g41c-gs/romstage.c index 07edfb4..9acf6c1 100644 --- a/src/mainboard/asrock/g41c-gs/romstage.c +++ b/src/mainboard/asrock/g41c-gs/romstage.c @@ -82,6 +82,8 @@ /* Decode range */ pci_write_config16(PCI_DEV(0, 0x1f, 0), LPC_EN, CNF1_LPC_EN | KBC_LPC_EN | LPT_LPC_EN | COMA_LPC_EN); + /* GEN1_DEC Enable IO range 0x290-29c */ + pci_write_config32(LPC_DEV, 0x84 , 0x000c0290); } void mainboard_romstage_entry(unsigned long bist) -- To view, visit https://review.coreboot.org/23048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibff3dffaf0f5c32c3b12336a23839dee501e7160 Gerrit-Change-Number: 23048 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: [util/vgabios_extract] hookup to build system
by build bot (Jenkins) (Code Review) 30 Dec '17

30 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23047 ) Change subject: [util/vgabios_extract] hookup to build system ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19849/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65101/ : SUCCESS -- To view, visit https://review.coreboot.org/23047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib792ff7c22853eb11ebec7fc834353eb3cbc5ad9 Gerrit-Change-Number: 23047 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Dec 2017 14:22:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]util/intelvbttool: Rewrite tool
by build bot (Jenkins) (Code Review) 30 Dec '17

30 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18902 ) Change subject: [WIP]util/intelvbttool: Rewrite tool ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19850/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65102/ : SUCCESS -- To view, visit https://review.coreboot.org/18902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cbde042c7f5632f36648419becd23e248ba6f76 Gerrit-Change-Number: 18902 Gerrit-PatchSet: 9 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Samuel Holland <samuel(a)sholland.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Dec 2017 14:20:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [util/vgabios_extract] Do intial commit
by build bot (Jenkins) (Code Review) 30 Dec '17

30 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23046 ) Change subject: [util/vgabios_extract] Do intial commit ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19848/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65100/ : SUCCESS -- To view, visit https://review.coreboot.org/23046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f67160a0a6e9035f81f29b1675272e9c992b143 Gerrit-Change-Number: 23046 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Dec 2017 14:10:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [util/vgabios_extract] hookup to build system
by Thomas Weißschuh (Code Review) 30 Dec '17

30 Dec '17

Thomas Weißschuh has uploaded this change for review. ( https://review.coreboot.org/23047 Change subject: [util/vgabios_extract] hookup to build system ...................................................................... [util/vgabios_extract] hookup to build system Allows the automatic extraction and usage of a VGA BIOS from an UEFI dump. Change-Id: Ib792ff7c22853eb11ebec7fc834353eb3cbc5ad9 Signed-off-by: Thomas Weißschuh <thomas(a)t-8ch.de> --- M src/arch/x86/Makefile.inc M src/device/Kconfig 2 files changed, 30 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/23047/1 diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index cc227b3..3f2f1e4 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -38,9 +38,24 @@ $(NVRAMTOOL) -y $(top)/src/mainboard/$(MAINBOARDDIR)/cmos.layout -H $@ endif # CONFIG_HAVE_OPTION_TABLE +vgabios-rom=$(obj)/vgabios.rom + +ifeq ($(CONFIG_VGA_BIOS_EXTRACT),y) + +$(vgabios-rom): $(call strip_quotes,$(CONFIG_VGA_BIOS_EXTRACT_FILE)) + @printf " VGA_BIOS_EXTRACT $(CONFIG_VGA_BIOS_EXTRACT_FILE) $(vgabios-rom)\n" + util/vgabios_extract/vgabios_extract.py $(CONFIG_VGA_BIOS_EXTRACT_FILE) $(vgabios-rom) + +else + +$(vgabios-rom): $(call strip_quotes,$(CONFIG_VGA_BIOS_FILE)) + $(CP) $(vgabios-rom) $(CONFIG_VGA_BIOS_FILE) + +endif + stripped_vgabios_id = $(call strip_quotes,$(CONFIG_VGA_BIOS_ID)) cbfs-files-$(CONFIG_VGA_BIOS) += pci$(stripped_vgabios_id).rom -pci$(stripped_vgabios_id).rom-file := $(call strip_quotes,$(CONFIG_VGA_BIOS_FILE)) +pci$(stripped_vgabios_id).rom-file := $(vgabios-rom) pci$(stripped_vgabios_id).rom-type := optionrom cbfs-files-$(CONFIG_INTEL_MBI) += mbi.bin diff --git a/src/device/Kconfig b/src/device/Kconfig index 28298d5..a6b1168 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -566,11 +566,23 @@ like to add to your ROM. You will be able to specify the location and file name of the - image later. + false + +config VGA_BIOS_EXTRACT + bool "Extract VGA BIOS from BIOS image" + depends on VGA_BIOS + default n + +config VGA_BIOS_EXTRACT_FILE + string "VGA BIOS extract path and filename" + depends on VGA_BIOS_EXTRACT + default "3rdpart/blobs/mainboard/$(MAINBOARDDIR)/bios.bin" + help + The path and filename of the file to extract the VGA BIOS from. config VGA_BIOS_FILE string "VGA BIOS path and filename" - depends on VGA_BIOS + depends on VGA_BIOS && !VGA_BIOS_EXTRACT default "vgabios.bin" help The path and filename of the file to use as VGA BIOS. -- To view, visit https://review.coreboot.org/23047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib792ff7c22853eb11ebec7fc834353eb3cbc5ad9 Gerrit-Change-Number: 23047 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de>

1 0

Change in coreboot[master]: [util/vgabios_extract] Do intial commit
by Thomas Weißschuh (Code Review) 30 Dec '17

30 Dec '17

Thomas Weißschuh has uploaded this change for review. ( https://review.coreboot.org/23046 Change subject: [util/vgabios_extract] Do intial commit ...................................................................... [util/vgabios_extract] Do intial commit This util extracts the VGA BIOS from an UEFI dump. Depends on the 3rd party Python library uefi-firmware-parser. (https://github.com/theopolis/uefi-firmware-parser) Change-Id: I8f67160a0a6e9035f81f29b1675272e9c992b143 Signed-off-by: Thomas Weißschuh <thomas(a)t-8ch.de> --- A util/vgabios_extract/vgabios_extract.py 1 file changed, 60 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/23046/1 diff --git a/util/vgabios_extract/vgabios_extract.py b/util/vgabios_extract/vgabios_extract.py new file mode 100755 index 0000000..1c32b93 --- /dev/null +++ b/util/vgabios_extract/vgabios_extract.py @@ -0,0 +1,60 @@ +#!/usr/bin/env python2 + +from __future__ import print_function + +import uefi_firmware + + +def extract_vga_bios(blob): + volumes = uefi_firmware.search_firmware_volumes(blob) + + objects = [] + + for v in volumes: + x = uefi_firmware.AutoParser(blob[v - 40:]) + + if x.type() == 'unknown': + continue + + objects.extend(x.parse().objects) + + while len(objects): + o = objects.pop() + + if not o: + continue + + subobjects = filter(lambda x: x is not None, o.objects) + + if subobjects: + objects.extend(subobjects) + continue + + if b'VGA Compatible BIOS' in o.content: + return o + + +if __name__ == '__main__': + import argparse + import sys + + print(sys.argv) + + parser = argparse.ArgumentParser() + parser.add_argument('input', type=str) + parser.add_argument('output', type=str) + + args = parser.parse_args() + + with open(args.input, 'rb') as f: + blob = f.read() + + o = extract_vga_bios(blob) + + if o is not None: + print('Found VGA Bios in {}'.format(o.guid_label), file=sys.stderr) + with open(args.output, 'wb') as f: + f.write(o.content) + else: + print('Did not find anything') + sys.exit(1) -- To view, visit https://review.coreboot.org/23046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8f67160a0a6e9035f81f29b1675272e9c992b143 Gerrit-Change-Number: 23046 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de>

1 0

Change in coreboot[master]: Extract the VGA BIOS from an UEFI dump
by build bot (Jenkins) (Code Review) 30 Dec '17

30 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23045 ) Change subject: Extract the VGA BIOS from an UEFI dump ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19847/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65099/ : SUCCESS -- To view, visit https://review.coreboot.org/23045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic95b7520c65062e2106f7bd7d39bb652d4cecd7a Gerrit-Change-Number: 23045 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Dec 2017 13:59:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Extract the VGA BIOS from an UEFI dump
by Arthur Heymans (Code Review) 30 Dec '17

30 Dec '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23045 ) Change subject: Extract the VGA BIOS from an UEFI dump ...................................................................... Patch Set 1: Please slit the commit in 2 parts: * the util * the hook up in the build system -- To view, visit https://review.coreboot.org/23045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic95b7520c65062e2106f7bd7d39bb652d4cecd7a Gerrit-Change-Number: 23045 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 30 Dec 2017 13:49:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: Extract the VGA BIOS from an UEFI dump
by Thomas Weißschuh (Code Review) 30 Dec '17

30 Dec '17

Thomas Weißschuh has uploaded this change for review. ( https://review.coreboot.org/23045 Change subject: Extract the VGA BIOS from an UEFI dump ...................................................................... Extract the VGA BIOS from an UEFI dump Depends on the 3rd party Python library uefi-firmware-parser. (https://github.com/theopolis/uefi-firmware-parser) Change-Id: Ic95b7520c65062e2106f7bd7d39bb652d4cecd7a Signed-off-by: Thomas Weißschuh <thomas(a)t-8ch.de> --- M src/arch/x86/Makefile.inc M src/device/Kconfig A util/vgabios_extract/vgabios_extract.py 3 files changed, 90 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/23045/1 diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index cc227b3..3f2f1e4 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -38,9 +38,24 @@ $(NVRAMTOOL) -y $(top)/src/mainboard/$(MAINBOARDDIR)/cmos.layout -H $@ endif # CONFIG_HAVE_OPTION_TABLE +vgabios-rom=$(obj)/vgabios.rom + +ifeq ($(CONFIG_VGA_BIOS_EXTRACT),y) + +$(vgabios-rom): $(call strip_quotes,$(CONFIG_VGA_BIOS_EXTRACT_FILE)) + @printf " VGA_BIOS_EXTRACT $(CONFIG_VGA_BIOS_EXTRACT_FILE) $(vgabios-rom)\n" + util/vgabios_extract/vgabios_extract.py $(CONFIG_VGA_BIOS_EXTRACT_FILE) $(vgabios-rom) + +else + +$(vgabios-rom): $(call strip_quotes,$(CONFIG_VGA_BIOS_FILE)) + $(CP) $(vgabios-rom) $(CONFIG_VGA_BIOS_FILE) + +endif + stripped_vgabios_id = $(call strip_quotes,$(CONFIG_VGA_BIOS_ID)) cbfs-files-$(CONFIG_VGA_BIOS) += pci$(stripped_vgabios_id).rom -pci$(stripped_vgabios_id).rom-file := $(call strip_quotes,$(CONFIG_VGA_BIOS_FILE)) +pci$(stripped_vgabios_id).rom-file := $(vgabios-rom) pci$(stripped_vgabios_id).rom-type := optionrom cbfs-files-$(CONFIG_INTEL_MBI) += mbi.bin diff --git a/src/device/Kconfig b/src/device/Kconfig index 28298d5..a6b1168 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -566,11 +566,23 @@ like to add to your ROM. You will be able to specify the location and file name of the - image later. + false + +config VGA_BIOS_EXTRACT + bool "Extract VGA BIOS from BIOS image" + depends on VGA_BIOS + default n + +config VGA_BIOS_EXTRACT_FILE + string "VGA BIOS extract path and filename" + depends on VGA_BIOS_EXTRACT + default "3rdpart/blobs/mainboard/$(MAINBOARDDIR)/bios.bin" + help + The path and filename of the file to extract the VGA BIOS from. config VGA_BIOS_FILE string "VGA BIOS path and filename" - depends on VGA_BIOS + depends on VGA_BIOS && !VGA_BIOS_EXTRACT default "vgabios.bin" help The path and filename of the file to use as VGA BIOS. diff --git a/util/vgabios_extract/vgabios_extract.py b/util/vgabios_extract/vgabios_extract.py new file mode 100755 index 0000000..1c32b93 --- /dev/null +++ b/util/vgabios_extract/vgabios_extract.py @@ -0,0 +1,60 @@ +#!/usr/bin/env python2 + +from __future__ import print_function + +import uefi_firmware + + +def extract_vga_bios(blob): + volumes = uefi_firmware.search_firmware_volumes(blob) + + objects = [] + + for v in volumes: + x = uefi_firmware.AutoParser(blob[v - 40:]) + + if x.type() == 'unknown': + continue + + objects.extend(x.parse().objects) + + while len(objects): + o = objects.pop() + + if not o: + continue + + subobjects = filter(lambda x: x is not None, o.objects) + + if subobjects: + objects.extend(subobjects) + continue + + if b'VGA Compatible BIOS' in o.content: + return o + + +if __name__ == '__main__': + import argparse + import sys + + print(sys.argv) + + parser = argparse.ArgumentParser() + parser.add_argument('input', type=str) + parser.add_argument('output', type=str) + + args = parser.parse_args() + + with open(args.input, 'rb') as f: + blob = f.read() + + o = extract_vga_bios(blob) + + if o is not None: + print('Found VGA Bios in {}'.format(o.guid_label), file=sys.stderr) + with open(args.output, 'wb') as f: + f.write(o.content) + else: + print('Did not find anything') + sys.exit(1) -- To view, visit https://review.coreboot.org/23045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic95b7520c65062e2106f7bd7d39bb652d4cecd7a Gerrit-Change-Number: 23045 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017