coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: [util/vgabios_extract] Do intial commit
by Thomas Weißschuh (Code Review) 30 Dec '17

30 Dec '17

Hello Arthur Heymans, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23045 to look at the new patch set (#2). Change subject: [util/vgabios_extract] Do intial commit ...................................................................... [util/vgabios_extract] Do intial commit This util extracts the VGA BIOS from an UEFI dump. Depends on the 3rd party Python library uefi-firmware-parser. (https://github.com/theopolis/uefi-firmware-parser) Change-Id: Ic95b7520c65062e2106f7bd7d39bb652d4cecd7a Signed-off-by: Thomas Weißschuh <thomas(a)t-8ch.de> --- A util/vgabios_extract/vgabios_extract.py 1 file changed, 60 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/23045/2 -- To view, visit https://review.coreboot.org/23045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic95b7520c65062e2106f7bd7d39bb652d4cecd7a Gerrit-Change-Number: 23045 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/asrock/g41c-gs: Add g41m-gs variant
by build bot (Jenkins) (Code Review) 30 Dec '17

30 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23043 ) Change subject: mb/asrock/g41c-gs: Add g41m-gs variant ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/65105/ : SUCCESS -- To view, visit https://review.coreboot.org/23043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6844efacaae109cf1e0894201852fddd8043a706 Gerrit-Change-Number: 23043 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Dec 2017 16:31:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/asrock/g41c-gs: Add decode range for Environment Controller
by Kevin Keijzer (Code Review) 30 Dec '17

30 Dec '17

Kevin Keijzer has posted comments on this change. ( https://review.coreboot.org/23048 ) Change subject: mb/asrock/g41c-gs: Add decode range for Environment Controller ...................................................................... Patch Set 2: Code-Review+1 Tested and working on ASRock G41M-GS. -- To view, visit https://review.coreboot.org/23048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibff3dffaf0f5c32c3b12336a23839dee501e7160 Gerrit-Change-Number: 23048 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Dec 2017 16:21:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/asrock/g41c-gs: Add g41m-gs variant
by Arthur Heymans (Code Review) 30 Dec '17

30 Dec '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23043 to look at the new patch set (#2). Change subject: mb/asrock/g41c-gs: Add g41m-gs variant ...................................................................... mb/asrock/g41c-gs: Add g41m-gs variant This board is quite similar to the other ones in this dir an can be supported with little code changes. TODO what works: * DDR2 dual channel PC2-6400; * SATA; * USB; * Ethernet; * Audio; * Native graphic init; * SuperIO Sensors; * Reboot, poweroff, S3 resume; * Flashrom (vendor and coreboot); TODO how tested: Tests were run with SeaBIOS and Debian stretch, using Linux 4.9.65. Change-Id: I6844efacaae109cf1e0894201852fddd8043a706 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/asrock/g41c-gs/Kconfig M src/mainboard/asrock/g41c-gs/Kconfig.name M src/mainboard/asrock/g41c-gs/gpio.c A src/mainboard/asrock/g41c-gs/variants/g41m-gs/devicetree.cb 4 files changed, 161 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/23043/2 -- To view, visit https://review.coreboot.org/23043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6844efacaae109cf1e0894201852fddd8043a706 Gerrit-Change-Number: 23043 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Extract the VGA BIOS from an UEFI dump
by Arthur Heymans (Code Review) 30 Dec '17

30 Dec '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23045 ) Change subject: Extract the VGA BIOS from an UEFI dump ...................................................................... Patch Set 1: > (This is my first time using gerrit) > > Splitting the patch will also mean splitting the review in Gerrit, > correct? yes and generally you want this. It makes the review process easier/faster since individual changes can be reviewed and approved independent of each other. -- To view, visit https://review.coreboot.org/23045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic95b7520c65062e2106f7bd7d39bb652d4cecd7a Gerrit-Change-Number: 23045 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Dec 2017 16:08:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/asrock/g41c-gs: Add decode range for Environment Controller
by build bot (Jenkins) (Code Review) 30 Dec '17

30 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23048 ) Change subject: mb/asrock/g41c-gs: Add decode range for Environment Controller ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19852/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65104/ : SUCCESS -- To view, visit https://review.coreboot.org/23048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibff3dffaf0f5c32c3b12336a23839dee501e7160 Gerrit-Change-Number: 23048 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Dec 2017 16:02:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/asrock/g41c-gs: Add decode range for Environment Controller
by Arthur Heymans (Code Review) 30 Dec '17

30 Dec '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23048 to look at the new patch set (#2). Change subject: mb/asrock/g41c-gs: Add decode range for Environment Controller ...................................................................... mb/asrock/g41c-gs: Add decode range for Environment Controller This seems to have been forgotten in the original patch which added the Asrock G41C-GS R2.0, but all variants have a similar SuperIO and set the Environment Controller IO decode address to the same value. TEST: see if the Linux module w832627dhg can properly read the sensors fan/temp/etc... (currently not further configured so values could be garbage). Change-Id: Ibff3dffaf0f5c32c3b12336a23839dee501e7160 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/asrock/g41c-gs/romstage.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/23048/2 -- To view, visit https://review.coreboot.org/23048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibff3dffaf0f5c32c3b12336a23839dee501e7160 Gerrit-Change-Number: 23048 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Extract the VGA BIOS from an UEFI dump
by Thomas Weißschuh (Code Review) 30 Dec '17

30 Dec '17

Thomas Weißschuh has posted comments on this change. ( https://review.coreboot.org/23045 ) Change subject: Extract the VGA BIOS from an UEFI dump ...................................................................... Patch Set 1: (This is my first time using gerrit) Splitting the patch will also mean splitting the review in Gerrit, correct? -- To view, visit https://review.coreboot.org/23045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic95b7520c65062e2106f7bd7d39bb652d4cecd7a Gerrit-Change-Number: 23045 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Dec 2017 15:52:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [util/vgabios_extract] hookup to build system
by Thomas Weißschuh (Code Review) 30 Dec '17

30 Dec '17

Thomas Weißschuh has abandoned this change. ( https://review.coreboot.org/23047 ) Change subject: [util/vgabios_extract] hookup to build system ...................................................................... Abandoned https://review.coreboot.org/#/c/coreboot/+/23045/ -- To view, visit https://review.coreboot.org/23047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ib792ff7c22853eb11ebec7fc834353eb3cbc5ad9 Gerrit-Change-Number: 23047 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [util/vgabios_extract] Do intial commit
by Thomas Weißschuh (Code Review) 30 Dec '17

30 Dec '17

Thomas Weißschuh has abandoned this change. ( https://review.coreboot.org/23046 ) Change subject: [util/vgabios_extract] Do intial commit ...................................................................... Abandoned Should be a rework of https://review.coreboot.org/#/c/coreboot/+/23045/ -- To view, visit https://review.coreboot.org/23046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I8f67160a0a6e9035f81f29b1675272e9c992b143 Gerrit-Change-Number: 23046 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017