coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: arch/x86: Write ACPI DBG2 table only if the device has been enabled
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22552 ) Change subject: arch/x86: Write ACPI DBG2 table only if the device has been enabled ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18516/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63616/ : SUCCESS -- To view, visit https://review.coreboot.org/22552 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56ce44ae0cf77916fcb640f79fb8944fe33177cd Gerrit-Change-Number: 22552 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 14:01:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/x86: Write ACPI DBG2 table only if the device has been enabled
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22552 ) Change subject: arch/x86: Write ACPI DBG2 table only if the device has been enabled ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18515/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63615/ : SUCCESS -- To view, visit https://review.coreboot.org/22552 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56ce44ae0cf77916fcb640f79fb8944fe33177cd Gerrit-Change-Number: 22552 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 13:16:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/x86: Write ACPI DBG2 table only if the device has been enabled
by Mario Scheithauer (Code Review) 21 Nov '17

21 Nov '17

Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/22552 Change subject: arch/x86: Write ACPI DBG2 table only if the device has been enabled ...................................................................... arch/x86: Write ACPI DBG2 table only if the device has been enabled The commit https://review.coreboot.org/#/c/22452/ causes a crash on the mainboard mc_apl1. On this mainboard all internal SOC UARTs in the devicetree are switched off. As a result, no resources are allocated to the UARTs. The function find_resource() expects an existing resource. Otherwise, the CPU will stop. It should therefore not only be queried whether a device is present, but also whether it has been enabled. Change-Id: I56ce44ae0cf77916fcb640f79fb8944fe33177cd Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/arch/x86/acpi.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/22552/1 diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index 56f6408..5a29ac1 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -8,7 +8,7 @@ * Copyright (C) 2005-2009 coresystems GmbH * Copyright (C) 2015 Timothy Pearson <tpearson(a)raptorengineeringinc.com>, * Raptor Engineering - * Copyright (C) 2016 Siemens AG + * Copyright (C) 2016-2017 Siemens AG * * ACPI FADT, FACS, and DSDT table support added by * Nick Barker <nick.barker9(a)btinternet.com>, and those portions @@ -734,6 +734,10 @@ printk(BIOS_ERR, "%s: Device not found\n", __func__); return current; } + if (!dev->enabled) { + printk(BIOS_ERR, "%s: Device not enabled\n", __func__); + return current; + } res = find_resource(dev, PCI_BASE_ADDRESS_0); if (!res) { printk(BIOS_ERR, "%s: Unable to find resource for %s\n", -- To view, visit https://review.coreboot.org/22552 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I56ce44ae0cf77916fcb640f79fb8944fe33177cd Gerrit-Change-Number: 22552 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>

1 0

Change in coreboot[master]: soc/intel/apollolake: Add PNP config
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22488 ) Change subject: soc/intel/apollolake: Add PNP config ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63613/ : SUCCESS -- To view, visit https://review.coreboot.org/22488 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd70a42c9406941c8a93cc972f22c2475e9d0200 Gerrit-Change-Number: 22488 Gerrit-PatchSet: 3 Gerrit-Owner: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 10:48:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Add PNP config
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22488 ) Change subject: soc/intel/apollolake: Add PNP config ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63611/ : SUCCESS -- To view, visit https://review.coreboot.org/22488 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd70a42c9406941c8a93cc972f22c2475e9d0200 Gerrit-Change-Number: 22488 Gerrit-PatchSet: 3 Gerrit-Owner: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 10:43:47 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Add PNP config
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22488 ) Change subject: soc/intel/apollolake: Add PNP config ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18514/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63614/ : SUCCESS -- To view, visit https://review.coreboot.org/22488 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd70a42c9406941c8a93cc972f22c2475e9d0200 Gerrit-Change-Number: 22488 Gerrit-PatchSet: 3 Gerrit-Owner: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 10:37:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Add PNP config
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22488 ) Change subject: soc/intel/apollolake: Add PNP config ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63609/ : SUCCESS -- To view, visit https://review.coreboot.org/22488 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd70a42c9406941c8a93cc972f22c2475e9d0200 Gerrit-Change-Number: 22488 Gerrit-PatchSet: 3 Gerrit-Owner: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 10:30:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Add PNP config
by Divya Chellappa (Code Review) 21 Nov '17

21 Nov '17

Divya Chellappa has uploaded a new patch set (#3). ( https://review.coreboot.org/22488 ) Change subject: soc/intel/apollolake: Add PNP config ...................................................................... soc/intel/apollolake: Add PNP config 1. Programs PNP values for AUNIT, BUNIT & TUNIT registers as per reference code. 2. A new Kconfig option PNP_SETTINGS is introduced to select PNP settings among performance, power, power&performance. TEST = built and booted glkrvp, verfied that the callback gets control, verified warm and cold reboots. Change-Id: Ibd70a42c9406941c8a93cc972f22c2475e9d0200 Signed-off-by: Divya Chellap <divya.chellappa(a)intel.com> --- M src/soc/intel/apollolake/Kconfig M src/soc/intel/apollolake/Makefile.inc A src/soc/intel/apollolake/include/soc/pnpconfig.h A src/soc/intel/apollolake/pnpconfig.c 4 files changed, 857 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/22488/3 -- To view, visit https://review.coreboot.org/22488 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd70a42c9406941c8a93cc972f22c2475e9d0200 Gerrit-Change-Number: 22488 Gerrit-PatchSet: 3 Gerrit-Owner: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: chromeec: Change the API for hostevent/wake masks to handle 64-bit
by build bot (Jenkins) (Code Review) 20 Nov '17

20 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22551 ) Change subject: chromeec: Change the API for hostevent/wake masks to handle 64-bit ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18513/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63605/ : SUCCESS -- To view, visit https://review.coreboot.org/22551 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If59f3f2b1a2aa5ce95883df3e72efc4a32de1190 Gerrit-Change-Number: 22551 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 04:39:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Invoke pmc and hard reset only if CSE fails to ...
by Pratikkumar V Prajapati (Code Review) 20 Nov '17

20 Nov '17

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/22549 ) Change subject: soc/intel/cannonlake: Invoke pmc and hard reset only if CSE fails to reset ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/22549/1/src/soc/intel/cannonlake/reset.c File src/soc/intel/cannonlake/reset.c: https://review.coreboot.org/#/c/22549/1/src/soc/intel/cannonlake/reset.c@83 PS1, Line 83: if(!send_heci_reset_message()) : return; > We dont want to return from here if heci reset fails. we would try pmc and Aah.. i see what you mean, but even if heci reset works then also there is no point to return. -- To view, visit https://review.coreboot.org/22549 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bb12554e5745d7704a1b684a3a51034bb35f787 Gerrit-Change-Number: 22549 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 04:33:25 +0000 Gerrit-HasComments: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017