coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: spi/tpm.c do not waste time on wake pulses unless necessary
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22321 ) Change subject: spi/tpm.c do not waste time on wake pulses unless necessary ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18531/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63631/ : SUCCESS -- To view, visit https://review.coreboot.org/22321 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8def1470ba3eab533075b9e7180f8a58e0b00b6 Gerrit-Change-Number: 22321 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: TH Lin <t.h_lin(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 21:02:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Add support for rainier
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22542 ) Change subject: google/gru: Add support for rainier ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18530/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63630/ : SUCCESS -- To view, visit https://review.coreboot.org/22542 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I596f7ca6bc26312ecaeb261c96cebd46974c2cdf Gerrit-Change-Number: 22542 Gerrit-PatchSet: 3 Gerrit-Owner: Ege Mihmanli <egemih(a)google.com> Gerrit-Reviewer: Ege Mihmanli <egemih(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 19:49:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: spi/tpm.c do not waste time on wake pulses unless necessary
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22321 ) Change subject: spi/tpm.c do not waste time on wake pulses unless necessary ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18529/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63629/ : SUCCESS -- To view, visit https://review.coreboot.org/22321 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8def1470ba3eab533075b9e7180f8a58e0b00b6 Gerrit-Change-Number: 22321 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: TH Lin <t.h_lin(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 19:09:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/i2c/tpm/cr50: Simplify and increase init delay to 30 seconds
by Vadim Bendebury (Code Review) 21 Nov '17

21 Nov '17

Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/22554 ) Change subject: drivers/i2c/tpm/cr50: Simplify and increase init delay to 30 seconds ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/22554/1/src/drivers/i2c/tpm/cr50.c File src/drivers/i2c/tpm/cr50.c: https://review.coreboot.org/#/c/22554/1/src/drivers/i2c/tpm/cr50.c@450 PS1, Line 450: : if (ENV_VERSTAGE || ENV_BOOTBLOCK) : if (request_locality(chip)) : return -1; > As a sanity, do we want to check if locality is still claimed in other stag actually, this is a good point, not as just a sanity issue: the old RO would release locality, so the new RW needs to claim it if there is RO/RW version mismatch. -- To view, visit https://review.coreboot.org/22554 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba8445caf1342e3a5fefcb2664b0759a1a8e84e3 Gerrit-Change-Number: 22554 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 18:26:09 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Invoke pmc and hard reset only if CSE fails to ...
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22549 ) Change subject: soc/intel/cannonlake: Invoke pmc and hard reset only if CSE fails to reset ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18528/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63628/ : SUCCESS -- To view, visit https://review.coreboot.org/22549 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bb12554e5745d7704a1b684a3a51034bb35f787 Gerrit-Change-Number: 22549 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 18:20:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/i2c/tpm/cr50: Simplify and increase init delay to 30 seconds
by Furquan Shaikh (Code Review) 21 Nov '17

21 Nov '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/22554 ) Change subject: drivers/i2c/tpm/cr50: Simplify and increase init delay to 30 seconds ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/22554/1/src/drivers/i2c/tpm/cr50.c File src/drivers/i2c/tpm/cr50.c: https://review.coreboot.org/#/c/22554/1/src/drivers/i2c/tpm/cr50.c@450 PS1, Line 450: : if (ENV_VERSTAGE || ENV_BOOTBLOCK) : if (request_locality(chip)) : return -1; As a sanity, do we want to check if locality is still claimed in other stages? -- To view, visit https://review.coreboot.org/22554 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba8445caf1342e3a5fefcb2664b0759a1a8e84e3 Gerrit-Change-Number: 22554 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 18:08:04 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: build system: drop duplicate rule for $(objutil)/blobtool/blobtool
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22555 ) Change subject: build system: drop duplicate rule for $(objutil)/blobtool/blobtool ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18527/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63627/ : SUCCESS -- To view, visit https://review.coreboot.org/22555 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bc17d3b182369cf5b67bdcf392db7932e5389bf Gerrit-Change-Number: 22555 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 18:05:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/soc/intel/apollolake: move TCO1 disable into bootblock
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22553 ) Change subject: src/soc/intel/apollolake: move TCO1 disable into bootblock ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18526/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63626/ : SUCCESS -- To view, visit https://review.coreboot.org/22553 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf1f97924590163e45bcac667b6c607503cc8b87 Gerrit-Change-Number: 22553 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 17:59:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: build system: drop duplicate rule for $(objutil)/blobtool/blobtool
by Patrick Georgi (Code Review) 21 Nov '17

21 Nov '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/22555 Change subject: build system: drop duplicate rule for $(objutil)/blobtool/blobtool ...................................................................... build system: drop duplicate rule for $(objutil)/blobtool/blobtool There's already one in util/blobtool/Makefile.inc BUG=chromium:787042 TEST=no more warning about duplicate rules Change-Id: I8bc17d3b182369cf5b67bdcf392db7932e5389bf Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M Makefile.inc 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/22555/1 diff --git a/Makefile.inc b/Makefile.inc index e6e9eae..4473bf5 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -495,10 +495,6 @@ $(HOSTCC) -g $(STACK) -Wall -o $@ $< BLOBTOOL:=$(objutil)/blobtool/blobtool -$(BLOBTOOL): - @printf " Compile BLOBTOOL\n" - +$(MAKE) -C $(top)/util/blobtool - cp -a $(top)/util/ifdtool/blobtool $@ IFDTOOL:=$(objutil)/ifdtool/ifdtool $(IFDTOOL): -- To view, visit https://review.coreboot.org/22555 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8bc17d3b182369cf5b67bdcf392db7932e5389bf Gerrit-Change-Number: 22555 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: drivers/i2c/tpm/cr50: Simplify and increase init delay to 30 seconds
by build bot (Jenkins) (Code Review) 21 Nov '17

21 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22554 ) Change subject: drivers/i2c/tpm/cr50: Simplify and increase init delay to 30 seconds ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18525/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63625/ : SUCCESS -- To view, visit https://review.coreboot.org/22554 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba8445caf1342e3a5fefcb2664b0759a1a8e84e3 Gerrit-Change-Number: 22554 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 17:51:48 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017