coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: mb/google/{poppy, nautilus, soraka}: Disable deep S3
by Furquan Shaikh (Code Review) 08 Nov '17

08 Nov '17

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22378 Change subject: mb/google/{poppy,nautilus,soraka}: Disable deep S3 ...................................................................... mb/google/{poppy,nautilus,soraka}: Disable deep S3 Poppy and variants won't be using deep S3. This change disables deep S3 option in devicetree. BUG=b:69053636 Change-Id: I5fb4a6a0e4216a3648b5ed888f6dc6618f1a9fc4 Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/mainboard/google/poppy/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/nautilus/devicetree.cb M src/mainboard/google/poppy/variants/soraka/devicetree.cb 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/22378/1 diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb index 61b16e6..920ab5c 100644 --- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb @@ -2,7 +2,7 @@ # Deep Sx states register "deep_s3_enable_ac" = "0" - register "deep_s3_enable_dc" = "1" + register "deep_s3_enable_dc" = "0" register "deep_s5_enable_ac" = "1" register "deep_s5_enable_dc" = "1" register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN" diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb index 2721218..efaea3f 100644 --- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb @@ -2,7 +2,7 @@ # Deep Sx states register "deep_s3_enable_ac" = "0" - register "deep_s3_enable_dc" = "1" + register "deep_s3_enable_dc" = "0" register "deep_s5_enable_ac" = "1" register "deep_s5_enable_dc" = "1" register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN" diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb index 1c342a4..14c2b06 100644 --- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb +++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb @@ -2,7 +2,7 @@ # Deep Sx states register "deep_s3_enable_ac" = "0" - register "deep_s3_enable_dc" = "1" + register "deep_s3_enable_dc" = "0" register "deep_s5_enable_ac" = "1" register "deep_s5_enable_dc" = "1" register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN" -- To view, visit https://review.coreboot.org/22378 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5fb4a6a0e4216a3648b5ed888f6dc6618f1a9fc4 Gerrit-Change-Number: 22378 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: mainboard/compulab: add support for CompuLab Intense-PC
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22210 ) Change subject: mainboard/compulab: add support for CompuLab Intense-PC ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18095/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63150/ : SUCCESS -- To view, visit https://review.coreboot.org/22210 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I741b0b2f87eb9147c375b405a5b6989a10c7ad0a Gerrit-Change-Number: 22210 Gerrit-PatchSet: 10 Gerrit-Owner: Hal Martin <hal.martin+coreboot(a)gmail.com> Gerrit-Reviewer: Hal Martin <hal.martin+coreboot(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 19:26:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8/ssdt: Add keyboard backlight interface
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21002 ) Change subject: ec/lenovo/h8/ssdt: Add keyboard backlight interface ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18092/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63147/ : SUCCESS -- To view, visit https://review.coreboot.org/21002 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia65e770e772936c9c32be33c30839a2dee2a107c Gerrit-Change-Number: 21002 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 19:13:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: Apply state on wake
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22377 ) Change subject: ec/lenovo/h8/acpi: Apply state on wake ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18094/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63149/ : SUCCESS -- To view, visit https://review.coreboot.org/22377 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13c08b8c6b1bf0f3deb25a464b26880d8469c005 Gerrit-Change-Number: 22377 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 19:12:47 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8/ssdt: Add UWB ACPI interface
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21003 ) Change subject: ec/lenovo/h8/ssdt: Add UWB ACPI interface ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18093/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63148/ : SUCCESS -- To view, visit https://review.coreboot.org/21003 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f9a56e45c0d765b0e06b8d3600bd3575dd09491 Gerrit-Change-Number: 21003 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 19:09:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8/ssdt: Add WWAN ACPI methods
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20986 ) Change subject: ec/lenovo/h8/ssdt: Add WWAN ACPI methods ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18091/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63146/ : SUCCESS -- To view, visit https://review.coreboot.org/20986 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5550c78e0d36884eca7a8d8ece19b64aaee44045 Gerrit-Change-Number: 20986 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 19:06:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: Apply state on wake
by Patrick Rudolph (Code Review) 08 Nov '17

08 Nov '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/22377 Change subject: ec/lenovo/h8/acpi: Apply state on wake ...................................................................... ec/lenovo/h8/acpi: Apply state on wake Store the requested state wake state for bluetooth and WWAN. Add new methods to init the state and apply the requested state on wake. Call the new method on all devices. Change-Id: I13c08b8c6b1bf0f3deb25a464b26880d8469c005 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t400/acpi/platform.asl M src/mainboard/lenovo/t420s/acpi/platform.asl M src/mainboard/lenovo/t430/acpi/platform.asl M src/mainboard/lenovo/t430s/acpi/platform.asl M src/mainboard/lenovo/t520/acpi/platform.asl M src/mainboard/lenovo/t530/acpi/platform.asl M src/mainboard/lenovo/t60/acpi/platform.asl M src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl M src/mainboard/lenovo/x200/acpi/platform.asl M src/mainboard/lenovo/x201/acpi/platform.asl M src/mainboard/lenovo/x220/acpi/platform.asl M src/mainboard/lenovo/x230/acpi/platform.asl M src/mainboard/lenovo/x60/acpi/platform.asl 14 files changed, 80 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/22377/1 diff --git a/src/ec/lenovo/h8/acpi/thinkpad.asl b/src/ec/lenovo/h8/acpi/thinkpad.asl index b5ad013..2e8bf60 100644 --- a/src/ec/lenovo/h8/acpi/thinkpad.asl +++ b/src/ec/lenovo/h8/acpi/thinkpad.asl @@ -150,6 +150,11 @@ Return (0x0100) } + /* Has thinkpad_acpi module loaded */ + Name (HAST, 0) + + /* State after sleep */ + Name (WBDC, 0) /* * Returns the current state: * Bit 0: BT HW present @@ -158,14 +163,15 @@ */ Method (GBDC, 0) { + Store (One, HAST) + If (HBDC) { Store(One, Local0) If(\_SB.PCI0.LPCB.EC.BTEB) { Or(Local0, 2, Local0) } - /* FIXME: Implement state at resume, for now Enabled */ - Or(Local0, 4, Local0) + Or(Local0, ShiftLeft(WBDC, 2), Local0) Return (Local0) } Else { Return (0) @@ -179,14 +185,18 @@ */ Method (SBDC, 1) { + Store (One, HAST) + If (HBDC) { ShiftRight (And(Arg0, 2), 1, Local0) Store (Local0, \_SB.PCI0.LPCB.EC.BTEB) - - /* FIXME: Store state at resume */ + ShiftRight (And(Arg0, 4), 2, Local0) + Store (Local0, WBDC) } } + /* State after sleep */ + Name (WWAN, 0) /* * Returns the current state: * Bit 0: WWAN HW present @@ -195,14 +205,15 @@ */ Method (GWAN, 0) { + Store (One, HAST) + If (HWAN) { Store(One, Local0) If(\_SB.PCI0.LPCB.EC.WWEB) { Or(Local0, 2, Local0) } - /* FIXME: Implement state at resume, for now Enabled */ - Or(Local0, 4, Local0) + Or(Local0, ShiftLeft(WWAN, 2), Local0) Return (Local0) } Else { Return (0) @@ -216,11 +227,12 @@ */ Method (SWAN, 1) { + Store (One, HAST) + If (HWAN) { ShiftRight (And(Arg0, 2), 1, Local0) Store (Local0, \_SB.PCI0.LPCB.EC.WWEB) - - /* FIXME: Store state at resume */ + ShiftRight (And(Arg0, 4), 2, WWAN) } } @@ -284,4 +296,24 @@ Store (Local0, \_SB.PCI0.LPCB.EC.UWBE) } } + + /* + * Store initial state + */ + Method (_INI, 0, NotSerialized) + { + Store (\_SB.PCI0.LPCB.EC.BTEB, WBDC) + Store (\_SB.PCI0.LPCB.EC.WWEB, WWAN) + } + + /* + * Called from _WAK + */ + Method (WAKE, 1) + { + If (HAST) { + Store (WBDC, \_SB.PCI0.LPCB.EC.BTEB) + Store (WWAN, \_SB.PCI0.LPCB.EC.WWEB) + } + } } diff --git a/src/mainboard/lenovo/t400/acpi/platform.asl b/src/mainboard/lenovo/t400/acpi/platform.asl index 5c6f968..85357a5 100644 --- a/src/mainboard/lenovo/t400/acpi/platform.asl +++ b/src/mainboard/lenovo/t400/acpi/platform.asl @@ -31,6 +31,9 @@ Method(_WAK,1) { + /* Wake the HKEY to init BT/WWAN */ + \_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) + // CPU specific part // Notify PCI Express slots in case a card diff --git a/src/mainboard/lenovo/t420s/acpi/platform.asl b/src/mainboard/lenovo/t420s/acpi/platform.asl index 6f26c5a..e4c8a24 100644 --- a/src/mainboard/lenovo/t420s/acpi/platform.asl +++ b/src/mainboard/lenovo/t420s/acpi/platform.asl @@ -32,6 +32,9 @@ Store (0, \_TZ.MEB1) Store (0, \_TZ.MEB2) + /* Wake the HKEY to init BT/WWAN */ + \_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) + /* Not implemented. */ Return(Package(){0,0}) } diff --git a/src/mainboard/lenovo/t430/acpi/platform.asl b/src/mainboard/lenovo/t430/acpi/platform.asl index efbf0ea..13ea2c1 100644 --- a/src/mainboard/lenovo/t430/acpi/platform.asl +++ b/src/mainboard/lenovo/t430/acpi/platform.asl @@ -18,6 +18,10 @@ /* ME may not be up yet. */ Store (0, \_TZ.MEB1) Store (0, \_TZ.MEB2) + + /* Wake the HKEY to init BT/WWAN */ + \_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) + Return(Package(){0,0}) } diff --git a/src/mainboard/lenovo/t430s/acpi/platform.asl b/src/mainboard/lenovo/t430s/acpi/platform.asl index 6f26c5a..e4c8a24 100644 --- a/src/mainboard/lenovo/t430s/acpi/platform.asl +++ b/src/mainboard/lenovo/t430s/acpi/platform.asl @@ -32,6 +32,9 @@ Store (0, \_TZ.MEB1) Store (0, \_TZ.MEB2) + /* Wake the HKEY to init BT/WWAN */ + \_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) + /* Not implemented. */ Return(Package(){0,0}) } diff --git a/src/mainboard/lenovo/t520/acpi/platform.asl b/src/mainboard/lenovo/t520/acpi/platform.asl index 6f26c5a..e4c8a24 100644 --- a/src/mainboard/lenovo/t520/acpi/platform.asl +++ b/src/mainboard/lenovo/t520/acpi/platform.asl @@ -32,6 +32,9 @@ Store (0, \_TZ.MEB1) Store (0, \_TZ.MEB2) + /* Wake the HKEY to init BT/WWAN */ + \_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) + /* Not implemented. */ Return(Package(){0,0}) } diff --git a/src/mainboard/lenovo/t530/acpi/platform.asl b/src/mainboard/lenovo/t530/acpi/platform.asl index 9cd327a..bf686f4 100644 --- a/src/mainboard/lenovo/t530/acpi/platform.asl +++ b/src/mainboard/lenovo/t530/acpi/platform.asl @@ -32,6 +32,9 @@ Store (0, \_TZ.MEB1) Store (0, \_TZ.MEB2) + /* Wake the HKEY to init BT/WWAN */ + \_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) + /* Not implemented. */ Return(Package(){0,0}) } diff --git a/src/mainboard/lenovo/t60/acpi/platform.asl b/src/mainboard/lenovo/t60/acpi/platform.asl index 006b6f0..f9e991b 100644 --- a/src/mainboard/lenovo/t60/acpi/platform.asl +++ b/src/mainboard/lenovo/t60/acpi/platform.asl @@ -29,6 +29,9 @@ Method(_WAK,1) { + /* Wake the HKEY to init BT/WWAN */ + \_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) + // CPU specific part // Notify PCI Express slots in case a card diff --git a/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl b/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl index 3e9225c..b63c91c 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl +++ b/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl @@ -30,6 +30,9 @@ Store (0, \_TZ.MEB1) Store (0, \_TZ.MEB2) + /* Wake the HKEY to init BT/WWAN */ + \_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) + /* Not implemented. */ Return(Package(){0,0}) } diff --git a/src/mainboard/lenovo/x200/acpi/platform.asl b/src/mainboard/lenovo/x200/acpi/platform.asl index 5c6f968..85357a5 100644 --- a/src/mainboard/lenovo/x200/acpi/platform.asl +++ b/src/mainboard/lenovo/x200/acpi/platform.asl @@ -31,6 +31,9 @@ Method(_WAK,1) { + /* Wake the HKEY to init BT/WWAN */ + \_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) + // CPU specific part // Notify PCI Express slots in case a card diff --git a/src/mainboard/lenovo/x201/acpi/platform.asl b/src/mainboard/lenovo/x201/acpi/platform.asl index 0a6d5f3..7d7013b 100644 --- a/src/mainboard/lenovo/x201/acpi/platform.asl +++ b/src/mainboard/lenovo/x201/acpi/platform.asl @@ -63,6 +63,9 @@ Method(_WAK,1) { + /* Wake the HKEY to init BT/WWAN */ + \_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) + /* Not implemented. */ Return(Package(){0,0}) } diff --git a/src/mainboard/lenovo/x220/acpi/platform.asl b/src/mainboard/lenovo/x220/acpi/platform.asl index 9cd327a..bf686f4 100644 --- a/src/mainboard/lenovo/x220/acpi/platform.asl +++ b/src/mainboard/lenovo/x220/acpi/platform.asl @@ -32,6 +32,9 @@ Store (0, \_TZ.MEB1) Store (0, \_TZ.MEB2) + /* Wake the HKEY to init BT/WWAN */ + \_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) + /* Not implemented. */ Return(Package(){0,0}) } diff --git a/src/mainboard/lenovo/x230/acpi/platform.asl b/src/mainboard/lenovo/x230/acpi/platform.asl index 9cd327a..bf686f4 100644 --- a/src/mainboard/lenovo/x230/acpi/platform.asl +++ b/src/mainboard/lenovo/x230/acpi/platform.asl @@ -32,6 +32,9 @@ Store (0, \_TZ.MEB1) Store (0, \_TZ.MEB2) + /* Wake the HKEY to init BT/WWAN */ + \_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) + /* Not implemented. */ Return(Package(){0,0}) } diff --git a/src/mainboard/lenovo/x60/acpi/platform.asl b/src/mainboard/lenovo/x60/acpi/platform.asl index 006b6f0..f9e991b 100644 --- a/src/mainboard/lenovo/x60/acpi/platform.asl +++ b/src/mainboard/lenovo/x60/acpi/platform.asl @@ -29,6 +29,9 @@ Method(_WAK,1) { + /* Wake the HKEY to init BT/WWAN */ + \_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) + // CPU specific part // Notify PCI Express slots in case a card -- To view, visit https://review.coreboot.org/22377 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I13c08b8c6b1bf0f3deb25a464b26880d8469c005 Gerrit-Change-Number: 22377 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: src/soc/amd/stoneyridge/southbridge.h: Remove unused prototypes
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22376 ) Change subject: src/soc/amd/stoneyridge/southbridge.h: Remove unused prototypes ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18089/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63143/ : SUCCESS -- To view, visit https://review.coreboot.org/22376 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If022f873813070aac6cc9090c2212178a4e66354 Gerrit-Change-Number: 22376 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 18:06:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/soc/amd/stoneyridge/southbridge.h: Fix prototypes
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22288 ) Change subject: src/soc/amd/stoneyridge/southbridge.h: Fix prototypes ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63144/ : SUCCESS -- To view, visit https://review.coreboot.org/22288 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9573a68f7153dbbad2fc6551d5dab000760c871e Gerrit-Change-Number: 22288 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 18:04:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/soc/amd/stoneyridge/southbridge.h: Fix prototypes
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22288 ) Change subject: src/soc/amd/stoneyridge/southbridge.h: Fix prototypes ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63142/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18088/ : SUCCESS -- To view, visit https://review.coreboot.org/22288 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9573a68f7153dbbad2fc6551d5dab000760c871e Gerrit-Change-Number: 22288 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 17:58:37 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017