coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: mainboard/google/zoombini: add dptf.asl and gpio.h
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22381 ) Change subject: mainboard/google/zoombini: add dptf.asl and gpio.h ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18100/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63156/ : SUCCESS -- To view, visit https://review.coreboot.org/22381 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9aa37f5afc35dab372917a4c84ff3121ec569546 Gerrit-Change-Number: 22381 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 21:36:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/zoombini: fix two gpio defines
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22380 ) Change subject: mainboard/google/zoombini: fix two gpio defines ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63155/ : SUCCESS -- To view, visit https://review.coreboot.org/22380 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d07bc0ef295d776635ff3a585c8de9028bd3f6a Gerrit-Change-Number: 22380 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 21:20:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/zoombini: add dptf.asl and gpio.h
by Nick Vaccaro (Code Review) 08 Nov '17

08 Nov '17

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/22381 Change subject: mainboard/google/zoombini: add dptf.asl and gpio.h ...................................................................... mainboard/google/zoombini: add dptf.asl and gpio.h Add dptf.asl to baseboard variant includes, instruct zoombini variant to use the baseboard's dptf.asl, instruct zoombini variant to use the baseboard's gpio.h. BUG=b:64395641 BRANCH=None TEST=Verify "./util/abuild/abuild -p none -t google/zoombini -x -a" compiles successfully. Change-Id: I9aa37f5afc35dab372917a4c84ff3121ec569546 Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- A src/mainboard/google/zoombini/variants/baseboard/include/baseboard/acpi/dptf.asl A src/mainboard/google/zoombini/variants/zoombini/include/variant/acpi/dptf.asl A src/mainboard/google/zoombini/variants/zoombini/include/variant/gpio.h 3 files changed, 123 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/22381/1 diff --git a/src/mainboard/google/zoombini/variants/baseboard/include/baseboard/acpi/dptf.asl b/src/mainboard/google/zoombini/variants/baseboard/include/baseboard/acpi/dptf.asl new file mode 100644 index 0000000..aba1385 --- /dev/null +++ b/src/mainboard/google/zoombini/variants/baseboard/include/baseboard/acpi/dptf.asl @@ -0,0 +1,86 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2017 Google Inc. + * Copyright (C) 2015 Intel Corporation. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#define DPTF_CPU_PASSIVE 95 +#define DPTF_CPU_CRITICAL 105 +#define DPTF_CPU_ACTIVE_AC0 90 +#define DPTF_CPU_ACTIVE_AC1 80 +#define DPTF_CPU_ACTIVE_AC2 70 +#define DPTF_CPU_ACTIVE_AC3 60 +#define DPTF_CPU_ACTIVE_AC4 50 + +#define DPTF_TSR0_SENSOR_ID 0 +#define DPTF_TSR0_SENSOR_NAME "Battery" +#define DPTF_TSR0_PASSIVE 120 +#define DPTF_TSR0_CRITICAL 125 + +#define DPTF_TSR1_SENSOR_ID 1 +#define DPTF_TSR1_SENSOR_NAME "Ambient" +#define DPTF_TSR1_PASSIVE 46 +#define DPTF_TSR1_CRITICAL 75 + +#define DPTF_TSR2_SENSOR_ID 2 +#define DPTF_TSR2_SENSOR_NAME "Charger" +#define DPTF_TSR2_PASSIVE 58 +#define DPTF_TSR2_CRITICAL 90 + +#define DPTF_ENABLE_CHARGER + +/* Charger performance states, board-specific values from charger and EC */ +Name (CHPS, Package () { + Package () { 0, 0, 0, 0, 255, 0xBB8, "mA", 0 }, /* 3A (MAX) */ + Package () { 0, 0, 0, 0, 24, 0x600, "mA", 0 }, /* 1.5A */ + Package () { 0, 0, 0, 0, 16, 0x400, "mA", 0 }, /* 1.0A */ + Package () { 0, 0, 0, 0, 8, 0x200, "mA", 0 }, /* 0.5A */ + Package () { 0, 0, 0, 0, 0, 0x000, "mA", 0 }, /* 0.0A */ +}) + +Name (DTRT, Package () { + /* CPU Throttle Effect on CPU */ + Package () { \_SB.PCI0.TCPU, \_SB.PCI0.TCPU, 100, 100, 0, 0, 0, 0 }, + + /* CPU Effect on Temp Sensor 0 */ + Package () { \_SB.PCI0.TCPU, \_SB.DPTF.TSR0, 100, 1200, 0, 0, 0, 0 }, + +#ifdef DPTF_ENABLE_CHARGER + /* Charger Effect on Temp Sensor 2 */ + Package () { \_SB.DPTF.TCHG, \_SB.DPTF.TSR2, 200, 300, 0, 0, 0, 0 }, +#endif + + /* CPU Effect on Temp Sensor 1 */ + Package () { \_SB.PCI0.TCPU, \_SB.DPTF.TSR1, 100, 150, 0, 0, 0, 0 }, +}) + +Name (MPPC, Package () +{ + 0x2, /* Revision */ + Package () { /* Power Limit 1 */ + 0, /* PowerLimitIndex, 0 for Power Limit 1 */ + 3000, /* PowerLimitMinimum */ + 12000, /* PowerLimitMaximum */ + 1000, /* TimeWindowMinimum */ + 1000, /* TimeWindowMaximum */ + 200 /* StepSize */ + }, + Package () { /* Power Limit 2 */ + 1, /* PowerLimitIndex, 1 for Power Limit 2 */ + 8000, /* PowerLimitMinimum */ + 15000, /* PowerLimitMaximum */ + 1000, /* TimeWindowMinimum */ + 1000, /* TimeWindowMaximum */ + 1000 /* StepSize */ + } +}) diff --git a/src/mainboard/google/zoombini/variants/zoombini/include/variant/acpi/dptf.asl b/src/mainboard/google/zoombini/variants/zoombini/include/variant/acpi/dptf.asl new file mode 100644 index 0000000..15c46e4 --- /dev/null +++ b/src/mainboard/google/zoombini/variants/zoombini/include/variant/acpi/dptf.asl @@ -0,0 +1,16 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2017 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/acpi/dptf.asl> diff --git a/src/mainboard/google/zoombini/variants/zoombini/include/variant/gpio.h b/src/mainboard/google/zoombini/variants/zoombini/include/variant/gpio.h new file mode 100644 index 0000000..4f79495 --- /dev/null +++ b/src/mainboard/google/zoombini/variants/zoombini/include/variant/gpio.h @@ -0,0 +1,21 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2017 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the + * GNU General Public License for more details. + */ + +#ifndef __MAINBOARD_GPIO_H__ +#define __MAINBOARD_GPIO_H__ + +#include <baseboard/gpio.h> + +#endif /* __MAINBOARD_GPIO_H__ */ -- To view, visit https://review.coreboot.org/22381 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9aa37f5afc35dab372917a4c84ff3121ec569546 Gerrit-Change-Number: 22381 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>

1 0

Change in coreboot[master]: google/zoombini: fix two gpio defines
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22380 ) Change subject: google/zoombini: fix two gpio defines ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18099/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63154/ : SUCCESS -- To view, visit https://review.coreboot.org/22380 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d07bc0ef295d776635ff3a585c8de9028bd3f6a Gerrit-Change-Number: 22380 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 20:27:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/zoombini: fix two gpio defines
by Nick Vaccaro (Code Review) 08 Nov '17

08 Nov '17

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/22380 Change subject: google/zoombini: fix two gpio defines ...................................................................... google/zoombini: fix two gpio defines Change EC_SCI_GPI to GPE0_ESPI, GPIO_EC_IN_RW to GPP_E1. BUG=b:64395641 BRANCH=master TEST=Compiles successfully using "./util/abuild/abuild -p none -t google/zoombini -x -a" Change-Id: I5d07bc0ef295d776635ff3a585c8de9028bd3f6a Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/zoombini/variants/baseboard/include/baseboard/gpio.h 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/22380/1 diff --git a/src/mainboard/google/zoombini/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/zoombini/variants/baseboard/include/baseboard/gpio.h index e8e9938..6db0fd4 100644 --- a/src/mainboard/google/zoombini/variants/baseboard/include/baseboard/gpio.h +++ b/src/mainboard/google/zoombini/variants/baseboard/include/baseboard/gpio.h @@ -16,6 +16,7 @@ #ifndef __MAINBOARD_GPIO_H__ #define __MAINBOARD_GPIO_H__ +#include <soc/gpe.h> #include <soc/gpio.h> /* Memory configuration board straps */ @@ -25,7 +26,7 @@ #define GPIO_MEM_CONFIG_3 GPP_D0 /* EC in RW */ -#define GPIO_EC_IN_RW GPP_A8 +#define GPIO_EC_IN_RW GPP_E1 /* BIOS Flash Write Protect */ #define GPIO_PCH_WP GPP_A1 @@ -34,5 +35,5 @@ #define GPE_EC_WAKE GPP_74 /* eSPI virtual wire reporting */ -#define EC_SCI_GPI GPP_76 +#define EC_SCI_GPI GPE0_ESPI #endif -- To view, visit https://review.coreboot.org/22380 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5d07bc0ef295d776635ff3a585c8de9028bd3f6a Gerrit-Change-Number: 22380 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>

1 0

Change in coreboot[master]: drivers/i2c/tpm/cr50: Increase init delay to 30 seconds
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22379 ) Change subject: drivers/i2c/tpm/cr50: Increase init delay to 30 seconds ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18097/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63152/ : SUCCESS -- To view, visit https://review.coreboot.org/22379 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bccff70e001dfc065c24be8ad34ef239a144db1 Gerrit-Change-Number: 22379 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 19:59:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common/psp: Add command to load fw blobs
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22056 ) Change subject: soc/amd/common/psp: Add command to load fw blobs ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18098/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63153/ : SUCCESS -- To view, visit https://review.coreboot.org/22056 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8431af341930f45ac74f471628b4dc4ede7735f4 Gerrit-Change-Number: 22056 Gerrit-PatchSet: 7 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 19:54:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/{poppy, nautilus, soraka}: Disable deep S3
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22378 ) Change subject: mb/google/{poppy,nautilus,soraka}: Disable deep S3 ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18096/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63151/ : SUCCESS -- To view, visit https://review.coreboot.org/22378 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fb4a6a0e4216a3648b5ed888f6dc6618f1a9fc4 Gerrit-Change-Number: 22378 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 19:37:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/i2c/tpm/cr50: Increase init delay to 30 seconds
by Furquan Shaikh (Code Review) 08 Nov '17

08 Nov '17

Hello Duncan Laurie, I'd like you to do a code review. Please visit https://review.coreboot.org/22379 to review the following change. Change subject: drivers/i2c/tpm/cr50: Increase init delay to 30 seconds ...................................................................... drivers/i2c/tpm/cr50: Increase init delay to 30 seconds In case the TPM is doing a long crypto operation the initial probe could be very delayed. Rather than end up in recovery make the delay long enough to accommodate the (current) long crypto times. BUG=b:65867313, b:68729265 TEST=Verified that Soraka no longer hangs during EC reboot test. Change-Id: I3bccff70e001dfc065c24be8ad34ef239a144db1 Signed-off-by: Duncan Laurie <dlaurie(a)google.com> Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/drivers/i2c/tpm/cr50.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/22379/1 diff --git a/src/drivers/i2c/tpm/cr50.c b/src/drivers/i2c/tpm/cr50.c index baf5fe0..9cc9e95 100644 --- a/src/drivers/i2c/tpm/cr50.c +++ b/src/drivers/i2c/tpm/cr50.c @@ -43,6 +43,7 @@ #include "tpm.h" #define CR50_MAX_BUFSIZE 63 +#define CR50_TIMEOUT_INIT_MS 30000 /* Very long timeout for TPM init */ #define CR50_TIMEOUT_LONG_MS 2000 /* Long timeout while waiting for TPM */ #define CR50_TIMEOUT_SHORT_MS 2 /* Short timeout during transactions */ #define CR50_TIMEOUT_NOIRQ_MS 20 /* Timeout for TPM ready without IRQ */ @@ -423,7 +424,7 @@ struct stopwatch sw; uint8_t buf = 0; int ret; - long sw_run_duration = CR50_TIMEOUT_LONG_MS; + long sw_run_duration = CR50_TIMEOUT_INIT_MS; tpm_dev->bus = bus; tpm_dev->addr = addr; -- To view, visit https://review.coreboot.org/22379 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3bccff70e001dfc065c24be8ad34ef239a144db1 Gerrit-Change-Number: 22379 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>

1 0

Change in coreboot[master]: drvs/ec/lenovo/h8: Rework ACPI device HKEY
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20985 ) Change subject: drvs/ec/lenovo/h8: Rework ACPI device HKEY ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18090/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63145/ : SUCCESS -- To view, visit https://review.coreboot.org/20985 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida825196650966194a883945896a038b0790fe45 Gerrit-Change-Number: 20985 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 19:31:05 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017