coreboot-gerrit October 2017

coreboot-gerrit@coreboot.org

1 participants
1771 discussions

Change in coreboot[master]: soc/intel/skylake: Turnoff XTAL Disqualification for XTAL Shutdown
by Roy Mingi Park (Code Review) 31 Oct '17

31 Oct '17

Hello Rajneesh Bhardwaj, Rushikesh S Kadam, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/22237 to look at the new patch set (#2). Change subject: soc/intel/skylake: Turnoff XTAL Disqualification for XTAL Shutdown ...................................................................... soc/intel/skylake: Turnoff XTAL Disqualification for XTAL Shutdown 24MHz Crystal Shutdown Qualification bit (0x31Ch[22]) need to be '0' if system can enter S0ix with XTAL Shutdown. Note: This patch should be applyied togather with below two patches so that system can enter S0ix with XTAL Shutdown. 1. https://review.coreboot.org/c/22236 2. https://review.coreboot.org/c/22240 BUG=None BRANCH=None TEST=Build for kabylake board with XTAL Disqualification off in pmc.h And read 24MHz Crystal Shutdown Qualification bit (0x31Ch[22]) iotools mmio_read32 0xFE00031c should return '0' on BIT[22] Change-Id: I8abc6e9b88b3bc25cf865824aa14b292ac0524ef Signed-off-by: Roy Mingi Park <roy.mingi.park(a)intel.com> --- M src/soc/intel/skylake/include/soc/pmc.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/22237/2 -- To view, visit https://review.coreboot.org/22237 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8abc6e9b88b3bc25cf865824aa14b292ac0524ef Gerrit-Change-Number: 22237 Gerrit-PatchSet: 2 Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.corp-partner.google.com> Gerrit-Reviewer: Rushikesh S Kadam <rushikesh.s.kadam(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: intelmetool: Print colored capabilities
by build bot (Jenkins) (Code Review) 31 Oct '17

31 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22217 ) Change subject: intelmetool: Print colored capabilities ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/62712/ : SUCCESS -- To view, visit https://review.coreboot.org/22217 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia911cc935d512174399aaf93bba982e071942212 Gerrit-Change-Number: 22217 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Schander <maxschander(a)googlemail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Maximilian Schander <maxschander(a)googlemail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 31 Oct 2017 03:36:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8: Clear EC output queue before enablement
by build bot (Jenkins) (Code Review) 31 Oct '17

31 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22181 ) Change subject: ec/lenovo/h8: Clear EC output queue before enablement ...................................................................... Patch Set 13: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17716/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62711/ : SUCCESS -- To view, visit https://review.coreboot.org/22181 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1733f7350232d0b10ac0d1bc912b62e7fa4da75 Gerrit-Change-Number: 22181 Gerrit-PatchSet: 13 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 31 Oct 2017 03:35:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/nautilus: enable elan touchpad support
by build bot (Jenkins) (Code Review) 31 Oct '17

31 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22187 ) Change subject: google/nautilus: enable elan touchpad support ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17713/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62708/ : SUCCESS -- To view, visit https://review.coreboot.org/22187 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30e6797ef06351690ff0b5c78ea76918547167a7 Gerrit-Change-Number: 22187 Gerrit-PatchSet: 3 Gerrit-Owner: Chris Wang <chriswang(a)ami.com.tw> Gerrit-Reviewer: Chris Wang <chriswang(a)ami.com.tw> Gerrit-Reviewer: Chris Wang <chriswang(a)ami.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: shkim <sh_.kim(a)samsung.com> Gerrit-Comment-Date: Tue, 31 Oct 2017 03:31:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intelmetool: Do small cosmetic changes
by build bot (Jenkins) (Code Review) 31 Oct '17

31 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22216 ) Change subject: intelmetool: Do small cosmetic changes ...................................................................... Patch Set 11: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17714/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62709/ : SUCCESS -- To view, visit https://review.coreboot.org/22216 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0038a146bd899f150518c4832258a42792abaabb Gerrit-Change-Number: 22216 Gerrit-PatchSet: 11 Gerrit-Owner: Maximilian Schander <maxschander(a)googlemail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Maximilian Schander <maxschander(a)googlemail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 31 Oct 2017 03:30:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/acpi: add mechanisms to clear EC output queue
by build bot (Jenkins) (Code Review) 31 Oct '17

31 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22180 ) Change subject: ec/acpi: add mechanisms to clear EC output queue ...................................................................... Patch Set 13: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17715/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62710/ : SUCCESS -- To view, visit https://review.coreboot.org/22180 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee031306c02f5211a4512c6b4ec90f7f0db196ae Gerrit-Change-Number: 22180 Gerrit-PatchSet: 13 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 31 Oct 2017 03:29:38 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Turnoff XTAL Disqualification for XTAL Shutdown
by rushikesh s kadam (Code Review) 31 Oct '17

31 Oct '17

rushikesh s kadam has posted comments on this change. ( https://review.coreboot.org/22237 ) Change subject: soc/intel/skylake: Turnoff XTAL Disqualification for XTAL Shutdown ...................................................................... Patch Set 1: Roy, If we turn off XTAL disqualification, the SoC will not enter S0ix for scenarios such as Wake-On-Voice. We could enable / disable in ASL based on WoV status, or we could just leave it on. Btw I did not see you reset the bit in this patch? -- To view, visit https://review.coreboot.org/22237 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8abc6e9b88b3bc25cf865824aa14b292ac0524ef Gerrit-Change-Number: 22237 Gerrit-PatchSet: 1 Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: rushikesh s kadam <rushikesh.s.kadam(a)intel.com> Gerrit-Comment-Date: Tue, 31 Oct 2017 03:20:13 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intelskylake: enable 8254 Static Clock Gating for XTAL shutdown
by Roy Mingi Park (Code Review) 31 Oct '17

31 Oct '17

Roy Mingi Park has removed Rajneesh Bhardwaj from this change. ( https://review.coreboot.org/22236 ) Change subject: soc/intelskylake: enable 8254 Static Clock Gating for XTAL shutdown ...................................................................... Removed reviewer Rajneesh Bhardwaj. -- To view, visit https://review.coreboot.org/22236 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I87fb6fa86f10be6e3c888dd3590d0e77a2b886e8 Gerrit-Change-Number: 22236 Gerrit-PatchSet: 2 Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.corp-partner.google.com> Gerrit-Reviewer: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: rushikesh s kadam <rushikesh.s.kadam(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/skylake: Turnoff XTAL Disqualification for XTAL Shutdown
by Roy Mingi Park (Code Review) 31 Oct '17

31 Oct '17

Roy Mingi Park has removed Rajneesh Bhardwaj from this change. ( https://review.coreboot.org/22237 ) Change subject: soc/intel/skylake: Turnoff XTAL Disqualification for XTAL Shutdown ...................................................................... Removed reviewer Rajneesh Bhardwaj. -- To view, visit https://review.coreboot.org/22237 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I8abc6e9b88b3bc25cf865824aa14b292ac0524ef Gerrit-Change-Number: 22237 Gerrit-PatchSet: 1 Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: rushikesh s kadam <rushikesh.s.kadam(a)intel.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add RunOnAP support
by build bot (Jenkins) (Code Review) 31 Oct '17

31 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22194 ) Change subject: soc/amd/stoneyridge: Add RunOnAP support ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17712/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62707/ : SUCCESS -- To view, visit https://review.coreboot.org/22194 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30cb2e0c6cc474158f3a7710dbb8ecf54f1ffe4 Gerrit-Change-Number: 22194 Gerrit-PatchSet: 4 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 31 Oct 2017 02:40:23 +0000 Gerrit-HasComments: No

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
178
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2017