the following patch was just integrated into master:
commit 9ef671769bc5be393f356c85359909a56145a912
Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com>
Date: Mon Apr 4 14:24:23 2016 -0500
sb/amd/sp5100: Add ehci_async_data_cache CMOS option
SP5100 devices are affected by an erratum that can lock up the
EHCI ports under certain conditions. Add an optional CMOS
option to enable a workaround at the expense of performance.
Change-Id: I305d23dfa50f10a3dcb5c731e8923305c8956dde
Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com>
Reviewed-on: https://review.coreboot.org/14241
Tested-by: build bot (Jenkins)
Tested-by: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com>
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/14241 for details.
-gerrit
Jonathan Neuschäfer (j.neuschaefer(a)gmx.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14244
-gerrit
commit 1aba292c52013861d9be1a7e4c1c4d00c9e7fd11
Author: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Date: Tue Apr 5 21:36:34 2016 +0200
libpayload/libc: Fix memset/sizeof usage
Since r is a pointer, memset(r, 0, sizeof(r)) would only zero the first
4 (or 8) bytes of the newly allocated struct align_region_t.
An alternative to this patch would be to use calloc, or introduce a new
zalloc (zeroed allocation; a single-element calloc) and use that.
Change-Id: Ic3e3487ce749eeebf6c4836e62b8a305ad766e7e
Found-by: Coverity (ID 1291160)
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
---
payloads/libpayload/libc/malloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/payloads/libpayload/libc/malloc.c b/payloads/libpayload/libc/malloc.c
index 7099e47..b7ac1a7 100644
--- a/payloads/libpayload/libc/malloc.c
+++ b/payloads/libpayload/libc/malloc.c
@@ -366,7 +366,7 @@ static struct align_region_t *allocate_region(int alignment, int num_elements,
if (r == NULL)
return NULL;
- memset(r, 0, sizeof(r));
+ memset(r, 0, sizeof(*r));
if (num_elements != 0) {
r->alignment = alignment;
Iru Cai (mytbk920423(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14257
-gerrit
commit 6edbd3d03b49e2205271df4dcf664012e3d63455
Author: Iru Cai <mytbk920423(a)gmail.com>
Date: Tue Apr 5 23:43:59 2016 +0800
xcompile: rename riscv to riscv64
In newer toolchain with binutils 2.26 and GCC 5.3.0, we build binutils
and GCC with machine type riscv32 and riscv64 instead of riscv. We can
see it in this riscv-gnu-toolchain commit:
https://github.com/riscv/riscv-gnu-toolchain/commit/dedbf07
Signed-off-by: Iru Cai <mytbk920423(a)gmail.com>
Change-Id: Id552859ec256d80108e073d25cd51dd1fc3fbfac
---
util/xcompile/xcompile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index 2b9b818..149a584 100755
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -334,7 +334,7 @@ arch_config_arm64() {
arch_config_riscv() {
TARCH="riscv"
TBFDARCHS="littleriscv"
- TCLIST="riscv"
+ TCLIST="riscv64"
TWIDTH="64"
TABI="elf"
}
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14232
-gerrit
commit 6f9f8d1d228fbc25c9d9215f85953eb631e82839
Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Date: Sun Apr 3 20:52:01 2016 -0700
crossgcc: Fix compilation on clang systems
Most targets have been broken on systems with CLANG being the default
compiler (OS X and some BSDs). CLANG dislikes some of GCC's autogenerated
code. We also missed switching CFLAGS to CXXFLAGS when GCC switched to C++
compilation per default.
Change-Id: I87caa1a15982c431048aa79748ea7ef655a9a3a1
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
---
util/crossgcc/buildgcc | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 525b574..96e4c19 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -18,8 +18,8 @@
cd $(dirname $0)
-CROSSGCC_DATE="March 21st, 2016"
-CROSSGCC_VERSION="1.37"
+CROSSGCC_DATE="April 3rd, 2016"
+CROSSGCC_VERSION="1.38"
# default settings
PACKAGE=GCC
@@ -453,13 +453,20 @@ build_BINUTILS() {
build_GCC() {
+ # Work around crazy code generator in GCC that confuses CLANG.
+ $CC --version | grep clang &>/dev/null &&
+ HOSTCFLAGS="$HOSTCFLAGS -fbracket-depth=1024"
+
# GCC does not honor HOSTCFLAGS at all. CFLAGS are used for
# both target and host object files.
# There's a work-around called CFLAGS_FOR_BUILD and CFLAGS_FOR_TARGET
# but it does not seem to work properly. At least the host library
# libiberty is not compiled with CFLAGS_FOR_BUILD.
+ # Also set the CXX version of the flags because GCC is now compiled
+ # using C++.
CC="$CC" CFLAGS_FOR_TARGET="-O2 -Dinhibit_libc" CFLAGS="$HOSTCFLAGS" \
- CFLAGS_FOR_BUILD="$HOSTCFLAGS" ../gcc-${GCC_VERSION}/configure \
+ CFLAGS_FOR_BUILD="$HOSTCFLAGS" CXXFLAGS="$HOSTCFLAGS" \
+ CXXFLAGS_FOR_BUILD="$HOSTCFLAGS" ../gcc-${GCC_VERSION}/configure \
--prefix=$TARGETDIR --libexecdir=$TARGETDIR/lib \
--target=${TARGETARCH} --disable-werror --disable-shared \
--enable-lto --enable-plugins --enable-gold --enable-ld=default \
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14244
-gerrit
commit b98262213f351dd83b55191da6add8a99b22de34
Author: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Date: Mon Apr 4 19:52:35 2016 +0200
libpayload/libc: Fix memset/sizeof usage
Since r is a pointer, memset(r, 0, sizeof(r)) would only zero the first
4 (or 8) bytes of the newly allocated struct align_region_t.
An alternative to this patch would be to use calloc, or introduce a new
zalloc (zeroed allocation; a single-element calloc) and use that.
This fixes Coverity ID 1291160.
Change-Id: Ic3e3487ce749eeebf6c4836e62b8a305ad766e7e
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
---
payloads/libpayload/libc/malloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/payloads/libpayload/libc/malloc.c b/payloads/libpayload/libc/malloc.c
index 7099e47..b7ac1a7 100644
--- a/payloads/libpayload/libc/malloc.c
+++ b/payloads/libpayload/libc/malloc.c
@@ -366,7 +366,7 @@ static struct align_region_t *allocate_region(int alignment, int num_elements,
if (r == NULL)
return NULL;
- memset(r, 0, sizeof(r));
+ memset(r, 0, sizeof(*r));
if (num_elements != 0) {
r->alignment = alignment;
the following patch was just integrated into master:
commit 1000a5561d0c122e3800896b36767f09f3d96901
Author: Patrick Georgi <pgeorgi(a)google.com>
Date: Thu Mar 31 15:59:41 2016 +0200
chromeos.fmd: Mark RW_LEGACY as CBFS
Change the existing chromeos.fmd files and the dts-to-fmd script to mark
RW_LEGACY as CBFS, so it's properly "formatted".
BUG=chromium:595715
BRANCH=none
TEST=none
Change-Id: I76de26032ea8da0c7755a76a01e7bea9cfaebe23
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
Original-Commit-Id: 717a00c459906fa87f61314ea4541c31b50539f4
Original-Change-Id: I4b037b60d10be3da824c6baecabfd244eec2cdac
Original-Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/336403
Original-Commit-Ready: Patrick Georgi <pgeorgi(a)chromium.org>
Original-Tested-by: Patrick Georgi <pgeorgi(a)chromium.org>
Original-Reviewed-by: Patrick Georgi <pgeorgi(a)chromium.org>
Reviewed-on: https://review.coreboot.org/14240
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/14240 for details.
-gerrit