coreboot-gerrit March 2016

coreboot-gerrit@coreboot.org

1 participants
1119 discussions

New patch to review for coreboot: cpu/x86/16bit/reset16: mark reset vector executable
by Aaron Durbin 02 Mar '16

02 Mar '16

Aaron Durbin (adurbin(a)chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13879 -gerrit commit 802bbb5a3104f383c6daa6a7ffc5c0b7e2efca9e Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed Mar 2 14:55:32 2016 -0600 cpu/x86/16bit/reset16: mark reset vector executable It's helpful to see the reset vector in objdump output. Without it being marked executable it doesn't get displayed. Change-Id: I85cb72ea0727d3f3c2186ae20b9c5cfe5d23aeed Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> --- src/cpu/x86/16bit/reset16.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cpu/x86/16bit/reset16.inc b/src/cpu/x86/16bit/reset16.inc index 2220aab..ebc3d4c 100644 --- a/src/cpu/x86/16bit/reset16.inc +++ b/src/cpu/x86/16bit/reset16.inc @@ -1,4 +1,4 @@ - .section ".reset" + .section ".reset", "ax", %progbits .code16 .globl reset_vector reset_vector:

1 0

New patch to review for coreboot: cpu/x86/16bit/reset16: remove stale 32-bit jump
by Aaron Durbin 02 Mar '16

02 Mar '16

Aaron Durbin (adurbin(a)chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13878 -gerrit commit dae481bc938113509b8d162cb2040314a4d72e86 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed Mar 2 13:42:57 2016 -0600 cpu/x86/16bit/reset16: remove stale 32-bit jump Patrick at least indicated this jump after the reset vector jump was a remnant from some construct used long ago in the project. It's not longer used (nor could I find where it was). Therefore, remove it. Change-Id: I31512c66a9144267739b08d5f9659c4fcde1b794 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> --- src/cpu/x86/16bit/reset16.inc | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/cpu/x86/16bit/reset16.inc b/src/cpu/x86/16bit/reset16.inc index 33712d1..2220aab 100644 --- a/src/cpu/x86/16bit/reset16.inc +++ b/src/cpu/x86/16bit/reset16.inc @@ -10,7 +10,4 @@ reset_vector: * instead of the weird 16 bit relocations that binutils does not * handle consistenly between versions because they are used so rarely. */ - .org 0x8; - .code32 - jmp protected_start .previous

1 0

Patch merged into coreboot/master: nb/intel/sandybridge/romstage: Read fuse bits for max MEM Clk
by gerrit＠coreboot.org 02 Mar '16

02 Mar '16

the following patch was just integrated into master: commit 9f3f9154c9f3dd1e3cfbd2703b681c3e9ddf4dc7 Author: Patrick Rudolph <siro(a)das-labor.org> Date: Tue Jan 26 20:02:14 2016 +0100 nb/intel/sandybridge/romstage: Read fuse bits for max MEM Clk Instead of hardcoding the maximum supported DDR frequency to 800Mhz (DDR3-1600), read the fuse bits that encode this information. Test system: * Intel IvyBridge * Gigabyte GA-B75M-D3H Change-Id: I515a2695a490f16aeb946bfaf3a1e860c607cba9 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> Reviewed-on: https://review.coreboot.org/13487 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> See https://review.coreboot.org/13487 for details. -gerrit

1 0

Patch merged into coreboot/master: src/arch/x86/smbios: Add vendors
by gerrit＠coreboot.org 02 Mar '16

02 Mar '16

the following patch was just integrated into master: commit 2bdeb7f843c707023ea2bd39e314f8eec51c7add Author: Patrick Rudolph <siro(a)das-labor.org> Date: Mon Feb 29 19:19:46 2016 +0100 src/arch/x86/smbios: Add vendors Add more manufacturer IDs for vendor: * GSkill * OCZ * Transcend Change-Id: Ic7df76b1310b2c1abea9c5d2d8fd688cb2a713b8 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> Reviewed-on: https://review.coreboot.org/13863 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See https://review.coreboot.org/13863 for details. -gerrit

1 0

Patch merged into coreboot/master: nb/intel/sandybridge/raminit: Make discover_timC_write non cyclic
by gerrit＠coreboot.org 02 Mar '16

02 Mar '16

the following patch was just integrated into master: commit 77e45d3eccc5cf82a2b4d4d1cd47654dec1962b4 Author: Patrick Rudolph <siro(a)das-labor.org> Date: Sun Feb 28 16:14:45 2016 +0100 nb/intel/sandybridge/raminit: Make discover_timC_write non cyclic The code can't handle cyclic zero runs. Make sure it will never wrap around by setting the top-most bit to constant one. Fixes "Mini channel test failed (2)". Test system: * Gigabyte GA-B75M-D3H * Intel Pentium CPU G2130 Change-Id: I55e610d984d564bd4675f9318dead6d6c1e288a3 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> Reviewed-on: https://review.coreboot.org/13853 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> See https://review.coreboot.org/13853 for details. -gerrit

1 0

New patch to review for coreboot: lint-kconfig: pipe stderr to stdout to catch script errors
by Martin Roth 02 Mar '16

02 Mar '16

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13877 -gerrit commit 8126f989e44edcf7e820eda91db396338fdfaeea Author: Martin Roth <martinroth(a)google.com> Date: Wed Mar 2 13:19:07 2016 -0700 lint-kconfig: pipe stderr to stdout to catch script errors Because the perl error messages go to stderr, we were not catching these on the build server. If the script has an issue, we want to know immediately, so change the bash script that calls into the perl lint tool to pipe these to stdout. Change-Id: Ieeec9ccbd59177cfd1859a9738a4ee1fab803d28 Signed-off-by: Martin Roth <martinroth(a)google.com> --- util/lint/lint-stable-008-kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/lint/lint-stable-008-kconfig b/util/lint/lint-stable-008-kconfig index 986fdc9..06e41b8 100755 --- a/util/lint/lint-stable-008-kconfig +++ b/util/lint/lint-stable-008-kconfig @@ -24,7 +24,7 @@ fi # If coreboot is in a git repo, use git grep to check as it will ignore any # files in the tree that aren't checked into git if [ -n "$(command -v git)" ] && [ -e ".git" ]; then - env perl util/lint/kconfig_lint --warnings_off + env perl util/lint/kconfig_lint --warnings_off 2>&1 else - env perl util/lint/kconfig_lint --no_git_grep --warnings_off + env perl util/lint/kconfig_lint --no_git_grep --warnings_off 2>&1 fi

1 0

New patch to review for coreboot: kconfig_lint: make sure if and endif statements are balanced
by Martin Roth 02 Mar '16

02 Mar '16

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13876 -gerrit commit 0b658c58801957b12ef8f2008906293269d2d45b Author: Martin Roth <martinroth(a)google.com> Date: Wed Mar 2 12:16:13 2016 -0700 kconfig_lint: make sure if and endif statements are balanced In Kconfig files, the 'if' and 'endif' statements need to match up. A file can't start an if statement that's completed in the next file. Add a check as the files are being parsed to make sure that they match up correctly. Change-Id: If51207ea037089ab84c768e5a868270468cf4c4f Signed-off-by: Martin Roth <martinroth(a)google.com> --- util/lint/kconfig_lint | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 38fa968..c955343 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -447,6 +447,7 @@ sub build_and_parse_kconfig_tree { my @inside_menu = (); # stack of menu names my $inside_choice = ""; my $configs_inside_choice; + my %fileinfo; #start the tree off by loading the top level kconfig @config_to_parse = load_kconfig_file( $top_level_kconfig, "", 0, 0, "", 0 ); @@ -601,12 +602,14 @@ sub build_and_parse_kconfig_tree { my $expr = $1; push( @inside_if, $expr ); handle_expressions( $expr, $inside_config, $filename, $line_no ); + $fileinfo{$filename}{iflevel}++; } # endif elsif ( $line =~ /^\s*endif/ ) { $inside_config = ""; pop(@inside_if); + $fileinfo{$filename}{iflevel}--; } #range <symbol> <symbol> [if <expr>] @@ -665,6 +668,16 @@ sub build_and_parse_kconfig_tree { } push @wholeconfig, @parseline; } + + foreach my $file ( keys %fileinfo ) { + if ( $fileinfo{$file}{iflevel} > 0 ) { + show_error("$file has $fileinfo{$file}{iflevel} more 'if' statement(s) than 'endif' statements."); + } + elsif ( $fileinfo{$file}{iflevel} < 0 ) { + show_error( + "$file has " . ( $fileinfo{$file}{iflevel} * -1 ) . " more 'endif' statement(s) than 'if' statements." ); + } + } } #-------------------------------------------------------------------------------

1 0

Patch merged into coreboot/master: crossgcc: add 'urls' option to print urls of all packages
by gerrit＠coreboot.org 02 Mar '16

02 Mar '16

the following patch was just integrated into master: commit 58c68d56de30c8681facbbecf7a2f08c8ebb3355 Author: Martin Roth <martinroth(a)google.com> Date: Tue Mar 1 15:22:42 2016 -0700 crossgcc: add 'urls' option to print urls of all packages This should allow the builder to download the packages securely. Change-Id: If5feeff85bd551cbe08849421197d11cc2432d1e Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/13867 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/13867 for details. -gerrit

1 0

Patch set updated for coreboot: buildgcc: Bump version to 1.36
by Stefan Reinauer 02 Mar '16

02 Mar '16

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13873 -gerrit commit b03ccddbe551d8d939deafa8c8d17ef9692d781e Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Tue Mar 1 22:34:34 2016 -0800 buildgcc: Bump version to 1.36 Numerous changes have gone in since the last bump, let's increase the version. Change-Id: Ie3ae8c24b26bd22b70bc5ddf5c1125b5b1d3a021 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- util/crossgcc/buildgcc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 679c0ef..df9ac4a 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -18,8 +18,8 @@ cd $(dirname $0) -CROSSGCC_DATE="January 29th, 2016" -CROSSGCC_VERSION="1.35" +CROSSGCC_DATE="March 1st, 2016" +CROSSGCC_VERSION="1.36" # default settings PACKAGE=GCC

1 0

Patch set updated for coreboot: crossgcc: add 'urls' option to print urls of all packages
by Stefan Reinauer 02 Mar '16

02 Mar '16

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13867 -gerrit commit c9b184ab6ba4e64a5b08b017b4bb7939d7044f9e Author: Martin Roth <martinroth(a)google.com> Date: Tue Mar 1 15:22:42 2016 -0700 crossgcc: add 'urls' option to print urls of all packages This should allow the builder to download the packages securely. Change-Id: If5feeff85bd551cbe08849421197d11cc2432d1e Signed-off-by: Martin Roth <martinroth(a)google.com> --- util/crossgcc/buildgcc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index e0ef981..679c0ef 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -64,6 +64,11 @@ CRT_ARCHIVE="http://llvm.org/releases/${CLANG_VERSION}/compiler-rt-${CLANG_VERSI CTE_ARCHIVE="http://llvm.org/releases/${CLANG_VERSION}/clang-tools-extra-${CLANG_VERSION…" MAKE_ARCHIVE="http://ftpmirror.gnu.org/make/make-${MAKE_VERSION}.tar.bz2" +ALL_ARCHIVES="$GMP_ARCHIVE $MPFR_ARCHIVE $MPC_ARCHIVE $LIBELF_ARCHIVE \ + $GCC_ARCHIVE $BINUTILS_ARCHIVE $GDB_ARCHIVE $IASL_ARCHIVE \ + $PYTHON_ARCHIVE $EXPAT_ARCHIVE $LLVM_ARCHIVE $CFE_ARCHIVE \ + $CRT_ARCHIVE $CTE_ARCHIVE $MAKE_ARCHIVE" + # GCC toolchain directories GMP_DIR="gmp-${GMP_VERSION}" MPFR_DIR="mpfr-${MPFR_VERSION}" @@ -316,6 +321,7 @@ myhelp() printf " [-t|--savetemps] don't remove temporary files after build\n" printf " [-y|--ccache] Use ccache when building cross compiler\n" printf " [--nocolor] don't print color codes in output\n" + printf " [--urls] print the urls for all packages\n" printf " [-j|--jobs <num>] run <num> jobs in parallel in make\n" printf " [-s]--supported <tool> print supported version of a tool" printf " [-d|--directory <target dir>] target directory to install cross compiler to\n" @@ -590,6 +596,7 @@ while true ; do -S|--scripting) shift; SKIPPYTHON=0;; -y|--ccache) shift; USECCACHE=1;; -s|--supported) shift; PRINTSTABLE="$1"; shift;; + --urls) shift; printf "%s\n" "$ALL_ARCHIVES"; exit 0;; --nocolor) shift; \ unset red RED green GREEN blue BLUE cyan CYAN NC;; --) shift; break;;

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2016