January 2016 - coreboot-gerrit

New patch to review for coreboot: Experiment with circular
by Vladimir Serbinenko Jan. 30, 2016

Jan. 30, 2016

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13527 -gerrit commit fa266bfd17a2e248c59651f09bd4e1b0fa28d693 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sat Jan 30 17:50:41 2016 +0100 Experiment with circular Change-Id: I67c428524f71db88757ead7fc7b1634c0b40728e --- src/northbridge/intel/sandybridge/raminit.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c index 8a287c1..fdfa7cd 100644 --- a/src/northbridge/intel/sandybridge/raminit.c +++ b/src/northbridge/intel/sandybridge/raminit.c @@ -1670,14 +1670,14 @@ struct run { int length; }; -static struct run get_longest_zero_run(int *seq, int sz) +static struct run get_longest_zero_run(int *seq, int sz, int circular) { int i, ls; int bl = 0, bs = 0; struct run ret; ls = 0; - for (i = 0; i < 2 * sz; i++) + for (i = 0; i < (1 + circular) * sz; i++) if (seq[i % sz]) { if (i - ls > bl) { bl = i - ls; @@ -1726,7 +1726,7 @@ static void discover_timA_coarse(ramctr_timing * ctrl, int channel, } } FOR_ALL_LANES { - struct run rn = get_longest_zero_run(statistics[lane], 128); + struct run rn = get_longest_zero_run(statistics[lane], 128. 1); ctrl->timings[channel][slotrank].lanes[lane].timA = rn.middle; upperA[lane] = rn.end; if (upperA[lane] < rn.middle) @@ -2106,7 +2106,7 @@ static void discover_timC(ramctr_timing * ctrl, int channel, int slotrank) } FOR_ALL_LANES { struct run rn = - get_longest_zero_run(statistics[lane], MAX_TIMC + 1); + get_longest_zero_run(statistics[lane], MAX_TIMC + 1, 1); ctrl->timings[channel][slotrank].lanes[lane].timC = rn.middle; if (rn.all) printk(BIOS_CRIT, "timC discovery failed"); @@ -2333,7 +2333,7 @@ static void discover_timB(ramctr_timing * ctrl, int channel, int slotrank) } } FOR_ALL_LANES { - struct run rn = get_longest_zero_run(statistics[lane], 128); + struct run rn = get_longest_zero_run(statistics[lane], 128, 0); ctrl->timings[channel][slotrank].lanes[lane].timB = rn.start; if (rn.all) die("timB discovery failed"); @@ -2821,7 +2821,7 @@ static int try_cmd_stretch(ramctr_timing * ctrl, int cmd_stretch) } FOR_ALL_POPULATED_RANKS { struct run rn = - get_longest_zero_run(stat[slotrank], 255); + get_longest_zero_run(stat[slotrank], 255, 1); ctrl->timings[channel][slotrank].val_320c = rn.middle - 127; printram("3val: %d, %d: %d\n", channel, @@ -2933,7 +2933,7 @@ static void discover_edges_real(ramctr_timing * ctrl, int channel, int slotrank, } FOR_ALL_LANES { struct run rn = - get_longest_zero_run(statistics[lane], MAX_EDGE_TIMING + 1); + get_longest_zero_run(statistics[lane], MAX_EDGE_TIMING + 1, 1); edges[lane] = rn.middle; if (rn.all) die("edge discovery failed"); @@ -3233,7 +3233,7 @@ static void discover_edges_write_real(ramctr_timing * ctrl, int channel, statistics[edge] = ! !(raw_statistics[edge] & (1 << lane)); rn = get_longest_zero_run(statistics, - MAX_EDGE_TIMING + 1); + MAX_EDGE_TIMING + 1, 1); printram("edges: %d, %d, %d: 0x%x-0x%x-0x%x, 0x%x-0x%x\n", channel, slotrank, i, rn.start, rn.middle, rn.end, rn.start + ctrl->edge_offset[i], @@ -3391,7 +3391,7 @@ static void discover_timC_write(ramctr_timing * ctrl) !!(raw_statistics[timC] & (1 << lane)); rn = get_longest_zero_run(statistics, - MAX_TIMC + 1); + MAX_TIMC + 1, 1); if (rn.all) die("timC write discovery failed"); printram("timC: %d, %d, %d: 0x%x-0x%x-0x%x, 0x%x-0x%x\n",

1 0

Patch set updated for coreboot: Makefile: Add a comment to fix syntax highlighting
by Martin Roth Jan. 30, 2016

Jan. 30, 2016

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13435 -gerrit commit 107d0a829fca5f25c559559d5c620e23154b1264 Author: Martin Roth <martinroth(a)google.com> Date: Mon Jan 25 15:59:24 2016 -0700 Makefile: Add a comment to fix syntax highlighting Trivial fix for syntax highlighting in editors. Some get confused by the double quote that doesn't have a close quote and stop highlighting at that point. This comment closes the quote and the paren pair so that they can recover. Change-Id: I566e8e0f4412009f679ab079f20ae30c2049b502 Signed-off-by: Martin Roth <martinroth(a)google.com> --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index c46c4d8..08a5460 100644 --- a/Makefile +++ b/Makefile @@ -153,6 +153,7 @@ endif include toolchain.inc strip_quotes = $(strip $(subst ",,$(subst \",,$(1)))) +# fix makefile syntax highlighting after strip macro \" ")) # The primary target needs to be here before we include the # other files

1 0

Patch merged into coreboot/master: kconfig_lint: Add readme document
by gerrit＠coreboot.org Jan. 30, 2016

Jan. 30, 2016

the following patch was just integrated into master: commit b5400ad412e1c8e6dba7d9f25d3eb7a5ba96d193 Author: Martin Roth <martinroth(a)google.com> Date: Mon Jan 25 20:10:14 2016 -0700 kconfig_lint: Add readme document The readme describes the operation and usage of kconfig_lint. It also lists all the notes, warnings, and errors that kconfig_lint looks for. Change-Id: I873f394ff93fce42cd9638cbbad6134f1aef3a6a Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/13464 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/13464 for details. -gerrit

1 0

Patch merged into coreboot/master: kconfig_lint: add comments and whitespace fixes.
by gerrit＠coreboot.org Jan. 30, 2016

Jan. 30, 2016

the following patch was just integrated into master: commit 08cf90f860604b4ef26d4740ae985f550f6bad90 Author: Martin Roth <martinroth(a)google.com> Date: Mon Jan 25 19:54:16 2016 -0700 kconfig_lint: add comments and whitespace fixes. No functional changes. Change-Id: I40284b68ddda7e19741c5306a8c74761c00e4b35 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/13463 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/13463 for details. -gerrit

1 0

Patch merged into coreboot/master: kconfig_lint: Skip temp files when looking for unused Kconfig files.
by gerrit＠coreboot.org Jan. 30, 2016

Jan. 30, 2016

the following patch was just integrated into master: commit ab2d777360e8105007eef2911db26fd23c1ead14 Author: Martin Roth <martinroth(a)google.com> Date: Mon Jan 25 16:45:14 2016 -0700 kconfig_lint: Skip temp files when looking for unused Kconfig files. Don't warn on Kconfig.orig and Kconfig~ files when trying to verify that all the Kconfig files in the coreboot source tree are being loaded. Change-Id: Ie7babe60b29735e5ccc5f93f4e42ad82dfb47044 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/13462 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/13462 for details. -gerrit

1 0

Patch merged into coreboot/master: kconfig_lint: Update prompt structure
by gerrit＠coreboot.org Jan. 30, 2016

Jan. 30, 2016

the following patch was just integrated into master: commit b58d349ca92b19869aaf9add81e83d37cad83a7a Author: Martin Roth <martinroth(a)google.com> Date: Mon Jan 25 16:42:13 2016 -0700 kconfig_lint: Update prompt structure - The prompts were not getting incremented, so each prompt for a symbol would overwrite the previous. - Record the menu each prompt is in. Change-Id: Ia282a30344d5e135f4f2027be9aff0e49a4e5edb Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/13461 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/13461 for details. -gerrit

1 0

Patch merged into coreboot/master: kconfig_lint: Add warning if tristate type is used in coreboot
by gerrit＠coreboot.org Jan. 30, 2016

Jan. 30, 2016

the following patch was just integrated into master: commit 08ee1cfafc2464cbeccaf3ede553b4c4e9b66367 Author: Martin Roth <martinroth(a)google.com> Date: Mon Jan 25 16:39:32 2016 -0700 kconfig_lint: Add warning if tristate type is used in coreboot Although there's no reason we COULDN'T use tristate types, we haven't up to this point. If there's a good reason to use them in the future, this check can be removed. Change-Id: I5f1903341f522bc957e394bc0fd288ba1adab431 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/13460 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/13460 for details. -gerrit

1 0

Patch merged into coreboot/master: kconfig_lint: merge 'git grep' and 'grep' exclude dir and files
by gerrit＠coreboot.org Jan. 30, 2016

Jan. 30, 2016

the following patch was just integrated into master: commit 819e67242fa632f465f002396dc7adaec9418ab3 Author: Martin Roth <martinroth(a)google.com> Date: Mon Jan 25 16:38:05 2016 -0700 kconfig_lint: merge 'git grep' and 'grep' exclude dir and files The code had originally been using standard grep to look through the coreboot tree for Kconfig symbols. When this was switched to git grep, the --exclude-dir options didn't work, and nothing was added to exclude the directories that shouldn't be searched for symbols. This resulted in invalid warnings as it searched directories that had Kconfig symbols for other projects. This merges the exclusion list for both the regular and git versions of grep for consistent behavior. Change-Id: I7fed8b9fa827cb14f7373e7b774acc56e43cb6ff Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/13459 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/13459 for details. -gerrit

1 0

Patch merged into coreboot/master: kconfig_lint: Don't look at IS_ENABLED() text in comments.
by gerrit＠coreboot.org Jan. 30, 2016

Jan. 30, 2016

the following patch was just integrated into master: commit 572a856b97b25e359c1468cf1b059210728b3762 Author: Martin Roth <martinroth(a)google.com> Date: Mon Jan 25 16:14:09 2016 -0700 kconfig_lint: Don't look at IS_ENABLED() text in comments. This fixes at least one kconfig_lint warning. Change-Id: I35edf57e90315a8372aaf3b41e923cd8dad7386a Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/13458 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/13458 for details. -gerrit

1 0

Patch merged into coreboot/master: kconfig_lint: Exclude some Kconfig symbols from unused symbol checks
by gerrit＠coreboot.org Jan. 30, 2016

Jan. 30, 2016

the following patch was just integrated into master: commit 6bfbf1c66fe321da5f7c6c8f815ea3d75107ed09 Author: Martin Roth <martinroth(a)google.com> Date: Mon Jan 25 16:12:49 2016 -0700 kconfig_lint: Exclude some Kconfig symbols from unused symbol checks The configuration that coreboot uses for setting selected symbols typically involves a structure like this: config BLEH_SPECIFIC_OPTIONS def_bool y select SYMBOL This leads to an an extra kconfig symbol BLEH_SPECIFIC_OPTIONS that is never referenced by anything else, generating a warning. Since this is currently the construct that coreboot uses, filter it out of the warnings for now. Change-Id: I85a95e4c4e8469870c7f219f2a92955819845573 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/13457 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/13457 for details. -gerrit

1 0