Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11728
-gerrit
commit 437fc2efcc2f692002d9de8fcdf42efd140fde68
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sat Sep 26 13:15:15 2015 +0200
[NOTFORMERGE] src/Kconfig: Enable code coverage by default
Change-Id: I3f1860004ccdaa429cfa0b531764e7e9027f0044
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/Kconfig b/src/Kconfig
index 2c75750..74a032e 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -210,7 +210,7 @@ config USE_BLOBS
config COVERAGE
bool "Code coverage support"
depends on COMPILER_GCC
- default n
+ default y
help
Add code coverage support for coreboot. This will store code
coverage information in CBMEM for extraction from user space.
@@ -1028,7 +1028,7 @@ config TRACE
config DEBUG_COVERAGE
bool "Debug code coverage"
- default n
+ default y
depends on COVERAGE
help
If enabled, the code coverage hooks in coreboot will output some
Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11729
-gerrit
commit d3760c573f38da7d01b6b5545197465c36d28f68
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Sun Sep 27 13:45:17 2015 +0200
program.ld: terminate ALIGN statement
This fixes building with CONFIG_COVERAGE=y
Change-Id: I5128ae0ef0d4f71e3ede7bcb3ee7ed7e265d1bb7
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
src/lib/program.ld | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/program.ld b/src/lib/program.ld
index ab36239..4c24231 100644
--- a/src/lib/program.ld
+++ b/src/lib/program.ld
@@ -69,7 +69,7 @@
#if ENV_RAMSTAGE && IS_ENABLED(CONFIG_COVERAGE)
.ctors . : {
- . = ALIGN(0x100)
+ . = ALIGN(0x100);
__CTOR_LIST__ = .;
KEEP(*(.ctors));
LONG(0);
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11728
-gerrit
commit 4a2c5c1c8182d77f79501fc41833efc8b87ebfff
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sat Sep 26 13:15:15 2015 +0200
[NOTFORMERGE] src/Kconfig: Enable code coverage by default
Change-Id: I3f1860004ccdaa429cfa0b531764e7e9027f0044
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Kconfig b/src/Kconfig
index 2c75750..fa74050 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -1028,7 +1028,7 @@ config TRACE
config DEBUG_COVERAGE
bool "Debug code coverage"
- default n
+ default y
depends on COVERAGE
help
If enabled, the code coverage hooks in coreboot will output some
Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11711
-gerrit
commit 13a2325d800b1a0aeacf96ac730bdef97a4c62ab
Author: zbao <fishbaozi(a)gmail.com>
Date: Sat Sep 26 06:49:47 2015 -0400
util/kconfig: fill glob_t with 0 before calling glob
On mingw, the function glob has some default options
which are not compliant with man page.
If gl_offs is not set as 0, there may be some slots which
is reserved.
If gl_pathc or gl_pathv is not set as 0, the result might
be appended to the list instead of being added as new ones.
Change-Id: I03110c4cdda70578828d6499262a085a81d26313
Signed-off-by: Zheng Bao <zheng.bao(a)amd.com>
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
util/kconfig/zconf.l | 3 +++
util/kconfig/zconf.lex.c_shipped | 3 +++
2 files changed, 6 insertions(+)
diff --git a/util/kconfig/zconf.l b/util/kconfig/zconf.l
index b6bed02..54c48ff 100644
--- a/util/kconfig/zconf.l
+++ b/util/kconfig/zconf.l
@@ -343,6 +343,9 @@ void zconf_nextfiles(const char *wildcard)
char **w;
int i;
+ g.gl_pathc = 0;
+ g.gl_pathv = NULL;
+ g.gl_offs = 0;
if (glob(wildcard, 0, NULL, &g) != 0) {
return;
}
diff --git a/util/kconfig/zconf.lex.c_shipped b/util/kconfig/zconf.lex.c_shipped
index cf05b19..99a437b 100644
--- a/util/kconfig/zconf.lex.c_shipped
+++ b/util/kconfig/zconf.lex.c_shipped
@@ -2421,6 +2421,9 @@ void zconf_nextfiles(const char *wildcard)
char **w;
int i;
+ g.gl_pathc = 0;
+ g.gl_pathv = NULL;
+ g.gl_offs = 0;
if (glob(wildcard, 0, NULL, &g) != 0) {
return;
}
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11727
-gerrit
commit 6b1bd82b7055c17b5ccfcae8fbf44a0ba15ce70a
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sat Sep 26 12:30:08 2015 +0200
libpayload/Kconfig: Use official spelling for TinyCurses
TinyCursess is officially spelled in CamelCase [1].
[1] https://github.com/tommyettinger/TinyCurses
Change-Id: I7e0aa5af54140796a981c0f4c58950b25fdd67ba
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
payloads/libpayload/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/payloads/libpayload/Kconfig b/payloads/libpayload/Kconfig
index 64289b3..024fa15 100644
--- a/payloads/libpayload/Kconfig
+++ b/payloads/libpayload/Kconfig
@@ -143,9 +143,9 @@ choice
depends on CURSES
config TINYCURSES
- bool "Tinycurses"
+ bool "TinyCurses"
help
- Tinycurses was the first curses implementation for libpayload.
+ TinyCurses was the first curses implementation for libpayload.
It features low memory consumption, static allocation of larger
data structures (so few or no memory allocation calls) and a
reduced feature set.
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11726
-gerrit
commit 6fc4d02c7ff6f21ec87f8b623ca810a476ceb9e0
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sat Sep 26 12:27:41 2015 +0200
libpayload/configs: Add default configuration with TinyCurses enabled
Change-Id: Ib057e2b5f15b8d5bcdf45666f8761614317d25ee
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
payloads/libpayload/configs/defconfig-tinycurses | 80 ++++++++++++++++++++++++
1 file changed, 80 insertions(+)
diff --git a/payloads/libpayload/configs/defconfig-tinycurses b/payloads/libpayload/configs/defconfig-tinycurses
new file mode 100644
index 0000000..f876903
--- /dev/null
+++ b/payloads/libpayload/configs/defconfig-tinycurses
@@ -0,0 +1,80 @@
+#
+# Automatically generated file; DO NOT EDIT.
+# Libpayload Configuration
+#
+
+#
+# Generic Options
+#
+# CONFIG_LP_GPL is not set
+# CONFIG_LP_EXPERIMENTAL is not set
+# CONFIG_LP_DEVELOPER is not set
+CONFIG_LP_COMPILER_GCC=y
+# CONFIG_LP_COMPILER_LLVM_CLANG is not set
+# CONFIG_LP_CHROMEOS is not set
+
+#
+# Architecture Options
+#
+# CONFIG_LP_ARCH_ARM is not set
+CONFIG_LP_ARCH_X86=y
+# CONFIG_LP_ARCH_ARM64 is not set
+# CONFIG_LP_ARCH_MIPS is not set
+# CONFIG_LP_MEMMAP_RAM_ONLY is not set
+CONFIG_LP_MULTIBOOT=y
+
+#
+# Standard Libraries
+#
+CONFIG_LP_LIBC=y
+CONFIG_LP_CURSES=y
+CONFIG_LP_TINYCURSES=y
+# CONFIG_LP_PDCURSES is not set
+CONFIG_LP_CBFS=y
+CONFIG_LP_LZMA=y
+CONFIG_LP_LZ4=y
+
+#
+# Console Options
+#
+# CONFIG_LP_SKIP_CONSOLE_INIT is not set
+CONFIG_LP_CBMEM_CONSOLE=y
+CONFIG_LP_SERIAL_CONSOLE=y
+CONFIG_LP_8250_SERIAL_CONSOLE=y
+# CONFIG_LP_S5P_SERIAL_CONSOLE is not set
+# CONFIG_LP_8250_MMIO32_SERIAL_CONSOLE is not set
+# CONFIG_LP_IPQ806X_SERIAL_CONSOLE is not set
+# CONFIG_LP_BG4CD_SERIAL_CONSOLE is not set
+# CONFIG_LP_PL011_SERIAL_CONSOLE is not set
+CONFIG_LP_SERIAL_IOBASE=0x3f8
+# CONFIG_LP_SERIAL_SET_SPEED is not set
+# CONFIG_LP_SERIAL_ACS_FALLBACK is not set
+CONFIG_LP_VIDEO_CONSOLE=y
+CONFIG_LP_VGA_VIDEO_CONSOLE=y
+# CONFIG_LP_GEODELX_VIDEO_CONSOLE is not set
+# CONFIG_LP_COREBOOT_VIDEO_CONSOLE is not set
+CONFIG_LP_PC_KEYBOARD=y
+CONFIG_LP_PC_KEYBOARD_LAYOUT_US=y
+# CONFIG_LP_PC_KEYBOARD_LAYOUT_DE is not set
+
+#
+# Drivers
+#
+CONFIG_LP_PCI=y
+CONFIG_LP_NVRAM=y
+# CONFIG_LP_RTC_PORT_EXTENDED_VIA is not set
+CONFIG_LP_SPEAKER=y
+CONFIG_LP_STORAGE=y
+# CONFIG_LP_STORAGE_64BIT_LBA is not set
+CONFIG_LP_STORAGE_ATA=y
+CONFIG_LP_STORAGE_ATAPI=y
+CONFIG_LP_STORAGE_AHCI=y
+CONFIG_LP_STORAGE_AHCI_ONLY_TESTED=y
+CONFIG_LP_TIMER_RDTSC=y
+# CONFIG_LP_USB is not set
+# CONFIG_LP_USB_GEN_HUB is not set
+# CONFIG_LP_UDC is not set
+# CONFIG_LP_BIG_ENDIAN is not set
+CONFIG_LP_LITTLE_ENDIAN=y
+CONFIG_LP_IO_ADDRESS_SPACE=y
+CONFIG_LP_ARCH_SPECIFIC_OPTIONS=y
Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11725
-gerrit
commit 719e295d8fdde1f93c31ad13b3e5f3bf031a4766
Author: zbao <fishbaozi(a)gmail.com>
Date: Sat Sep 26 06:24:09 2015 -0400
kconfig: Some terms or curses libraries treat backspace as 0x08
Change-Id: I8e4ea493afa88019fd299651af1df2fb992ab97b
Signed-off-by: Zheng Bao <zheng.bao(a)amd.com>
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
util/kconfig/lxdialog/inputbox.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/kconfig/lxdialog/inputbox.c b/util/kconfig/lxdialog/inputbox.c
index d58de1d..2ec124e 100644
--- a/util/kconfig/lxdialog/inputbox.c
+++ b/util/kconfig/lxdialog/inputbox.c
@@ -127,6 +127,7 @@ do_resize:
break;
case KEY_BACKSPACE:
case 127:
+ case '\b':
if (pos) {
wattrset(dialog, dlg.inputbox.atr);
if (input_x == 0) {
Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11723
-gerrit
commit 95bbe14cc6f48aadbaa5da4ebd372584effeb807
Author: zbao <fishbaozi(a)gmail.com>
Date: Sat Sep 26 06:20:53 2015 -0400
util/kconfig: Set parameter of mkdir to only one for mingw.
Change-Id: I88e317f075e8a39f0a280b3dd6e597d119f0f741
Signed-off-by: Zheng Bao <zheng.bao(a)amd.com>
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
util/kconfig/confdata.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/util/kconfig/confdata.c b/util/kconfig/confdata.c
index 5804b29..02e3ac3 100644
--- a/util/kconfig/confdata.c
+++ b/util/kconfig/confdata.c
@@ -27,6 +27,10 @@ static int conf_lineno, conf_warnings, conf_unsaved;
const char conf_defname[] = "arch/$ARCH/defconfig";
+#ifdef __MINGW32__
+#define mkdir(_n,_p) mkdir((_n))
+#endif
+
static void conf_warning(const char *fmt, ...)
{
va_list ap;