coreboot-gerrit May 2015

coreboot-gerrit@coreboot.org

1 participants
1299 discussions

Patch merged into coreboot/master: 786b122 arm64: Reorganize payload entry code and related Kconfigs
by gerrit＠coreboot.org 19 May '15

19 May '15

the following patch was just integrated into master: commit 786b1224795b76889e5eb10644b5102646f4c24b Author: Julius Werner <jwerner(a)chromium.org> Date: Thu May 7 16:59:31 2015 -0700 arm64: Reorganize payload entry code and related Kconfigs This patch slightly reorganizes arm64/boot.c with the aim of being more readable: the secure monitor entry is now guarded by an explicit if statement for its Kconfig rather than hiding than in the corresponding header file. This makes it clear that there are two (soon three) separate code paths here. Change-Id: I44993da7a982b08f485b93ffc522d193bb3fa118 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Original-Commit-Id: 5067e47bc03f04ad2dba044f022716e0fc62bb9e Original-Change-Id: I1b2038acc0d054716a3c580ce97ea8e9a45abfa2 Original-Signed-off-by: Julius Werner <jwerner(a)chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/270783 Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/10243 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/10243 for details. -gerrit

1 0

Patch merged into coreboot/master: f1df50e arm64: Reorganize payload entry code and related Kconfigs
by gerrit＠coreboot.org 19 May '15

19 May '15

the following patch was just integrated into master: commit f1df50edf3dd9b605f35495287101e8708a69d33 Author: Julius Werner <jwerner(a)chromium.org> Date: Thu May 7 16:59:31 2015 -0700 arm64: Reorganize payload entry code and related Kconfigs Rename Kconfig options for secmon and spintable to be prefixed with ARM64_ instead of ARCH_, which seems to be the standard throughout the rest of coreboot (e.g. ARM_LPAE or X86_BOOTBLOCK_SIMPLE). I think this provides a clearer separation between generic options that are selected by the architecture (e.g. a hypothetical ARCH_HAS_FEATURE_X similar to some of the MAINBOARD_HAS_... we have) and options that only make sense in the context of a single architecture. Change-Id: I38c2efab833f252adbb7b61ef0af60ab25b768b0 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Original-Commit-Id: 5067e47bc03f04ad2dba044f022716e0fc62bb9e Original-Change-Id: I1b2038acc0d054716a3c580ce97ea8e9a45abfa2 Original-Signed-off-by: Julius Werner <jwerner(a)chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/270783 Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/10242 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/10242 for details. -gerrit

1 0

Patch merged into coreboot/master: 75515ea arm64: Reorganize payload entry code and related Kconfigs
by gerrit＠coreboot.org 19 May '15

19 May '15

the following patch was just integrated into master: commit 75515eaa4ba73136fc366b519309a99c0d1e34f2 Author: Julius Werner <jwerner(a)chromium.org> Date: Thu May 7 16:59:31 2015 -0700 arm64: Reorganize payload entry code and related Kconfigs The secure monitor entry is now guarded by an explicit if statement for its Kconfig rather than hiding than in the corresponding header file. This makes it clear that there are two (soon three) separate code paths here. Similar change for the optional spintable feature in the "legacy" payload entry path. [pg: split out from the patch linked below] Change-Id: Ia1554959b3268b718a9606e2f79d8f22f336c94d Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Original-Commit-Id: 5067e47bc03f04ad2dba044f022716e0fc62bb9e Original-Change-Id: I1b2038acc0d054716a3c580ce97ea8e9a45abfa2 Original-Signed-off-by: Julius Werner <jwerner(a)chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/270783 Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/10248 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/10248 for details. -gerrit

1 0

Patch merged into coreboot/master: 59e7b42 arm64: Reorganize payload entry code and related Kconfigs
by gerrit＠coreboot.org 19 May '15

19 May '15

the following patch was just integrated into master: commit 59e7b42af7984ad87638b2b639e9022d6483ed3a Author: Julius Werner <jwerner(a)chromium.org> Date: Thu May 7 16:59:31 2015 -0700 arm64: Reorganize payload entry code and related Kconfigs Remove the secmon Kconfig guard from Makefiles that add to the secmon class since they are redundant (the class is simply not used when compiling without secmon) to improve readability/ease-of-use. [pg: taken out of the patch linked below] Change-Id: I2f0ad8a923ca32fcade748ac8ee50c23cf9bafb9 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Original-Commit-Id: 5067e47bc03f04ad2dba044f022716e0fc62bb9e Original-Change-Id: I1b2038acc0d054716a3c580ce97ea8e9a45abfa2 Original-Signed-off-by: Julius Werner <jwerner(a)chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/270783 Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/10241 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/10241 for details. -gerrit

1 0

Patch merged into coreboot/master: 404df44 arm64: Reorganize payload entry code and related Kconfigs
by gerrit＠coreboot.org 19 May '15

19 May '15

the following patch was just integrated into master: commit 404df444271b998948f6ef40f518cbb2fa27c493 Author: Julius Werner <jwerner(a)chromium.org> Date: Thu May 7 16:59:31 2015 -0700 arm64: Reorganize payload entry code and related Kconfigs Reorganize Kconfig (split out from the original patch linked below) Change-Id: I84ec8e453dd7a3980de95a455ad21494c601a98c Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Original-Commit-Id: 5067e47bc03f04ad2dba044f022716e0fc62bb9e Original-Change-Id: I1b2038acc0d054716a3c580ce97ea8e9a45abfa2 Original-Signed-off-by: Julius Werner <jwerner(a)chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/270783 Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/10240 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/10240 for details. -gerrit

1 0

Patch merged into coreboot/master: 7b32145 cbfstool: Copy generated files to the build hierarchy before use
by gerrit＠coreboot.org 19 May '15

19 May '15

the following patch was just integrated into master: commit 7b32145763fd5997886b8da5ae6af4660d154c79 Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Tue May 19 16:43:05 2015 +0200 cbfstool: Copy generated files to the build hierarchy before use Instead of writing to the source tree (which we should generally avoid), copy the pre-generated files (from lex and yacc) to $(objutil). Adapt include paths and rules so they're found. Change-Id: Id33be6d1dccf9a1b5857a29c55120dcc8f8db583 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Reviewed-on: http://review.coreboot.org/10252 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/10252 for details. -gerrit

1 0

Patch merged into coreboot/master: 8d6e24c cbfstool: clarify dependencies in Makefile
by gerrit＠coreboot.org 19 May '15

19 May '15

the following patch was just integrated into master: commit 8d6e24c739699c1e66434a03a781ba5b9efb1fba Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Tue May 19 16:41:21 2015 +0200 cbfstool: clarify dependencies in Makefile While logical, make's handling of multiple targets in a rule isn't intuitive, and was done wrong in cbfstool's Makefile. %.c %.h: %.l encourages make to run the rule twice, once to generate the .c file, once for the .h file. Hilarity ensues. Change-Id: I2560cb34b6aee5f4bdd764bb05bb69ea2789c7d8 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Reviewed-on: http://review.coreboot.org/10251 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/10251 for details. -gerrit

1 0

Patch merged into coreboot/master: d32b273 cbfstool: Rename autogenerated targets
by gerrit＠coreboot.org 19 May '15

19 May '15

the following patch was just integrated into master: commit d32b27383b35b62ea853e5edda5af302898c9cf2 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Fri May 15 09:27:34 2015 +0300 cbfstool: Rename autogenerated targets These names will skip the lint-whitespace tests. Change-Id: If4ac1f8e11fd0ac62f09696f2704477b6eb30046 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: http://review.coreboot.org/10212 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/10212 for details. -gerrit

1 0

New patch to review for coreboot: 0275185 cbfstool: Copy generated files to the build hierarchy before use
by Patrick Georgi 19 May '15

19 May '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10252 -gerrit commit 02751852e67632644297d460c35234a8677344c7 Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Tue May 19 16:43:05 2015 +0200 cbfstool: Copy generated files to the build hierarchy before use Instead of writing to the source tree (which we should generally avoid), copy the pre-generated files (from lex and yacc) to $(objutil). Adapt include paths and rules so they're found. Change-Id: Id33be6d1dccf9a1b5857a29c55120dcc8f8db583 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> --- util/cbfstool/Makefile.inc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc index 84ab724..dde8c68 100644 --- a/util/cbfstool/Makefile.inc +++ b/util/cbfstool/Makefile.inc @@ -47,12 +47,18 @@ TOOLCFLAGS += -Wstrict-prototypes -Wwrite-strings TOOLCPPFLAGS ?= -D_DEFAULT_SOURCE # memccpy() from string.h TOOLCPPFLAGS += -D_POSIX_C_SOURCE=200809L # strdup() from string.h TOOLCPPFLAGS += -I$(top)/util/cbfstool/flashmap +TOOLCPPFLAGS += -I$(top)/util/cbfstool +TOOLCPPFLAGS += -I$(objutil)/cbfstool TOOLLDFLAGS ?= ifeq ($(shell uname -s | cut -c-7 2>/dev/null), MINGW32) TOOLFLAGS+=-mno-ms-bitfields endif +$(objutil)/cbfstool/%.o: $(objutil)/cbfstool/%.c + printf " HOSTCC $(subst $(objutil)/,,$(@))\n" + $(HOSTCC) $(TOOLCPPFLAGS) $(TOOLCFLAGS) $(HOSTCFLAGS) -c -o $@ $< + $(objutil)/cbfstool/%.o: $(top)/util/cbfstool/%.c printf " HOSTCC $(subst $(objutil)/,,$(@))\n" $(HOSTCC) $(TOOLCPPFLAGS) $(TOOLCFLAGS) $(HOSTCFLAGS) -c -o $@ $< @@ -90,12 +96,12 @@ $(objutil)/cbfstool/fmd_scanner.o: TOOLCFLAGS += -Wno-unused-function # Tolerate lzma sdk warnings $(objutil)/cbfstool/LzmaEnc.o: TOOLCFLAGS += -Wno-sign-compare -Wno-cast-qual -$(objutil)/cbfstool/fmd.o: $(top)/util/cbfstool/fmd_parser.h -$(objutil)/cbfstool/fmd.o: $(top)/util/cbfstool/fmd_scanner.h +$(objutil)/cbfstool/fmd.o: $(objutil)/cbfstool/fmd_parser.h +$(objutil)/cbfstool/fmd.o: $(objutil)/cbfstool/fmd_scanner.h $(objutil)/cbfstool/fmd_parser.o: $(objutil)/cbfstool/fmd.o $(objutil)/cbfstool/fmd_scanner.o: $(objutil)/cbfstool/fmd.o -$(top)/util/cbfstool/%: $(top)/util/cbfstool/%_shipped +$(objutil)/cbfstool/%: $(top)/util/cbfstool/%_shipped mkdir -p $(dir $@) cp $< $@

1 0

New patch to review for coreboot: 997d3e6 cbfstool: clarify dependencies in Makefile
by Patrick Georgi 19 May '15

19 May '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10251 -gerrit commit 997d3e60cbd812e2f9dbae5a5607ed7775222c7c Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Tue May 19 16:41:21 2015 +0200 cbfstool: clarify dependencies in Makefile While logical, make's handling of multiple targets in a rule isn't intuitive, and was done wrong in cbfstool's Makefile. %.c %.h: %.l encourages make to run the rule twice, once to generate the .c file, once for the .h file. Hilarity ensues. Change-Id: I2560cb34b6aee5f4bdd764bb05bb69ea2789c7d8 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> --- util/cbfstool/Makefile | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/util/cbfstool/Makefile b/util/cbfstool/Makefile index 6e8235b..65d5710 100644 --- a/util/cbfstool/Makefile +++ b/util/cbfstool/Makefile @@ -54,9 +54,13 @@ $(obj)/%: $(obj)/%.o $(obj)/%.o: %.c mkdir -p $(dir $@) $(HOSTCC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $< -%.c %.h: %.l + +fmd_scanner.h: fmd_scanner.c +fmd_scanner.c: fmd_scanner.l $(LEX) $(LFLAGS) -t --header-file=$*.h $< >$*.c -%.c %.h: %.y + +fmd_parser.h: fmd_parser.c +fmd_parser.c: fmd_parser.y $(YACC) $(YFLAGS) -d $< mv -f y.tab.c $*.c mv -f y.tab.h $*.h

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2015