Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10380
-gerrit
commit e2eb555515940fdfcc307f620fc451a25361f63e
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Sat May 30 22:55:44 2015 +0200
Kconfig: Hide RAM_CODE_SUPPORT.
It builds only on veyron_* which already select it, no need to ask user.
Change-Id: Ie508b9eade16e0f39073b23dc0da6b6d1e0a4c73
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
src/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Kconfig b/src/Kconfig
index 6259eba..edcafe8 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -322,7 +322,7 @@ config BOARD_ID_STRING
board type.
config RAM_CODE_SUPPORT
- bool "Discover RAM configuration code and store it in coreboot table"
+ bool
default n
help
If enabled, coreboot discovers RAM configuration (value obtained by
Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10382
-gerrit
commit ef190ecc03ed453d32b8a8a77dea23d34265be64
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Sat May 30 23:13:48 2015 +0200
board_id: Remove extra quotes.
make already quotes the string. Double quoting actually removes the quoting.
Change-Id: I927d90dc2ce8af4e8d2d700d2bb3e04254459e1b
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
Makefile.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.inc b/Makefile.inc
index 0c688f7..49e1ba3 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -639,7 +639,7 @@ board_id-file := $(obj)/board_id
board_id-type := raw
$(obj)/board_id:
- printf "$(CONFIG_BOARD_ID_STRING)" > $@
+ printf $(CONFIG_BOARD_ID_STRING) > $@
JENKINS_PAYLOAD=none
what-jenkins-does:
Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10379
-gerrit
commit 5b543f96d92cf855b9b0e12cd9f9302c621bbcaa
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Sat May 30 22:47:22 2015 +0200
Kconfig: Hide BOARD_ID_MANUAL.
board_id() returns an integer which is platform-specific. 0 for one port
is different from 0 for another port. So there is no default board_id()
and hence enabling it on boards other than urara would cause build failure.
Not enabling it on urara or just setting id to "(none)" as is default results
in board_id() = 0 which means urara and an error message on console.
Change-Id: I94618f36a75e7505984bbec345a31fe0fa9cc867
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
src/Kconfig | 2 +-
src/mainboard/google/urara/Kconfig | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/Kconfig b/src/Kconfig
index 5aa76fb..6259eba 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -304,7 +304,7 @@ config BOARD_ID_AUTO
(ie. GPIO) select this configuration option.
config BOARD_ID_MANUAL
- bool "Add board ID file to CBFS"
+ bool
default n
depends on !BOARD_ID_AUTO
help
diff --git a/src/mainboard/google/urara/Kconfig b/src/mainboard/google/urara/Kconfig
index a43d84e..eb7e09f 100644
--- a/src/mainboard/google/urara/Kconfig
+++ b/src/mainboard/google/urara/Kconfig
@@ -29,6 +29,7 @@ config BOARD_SPECIFIC_OPTIONS
select CPU_IMGTEC_PISTACHIO
select COMMON_CBFS_SPI_WRAPPER
select SPI_FLASH
+ select BOARD_ID_MANUAL
config MAINBOARD_DIR
string
Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10382
-gerrit
commit 83bcd75a0dd29e292315aa411f52892e03b4c5d5
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Sat May 30 23:13:48 2015 +0200
board_id: Remove extra quotes.
make already quotes the string. Double quoting actually removes the quoting.
Change-Id: I927d90dc2ce8af4e8d2d700d2bb3e04254459e1b
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
Makefile.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.inc b/Makefile.inc
index 0c688f7..49e1ba3 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -639,7 +639,7 @@ board_id-file := $(obj)/board_id
board_id-type := raw
$(obj)/board_id:
- printf "$(CONFIG_BOARD_ID_STRING)" > $@
+ printf $(CONFIG_BOARD_ID_STRING) > $@
JENKINS_PAYLOAD=none
what-jenkins-does:
Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10380
-gerrit
commit 23aa1ce368a8f2f9cde4bb79baaf23738e259552
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Sat May 30 22:55:44 2015 +0200
Kconfig: Hide RAM_CODE_SUPPORT.
It builds only on veyron_* which already select it, no need to ask user.
Change-Id: Ie508b9eade16e0f39073b23dc0da6b6d1e0a4c73
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
src/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Kconfig b/src/Kconfig
index 6259eba..edcafe8 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -322,7 +322,7 @@ config BOARD_ID_STRING
board type.
config RAM_CODE_SUPPORT
- bool "Discover RAM configuration code and store it in coreboot table"
+ bool
default n
help
If enabled, coreboot discovers RAM configuration (value obtained by
Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10379
-gerrit
commit f56340323d7d3e5b37289272f13cadf9ecd6e15f
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Sat May 30 22:47:22 2015 +0200
Kconfig: Hide BOARD_ID_MANUAL.
board_id() returns an integer which is platform-specific. 0 for one port
is different from 0 for another port. So there is no default board_id()
and hence enabling it on boards other than urara would cause build failure.
Not enabling it on urara or just setting id to "(none)" as is default results
in board_id() = 0 which means urara and an error message on console.
Change-Id: I94618f36a75e7505984bbec345a31fe0fa9cc867
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
src/Kconfig | 2 +-
src/mainboard/google/urara/Kconfig | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/Kconfig b/src/Kconfig
index 5aa76fb..6259eba 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -304,7 +304,7 @@ config BOARD_ID_AUTO
(ie. GPIO) select this configuration option.
config BOARD_ID_MANUAL
- bool "Add board ID file to CBFS"
+ bool
default n
depends on !BOARD_ID_AUTO
help
diff --git a/src/mainboard/google/urara/Kconfig b/src/mainboard/google/urara/Kconfig
index a43d84e..eb7e09f 100644
--- a/src/mainboard/google/urara/Kconfig
+++ b/src/mainboard/google/urara/Kconfig
@@ -29,6 +29,7 @@ config BOARD_SPECIFIC_OPTIONS
select CPU_IMGTEC_PISTACHIO
select COMMON_CBFS_SPI_WRAPPER
select SPI_FLASH
+ select BOARD_ID_MANUAL
config MAINBOARD_DIR
string