Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8550
-gerrit
commit 1b8389fb9fc711a8a71319b6babf1e7321f7a95a
Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Date: Sat Feb 21 23:56:07 2015 +0200
AMD K8: Fix add_more_links()
There is no requirement that in dev->link_list the last element
would have the highest link->link_num.
Also fix off-by-one error when allocating for more links.
Change-Id: Id8a7db3ffb4111eb31e70ea14fd522b70368dd8c
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
src/northbridge/amd/amdk8/northbridge.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/northbridge/amd/amdk8/northbridge.c b/src/northbridge/amd/amdk8/northbridge.c
index 63f543e..a17aa65 100644
--- a/src/northbridge/amd/amdk8/northbridge.c
+++ b/src/northbridge/amd/amdk8/northbridge.c
@@ -1165,14 +1165,16 @@ static struct device_operations pci_domain_ops = {
static void add_more_links(device_t dev, unsigned total_links)
{
struct bus *link, *last = NULL;
- int link_num;
+ int link_num = -1;
- for (link = dev->link_list; link; link = link->next)
+ for (link = dev->link_list; link; link = link->next) {
+ if (link_num < link->link_num)
+ link_num = link->link_num;
last = link;
+ }
if (last) {
- int links = total_links - last->link_num;
- link_num = last->link_num;
+ int links = total_links - (link_num + 1);
if (links > 0) {
link = malloc(links*sizeof(*link));
if (!link)
@@ -1182,7 +1184,6 @@ static void add_more_links(device_t dev, unsigned total_links)
}
}
else {
- link_num = -1;
link = malloc(total_links*sizeof(*link));
memset(link, 0, total_links*sizeof(*link));
dev->link_list = link;
Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8548
-gerrit
commit 9dcb2cf833ed47a4981986e7b1c4fed9e7c7b8bb
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Sat Feb 28 12:53:53 2015 +0100
build system: make crosstools should build all supported compilers
It only built i386-elf
Change-Id: I02f94d12297901136e1c17c63bbeb103c1d93e8d
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
Makefile.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.inc b/Makefile.inc
index 69f6786..66f9902 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -457,7 +457,7 @@ crossgcc-arm: clean-for-update
crossgcc-aarch64: clean-for-update
$(MAKE) -C util/crossgcc build-aarch64-without-gdb
-crosstools: crosstools-i386
+crosstools: crosstools-i386 crosstools-arm crosstools-aarch64
.PHONY: crosstools-i386 crosstools-arm crosstools-aarch64
crosstools-i386: clean-for-update
Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8545
-gerrit
commit 7b69a6745fd04cee96855dbec1c725f53d9ff19f
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Fri Feb 27 23:36:26 2015 +0100
crossgcc: Clean GNU make context so builds succeed
GCC's build system is sometimes confused by our build system's
configuration: make crossgcc failed, while
util/crossgcc/buildgcc -p armv7-a-eabi didn't.
Make sure the GCC build system runs independently from
ours by breaking any ties.
Change-Id: I563e17b22127bc8c83ebfb17252184a3b6e0e58b
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
util/crossgcc/buildgcc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index e4ddbc2..0779266 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -64,6 +64,8 @@ IASL_DIR="acpica-unix-${IASL_VERSION}"
PYTHON_DIR="Python-${PYTHON_VERSION}"
EXPAT_DIR="expat-${EXPAT_VERSION}"
+unset MAKELEVEL MAKEFLAGS
+
SAVETEMPS=0
SKIPGDB=1
SKIPPYTHON=1
the following patch was just integrated into master:
commit 5818da262dc0ce56bb1d5439b6d139bc08c25554
Author: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
Date: Fri Dec 13 16:56:23 2013 -0600
cpu/intel: (non-FSP) Remove microcode updates from tree
Now that we use the microcode updates in the blobs repository, remove
them from the main repo. Since the microcode updates are blobs, it
makes more sense to ship them in the blobs repo rather than the main
one.
The update-microcodes.sh script is also deleted, as a more current
version resides in 3rdparty.
Change-Id: Iee74a3ede3b5eb684ef0386d270120e70173c1b4
Signed-off-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
Reviewed-on: http://review.coreboot.org/4531
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Reviewed-by: Patrick Georgi <pgeorgi(a)google.com>
See http://review.coreboot.org/4531 for details.
-gerrit
Kevin Paul Herbert (kph(a)meraki.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8547
-gerrit
commit c5e28a4b2db0fd76c83fd6e0e039fae4fb5c5adf
Author: Kevin Paul Herbert <kph(a)meraki.net>
Date: Tue Feb 24 19:09:20 2015 -0800
toolchain.inc: don't make error if no verstage compiler on platforms that don't use one
In commit 77b1655d9 (vboot2: add verstage) support was added for the
"verstage" pseudo-stage. This was done by adding verstage to the
list of stages. However, this was done by using the make function
"create_class_compiler", which does not expect to be invoked for
compilers that do not exist. This causes make to emit the error:
toolchain.inc:135: *** building verstage without the required toolchain. Stop.
To fix this problem, only use init_standard_toolchain (which calls
create_class_compiler) for toolchains that actually exist for a platform.
This was found building an ARM platform (not yet merged upstream).
Change-Id: I216393dab88598ce065c54b189523418a4bffa12
Signed-off-by: Kevin Paul Herbert <kph(a)meraki.net>
---
toolchain.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/toolchain.inc b/toolchain.inc
index f888d68..3a389cc 100644
--- a/toolchain.inc
+++ b/toolchain.inc
@@ -125,7 +125,7 @@ endef
# @1 : stage for which the toolchain is to be initialized
init_standard_toolchain = \
$(eval $(call set_stage_toolchain,$(1))) \
- $(eval $(call create_class_compiler,$(1),$(ARCH-$(1)-y)))
+ $(if $(ARCH-$(1)-y),$(eval $(call create_class_compiler,$(1),$(ARCH-$(1)-y))))
init_stages = \
$(foreach stage,$(COREBOOT_STANDARD_STAGES),$(eval $(call init_standard_toolchain,$(stage))))
the following patch was just integrated into master:
commit ee89435798022021026f511deddf0e3b401ad031
Author: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
Date: Fri Dec 13 16:50:28 2013 -0600
cpu/intel (non-FSP): Use microcode from blobs repository
Now that microcode has been added to blobs, use that one instead of
the one included in the tree. Microcode from the tree will be
removed in a subsequent patch. Since the microcode updates are blobs,
they belong in the blobs repository.
This change may introduce a build failure if the "Generate from tree"
microcode option is selected, but the blobs repository is not
enabled. We have to live with this for now, until microcode is moved
to blobs for all CPUs, at which point we may adjust Kconfig
accordingly.
Leave the FSP cpu alone for now, as that will need approval from
SAGE.
Change-Id: Ia77ba2e26c083da092449b04ab2323b91a2ca15b
Signed-off-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
Reviewed-on: http://review.coreboot.org/4530
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Reviewed-by: Patrick Georgi <pgeorgi(a)google.com>
See http://review.coreboot.org/4530 for details.
-gerrit