New patch to review for coreboot: c5e28a4 toolchain.inc: don't make error if no verstage compiler on platforms that don't use one
Kevin Paul Herbert (kph@meraki.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8547
-gerrit
commit c5e28a4b2db0fd76c83fd6e0e039fae4fb5c5adf Author: Kevin Paul Herbert kph@meraki.net Date: Tue Feb 24 19:09:20 2015 -0800
toolchain.inc: don't make error if no verstage compiler on platforms that don't use one
In commit 77b1655d9 (vboot2: add verstage) support was added for the "verstage" pseudo-stage. This was done by adding verstage to the list of stages. However, this was done by using the make function "create_class_compiler", which does not expect to be invoked for compilers that do not exist. This causes make to emit the error:
toolchain.inc:135: *** building verstage without the required toolchain. Stop.
To fix this problem, only use init_standard_toolchain (which calls create_class_compiler) for toolchains that actually exist for a platform.
This was found building an ARM platform (not yet merged upstream).
Change-Id: I216393dab88598ce065c54b189523418a4bffa12 Signed-off-by: Kevin Paul Herbert kph@meraki.net --- toolchain.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/toolchain.inc b/toolchain.inc index f888d68..3a389cc 100644 --- a/toolchain.inc +++ b/toolchain.inc @@ -125,7 +125,7 @@ endef # @1 : stage for which the toolchain is to be initialized init_standard_toolchain = \ $(eval $(call set_stage_toolchain,$(1))) \ - $(eval $(call create_class_compiler,$(1),$(ARCH-$(1)-y))) + $(if $(ARCH-$(1)-y),$(eval $(call create_class_compiler,$(1),$(ARCH-$(1)-y))))
init_stages = \ $(foreach stage,$(COREBOOT_STANDARD_STAGES),$(eval $(call init_standard_toolchain,$(stage))))
-
Kevin Paul Herbert