December 2015 - coreboot-gerrit

New patch to review for coreboot: buildgcc: Update coreboot's IASL version to 20151218
by Martin Roth Dec. 30, 2015

Dec. 30, 2015

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12817 -gerrit commit 9987382f0aa72f469596f4db264f0a2c30d9f62a Author: Martin Roth <gaumless(a)gmail.com> Date: Wed Dec 30 15:10:13 2015 -0700 buildgcc: Update coreboot's IASL version to 20151218 Update IASL from 20150619 to 20151218 See release notes at acpica.org Change-Id: Ic7e7b3956378ad611069e984d5a59c78e4cb08b1 Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- util/crossgcc/buildgcc | 2 +- .../patches/acpica-unix-20150619_iasl.patch | 12 ---------- .../patches/acpica-unix-20151218_iasl.patch | 27 ++++++++++++++++++++++ .../crossgcc/sum/acpica-unix-20150619.tar.gz.cksum | 1 - .../crossgcc/sum/acpica-unix-20151218.tar.gz.cksum | 1 + 5 files changed, 29 insertions(+), 14 deletions(-) diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 77e8bbd..b42ca9b 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -39,7 +39,7 @@ GCC_VERSION=5.2.0 GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.25 GDB_VERSION=7.9.1 -IASL_VERSION=20150619 +IASL_VERSION=20151218 PYTHON_VERSION=3.4.3 EXPAT_VERSION=2.1.0 # CLANG version number diff --git a/util/crossgcc/patches/acpica-unix-20150619_iasl.patch b/util/crossgcc/patches/acpica-unix-20150619_iasl.patch deleted file mode 100644 index 6cb087c..0000000 --- a/util/crossgcc/patches/acpica-unix-20150619_iasl.patch +++ /dev/null @@ -1,12 +0,0 @@ -diff -urN acpica-unix-20150619/source/compiler/asloptions.c acpica-unix-20150619/source/compiler/asloptions.c ---- acpica-unix-20150619/source/compiler/asloptions.c 2015-06-19 08:56:19.000000000 -0600 -+++ acpica-unix-20150619/source/compiler/asloptions.c 2015-12-08 10:44:58.816669240 -0700 -@@ -717,6 +717,7 @@ - case '^': - - printf (ACPI_COMMON_SIGNON (ASL_COMPILER_NAME)); -+ printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION); - exit (0); - - case 'a': - diff --git a/util/crossgcc/patches/acpica-unix-20151218_iasl.patch b/util/crossgcc/patches/acpica-unix-20151218_iasl.patch new file mode 100644 index 0000000..e35a360 --- /dev/null +++ b/util/crossgcc/patches/acpica-unix-20151218_iasl.patch @@ -0,0 +1,27 @@ +Add coreboot toolchain version string +--- acpica-unix-20151218/source/compiler/asloptions.c ++++ acpica-unix-20151218/source/compiler/asloptions.c +@@ -169,6 +169,7 @@ + if (argc < 2) + { + printf (ACPI_COMMON_SIGNON (ASL_COMPILER_NAME)); ++ printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION); + Usage (); + exit (1); + } +@@ -199,6 +200,7 @@ + if (Gbl_DoSignon) + { + printf (ACPI_COMMON_SIGNON (ASL_COMPILER_NAME)); ++ printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION); + if (Gbl_IgnoreErrors) + { + printf ("Ignoring all errors, forcing AML file generation\n\n"); +@@ -743,6 +745,7 @@ + case '^': + + printf (ACPI_COMMON_SIGNON (ASL_COMPILER_NAME)); ++ printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION); + exit (0); + + case 'a': diff --git a/util/crossgcc/sum/acpica-unix-20150619.tar.gz.cksum b/util/crossgcc/sum/acpica-unix-20150619.tar.gz.cksum deleted file mode 100644 index 4047300..0000000 --- a/util/crossgcc/sum/acpica-unix-20150619.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -ccc86513f10c47762bf46bf4d348c8cbda4336f5 tarballs/acpica-unix-20150619.tar.gz diff --git a/util/crossgcc/sum/acpica-unix-20151218.tar.gz.cksum b/util/crossgcc/sum/acpica-unix-20151218.tar.gz.cksum new file mode 100644 index 0000000..fb9876b --- /dev/null +++ b/util/crossgcc/sum/acpica-unix-20151218.tar.gz.cksum @@ -0,0 +1 @@ +97e430aa6e936e77abeba936345588fff003e280 tarballs/acpica-unix-20151218.tar.gz

1 0

Patch merged into coreboot/master: gigabyte/ga-g41m-es2l: Add mainboard
by gerrit＠coreboot.org Dec. 30, 2015

Dec. 30, 2015

the following patch was just integrated into master: commit cbe7a8e1008009c45551b56171da5df79a07fcce Author: Damien Zammit <damien(a)zamaudio.com> Date: Wed Aug 19 15:23:32 2015 +1000 gigabyte/ga-g41m-es2l: Add mainboard Board uses x4x native raminit Board boots into Debian 8 with full graphics IRQ9: nobody cared, gets disabled (PIC needs IRQ settings?) VGA: - VGA native init works in grub with analog connector - Fails to boot with both channels of ram populated Change-Id: I7417813456817529b8cbaace45cefe47467d0a82 Signed-off-by: Damien Zammit <damien(a)zamaudio.com> Reviewed-on: https://review.coreboot.org/11306 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> See https://review.coreboot.org/11306 for details. -gerrit

1 0

Patch merged into coreboot/master: northbridge/intel/x4x: Native raminit
by gerrit＠coreboot.org Dec. 30, 2015

Dec. 30, 2015

the following patch was just integrated into master: commit 4b513a618d7d7edeb5ed9c5073e838b46e2f4676 Author: Damien Zammit <damien(a)zamaudio.com> Date: Thu Aug 20 00:37:05 2015 +1000 northbridge/intel/x4x: Native raminit Passes memtest86+ with either one or two sticks of 2GB ram but memory map needs a hole at 0xa0000000 to 0xc0000000 Change-Id: Ib34d862cb48b49c054a505fffcba1c17aeb39436 Signed-off-by: Damien Zammit <damien(a)zamaudio.com> Reviewed-on: https://review.coreboot.org/11307 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> See https://review.coreboot.org/11307 for details. -gerrit

1 0

Patch merged into coreboot/master: superio/it8718f: Add missing PNP info
by gerrit＠coreboot.org Dec. 30, 2015

Dec. 30, 2015

the following patch was just integrated into master: commit 9074cec9b997f2be7083f96ef872e281e9194015 Author: Damien Zammit <damien(a)zamaudio.com> Date: Mon Dec 28 23:34:00 2015 +1100 superio/it8718f: Add missing PNP info Change-Id: Id6d50d4d6af31e43f851645f09383121755291f6 Signed-off-by: Damien Zammit <damien(a)zamaudio.com> Reviewed-on: https://review.coreboot.org/12815 Tested-by: build bot (Jenkins) Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> See https://review.coreboot.org/12815 for details. -gerrit

1 0

Patch set updated for coreboot: util/crossgcc: Regenerate GMP autotools files before build
by Timothy Pearson Dec. 30, 2015

Dec. 30, 2015

Timothy Pearson (tpearson(a)raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12816 -gerrit commit 2cabe8f80446d9682314a2fb2889b6e94e62049b Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Wed Dec 30 14:52:19 2015 -0600 util/crossgcc: Regenerate GMP autotools files before build The config.guess file included with GMP is completely obsolete, leading to build failures on ppc64el due to the system architecture not being detected. Regenerate the files from the host system via automake before attempting to build GMP. Change-Id: I00fc16003906e373d112c25978197ac907adccfd Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> --- util/crossgcc/buildgcc | 1 + 1 file changed, 1 insertion(+) diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 988e3c3..e15ca52 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -367,6 +367,7 @@ build_GMP() { build_MPFR() { test $UNAME = "Darwin" && CFLAGS="$CFLAGS -force_cpusubtype_ALL" + CC="$CC" automake --add-missing --copy --force-missing CC="$CC" ../${MPFR_DIR}/configure --disable-shared --prefix=$TARGETDIR \ --infodir=$TARGETDIR/info \ --with-gmp=$DESTDIR$TARGETDIR CFLAGS="$HOSTCFLAGS" || \

1 0

New patch to review for coreboot: util/crossgcc: Regenrate GMP autotools files before build
by Timothy Pearson Dec. 30, 2015

Dec. 30, 2015

Timothy Pearson (tpearson(a)raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12816 -gerrit commit 2be096f7766ddf5bd83f5634b8219a6d138f17b8 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Wed Dec 30 14:52:19 2015 -0600 util/crossgcc: Regenrate GMP autotools files before build The config.guess file included with GMP is completely obsolete, leading to build failures on ppc64el due to the system architecture not being detected. Regenerate the files from the host system via automake before attempting to build GMP. Change-Id: I00fc16003906e373d112c25978197ac907adccfd Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> --- util/crossgcc/buildgcc | 1 + 1 file changed, 1 insertion(+) diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 988e3c3..e15ca52 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -367,6 +367,7 @@ build_GMP() { build_MPFR() { test $UNAME = "Darwin" && CFLAGS="$CFLAGS -force_cpusubtype_ALL" + CC="$CC" automake --add-missing --copy --force-missing CC="$CC" ../${MPFR_DIR}/configure --disable-shared --prefix=$TARGETDIR \ --infodir=$TARGETDIR/info \ --with-gmp=$DESTDIR$TARGETDIR CFLAGS="$HOSTCFLAGS" || \

1 0

Patch set updated for coreboot: Documentation: Add information about patches from other git repos
by Martin Roth Dec. 30, 2015

Dec. 30, 2015

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12804 -gerrit commit df02ac3620fa3431a4c25d103ba645dd30105d51 Author: Martin Roth <martinroth(a)google.com> Date: Sat Dec 26 13:33:09 2015 -0700 Documentation: Add information about patches from other git repos This is more tribal knowledge that I don't think I've seen written down anywhere else. It's not a huge issue, but when looking through the git log, it helps to be able to differentiate the information from the old gerrit with the information from the new one. Change-Id: I7993bda1e9aab79dc26940aaba9ddc52382ed0df Signed-off-by: Martin Roth <martinroth(a)google.com> --- Documentation/gerrit_guidelines.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/gerrit_guidelines.md b/Documentation/gerrit_guidelines.md index 3140ff5..1833b0a 100644 --- a/Documentation/gerrit_guidelines.md +++ b/Documentation/gerrit_guidelines.md @@ -236,6 +236,20 @@ request. For major problems where the change doesn’t work as intended or breaks other platforms, the change really needs to go into the original patch. +* When bringing in a patch from another git repo, update the original +git/gerrit tags by prepending the lines with 'Original-'. Marking +the original text this way makes it much easier to tell what changes +happened in which repository. This applies to these lines, not the actual +commit message itself: + Commit-Id: + Change-Id: + Signed-off-by: + Reviewed-on: + Tested-by: + Reviewed-by: +The script 'util/gitconfig/rebase.sh' can be used to help automate this. +Other tags such as 'Commit-Queue' can simply be removed. + Expectations contributors should have: --------------------------------------

1 0

Patch merged into coreboot/master: drivers/xgi/common: Fix XGI_SetGroup2
by gerrit＠coreboot.org Dec. 30, 2015

Dec. 30, 2015

the following patch was just integrated into master: commit d09a8819883e3d6784a359e7f25358f4012af24b Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Thu Dec 17 13:03:11 2015 -0800 drivers/xgi/common: Fix XGI_SetGroup2 This code looks like it was created from a disassembly of some other driver. Attempt to fix it, without hardware or documentation. CID 142909: Operands don't affect result (CONSTANT_EXPRESSION_RESULT) Change-Id: I9b9cadf2acdba73913aad6bbe0d14ad64a652915 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: https://review.coreboot.org/12774 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Tested-by: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com> Reviewed-by: Martin Roth <martinroth(a)google.com> Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> Reviewed-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> See https://review.coreboot.org/12774 for details. -gerrit

1 0

Patch merged into coreboot/master: Kconfig: move fmap description file prompt into the mainboard menu
by gerrit＠coreboot.org Dec. 30, 2015

Dec. 30, 2015

the following patch was just integrated into master: commit da1ca20ac3481e8108863b5bdc32faff38f7b740 Author: Martin Roth <gaumless(a)gmail.com> Date: Sat Dec 26 16:51:16 2015 -0700 Kconfig: move fmap description file prompt into the mainboard menu The FMD is board-specific, so it makes sense to have it in the mainboard menu. Change-Id: I52fba5ced869d51d10065f8c9ebd258d3a1d4156 Signed-off-by: Martin Roth <gaumless(a)gmail.com> Reviewed-on: https://review.coreboot.org/12805 Tested-by: build bot (Jenkins) Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> See https://review.coreboot.org/12805 for details. -gerrit

1 0

Patch merged into coreboot/master: MAINTAINERS: Designate Intel maintainers for FSP 1.0 Baytrail
by gerrit＠coreboot.org Dec. 30, 2015

Dec. 30, 2015

the following patch was just integrated into master: commit 000e8aa3f7d25e3fa30487cb77263e8b66aa26ce Author: Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com> Date: Tue Oct 13 17:30:04 2015 -0700 MAINTAINERS: Designate Intel maintainers for FSP 1.0 Baytrail After several internal discussions, teams at Intel with stakes in coreboot have decided to each assign one or more maintainers. These maintainers can be expected to provide a point of contact for assistance with technical (code-related) issues, testing on real hardware, and making sure that their FSP-related areas continue to function with upstream coreboot. They understand that the inclusion of their information in the MAINTAINERS file does not give them any extra power over their areas. At the same time, nobody expects any community process to change. The one expectation is that reasonable efforts be made to contact these maintainers when making fundamental changes to their areas, or when discussing code removal. Change-Id: I62b2eaec8270ac1fce5bfbee3b3da68aba116b0f Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com> Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/11894 Reviewed-by: York Yang <york.yang(a)intel.com> Tested-by: build bot (Jenkins) See https://review.coreboot.org/11894 for details. -gerrit

1 0