Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12804
-gerrit
commit 65a810c665fc053f090730f26920ee5aa10682d2
Author: Martin Roth <martinroth(a)google.com>
Date: Sat Dec 26 13:33:09 2015 -0700
Documentation: Add information about patches from other git repos
This is more tribal knowledge that I don't think I've seen written down
anywhere else. It's not a huge issue, but when looking through the git
log, it helps to be able to differentiate the information from the old
gerrit with the information from the new one.
Change-Id: I7993bda1e9aab79dc26940aaba9ddc52382ed0df
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
Documentation/gerrit_guidelines.md | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/gerrit_guidelines.md b/Documentation/gerrit_guidelines.md
index 3140ff5..3a5f7fc 100644
--- a/Documentation/gerrit_guidelines.md
+++ b/Documentation/gerrit_guidelines.md
@@ -236,6 +236,18 @@ request. For major problems where the change doesn’t work as intended or
breaks other platforms, the change really needs to go into the original
patch.
+* When bringing in a patch from another git repo, update the original
+git/gerrit information by prepending the lines with 'Original-'. Marking
+the original text this way makes it much easier to tell what changes
+happened in which repository. This applies to these lines, not the actual
+commit message itself:
+ Commit-Id:
+ Change-Id:
+ Signed-off-by:
+ Reviewed-on:
+ Tested-by:
+ Reviewed-by:
+
Expectations contributors should have:
--------------------------------------
the following patch was just integrated into master:
commit d890b45520a4b2af2ae2b15096b5897ed7464fcb
Author: Martin Roth <martinroth(a)google.com>
Date: Thu Dec 10 08:04:44 2015 -0700
ACPI: Add hack to avoid IASL warning when reading back registers
Upcoming versions of IASL give a warning about unused methods. This
adds an operation after the read to use the local variable and avoid
the warning.
The warning can be completely disabled on the command line, but as it
can find real issues, my preference is to not do that.
Fixes warnings:
dsdt.aml 640: Store (CTMP, Local0)
Warning 3144 - Method Local is set but never used ^ (Local0)
Change-Id: If55bb8e03abb8861e1f2f08a8bcb1be8c9783afe
Signed-off-by: Martin Roth <martinroth(a)google.com>
Reviewed-on: https://review.coreboot.org/12704
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
See https://review.coreboot.org/12704 for details.
-gerrit
the following patch was just integrated into master:
commit 80ef7b778e5e5ec8b2940c875df76bb705855ede
Author: david <david_wu(a)quantatw.com>
Date: Mon Jan 19 17:11:36 2015 +0800
IT8772F: Clean up it8772f includes and add a LED API
- Remove it8772f c includes
- Add a new LED API, it8772f_gpio_led
- Stumpy: using it8772f_gpio_led
BUG=chrome-os-partner:28232
BRANCH=Guado
TEST=emerge-guado coreboot chromeos-bootimage
Change-Id: I08de52515d3c1e7e85d1761c09a0cebffda7dda3
Signed-off-by: David Wu <David_Wu(a)quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/241813
Tested-by: David Wu <david_wu(a)quantatw.com>
Reviewed-by: Shawn N <shawnn(a)chromium.org>
Commit-Queue: David Wu <david_wu(a)quantatw.com>
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
Reviewed-on: https://review.coreboot.org/12797
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
See https://review.coreboot.org/12797 for details.
-gerrit
the following patch was just integrated into master:
commit 0fa4f6f23d6bec4216e0be27526a009db50c8938
Author: Martin Roth <martinroth(a)google.com>
Date: Mon Dec 21 12:51:40 2015 -0700
cpu/allwinner/a10: Fix I2c speed calculation
Looking at the A10 datasheet, N should go in bits 2:0, but
was being cleared by shifting it left by three bits, then
anding it with 7.
Fixes coverity warning:
CID 1241888 (#1 of 1): Wrong operator used (CONSTANT_EXPRESSION_RESULT)
operator_confusion: (n << 3) & (7U /* 7 << 0 */) is always 0 regardless
of the values of its operands. This occurs as the bitwise second operand
of '|'.
Change-Id: I17e71a73adf37a62607e8e5865b1da749d7278aa
Signed-off-by: Martin Roth <martinroth(a)google.com>
Reviewed-on: https://review.coreboot.org/12779
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
See https://review.coreboot.org/12779 for details.
-gerrit