coreboot-gerrit November 2015

coreboot-gerrit@coreboot.org

1 participants
1544 discussions

Patch merged into coreboot/master: southbridge/amd/sr5650: Add IOMMU support
by gerrit＠coreboot.org 23 Nov '15

23 Nov '15

the following patch was just integrated into master: commit 44e4a4e4db23677c960591d3209004f4f8b80326 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Tue Aug 11 17:49:06 2015 -0500 southbridge/amd/sr5650: Add IOMMU support Change-Id: I2083d0c5653515c27d4626c62a6499b850f7547b Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/12044 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> See http://review.coreboot.org/12044 for details. -gerrit

1 0

Patch merged into coreboot/master: arch/x86/acpi: Add IVRS table generation routines
by gerrit＠coreboot.org 23 Nov '15

23 Nov '15

the following patch was just integrated into master: commit ff8ccf05b04714ae86ed947841de718699a09d2c Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Tue Aug 11 17:48:32 2015 -0500 arch/x86/acpi: Add IVRS table generation routines Change-Id: Ia5d97d01dc9ddc45f81d998d126d592a915b4a75 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/12043 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/12043 for details. -gerrit

1 0

Patch merged into coreboot/master: cpu/amd/fam15h: Set up Link Base Channel Buffer Count registers
by gerrit＠coreboot.org 23 Nov '15

23 Nov '15

the following patch was just integrated into master: commit a52d5d1269bdf82af76de78e0e27f9c6acce1fab Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Sat Aug 8 20:30:36 2015 -0500 cpu/amd/fam15h: Set up Link Base Channel Buffer Count registers Change-Id: I8d616a64a5a9cf0b51288535f5050c6866d0996b Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/12038 Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Tested-by: build bot (Jenkins) See http://review.coreboot.org/12038 for details. -gerrit

1 0

Patch merged into coreboot/master: northbridge/amd/amdfam10: Add Family 15h cache partitioning support
by gerrit＠coreboot.org 23 Nov '15

23 Nov '15

the following patch was just integrated into master: commit 5a0375a2f6b02c4f01facf6be40e59a6062edec0 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Sat Aug 8 20:29:27 2015 -0500 northbridge/amd/amdfam10: Add Family 15h cache partitioning support Certain workloads may evict too many lines of other cores from the L3 cache if configured as one monolithic shared cache region. Forcibly partition L3 cache to improve performance. Change-Id: Ie4e28dd886aaa1c586b0919c5fe87ef1696f47e9 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/12036 Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> See http://review.coreboot.org/12036 for details. -gerrit

1 0

Patch merged into coreboot/master: northbridge/amd/amdfam10: Fix invalid NUMA table
by gerrit＠coreboot.org 23 Nov '15

23 Nov '15

the following patch was just integrated into master: commit 121ef60666e59656a74044c7f21f52b3bb849b1d Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Sat Aug 8 02:40:58 2015 -0500 northbridge/amd/amdfam10: Fix invalid NUMA table The existing code generated an invalid NUMA table that was rejected by Linux, leading to poor resource allocation. This was due to system MMIO resources being inserted into the table when the table should only contain DRAM resources. Do not include system MMIO resources (i.e. resources with an index less than 0x10) in the NUMA table. Change-Id: I99c200382b52a99687daf266a84873d9ae2df025 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/12035 Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/12035 for details. -gerrit

1 0

New patch to review for coreboot: superio/smsc/mec1308: Fix IASL warnings
by Martin Roth 23 Nov '15

23 Nov '15

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12520 -gerrit commit 19c5cb7b21812241efa5f800f2ce7b3ff7c4b4e5 Author: Martin Roth <martinroth(a)google.com> Date: Mon Nov 23 14:34:51 2015 -0700 superio/smsc/mec1308: Fix IASL warnings The SIO device needs to provide an _ADR object with the IO address as well as the address in the OperationRegion. ACPI provides two different Resource Descriptor Macros to describe the I/O areas required for a device. The FixedIO macro is only valid for 10-bit IO addresses. Changed to use the IO macro instead. Thank you to recent IASL that allows for addition in the ASL file. :) Fixes these warnings: dsdt.aml 2276: Device (SIO) { Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) dsdt.aml 2390: FixedIO (0xa00, 0x34) Warning 3060 - ^ Maximum 10-bit ISA address (0x3FF) dsdt.aml 2394: FixedIO (0xa00, 0x34) Warning 3060 - ^ Maximum 10-bit ISA address (0x3FF) Lumpy now compiles its ASL tables with no warnings. Re-Enable Warnings as errors. Change-Id: Id26e234eadaa3b966e8f769cb9f9fb7ea64fc9e3 Signed-off-by: Martin Roth <martinroth(a)google.com> --- src/mainboard/samsung/lumpy/Kconfig | 4 ---- src/superio/smsc/mec1308/acpi/superio.asl | 5 +++-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig index 1660c27..ac19be5 100644 --- a/src/mainboard/samsung/lumpy/Kconfig +++ b/src/mainboard/samsung/lumpy/Kconfig @@ -64,8 +64,4 @@ config EARLY_PCI_MMIO_BASE endif -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif # BOARD_SAMSUNG_LUMPY diff --git a/src/superio/smsc/mec1308/acpi/superio.asl b/src/superio/smsc/mec1308/acpi/superio.asl index 7251259..6794448 100644 --- a/src/superio/smsc/mec1308/acpi/superio.asl +++ b/src/superio/smsc/mec1308/acpi/superio.asl @@ -16,6 +16,7 @@ // Scope is \_SB.PCI0.LPCB Device (SIO) { + Name (_ADR, 0x2E) OperationRegion (SIOA, SystemIO, 0x2E, 0x02) Field (SIOA, ByteAcc, NoLock, Preserve) { @@ -245,12 +246,12 @@ Device (SIO) { Name (_CRS, ResourceTemplate() { - FixedIO (SIO_SMBX_IO0, 0x34) + IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0 + 0x34, 0x01, 0x34) }) Name (_PRS, ResourceTemplate() { - FixedIO (SIO_SMBX_IO0, 0x34) + IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0 + 0x34, 0x01, 0x34) }) } #endif

1 0

New patch to review for coreboot: google/rambi: Fix IASL warnings _CRS must return a value
by Martin Roth 23 Nov '15

23 Nov '15

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12519 -gerrit commit 1d46971d19cd63712131608e412fca5688c7d937 Author: Martin Roth <martinroth(a)google.com> Date: Mon Nov 23 14:03:13 2015 -0700 google/rambi: Fix IASL warnings _CRS must return a value The Touchpad and Touchscreen _CRS methods do not return an interrupt value if the I2c busses that the devices are on are not in PCI mode. Previously they didn't return any value if they weren't in PCI mode. This patch has them return an empty resource template. Fixes these warnings: dsdt.aml 2813: Method (_CRS) Warning 3115 - ^ Not all control paths return a value (_CRS) dsdt.aml 2813: Method (_CRS) Warning 3107 - ^ Reserved method must return a value (Buffer required for _CRS) dsdt.aml 2832: Method (_CRS) Warning 3115 - ^ Not all control paths return a value (_CRS) dsdt.aml 2832: Method (_CRS) Warning 3107 - ^ Reserved method must return a value (Buffer required for _CRS) Change-Id: I02a29e56a513ec34a98534fb4a8d51df3b70a522 Signed-off-by: Martin Roth <martinroth(a)google.com> --- src/mainboard/google/rambi/Kconfig | 3 --- src/mainboard/google/rambi/acpi/mainboard.asl | 10 ++++++++-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index c5d158c..32104fa 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -38,7 +38,4 @@ config HAVE_ME_BIN bool default n -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n endif # BOARD_GOOGLE_RAMBI diff --git a/src/mainboard/google/rambi/acpi/mainboard.asl b/src/mainboard/google/rambi/acpi/mainboard.asl index 7bd9aa1..7236c93 100644 --- a/src/mainboard/google/rambi/acpi/mainboard.asl +++ b/src/mainboard/google/rambi/acpi/mainboard.asl @@ -52,10 +52,13 @@ Scope (\_SB) Method (_CRS) { - /* Only return interrupt if I2C1 is PCI mode */ + /* Return interrupt if I2C1 is PCI mode */ If (LEqual (\S1EN, 0)) { Return (^RBUF) } + + /* Return empty resource template otherwise */ + Return (ResourceTemplate() {}) } } @@ -76,10 +79,13 @@ Scope (\_SB) Method (_CRS) { - /* Only return interrupt if I2C6 is PCI mode */ + /* Return interrupt if I2C6 is PCI mode */ If (LEqual (\S6EN, 0)) { Return (^RBUF) } + + /* Return empty resource template otherwise */ + Return (ResourceTemplate() {}) } } }

1 0

Patch merged into coreboot/master: commonlib/cbmem_id.h: Add CBMEM_ID_HOB_POINTER to CBMEM_ID_TO_NAME_TABLE
by gerrit＠coreboot.org 23 Nov '15

23 Nov '15

the following patch was just integrated into master: commit acd47aeaa3cbb5c3dbc158c4b312120b9fc5bc8f Author: Ben Gardner <gardner.ben(a)gmail.com> Date: Thu Nov 19 10:26:11 2015 -0600 commonlib/cbmem_id.h: Add CBMEM_ID_HOB_POINTER to CBMEM_ID_TO_NAME_TABLE fsp-based platforms have this ID, so give it a name. Change-Id: Idce4dbb60b7b3581e18046e66183a7c91b17abd7 Signed-off-by: Ben Gardner <gardner.ben(a)gmail.com> Reviewed-on: http://review.coreboot.org/12485 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/12485 for details. -gerrit

1 0

New patch to review for coreboot: lenovo t400: Fix IASL warning and remark
by Martin Roth 23 Nov '15

23 Nov '15

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12518 -gerrit commit dde12b4112af6ca5d55e04f344710784fd5e090c Author: Martin Roth <martinroth(a)google.com> Date: Mon Nov 23 12:37:22 2015 -0700 lenovo t400: Fix IASL warning and remark If any path in a method returns a value, IASL expects that all paths within that method will return a value. Presumably, the ATPX would not need a return value if Arg0 is anything other than 0, so just return a zero. - Serialize ATPX method to make IASL happy. This means that it can only be used by one thread at a time. Fixes these issues: dsdt.aml 2581: Method (ATPX, 2, NotSerialized) { Remark 2120 - ^ Control Method should be made Serialized (due to creation of named objects within) dsdt.aml 2581: Method (ATPX, 2, NotSerialized) { Warning 3115 - ^ Not all control paths return a value (ATPX) Change-Id: I14aeab0cebe4596e06a17cffc36cc01b953d7191 Signed-off-by: Martin Roth <martinroth(a)google.com> --- src/mainboard/lenovo/t400/Kconfig | 4 ---- src/mainboard/lenovo/t400/acpi/graphics.asl | 3 ++- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mainboard/lenovo/t400/Kconfig b/src/mainboard/lenovo/t400/Kconfig index 8d258d9..467cd63 100644 --- a/src/mainboard/lenovo/t400/Kconfig +++ b/src/mainboard/lenovo/t400/Kconfig @@ -51,8 +51,4 @@ config CBFS_SIZE hex default 0x200000 -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif # BOARD_LENOVO_T400 diff --git a/src/mainboard/lenovo/t400/acpi/graphics.asl b/src/mainboard/lenovo/t400/acpi/graphics.asl index d2cfdb9..818ea93 100644 --- a/src/mainboard/lenovo/t400/acpi/graphics.asl +++ b/src/mainboard/lenovo/t400/acpi/graphics.asl @@ -55,7 +55,7 @@ Method(SHYB, 1) { } } -Method (ATPX, 2, NotSerialized) { +Method (ATPX, 2, Serialized) { /* Create local variables */ Name (ATPR, Buffer (0x08) { 0x0, 0x0, 0x0, 0x0, @@ -94,4 +94,5 @@ Method (ATPX, 2, NotSerialized) { SHYB(0x00) } } + Return(Zero) }

1 0

New patch to review for coreboot: ec/lenovo/h8: Fix IASL warnings
by Martin Roth 23 Nov '15

23 Nov '15

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12517 -gerrit commit 3b6700f4881935bb3c77baec921da2156b4aecdd Author: Martin Roth <martinroth(a)google.com> Date: Mon Nov 23 12:23:19 2015 -0700 ec/lenovo/h8: Fix IASL warnings If any path in a method returns a value, IASL expects that all paths within that method will return a value. Presumably the MKHP method wouldn't get called unless there were a pending event, but if no event is found, return a zero. Fixes IASL warning: dsdt.aml 1785: Method (MHKP, 0, NotSerialized) Warning 3115 - ^ Not all control paths return a value (MHKP) This was the only IASL warning in most lenovo mainboards. Change-Id: Id93dcc4a74bd4c18b78f1dde821e7ba0f3444da3 Signed-off-by: Martin Roth <martinroth(a)google.com> --- src/ec/lenovo/h8/acpi/ec.asl | 1 + src/mainboard/lenovo/r400/Kconfig | 4 ---- src/mainboard/lenovo/t420s/Kconfig | 4 ---- src/mainboard/lenovo/t430s/Kconfig | 4 ---- src/mainboard/lenovo/t520/Kconfig | 4 ---- src/mainboard/lenovo/t530/Kconfig | 4 ---- src/mainboard/lenovo/t60/Kconfig | 4 ---- src/mainboard/lenovo/x200/Kconfig | 4 ---- src/mainboard/lenovo/x201/Kconfig | 4 ---- src/mainboard/lenovo/x220/Kconfig | 4 ---- src/mainboard/lenovo/x230/Kconfig | 4 ---- src/mainboard/lenovo/x60/Kconfig | 4 ---- 12 files changed, 1 insertion(+), 44 deletions(-) diff --git a/src/ec/lenovo/h8/acpi/ec.asl b/src/ec/lenovo/h8/acpi/ec.asl index d1789e6..085492d 100644 --- a/src/ec/lenovo/h8/acpi/ec.asl +++ b/src/ec/lenovo/h8/acpi/ec.asl @@ -300,6 +300,7 @@ Device(EC) Add (Local0, 0x5000, Local0) Return (Local0) } + Return (Zero) } /* Report event */ Method (RHK, 1, NotSerialized) { diff --git a/src/mainboard/lenovo/r400/Kconfig b/src/mainboard/lenovo/r400/Kconfig index 3664eb0..0966bf1 100644 --- a/src/mainboard/lenovo/r400/Kconfig +++ b/src/mainboard/lenovo/r400/Kconfig @@ -4,8 +4,4 @@ config MAINBOARD_PART_NUMBER string default "ThinkPad R400" -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif diff --git a/src/mainboard/lenovo/t420s/Kconfig b/src/mainboard/lenovo/t420s/Kconfig index 0250bc0..65d37a7 100644 --- a/src/mainboard/lenovo/t420s/Kconfig +++ b/src/mainboard/lenovo/t420s/Kconfig @@ -73,8 +73,4 @@ config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x21d2 -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif # BOARD_LENOVO_T420S diff --git a/src/mainboard/lenovo/t430s/Kconfig b/src/mainboard/lenovo/t430s/Kconfig index 2518330..6e257dd 100644 --- a/src/mainboard/lenovo/t430s/Kconfig +++ b/src/mainboard/lenovo/t430s/Kconfig @@ -70,8 +70,4 @@ config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x21fb -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif # BOARD_LENOVO_T430S diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig index ce33f04..df7c2db 100644 --- a/src/mainboard/lenovo/t520/Kconfig +++ b/src/mainboard/lenovo/t520/Kconfig @@ -73,8 +73,4 @@ config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x21cf -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif # BOARD_LENOVO_T520 diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig index c87521a..7b4ca7a 100644 --- a/src/mainboard/lenovo/t530/Kconfig +++ b/src/mainboard/lenovo/t530/Kconfig @@ -71,8 +71,4 @@ config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x21fa -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif # BOARD_LENOVO_T530 diff --git a/src/mainboard/lenovo/t60/Kconfig b/src/mainboard/lenovo/t60/Kconfig index 02a5ada..52eeda3 100644 --- a/src/mainboard/lenovo/t60/Kconfig +++ b/src/mainboard/lenovo/t60/Kconfig @@ -54,8 +54,4 @@ config SEABIOS_PS2_TIMEOUT int default 3000 -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif diff --git a/src/mainboard/lenovo/x200/Kconfig b/src/mainboard/lenovo/x200/Kconfig index 9b61f75..7bae12d 100644 --- a/src/mainboard/lenovo/x200/Kconfig +++ b/src/mainboard/lenovo/x200/Kconfig @@ -48,8 +48,4 @@ config CBFS_SIZE hex default 0x200000 -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif # BOARD_LENOVO_X200 diff --git a/src/mainboard/lenovo/x201/Kconfig b/src/mainboard/lenovo/x201/Kconfig index 39389ee..7f96cbe 100644 --- a/src/mainboard/lenovo/x201/Kconfig +++ b/src/mainboard/lenovo/x201/Kconfig @@ -49,8 +49,4 @@ config CPU_ADDR_BITS int default 36 -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig index 5fbda79..c13b644 100644 --- a/src/mainboard/lenovo/x220/Kconfig +++ b/src/mainboard/lenovo/x220/Kconfig @@ -74,8 +74,4 @@ config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x21db -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif # BOARD_LENOVO_X220 diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index 370eb77..1d336eb 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -74,8 +74,4 @@ config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x21fa -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif # BOARD_LENOVO_X230 diff --git a/src/mainboard/lenovo/x60/Kconfig b/src/mainboard/lenovo/x60/Kconfig index 1461c6b..ab4b58e 100644 --- a/src/mainboard/lenovo/x60/Kconfig +++ b/src/mainboard/lenovo/x60/Kconfig @@ -61,8 +61,4 @@ config SEABIOS_PS2_TIMEOUT int default 3000 -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2015