coreboot-gerrit January 2015

coreboot-gerrit@coreboot.org

1 participants
1236 discussions

Patch merged into coreboot/master: 6355cbf AMD platforms: fix callout_entry doxygen errors
by gerrit＠coreboot.org 05 Jan '15

05 Jan '15

the following patch was just integrated into master: commit 6355cbff51966144d5b709a73e24622df3e96122 Author: Martin Roth <martin.roth(a)se-eng.com> Date: Sun Jan 4 15:22:26 2015 -0700 AMD platforms: fix callout_entry doxygen errors Somewhere along the line, the sb_cfg parameter name was changed to config, but this wasn't carried into the documentation or the function prototypes everywhere. Change-Id: Iccb0829c2f50370dddb70af915a6759316c4727a Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> Reviewed-on: http://review.coreboot.org/8098 Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/8098 for details. -gerrit

1 0

Patch merged into coreboot/master: d30746a AMD Mainboards - rd890_cfg.h: fix Doxygen errors.
by gerrit＠coreboot.org 05 Jan '15

05 Jan '15

the following patch was just integrated into master: commit d30746ab6bf2f5237e9a9f5b68719f9651060027 Author: Martin Roth <martin.roth(a)se-eng.com> Date: Sun Jan 4 15:29:08 2015 -0700 AMD Mainboards - rd890_cfg.h: fix Doxygen errors. Doxygen gives an error when processing #defines inside doxygen comments. Normal comments are ignored. The choice for this fix was to make this a standard comment starting with '/*' instead of '/**', or to make the comment not a #define. Change-Id: I97fbbcea6f045d80ec7c0ab5e196d57e5da16d86 Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> Reviewed-on: http://review.coreboot.org/8099 Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/8099 for details. -gerrit

1 0

Patch merged into coreboot/master: 5f066b2 doxygen fixes: change @var to @param var
by gerrit＠coreboot.org 05 Jan '15

05 Jan '15

the following patch was just integrated into master: commit 5f066b29ce993c0fd67fc8b6ab156a0a0fa02c6c Author: Martin Roth <martin.roth(a)se-eng.com> Date: Sun Jan 4 16:47:39 2015 -0700 doxygen fixes: change @var to @param var These files were trying to document the parameters, but didn't have the syntax quite right. Change the comments from @varname to @param varname as required by doxygen. Change-Id: I63662094d3f1686e3e35b61925b580eb06e72e28 Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> Reviewed-on: http://review.coreboot.org/8100 Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Tested-by: build bot (Jenkins) Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> See http://review.coreboot.org/8100 for details. -gerrit

1 0

Patch merged into coreboot/master: d63dbe8 AMD Mainboards - rd890_cfg.c: Fix doxygen warnings
by gerrit＠coreboot.org 05 Jan '15

05 Jan '15

the following patch was just integrated into master: commit d63dbe8ef9455c546571585f9dbfa82243fb81f0 Author: Martin Roth <martin.roth(a)se-eng.com> Date: Sun Jan 4 15:12:21 2015 -0700 AMD Mainboards - rd890_cfg.c: Fix doxygen warnings Remove variable types from the param declaration. Change-Id: Ia6a3d36fcf01d7a52bb1a31cfdb47d88bf612d79 Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> Reviewed-on: http://review.coreboot.org/8097 Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/8097 for details. -gerrit

1 0

Patch merged into coreboot/master: 32bc6b6 doxygen fixes: fix parameter names to match the functions
by gerrit＠coreboot.org 05 Jan '15

05 Jan '15

the following patch was just integrated into master: commit 32bc6b6b8425e800d18f4fb8a34aa5badb1cd329 Author: Martin Roth <martin.roth(a)se-eng.com> Date: Sun Jan 4 16:54:35 2015 -0700 doxygen fixes: fix parameter names to match the functions The doxygen parameter names in the comments no longer matched the functions they were attached to. Doxygen complains about extra parameter comments and uncommented parameters in the functions. Change-Id: I21b8a951f8d8d04b07c3779000eeaf1e69fed463 Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> Reviewed-on: http://review.coreboot.org/8101 Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Tested-by: build bot (Jenkins) Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> See http://review.coreboot.org/8101 for details. -gerrit

1 0

Patch merged into coreboot/master: 0b2c4ec Remove AMD's "Release Content" doxygen from coreboot files
by gerrit＠coreboot.org 05 Jan '15

05 Jan '15

the following patch was just integrated into master: commit 0b2c4ece7d909fae41c4fc1821a48dd2758093d0 Author: Martin Roth <martin.roth(a)se-eng.com> Date: Mon Dec 29 14:38:31 2014 -0700 Remove AMD's "Release Content" doxygen from coreboot files These comments are left over and are not relevent in the coreboot code, but created a new section titled "Release Content" in the doxygen documentation produced by the coreboot code. In an effort to clean up the output, I'm removing these doxygen comments. Change-Id: I4d7be3313a2ab6c140b4f3afe70dffc4abba7bca Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> Reviewed-on: http://review.coreboot.org/8069 Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Tested-by: build bot (Jenkins) Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> See http://review.coreboot.org/8069 for details. -gerrit

1 0

Patch merged into coreboot/master: fc34750 drivers/intel/fsp: split the UEFI HOB functions into hob.c
by gerrit＠coreboot.org 05 Jan '15

05 Jan '15

the following patch was just integrated into master: commit fc34750c88b74f79f5bcd1d622486285af1b95d8 Author: Martin Roth <martin.roth(a)se-eng.com> Date: Sat Jan 3 07:28:39 2015 -0700 drivers/intel/fsp: split the UEFI HOB functions into hob.c The FSP uses a lot of UEFI HOB (Hand Off Block) functions for reporting and passing information to coreboot. These seem to me like they should be in their own file, so I'm splitting them out of fsp_util.c. I'll be adding a couple more functions in the next patch. These functions should all be compliant to the Hand Off Block spec. Change-Id: Ie8bbc0a9277b9484f13dd077b3a52e424a8600fe Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> Reviewed-on: http://review.coreboot.org/8065 Tested-by: build bot (Jenkins) Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> See http://review.coreboot.org/8065 for details. -gerrit

1 0

New patch to review for coreboot: ddffa18 Makefile: clang - ramp up some more warnings
by Edward O'Callaghan 05 Jan '15

05 Jan '15

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8136 -gerrit commit ddffa18357eb1823f21d8331faae2476fa78b172 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Tue Jan 6 14:58:31 2015 +1100 Makefile: clang - ramp up some more warnings Change-Id: I5262cba22d262f5d74d1edd958b59c2695271293 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 6ef9838..ce2b727 100644 --- a/Makefile +++ b/Makefile @@ -119,7 +119,7 @@ ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) # this means the triple is i386-linux-elf instead of i386-none-elf CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 # Tone down some clang warnings -CFLAGS_x86_32 += -Wno-unused-variable -Wno-unused-function -Wno-tautological-compare -Wno-shift-overflow +CFLAGS_x86_32 += -Wno-unused-variable -Wno-tautological-compare -Wno-shift-overflow CC_x86_32:=clang HOSTCC := clang

1 0

Patch merged into coreboot/master: 9270553 Re-factor 'to_flash_offset()' into 'spi_flash.h'
by gerrit＠coreboot.org 05 Jan '15

05 Jan '15

the following patch was just integrated into master: commit 9270553fff23462fcb298f154296319bf3639d15 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sat May 24 04:09:50 2014 +1000 Re-factor 'to_flash_offset()' into 'spi_flash.h' Re-factor to_flash_offset() into 'spi_flash.h' header. Motivated by Clang complaining that the function 'to_flash_offset' is unused. Change-Id: Ic75fd2fb4edc5e434c199ebd10c7384d197e0c63 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-on: http://review.coreboot.org/7519 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/7519 for details. -gerrit

1 0

Patch set updated for coreboot: e04bff4 arch/x86/include/stdint.h: Don't let header wind up in ASL files
by Edward O'Callaghan 05 Jan '15

05 Jan '15

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8106 -gerrit commit e04bff461bde32511f74601130bd3c7030f1c786 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Tue Jan 6 04:15:47 2015 +1100 arch/x86/include/stdint.h: Don't let header wind up in ASL files Push '#ifndef __ACPI__' guard into system header so that it does not wind up in ASL files DSDT builds. Change-Id: I59800b2f75196ff1c80a29f104ea9fa6706e51fb Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/arch/x86/include/stdint.h | 5 ++++- src/northbridge/intel/gm45/gm45.h | 3 +-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/arch/x86/include/stdint.h b/src/arch/x86/include/stdint.h index c491f4b..eed22e0 100644 --- a/src/arch/x86/include/stdint.h +++ b/src/arch/x86/include/stdint.h @@ -1,6 +1,8 @@ #ifndef I386_STDINT_H #define I386_STDINT_H +#ifndef __ACPI__ + #if defined(__GNUC__) #define __HAVE_LONG_LONG__ 1 #else @@ -89,7 +91,8 @@ typedef int32_t s32; #define PRIu64 "llu" #endif - #undef __HAVE_LONG_LONG__ +#endif /* __ACPI__ */ + #endif /* I386_STDINT_H */ diff --git a/src/northbridge/intel/gm45/gm45.h b/src/northbridge/intel/gm45/gm45.h index 5bdf9e4..0eaa629 100644 --- a/src/northbridge/intel/gm45/gm45.h +++ b/src/northbridge/intel/gm45/gm45.h @@ -22,11 +22,10 @@ #define __NORTHBRIDGE_INTEL_GM45_GM45_H__ #include "southbridge/intel/i82801ix/i82801ix.h" +#include <stdint.h> #ifndef __ACPI__ -#include <stdint.h> - typedef enum { FSB_CLOCK_1067MHz = 0, FSB_CLOCK_800MHz = 1,

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2015